134683 2014-07-07 10:13:28 -0700 fix nested function crash on iOS 2014-07-09 10:28:17 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/nested-functions-should-not-crash.html P2 Normal --- 134748 1 achristensen achristensen commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 1020826 0 achristensen 2014-07-07 10:13:28 -0700 I verified that this fixes the WebGL crash in the nested-functions-should-not-crash.html test. 1020827 1 achristensen 2014-07-07 10:13:50 -0700 <rdar://problem/17541529> 1020828 2 234491 achristensen 2014-07-07 10:15:54 -0700 Created attachment 234491 Patch 1020843 3 234491 ggaren 2014-07-07 10:59:05 -0700 Comment on attachment 234491 Patch r=me Is there a performance cost to this limit? 1020848 4 achristensen 2014-07-07 11:05:56 -0700 (In reply to comment #3) > (From update of attachment 234491 [details]) > r=me > > Is there a performance cost to this limit? If someone has a shader with more than 256 nested functions, it will no longer compile. I don't think there's a performance hit because this only changes the shader validator, and I think the call depth is counted anyway. It just wasn't used without this change. 1020856 5 234491 commit-queue 2014-07-07 11:21:39 -0700 Comment on attachment 234491 Patch Clearing flags on attachment: 234491 Committed r170849: <http://trac.webkit.org/changeset/170849> 1020857 6 commit-queue 2014-07-07 11:21:42 -0700 All reviewed patches have been landed. Closing bug. 1021250 7 commit-queue 2014-07-08 17:37:38 -0700 Re-opened since this is blocked by bug 134748 1021387 8 achristensen 2014-07-09 10:28:17 -0700 this did not break the build and it was not rolled out. reclosing. 234491 2014-07-07 10:15:54 -0700 2014-07-07 11:21:39 -0700 Patch bug-134683-20140707101536.patch text/plain 1896 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDg0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTA3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2lPUyBXZWJH TF0gRml4IGNyYXNoIHdpdGggdG9vIG1hbnkgbmVzdGVkIGdsc2wgZnVuY3Rpb25zLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NjgzCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNzU0MTUyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHRoZSBLaHJvbm9zIFdlYkdMIDEuMC4zIHRl c3QgbmVzdGVkLWZ1bmN0aW9ucy1zaG91bGQtbm90LWNyYXNoLmh0bWwuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkV4dGVuc2lvbnMzRE9wZW5HTENvbW1vbjo6Z2V0VHJhbnNsYXRlZFNo YWRlclNvdXJjZUFOR0xFKToKKyAgICAgICAgQWRkIFNIX0xJTUlUX0NBTExfU1RBQ0tfREVQVEgg dG8gZXh0cmFDb21waWxlT3B0aW9ucy4KKwogMjAxNC0wNy0wNyAgSW9uIFJvc2NhICA8cm9zY2FA YWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgQmxlbmRpbmddVGhlIGJhY2tncm91bmQgaW1hZ2Vz IHNldCBvbiB0aGUgcm9vdCBlbGVtZW50IHdpbGwgYmxlbmQgb24gYW4gaW5pdGlhbCB3aGl0ZSBi YWNrZHJvcC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9F eHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwCShy ZXZpc2lvbiAxNzA4NDUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg3LDcg KzE4Nyw3IEBAIFN0cmluZyBFeHRlbnNpb25zM0RPcGVuR0xDb21tb246OmdldFRyYW4KIAogICAg IFN0cmluZyB0cmFuc2xhdGVkU2hhZGVyU291cmNlOwogICAgIFN0cmluZyBzaGFkZXJJbmZvTG9n OwotICAgIGludCBleHRyYUNvbXBpbGVPcHRpb25zID0gU0hfQ0xBTVBfSU5ESVJFQ1RfQVJSQVlf Qk9VTkRTIHwgU0hfVU5GT0xEX1NIT1JUX0NJUkNVSVQgfCBTSF9FTkZPUkNFX1BBQ0tJTkdfUkVT VFJJQ1RJT05TIHwgU0hfSU5JVF9WQVJZSU5HU19XSVRIT1VUX1NUQVRJQ19VU0UgfCBTSF9MSU1J VF9FWFBSRVNTSU9OX0NPTVBMRVhJVFk7CisgICAgaW50IGV4dHJhQ29tcGlsZU9wdGlvbnMgPSBT SF9DTEFNUF9JTkRJUkVDVF9BUlJBWV9CT1VORFMgfCBTSF9VTkZPTERfU0hPUlRfQ0lSQ1VJVCB8 IFNIX0VORk9SQ0VfUEFDS0lOR19SRVNUUklDVElPTlMgfCBTSF9JTklUX1ZBUllJTkdTX1dJVEhP VVRfU1RBVElDX1VTRSB8IFNIX0xJTUlUX0VYUFJFU1NJT05fQ09NUExFWElUWSB8IFNIX0xJTUlU X0NBTExfU1RBQ0tfREVQVEg7CiAKICAgICBpZiAobV9yZXF1aXJlc0J1aWx0SW5GdW5jdGlvbkVt dWxhdGlvbikKICAgICAgICAgZXh0cmFDb21waWxlT3B0aW9ucyB8PSBTSF9FTVVMQVRFX0JVSUxU X0lOX0ZVTkNUSU9OUzsK