134678 2014-07-06 23:07:28 -0700 Some of the WKPreferences (API) property getters read like questions 2014-07-07 15:41:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton andersca andersca darin mitz webkit-bug-importer oldest_to_newest 1020777 0 thorton 2014-07-06 23:07:28 -0700 Specifically, Dan calls these three out in https://bugs.webkit.org/show_bug.cgi?id=134645#c8: @property (nonatomic, getter=isJavaScriptEnabled) BOOL javaScriptEnabled; @property (nonatomic, getter=isJavaEnabled) BOOL javaEnabled; @property (nonatomic, getter=arePlugInsEnabled) BOOL plugInsEnabled; See the discussion in that bug for potential alternatives. 1020847 1 webkit-bug-importer 2014-07-07 11:05:41 -0700 <rdar://problem/17576847> 1020869 2 234500 andersca 2014-07-07 12:06:07 -0700 Created attachment 234500 Patch 1020874 3 234502 andersca 2014-07-07 12:47:48 -0700 Created attachment 234502 Patch 1020876 4 andersca 2014-07-07 12:52:46 -0700 Committed r170853: <http://trac.webkit.org/changeset/170853> 1020941 5 darin 2014-07-07 15:41:39 -0700 You silently fixed incorrect header documentation too. Was that intentional? 234500 2014-07-07 12:06:07 -0700 2014-07-07 12:47:45 -0700 Patch bug-134678-20140707120549.patch text/plain 3295 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGJkOTM4Mjk5MGU2Y2Zk YTMzMmU2NWNiYzJlOWNkYjAzYTQwNjhiOS4uMzc3ZTRiMzc0MzIwMDk4NTVlZDljZDJjNDhiMjdj YTYzOTgyOGRhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA3LTA3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBvZiB0aGUg V0tQcmVmZXJlbmNlcyAoQVBJKSBwcm9wZXJ0eSBnZXR0ZXJzIHJlYWQgbGlrZSBxdWVzdGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDY3OAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc1NzY4NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVy ZW5jZXMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW06 CisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgamF2YVNjcmlwdElzRW5hYmxlZF0pOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIGphdmFJc0VuYWJsZWRdKToKKyAgICAgICAgKC1bV0tQcmVmZXJl bmNlcyBwbHVnSW5zQXJlRW5hYmxlZF0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIGlzSmF2 YVNjcmlwdEVuYWJsZWRdKTogRGVsZXRlZC4KKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBpc0ph dmFFbmFibGVkXSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgYXJlUGx1Z0lu c0VuYWJsZWRdKTogRGVsZXRlZC4KKwogMjAxNC0wNy0wNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQXNzZXJ0aW9uIGZhaWx1cmUgaW4gTmF2aWdh dGlvblN0YXRlOjpMb2FkZXJDbGllbnQ6OmRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUg KG5hdmlnYXRpb25JRCkgd2hlbiBuYXZpZ2F0aW5nIHRocm91Z2ggdGhlIHBhZ2UgY2FjaGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl cy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgK aW5kZXggNThhYWJlOWE0MDVjMGQxYzhhNTVkMDgxOTM2MTQ2YTJkNTkzODA5Ny4uMjBmNTI2ZWQ5 ZTJlZWUzY2M5YjQ5NmQ3YjU2YWE2ZmQ0NGIxNzM5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgKQEAgLTQ1LDcgKzQ1LDcgQEAg V0tfQ0xBU1NfQVZBSUxBQkxFKDEwXzEwLCA4XzApCiAvKiEgQGFic3RyYWN0IEEgQm9vbGVhbiB2 YWx1ZSBpbmRpY2F0aW5nIHdoZXRoZXIgSmF2YVNjcmlwdCBpcyBlbmFibGVkLgogIEBkaXNjdXNz aW9uIFRoZSBkZWZhdWx0IHZhbHVlIGlzIFlFUy4KICAqLwotQHByb3BlcnR5IChub25hdG9taWMs IGdldHRlcj1pc0phdmFTY3JpcHRFbmFibGVkKSBCT09MIGphdmFTY3JpcHRFbmFibGVkOworQHBy b3BlcnR5IChub25hdG9taWMsIHNldHRlcj1zZXRKYXZhU2NyaXB0RW5hYmxlZDopIEJPT0wgamF2 YVNjcmlwdElzRW5hYmxlZDsKIAogLyohIEBhYnN0cmFjdCBBIEJvb2xlYW4gdmFsdWUgaW5kaWNh dGluZyB3aGV0aGVyIEphdmFTY3JpcHQgY2FuIG9wZW4KICB3aW5kb3dzIHdpdGhvdXQgdXNlciBp bnRlcmFjdGlvbi4KQEAgLTU3LDEyICs1NywxMiBAQCBXS19DTEFTU19BVkFJTEFCTEUoMTBfMTAs IDhfMCkKIC8qISBAYWJzdHJhY3QgQSBCb29sZWFuIHZhbHVlIGluZGljYXRpbmcgd2hldGhlciBK YXZhIGlzIGVuYWJsZWQuCiAgQGRpc2N1c3Npb24gVGhlIGRlZmF1bHQgdmFsdWUgaXMgWUVTLgog ICovCi1AcHJvcGVydHkgKG5vbmF0b21pYywgZ2V0dGVyPWlzSmF2YUVuYWJsZWQpIEJPT0wgamF2 YUVuYWJsZWQ7CitAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPXNldEphdmFFbmFibGVkOikg Qk9PTCBqYXZhSXNFbmFibGVkOwogCiAvKiEgQGFic3RyYWN0IEEgQm9vbGVhbiB2YWx1ZSBpbmRp Y2F0aW5nIHdoZXRoZXIgcGx1Zy1pbnMgYXJlIGVuYWJsZWQuCiAgQGRpc2N1c3Npb24gVGhlIGRl ZmF1bHQgdmFsdWUgaXMgWUVTLgogICovCi1AcHJvcGVydHkgKG5vbmF0b21pYywgZ2V0dGVyPWFy ZVBsdWdJbnNFbmFibGVkKSBCT09MIHBsdWdJbnNFbmFibGVkOworQHByb3BlcnR5IChub25hdG9t aWMsIHNldHRlcj1zZXRQbHVnSW5zRW5hYmxlZDopIEJPT0wgcGx1Z0luc0FyZUVuYWJsZWQ7CiAj ZW5kaWYKIAogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1ByZWZlcmVuY2VzLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1ByZWZlcmVuY2VzLm1tCmluZGV4IDQ0MWM1NGI3ODkzOGZhNjFhNWJiYmJiOTc5ZTgyMGI2 YzQ1OWZkMDcuLjY4MjBhMjdlOGNlOTI5NDkwZWRjYzM4MmJlOWI0MzkyY2U1NDMxMTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMu bW0KQEAgLTUzLDcgKzUzLDcgQEAKICAgICBfcHJlZmVyZW5jZXMtPnNldE1pbmltdW1Gb250U2l6 ZShtaW5pbXVtRm9udFNpemUpOwogfQogCi0tIChCT09MKWlzSmF2YVNjcmlwdEVuYWJsZWQKKy0g KEJPT0wpamF2YVNjcmlwdElzRW5hYmxlZAogewogICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPmph dmFTY3JpcHRFbmFibGVkKCk7CiB9CkBAIC03Nyw3ICs3Nyw3IEBACiAKICNpZiBQTEFURk9STShN QUMpCiAKLS0gKEJPT0wpaXNKYXZhRW5hYmxlZAorLSAoQk9PTClqYXZhSXNFbmFibGVkCiB7CiAg ICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+amF2YUVuYWJsZWQoKTsKIH0KQEAgLTg3LDcgKzg3LDcg QEAKICAgICBfcHJlZmVyZW5jZXMtPnNldEphdmFFbmFibGVkKGphdmFFbmFibGVkKTsKIH0KIAot LSAoQk9PTClhcmVQbHVnSW5zRW5hYmxlZAorLSAoQk9PTClwbHVnSW5zQXJlRW5hYmxlZAogewog ICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPnBsdWdpbnNFbmFibGVkKCk7CiB9Cg== 234502 2014-07-07 12:47:48 -0700 2014-07-07 12:48:51 -0700 Patch bug-134678-20140707124730.patch text/plain 3303 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGJkOTM4Mjk5MGU2Y2Zk YTMzMmU2NWNiYzJlOWNkYjAzYTQwNjhiOS4uMzc3ZTRiMzc0MzIwMDk4NTVlZDljZDJjNDhiMjdj YTYzOTgyOGRhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA3LTA3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBvZiB0aGUg V0tQcmVmZXJlbmNlcyAoQVBJKSBwcm9wZXJ0eSBnZXR0ZXJzIHJlYWQgbGlrZSBxdWVzdGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDY3OAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc1NzY4NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVy ZW5jZXMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW06 CisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgamF2YVNjcmlwdElzRW5hYmxlZF0pOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIGphdmFJc0VuYWJsZWRdKToKKyAgICAgICAgKC1bV0tQcmVmZXJl bmNlcyBwbHVnSW5zQXJlRW5hYmxlZF0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIGlzSmF2 YVNjcmlwdEVuYWJsZWRdKTogRGVsZXRlZC4KKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBpc0ph dmFFbmFibGVkXSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgYXJlUGx1Z0lu c0VuYWJsZWRdKTogRGVsZXRlZC4KKwogMjAxNC0wNy0wNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQXNzZXJ0aW9uIGZhaWx1cmUgaW4gTmF2aWdh dGlvblN0YXRlOjpMb2FkZXJDbGllbnQ6OmRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUg KG5hdmlnYXRpb25JRCkgd2hlbiBuYXZpZ2F0aW5nIHRocm91Z2ggdGhlIHBhZ2UgY2FjaGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl cy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgK aW5kZXggNThhYWJlOWE0MDVjMGQxYzhhNTVkMDgxOTM2MTQ2YTJkNTkzODA5Ny4uNjYwM2E4OWMw ZjZjYzk4MzVmYjM1MTlhYzhhNGZhNDE0OGU0NDFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgKQEAgLTQ1LDcgKzQ1LDcgQEAg V0tfQ0xBU1NfQVZBSUxBQkxFKDEwXzEwLCA4XzApCiAvKiEgQGFic3RyYWN0IEEgQm9vbGVhbiB2 YWx1ZSBpbmRpY2F0aW5nIHdoZXRoZXIgSmF2YVNjcmlwdCBpcyBlbmFibGVkLgogIEBkaXNjdXNz aW9uIFRoZSBkZWZhdWx0IHZhbHVlIGlzIFlFUy4KICAqLwotQHByb3BlcnR5IChub25hdG9taWMs IGdldHRlcj1pc0phdmFTY3JpcHRFbmFibGVkKSBCT09MIGphdmFTY3JpcHRFbmFibGVkOworQHBy b3BlcnR5IChub25hdG9taWMpIEJPT0wgamF2YVNjcmlwdEVuYWJsZWQ7CiAKIC8qISBAYWJzdHJh Y3QgQSBCb29sZWFuIHZhbHVlIGluZGljYXRpbmcgd2hldGhlciBKYXZhU2NyaXB0IGNhbiBvcGVu CiAgd2luZG93cyB3aXRob3V0IHVzZXIgaW50ZXJhY3Rpb24uCkBAIC01NSwxNCArNTUsMTQgQEAg V0tfQ0xBU1NfQVZBSUxBQkxFKDEwXzEwLCA4XzApCiAKICNpZiAhVEFSR0VUX09TX0lQSE9ORQog LyohIEBhYnN0cmFjdCBBIEJvb2xlYW4gdmFsdWUgaW5kaWNhdGluZyB3aGV0aGVyIEphdmEgaXMg ZW5hYmxlZC4KLSBAZGlzY3Vzc2lvbiBUaGUgZGVmYXVsdCB2YWx1ZSBpcyBZRVMuCisgQGRpc2N1 c3Npb24gVGhlIGRlZmF1bHQgdmFsdWUgaXMgTk8uCiAgKi8KLUBwcm9wZXJ0eSAobm9uYXRvbWlj LCBnZXR0ZXI9aXNKYXZhRW5hYmxlZCkgQk9PTCBqYXZhRW5hYmxlZDsKK0Bwcm9wZXJ0eSAobm9u YXRvbWljKSBCT09MIGphdmFFbmFibGVkOwogCiAvKiEgQGFic3RyYWN0IEEgQm9vbGVhbiB2YWx1 ZSBpbmRpY2F0aW5nIHdoZXRoZXIgcGx1Zy1pbnMgYXJlIGVuYWJsZWQuCi0gQGRpc2N1c3Npb24g VGhlIGRlZmF1bHQgdmFsdWUgaXMgWUVTLgorIEBkaXNjdXNzaW9uIFRoZSBkZWZhdWx0IHZhbHVl IGlzIE5PLgogICovCi1AcHJvcGVydHkgKG5vbmF0b21pYywgZ2V0dGVyPWFyZVBsdWdJbnNFbmFi bGVkKSBCT09MIHBsdWdJbnNFbmFibGVkOworQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgcGx1 Z0luc0VuYWJsZWQ7CiAjZW5kaWYKIAogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCmluZGV4IDQ0MWM1NGI3ODkzOGZhNjFh NWJiYmJiOTc5ZTgyMGI2YzQ1OWZkMDcuLjFkOTI0OGQwZTQ4YjE1MGE5YzFkNmZiMjhkYzliNzlk NjQwNDY5MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLUHJlZmVyZW5jZXMubW0KQEAgLTUzLDcgKzUzLDcgQEAKICAgICBfcHJlZmVyZW5jZXMtPnNl dE1pbmltdW1Gb250U2l6ZShtaW5pbXVtRm9udFNpemUpOwogfQogCi0tIChCT09MKWlzSmF2YVNj cmlwdEVuYWJsZWQKKy0gKEJPT0wpamF2YVNjcmlwdEVuYWJsZWQKIHsKICAgICByZXR1cm4gX3By ZWZlcmVuY2VzLT5qYXZhU2NyaXB0RW5hYmxlZCgpOwogfQpAQCAtNzcsNyArNzcsNyBAQAogCiAj aWYgUExBVEZPUk0oTUFDKQogCi0tIChCT09MKWlzSmF2YUVuYWJsZWQKKy0gKEJPT0wpamF2YUVu YWJsZWQKIHsKICAgICByZXR1cm4gX3ByZWZlcmVuY2VzLT5qYXZhRW5hYmxlZCgpOwogfQpAQCAt ODcsNyArODcsNyBAQAogICAgIF9wcmVmZXJlbmNlcy0+c2V0SmF2YUVuYWJsZWQoamF2YUVuYWJs ZWQpOwogfQogCi0tIChCT09MKWFyZVBsdWdJbnNFbmFibGVkCistIChCT09MKXBsdWdJbnNFbmFi bGVkCiB7CiAgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+cGx1Z2luc0VuYWJsZWQoKTsKIH0K