134644 2014-07-04 23:45:27 -0700 [WK2] Don't support dynamically enabling the RemoteLayerTree debug indicator 2014-07-06 23:05:22 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 1020577 0 thorton 2014-07-04 23:45:27 -0700 The indicator depends on the live layer tree commits coming in, including layer creation, so it can't be turned on after the root layer is created. Even a refresh is insufficient to get it working; the debug indicator really needs to exist from the first commit. So, let's not even attempt to dynamically enable the indicator. 1020583 1 234434 thorton 2014-07-05 01:34:03 -0700 Created attachment 234434 patch 1020776 2 thorton 2014-07-06 23:05:22 -0700 http://trac.webkit.org/changeset/170838 234434 2014-07-05 01:34:03 -0700 2014-07-06 17:20:11 -0700 patch dynamic-tilemap.diff text/plain 5243 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYTE3ODM2Li5lNjJmYjg2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3 IEBACiAyMDE0LTA3LTA1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog CisgICAgICAgIFtXSzJdIERvbid0IHN1cHBvcnQgZHluYW1pY2FsbHkgZW5hYmxpbmcgdGhlIFJl bW90ZUxheWVyVHJlZSBkZWJ1ZyBpbmRpY2F0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDY0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaDoKKyAg ICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eTo6c2V0U2hvdWxkU2hvd0RlYnVnSW5kaWNh dG9yKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpwcmVmZXJlbmNlc0RpZENoYW5nZSk6CisgICAg ICAgICogVUlQcm9jZXNzL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lmg6Cisg ICAgICAgICogVUlQcm9jZXNzL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lm1t OgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpSZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5KToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5 ZXJUcmVlRHJhd2luZ0FyZWFQcm94eTo6aW5pdGlhbGl6ZURlYnVnSW5kaWNhdG9yKToKKyAgICAg ICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eTo6c2V0U2hvdWxkU2hv d0RlYnVnSW5kaWNhdG9yKTogRGVsZXRlZC4KKyAgICAgICAgVGhlIGluZGljYXRvciBkZXBlbmRz IG9uIHRoZSBsaXZlIGxheWVyIHRyZWUgY29tbWl0cyBjb21pbmcgaW4sIGluY2x1ZGluZyBsYXll ciBjcmVhdGlvbiwKKyAgICAgICAgc28gaXQgY2FuJ3QgYmUgdHVybmVkIG9uIGFmdGVyIHRoZSBy b290IGxheWVyIGlzIGNyZWF0ZWQuIEV2ZW4gYSByZWZyZXNoIGlzIGluc3VmZmljaWVudAorICAg ICAgICB0byBnZXQgaXQgd29ya2luZzsgdGhlIGRlYnVnIGluZGljYXRvciByZWFsbHkgbmVlZHMg dG8gZXhpc3QgZnJvbSB0aGUgZmlyc3QgY29tbWl0LgorICAgICAgICBTbywgZG9uJ3QgZXZlbiBh dHRlbXB0IHRvIGR5bmFtaWNhbGx5IGVuYWJsZSB0aGUgaW5kaWNhdG9yOyBjcmVhdGUgaXQgYXQK KyAgICAgICAgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eSBjb25zdHJ1Y3Rpb24gdGlt ZSBpZiB0aGUgcHJlZiBpcyBlbmFibGVkLgorCisyMDE0LTA3LTA1ICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCiAgICAgICAgIFtXSzJdIEV4cG9zZSBhIGZldyBkcmF3 aW5nL2NvbXBvc2l0aW5nIHNldHRpbmdzIG9uIFdLUHJlZmVyZW5jZXMoUHJpdmF0ZSkKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDY0NQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaAppbmRleCA0NTM3MTA4Li4w YjgxMjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQ cm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgK QEAgLTgzLDcgKzgzLDYgQEAgcHVibGljOgogI2VuZGlmCiAKICAgICB2aXJ0dWFsIHZvaWQgdXBk YXRlRGVidWdJbmRpY2F0b3IoKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvdWxkU2hvd0Rl YnVnSW5kaWNhdG9yKGJvb2wpIHsgfQogCiAgICAgdmlydHVhbCB2b2lkIHdhaXRGb3JEaWRVcGRh dGVWaWV3U3RhdGUoKSB7IH0KICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAKaW5kZXggMGMwYWIyZS4uZTJlNDMzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTIzODQsOSArMjM4NCw2IEBAIHZvaWQgV2ViUGFnZVBy b3h5OjpwcmVmZXJlbmNlc0RpZENoYW5nZSgpCiAgICAgICAgIGluc3BlY3RvcigpLT5lbmFibGVS ZW1vdGVJbnNwZWN0aW9uKCk7CiAjZW5kaWYKIAotICAgIGlmIChtX2RyYXdpbmdBcmVhKQotICAg ICAgICBtX2RyYXdpbmdBcmVhLT5zZXRTaG91bGRTaG93RGVidWdJbmRpY2F0b3IobV9wcmVmZXJl bmNlcy0+dGlsZWRTY3JvbGxpbmdJbmRpY2F0b3JWaXNpYmxlKCkpOwotCiAgICAgbV9wcm9jZXNz LT5wYWdlUHJlZmVyZW5jZXNDaGFuZ2VkKHRoaXMpOwogCiAgICAgbV9wYWdlQ2xpZW50LnByZWZl cmVuY2VzRGlkQ2hhbmdlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5oCmluZGV4IDcxZGFi MWUuLjk0ODc1MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVt b3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5oCkBAIC02Miw3ICs2Miw2 IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoQWZ0ZXJFbnN1cmluZ0RyYXdp bmcoc3RkOjpmdW5jdGlvbjx2b2lkIChDYWxsYmFja0Jhc2U6OkVycm9yKT4pIG92ZXJyaWRlOwog CiAgICAgV2ViQ29yZTo6RmxvYXRSZWN0IHNjYWxlZEV4cG9zZWRSZWN0KCkgY29uc3Q7Ci0gICAg dmlydHVhbCB2b2lkIHNldFNob3VsZFNob3dEZWJ1Z0luZGljYXRvcihib29sKSBvdmVycmlkZTsK IAogI2lmIFBMQVRGT1JNKE1BQykKICAgICB2aXJ0dWFsIHZvaWQgc2V0RXhwb3NlZFJlY3QoY29u c3QgV2ViQ29yZTo6RmxvYXRSZWN0Jikgb3ZlcnJpZGU7CkBAIC03Miw2ICs3MSw3IEBAIHByaXZh dGU6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZURlYnVnSW5kaWNhdG9yKCkgb3ZlcnJpZGU7CiAg ICAgdm9pZCB1cGRhdGVEZWJ1Z0luZGljYXRvcihXZWJDb3JlOjpJbnRTaXplIGNvbnRlbnRzU2l6 ZSwgYm9vbCByb290TGF5ZXJDaGFuZ2VkLCBmbG9hdCBzY2FsZSk7CiAgICAgdm9pZCB1cGRhdGVE ZWJ1Z0luZGljYXRvclBvc2l0aW9uKCk7CisgICAgdm9pZCBpbml0aWFsaXplRGVidWdJbmRpY2F0 b3IoKTsKIAogICAgIHZpcnR1YWwgdm9pZCB3YWl0Rm9yRGlkVXBkYXRlVmlld1N0YXRlKCkgb3Zl cnJpZGU7CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1Jl bW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHkubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHkubW0KaW5kZXggODlhZjQwOC4u YTFmMTc5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9SZW1vdGVM YXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5tbQpAQCAtNjAsNyArNjAsOCBA QCBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpSZW1vdGVMYXllclRyZWVEcmF3aW5n QXJlYVByb3h5KFdlYlBhZ2VQcm94eSogdwogCiAgICAgbV93ZWJQYWdlUHJveHktPnByb2Nlc3Mo KS5hZGRNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVh UHJveHk6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV93ZWJQYWdlUHJveHktPnBhZ2VJRCgpLCAq dGhpcyk7CiAKLSAgICBzZXRTaG91bGRTaG93RGVidWdJbmRpY2F0b3IobV93ZWJQYWdlUHJveHkt PnByZWZlcmVuY2VzKCkudGlsZWRTY3JvbGxpbmdJbmRpY2F0b3JWaXNpYmxlKCkpOworICAgIGlm IChtX3dlYlBhZ2VQcm94eS0+cHJlZmVyZW5jZXMoKS50aWxlZFNjcm9sbGluZ0luZGljYXRvclZp c2libGUoKSkKKyAgICAgICAgaW5pdGlhbGl6ZURlYnVnSW5kaWNhdG9yKCk7CiAKICAgICBtX2xh eWVyQ29tbWl0T2JzZXJ2ZXIgPSBSdW5Mb29wT2JzZXJ2ZXI6OmNyZWF0ZShkaWRDb21taXRMYXll cnNSdW5Mb29wT3JkZXIsIFt0aGlzXSgpIHsKICAgICAgICAgdGhpcy0+Y29yZUFuaW1hdGlvbkRp ZENvbW1pdExheWVycygpOwpAQCAtMjY2LDE5ICsyNjcsOCBAQCB2b2lkIFJlbW90ZUxheWVyVHJl ZURyYXdpbmdBcmVhUHJveHk6OnVwZGF0ZURlYnVnSW5kaWNhdG9yKEludFNpemUgY29udGVudHNT aXplLAogICAgIH0KIH0KIAotdm9pZCBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5Ojpz ZXRTaG91bGRTaG93RGVidWdJbmRpY2F0b3IoYm9vbCBzaG93KQordm9pZCBSZW1vdGVMYXllclRy ZWVEcmF3aW5nQXJlYVByb3h5Ojppbml0aWFsaXplRGVidWdJbmRpY2F0b3IoKQogewotICAgIGlm IChzaG93ID09ICEhbV9kZWJ1Z0luZGljYXRvckxheWVyVHJlZUhvc3QpCi0gICAgICAgIHJldHVy bjsKLSAgICAKLSAgICBpZiAoIXNob3cpIHsKLSAgICAgICAgW21fdGlsZU1hcEhvc3RMYXllciBy ZW1vdmVGcm9tU3VwZXJsYXllcl07Ci0gICAgICAgIG1fdGlsZU1hcEhvc3RMYXllciA9IG51bGxw dHI7Ci0gICAgICAgIG1fZXhwb3NlZFJlY3RJbmRpY2F0b3JMYXllciA9IG51bGxwdHI7Ci0gICAg ICAgIG1fZGVidWdJbmRpY2F0b3JMYXllclRyZWVIb3N0ID0gbnVsbHB0cjsKLSAgICAgICAgcmV0 dXJuOwotICAgIH0KLSAgICAKICAgICBtX2RlYnVnSW5kaWNhdG9yTGF5ZXJUcmVlSG9zdCA9IHN0 ZDo6bWFrZV91bmlxdWU8UmVtb3RlTGF5ZXJUcmVlSG9zdD4oKnRoaXMpOwogICAgIG1fZGVidWdJ bmRpY2F0b3JMYXllclRyZWVIb3N0LT5zZXRJc0RlYnVnTGF5ZXJUcmVlSG9zdCh0cnVlKTsKIAo=