134629 2014-07-04 04:10:03 -0700 [EFL][WK2]Fix build break in EFL WK2 2014-07-04 15:28:40 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned bunhere cmarcelo commit-queue gyuyoung.kim hyuki.kim lucas.de.marchi luiz noam ryuan.choi sergio zeno oldest_to_newest 1020473 0 kumar.rohit 2014-07-04 04:10:03 -0700 Build log: [ 82%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/VisitedLinkTableController.cpp.o In file included from /home/kumar.rohit/WebKit/Source/WTF/wtf/FastMalloc.h:27:0, from /home/kumar.rohit/WebKit/Source/WebKit2/config.h:55, from /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:26: /home/kumar.rohit/WebKit/Source/WTF/wtf/StdLibExtras.h: In instantiation of ‘typename std::_Unique_if<T>::_Single_object std::make_unique(Args&& ...) [with T = WebKit::CoordinatedDrawingArea; Args = {WebKit::WebPage&, const WebKit::WebPageCreationParameters&}; typename std::_Unique_if<T>::_Single_object = std::unique_ptr<WebKit::CoordinatedDrawingArea, std::default_delete<WebKit::CoordinatedDrawingArea> >]’: /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:63:76: required from here /home/kumar.rohit/WebKit/Source/WTF/wtf/StdLibExtras.h:362:60: error: cannot allocate an object of abstract type ‘WebKit::CoordinatedDrawingArea’ return unique_ptr<T>(new T(std::forward<Args>(args)...)); ^ In file included from /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:38:0: /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:39:7: note: because the following virtual functions are pure within ‘WebKit::CoordinatedDrawingArea’: class CoordinatedDrawingArea : public DrawingArea { ^ In file included from /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:27:0: /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/DrawingArea.h:104:18: note: virtual void WebKit::DrawingArea::scheduleCompositingLayerFlushImmediately() virtual void scheduleCompositingLayerFlushImmediately() = 0; ^ [ 82%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebUndoStep.cpp.o In file included from /home/kumar.rohit/WebKit/Source/WTF/wtf/FastMalloc.h:27:0, from /home/kumar.rohit/WebKit/Source/WebKit2/config.h:55, from /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:26: /home/kumar.rohit/WebKit/Source/WTF/wtf/StdLibExtras.h: In function ‘typename std::_Unique_if<T>::_Single_object std::make_unique(Args&& ...) [with T = WebKit::CoordinatedDrawingArea; Args = {WebKit::WebPage&, const WebKit::WebPageCreationParameters&}; typename std::_Unique_if<T>::_Single_object = std::unique_ptr<WebKit::CoordinatedDrawingArea, std::default_delete<WebKit::CoordinatedDrawingArea> >]’: /home/kumar.rohit/WebKit/Source/WTF/wtf/StdLibExtras.h:363:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1plus: all warnings being treated as errors 1020477 1 234401 kumar.rohit 2014-07-04 04:26:50 -0700 Created attachment 234401 Patch 1020486 2 hyuki.kim 2014-07-04 05:50:16 -0700 I need this patch. :) This broke my build for now. 1020540 3 ryuan.choi 2014-07-04 15:27:55 -0700 Committed r170814: <http://trac.webkit.org/changeset/170814> 1020541 4 234401 ryuan.choi 2014-07-04 15:28:40 -0700 Comment on attachment 234401 Patch Clear r? after landed without review. It's because this is just for build fix. 234401 2014-07-04 04:26:50 -0700 2014-07-04 15:28:40 -0700 Patch bug-134629-20140704165709.patch text/plain 2605 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzBhMmJkMDRlMjIzMDdi MTcwZDRjNjdlOWIwN2EzM2ZhNTczMmFiMy4uYWY3M2E0MTAxOWVlZjY5MjNjNjc4NzE2OWVmMGMz ZWNjMjkwMDVmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA3LTA0ICBSb2hp dCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl1G aXggYnVpbGQgYnJlYWsgaW4gRUZMIFdLMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0 ZWREcmF3aW5nQXJlYTo6c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyRmx1c2hJbW1lZGlhdGVseSk6 CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRp bmF0ZWREcmF3aW5nQXJlYS5oOgorCiAyMDE0LTA3LTA0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBHVEsgV0syIGJ1aWxkIGZp eCBhZnRlciByMTcwNzg3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29y ZGluYXRlZERyYXdpbmdBcmVhLmNwcAppbmRleCBlNjc5OTFmYzc3ZjAzMWY4ZjNlNGY2YTYwOTMy NmNhYThiMzQzNjgyLi40MTZiNGZhZTAwOWNhMGM3N2Q0YjM2ZDk4YTA5YjliNmI1MmM5MzQ3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRH cmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdB cmVhLmNwcApAQCAtMjk1LDYgKzI5NSwxMSBAQCB2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0FyZWE6 OnNjaGVkdWxlQ29tcG9zaXRpbmdMYXllckZsdXNoKCkKICAgICBtX2xheWVyVHJlZUhvc3QtPnNj aGVkdWxlTGF5ZXJGbHVzaCgpOwogfQogCit2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0FyZWE6OnNj aGVkdWxlQ29tcG9zaXRpbmdMYXllckZsdXNoSW1tZWRpYXRlbHkoKQoreworICAgIHNjaGVkdWxl Q29tcG9zaXRpbmdMYXllckZsdXNoKCk7IAorfQorCiB2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0Fy ZWE6OnVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlKHVpbnQ2NF90IHN0YXRlSUQsIGJvb2wgcmVzcG9u ZEltbWVkaWF0ZWx5LCBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciwgY29uc3QgV2ViQ29yZTo6SW50 U2l6ZSYgc2l6ZSwgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgc2Nyb2xsT2Zmc2V0KQogewogICAg IEFTU0VSVCghbV9pblVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5h dGVkRHJhd2luZ0FyZWEuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29y ZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuaAppbmRleCA5OWIxZWJiNjVl ZDQ1NzFkYTMzNzYwMWYzNzY1NGYyYzUxZmIzZDliLi43ZTY0ODZlYWJhMDNiODgxN2I0MWVlNmQz YmUzOGJkOGU3MzVmMTEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmgKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29v cmRpbmF0ZWREcmF3aW5nQXJlYS5oCkBAIC02Miw2ICs2Miw3IEBAIHByaXZhdGU6CiAgICAgdmly dHVhbCBXZWJDb3JlOjpHcmFwaGljc0xheWVyRmFjdG9yeSogZ3JhcGhpY3NMYXllckZhY3Rvcnko KSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoV2Vi Q29yZTo6R3JhcGhpY3NMYXllciopIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzY2hlZHVs ZUNvbXBvc2l0aW5nTGF5ZXJGbHVzaCgpIG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBzY2hl ZHVsZUNvbXBvc2l0aW5nTGF5ZXJGbHVzaEltbWVkaWF0ZWx5KCkgb3ZlcnJpZGU7CiAKICAgICB2 aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZUNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdE1lc3NhZ2UoSVBD OjpDb25uZWN0aW9uKiwgSVBDOjpNZXNzYWdlRGVjb2RlciYpOwogCg==