134619 2014-07-03 16:56:02 -0700 [iOS WK2] Compositing layers draw outside page bounds 2014-07-03 17:49:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser benjamin bunhere cdumez commit-queue gyuyoung.kim sergio simon.fraser oldest_to_newest 1020406 0 simon.fraser 2014-07-03 16:56:02 -0700 [iOS WK2] Compositing layers draw outside page bounds 1020407 1 234381 simon.fraser 2014-07-03 16:59:59 -0700 Created attachment 234381 Patch 1020408 2 simon.fraser 2014-07-03 17:00:27 -0700 <rdar://problem/16953222> 1020410 3 234381 benjamin 2014-07-03 17:25:09 -0700 Comment on attachment 234381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234381&action=review > Source/WebKit2/UIProcess/ios/WKContentView.mm:570 > + [_fixedClippingView setPosition:clippingBounds.location()]; UIView's setPosition is deprecated API > Source/WebKit2/UIProcess/ios/WKContentView.mm:704 > + FloatRect fixedPositionRect = _page->computeCustomFixedPositionRect(_page->unobscuredContentRect(), [[_webView scrollView] zoomScale]); I think I'd prefere m_webPageProxy.displayedContentScale() here to be consistent with RemoteScrollingCoordinatorProxy::customFixedPositionRect(). I don't feel strongly about this, they should be the same values, do as you prefer. 1020420 4 simon.fraser 2014-07-03 17:49:06 -0700 https://trac.webkit.org/r170783 234381 2014-07-03 16:59:59 -0700 2014-07-03 17:25:08 -0700 Patch bug-134619-20140703165941.patch text/plain 7016 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTY1YmE0ZDg1NjBmMmFl NjE1NWE2MmE3ZGY3NzRkOTViODg4MTI4ZS4uNjc1ZjU3M2Y3MGEyODc5NGM4NmEwNzMzZjFjNjE3 YThmMDIxYmFiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE0LTA3LTAzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBD b21wb3NpdGluZyBsYXllcnMgZHJhdyBvdXRzaWRlIHBhZ2UgYm91bmRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ2MTkKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE2OTUzMjIyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICAKKyAgICAgICAgV2l0aCB0aGUgbmV3IHJ1YmJlci1iYW5kaW5nIGJlaGF2aW9y LCB3ZSBubyBsb25nZXIgaGF2ZSB0aGUgcm9vdCBjb250ZW50IGxheWVyIGNsaXBwaW5nIGFsbAor ICAgICAgICB0aGUgd2ViIGxheWVycywgYnV0IHRoaXMgcmVzdWx0ZWQgaW4gd2ViIGxheWVycyB3 aGljaCB3ZXJlIG1vdmVkIG91dHNpZGUgdGhlIHZpZXdwb3J0IGJ5IENTUworICAgICAgICB0cmFu c2Zvcm1zIG5vdCBiZWluZyBjbGlwcGVkLgorICAgICAgICAKKyAgICAgICAgRml4IGJ5IGFkZGlu ZyBhIGNsaXBwaW5nIGxheWVyIGluc2lkZSB0aGUgc2Nyb2xsIHZpZXcsIGFib3ZlIF9yb290Q29u dGVudFZpZXcuIFRoaXMgbGF5ZXIKKyAgICAgICAgbm9ybWFsbHkgaGFzIHRoZSBzYW1lIGJvdW5k cyBhcyB0aGUgY29udGVudCwgYnV0IHdoZW4gcnViYmVyLWJhbmRpbmcgb3IgcGluY2hpbmcsCisg ICAgICAgIGl0IHRha2VzIHRoZSB1bmlvbiBvZiB0aGUgY29udGVudCBib3VuZHMgYW5kIHRoZSBy ZWN0IHVzZWQgZm9yIGZpeGVkIHBvc2l0aW9uaW5nLgorICAgICAgICBUbyBtYWtlIHNjcm9sbGlu ZyB3b3JrIGFzIGV4cGVjdGVkIGluIHRoaXMgc2NlbmFyaW8sIHdoZW4gaXQgaGFzIG5vbi16ZXJv IG9mZnNldCwgaXQKKyAgICAgICAgaGFzIHRvIGNvbXBlbnNhdGUgYnkgc2V0dGluZyBpdHMgYm91 bmRzIG9yaWdpbi4KKworICAgICAgICBUaGUgYm91bmRzIG9mIHRoZSBjbGlwcGluZyBsYXllciBh cmUgdXBkYXRlZCBvbiBzY3JvbGxpbmcvem9vbWluZywgYW5kIHdoZW4gdGhlCisgICAgICAgIGxh eWVyIGNvbW1pdCB0ZWxscyB1cyB0aGF0IHRoZSBjb250ZW50IHNpemUgY2hhbmdlZC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dl YlZpZXcgX3VwZGF0ZVNjcm9sbFZpZXdCYWNrZ3JvdW5kXSk6CisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGluaXRXaXRo RnJhbWU6Y29udGV4dDpjb25maWd1cmF0aW9uOndlYlZpZXc6XSk6CisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgdXBkYXRlRml4ZWRDbGlwcGluZ1ZpZXc6XSk6CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgZGlkVXBkYXRlVmlzaWJsZVJlY3Q6dW5vYnNjdXJlZFJlY3Q6dW5vYnNjdXJlZFJlY3RJ blNjcm9sbFZpZXdDb29yZGluYXRlczpzY2FsZTptaW5pbXVtU2NhbGU6aW5TdGFibGVTdGF0ZTpp c0NoYW5naW5nT2JzY3VyZWRJbnNldHNJbnRlcmFjdGl2ZWx5Ol0pOgorICAgICAgICAoLVtXS0Nv bnRlbnRWaWV3IF9kaWRDb21taXRMYXllclRyZWU6XSk6CisKIDIwMTQtMDctMDIgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYktp dFZlcnNpb24uaCBzaG91bGQgYmUgc2hhcmVkIGJldHdlZW4gVUkgYW5kIFdlYiBQcm9jZXNzIEFQ SXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K aW5kZXggYWE1OTc1ZjcxMTIwY2RjOWI5ZjJlMGQ5ODczZWVhNmEyNTk3NDlkYi4uYmNjNWE4NzRm OTMxMDAxNTk3ZTM2NmQ0MmViNjdlODgwZmFiODI0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTY2Myw2ICs2NjMsNyBAQCAtICh2 b2lkKV91cGRhdGVTY3JvbGxWaWV3QmFja2dyb3VuZAogICAgICAgICBjb2xvciA9IFtfY3VzdG9t Q29udGVudFZpZXcgYmFja2dyb3VuZENvbG9yXS5DR0NvbG9yOwogICAgIGVsc2UKICAgICAgICAg Y29sb3IgPSBfcGFnZS0+cGFnZUV4dGVuZGVkQmFja2dyb3VuZENvbG9yKCk7CisKICAgICBDR0Zs b2F0IHpvb21TY2FsZSA9IGNvbnRlbnRab29tU2NhbGUoc2VsZik7CiAgICAgQ0dGbG9hdCBtaW5p bXVtWm9vbVNjYWxlID0gW19zY3JvbGxWaWV3IG1pbmltdW1ab29tU2NhbGVdOwogICAgIGlmICh6 b29tU2NhbGUgPCBtaW5pbXVtWm9vbVNjYWxlKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggODEyYzg0NjIxYTZjMWNhMGYwOThkODI3MDNm ZWVhMmNlYjQ0N2M2Mi4uNDFjZmQ3ZTZjZWI1NWNkYWIyYjMzNzVjNjkzZDRlNWY2NzNiYWEzZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQpAQCAt NDE3LDYgKzQxNyw3IEBAIEBpbXBsZW1lbnRhdGlvbiBXS0NvbnRlbnRWaWV3IHsKICAgICBSZXRh aW5QdHI8V0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyPiBfYnJvd3NpbmdDb250ZXh0Q29udHJv bGxlcjsKIAogICAgIFJldGFpblB0cjxVSVZpZXc+IF9yb290Q29udGVudFZpZXc7CisgICAgUmV0 YWluUHRyPFVJVmlldz4gX2ZpeGVkQ2xpcHBpbmdWaWV3OwogICAgIFJldGFpblB0cjxXS0luc3Bl Y3RvckluZGljYXRpb25WaWV3PiBfaW5zcGVjdG9ySW5kaWNhdGlvblZpZXc7CiAgICAgUmV0YWlu UHRyPFdLSW5zcGVjdG9ySGlnaGxpZ2h0Vmlldz4gX2luc3BlY3RvckhpZ2hsaWdodFZpZXc7CiAK QEAgLTQ0NCw4ICs0NDUsMTYgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6KENHUmVj dClmcmFtZSBjb250ZXh0OihXZWJLaXQ6OldlYkNvbnRleHQmKWNvbnRleHQKIAogICAgIF9yb290 Q29udGVudFZpZXcgPSBhZG9wdE5TKFtbVUlWaWV3IGFsbG9jXSBpbml0XSk7CiAgICAgW19yb290 Q29udGVudFZpZXcgbGF5ZXJdLm1hc2tzVG9Cb3VuZHMgPSBOTzsKKyAgICAKKyAgICBfZml4ZWRD bGlwcGluZ1ZpZXcgPSBhZG9wdE5TKFtbVUlWaWV3IGFsbG9jXSBpbml0XSk7CisgICAgW19maXhl ZENsaXBwaW5nVmlldyBsYXllcl0ubWFza3NUb0JvdW5kcyA9IFlFUzsKKyAgICBbX2ZpeGVkQ2xp cHBpbmdWaWV3IGxheWVyXS5hbmNob3JQb2ludCA9IENHUG9pbnRaZXJvOworI2lmbmRlZiBOREVC VUcKKyAgICBbW19maXhlZENsaXBwaW5nVmlldyBsYXllcl0gc2V0TmFtZTpAIkZpeGVkIGNsaXBw aW5nIl07CisjZW5kaWYKIAotICAgIFtzZWxmIGFkZFN1YnZpZXc6X3Jvb3RDb250ZW50Vmlldy5n ZXQoKV07CisgICAgW3NlbGYgYWRkU3VidmlldzpfZml4ZWRDbGlwcGluZ1ZpZXcuZ2V0KCldOwor ICAgIFtfZml4ZWRDbGlwcGluZ1ZpZXcgYWRkU3Vidmlldzpfcm9vdENvbnRlbnRWaWV3LmdldCgp XTsKIAogICAgIFtzZWxmIHNldHVwSW50ZXJhY3Rpb25dOwogICAgIFtzZWxmIHNldFVzZXJJbnRl cmFjdGlvbkVuYWJsZWQ6WUVTXTsKQEAgLTU1Myw2ICs1NjIsMTUgQEAgLSAodm9pZClzZXRTaG93 aW5nSW5zcGVjdG9ySW5kaWNhdGlvbjooQk9PTClzaG93CiAgICAgfQogfQogCistICh2b2lkKXVw ZGF0ZUZpeGVkQ2xpcHBpbmdWaWV3OihGbG9hdFJlY3QpZml4ZWRQb3NpdGlvblJlY3RGb3JVSQor eworICAgIEZsb2F0UmVjdCBjbGlwcGluZ0JvdW5kcyA9IFtzZWxmIGJvdW5kc107CisgICAgY2xp cHBpbmdCb3VuZHMudW5pdGUoZml4ZWRQb3NpdGlvblJlY3RGb3JVSSk7CisKKyAgICBbX2ZpeGVk Q2xpcHBpbmdWaWV3IHNldFBvc2l0aW9uOmNsaXBwaW5nQm91bmRzLmxvY2F0aW9uKCldOworICAg IFtfZml4ZWRDbGlwcGluZ1ZpZXcgc2V0Qm91bmRzOmNsaXBwaW5nQm91bmRzXTsKK30KKwogLSAo dm9pZClkaWRVcGRhdGVWaXNpYmxlUmVjdDooQ0dSZWN0KXZpc2libGVSZWN0IHVub2JzY3VyZWRS ZWN0OihDR1JlY3QpdW5vYnNjdXJlZFJlY3QgdW5vYnNjdXJlZFJlY3RJblNjcm9sbFZpZXdDb29y ZGluYXRlczooQ0dSZWN0KXVub2JzY3VyZWRSZWN0SW5TY3JvbGxWaWV3Q29vcmRpbmF0ZXMKICAg ICBzY2FsZTooQ0dGbG9hdCl6b29tU2NhbGUgbWluaW11bVNjYWxlOihDR0Zsb2F0KW1pbmltdW1T Y2FsZSBpblN0YWJsZVN0YXRlOihCT09MKWlzU3RhYmxlU3RhdGUgaXNDaGFuZ2luZ09ic2N1cmVk SW5zZXRzSW50ZXJhY3RpdmVseTooQk9PTClpc0NoYW5naW5nT2JzY3VyZWRJbnNldHNJbnRlcmFj dGl2ZWx5CiB7CkBAIC01NzAsMTMgKzU4OCwxNiBAQCAtICh2b2lkKWRpZFVwZGF0ZVZpc2libGVS ZWN0OihDR1JlY3QpdmlzaWJsZVJlY3QgdW5vYnNjdXJlZFJlY3Q6KENHUmVjdCl1bm9ic2N1cgog ICAgICAgICB6b29tU2NhbGUsIGlzU3RhYmxlU3RhdGUsIGlzQ2hhbmdpbmdPYnNjdXJlZEluc2V0 c0ludGVyYWN0aXZlbHksIHRpbWVzdGFtcCwgdmVsb2NpdHlEYXRhLmhvcml6b250YWxWZWxvY2l0 eSwgdmVsb2NpdHlEYXRhLnZlcnRpY2FsVmVsb2NpdHksIHZlbG9jaXR5RGF0YS5zY2FsZUNoYW5n ZVJhdGUpOwogCiAgICAgUmVtb3RlU2Nyb2xsaW5nQ29vcmRpbmF0b3JQcm94eSogc2Nyb2xsaW5n Q29vcmRpbmF0b3IgPSBfcGFnZS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3JQcm94eSgpOwotICAgIHNj cm9sbGluZ0Nvb3JkaW5hdG9yLT52aWV3cG9ydENoYW5nZWRWaWFEZWxlZ2F0ZWRTY3JvbGxpbmco c2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnJvb3RTY3JvbGxpbmdOb2RlSUQoKSwgX3BhZ2UtPmNvbXB1 dGVDdXN0b21GaXhlZFBvc2l0aW9uUmVjdChfcGFnZS0+dW5vYnNjdXJlZENvbnRlbnRSZWN0KCks IHpvb21TY2FsZSksIHpvb21TY2FsZSk7CisgICAgRmxvYXRSZWN0IGZpeGVkUG9zaXRpb25SZWN0 ID0gX3BhZ2UtPmNvbXB1dGVDdXN0b21GaXhlZFBvc2l0aW9uUmVjdChfcGFnZS0+dW5vYnNjdXJl ZENvbnRlbnRSZWN0KCksIHpvb21TY2FsZSk7CisgICAgc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnZp ZXdwb3J0Q2hhbmdlZFZpYURlbGVnYXRlZFNjcm9sbGluZyhzY3JvbGxpbmdDb29yZGluYXRvci0+ cm9vdFNjcm9sbGluZ05vZGVJRCgpLCBmaXhlZFBvc2l0aW9uUmVjdCwgem9vbVNjYWxlKTsKIAog ICAgIGlmIChhdXRvIGRyYXdpbmdBcmVhID0gX3BhZ2UtPmRyYXdpbmdBcmVhKCkpCiAgICAgICAg IGRyYXdpbmdBcmVhLT51cGRhdGVEZWJ1Z0luZGljYXRvcigpOwogCiAgICAgaWYgKCF3aXRoaW5F cHNpbG9uKG9sZERpc3BsYXllZENvbnRlbnRTY2FsZSwgem9vbVNjYWxlKSkKICAgICAgICAgW3Nl bGYgX3VwZGF0ZVVuc2NhbGVkVmlld107CisgICAgICAgIAorICAgIFtzZWxmIHVwZGF0ZUZpeGVk Q2xpcHBpbmdWaWV3OmZpeGVkUG9zaXRpb25SZWN0XTsKIH0KIAogLSAodm9pZClzZXRNaW5pbXVt U2l6ZTooQ0dTaXplKXNpemUKQEAgLTY2NywxMiArNjg4LDIzIEBAIC0gKHZvaWQpX2RpZENvbW1p dExvYWRGb3JNYWluRnJhbWUKIC0gKHZvaWQpX2RpZENvbW1pdExheWVyVHJlZTooY29uc3QgV2Vi S2l0OjpSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbiYpbGF5ZXJUcmVlVHJhbnNhY3Rpb24KIHsK ICAgICBDR1NpemUgY29udGVudHNTaXplID0gbGF5ZXJUcmVlVHJhbnNhY3Rpb24uY29udGVudHNT aXplKCk7Ci0KLSAgICBbc2VsZiBzZXRCb3VuZHM6e0NHUG9pbnRaZXJvLCBjb250ZW50c1NpemV9 XTsKLSAgICBbX3Jvb3RDb250ZW50VmlldyBzZXRGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIGNvbnRl bnRzU2l6ZS53aWR0aCwgY29udGVudHNTaXplLmhlaWdodCldOwotICAgIFtfaW5zcGVjdG9ySW5k aWNhdGlvblZpZXcgc2V0RnJhbWU6W3NlbGYgYm91bmRzXV07CisgICAgQ0dSZWN0IGNvbnRlbnRC b3VuZHMgPSB7IENHUG9pbnRaZXJvLCBjb250ZW50c1NpemUgfTsKKyAgICBDR1JlY3Qgb2xkQm91 bmRzID0gW3NlbGYgYm91bmRzXTsKKworICAgIEJPT0wgYm91bmRzQ2hhbmdlZCA9ICFDR1JlY3RF cXVhbFRvUmVjdChvbGRCb3VuZHMsIGNvbnRlbnRCb3VuZHMpOworICAgIGlmIChib3VuZHNDaGFu Z2VkKSB7CisgICAgICAgIFtzZWxmIHNldEJvdW5kczpjb250ZW50Qm91bmRzXTsKKyAgICAgICAg W19yb290Q29udGVudFZpZXcgc2V0RnJhbWU6Y29udGVudEJvdW5kc107CisgICAgICAgIFtfaW5z cGVjdG9ySW5kaWNhdGlvblZpZXcgc2V0RnJhbWU6Y29udGVudEJvdW5kc107CisgICAgfQogCiAg ICAgW193ZWJWaWV3IF9kaWRDb21taXRMYXllclRyZWU6bGF5ZXJUcmVlVHJhbnNhY3Rpb25dOwor ICAgIAorICAgIGlmIChib3VuZHNDaGFuZ2VkKSB7CisgICAgICAgIEZsb2F0UmVjdCBmaXhlZFBv c2l0aW9uUmVjdCA9IF9wYWdlLT5jb21wdXRlQ3VzdG9tRml4ZWRQb3NpdGlvblJlY3QoX3BhZ2Ut PnVub2JzY3VyZWRDb250ZW50UmVjdCgpLCBbW193ZWJWaWV3IHNjcm9sbFZpZXddIHpvb21TY2Fs ZV0pOworICAgICAgICBbc2VsZiB1cGRhdGVGaXhlZENsaXBwaW5nVmlldzpmaXhlZFBvc2l0aW9u UmVjdF07CisgICAgfQorICAgIAogICAgIFtzZWxmIF91cGRhdGVDaGFuZ2VkU2VsZWN0aW9uXTsK IH0KIAo=