<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134601</bug_id>
          
          <creation_ts>2014-07-03 10:30:06 -0700</creation_ts>
          <short_desc>Rationalize the interaction between GC and the SymbolTable lock</short_desc>
          <delta_ts>2015-03-30 11:40:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>barraclough</cc>
    
    <cc>ggaren</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1020294</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-07-03 10:30:06 -0700</bug_when>
    <thetext>Currently we have everything we need to ensure that we don&apos;t do GC things while holding the SymbolTable lock, and yet we still use a GCSafeConcurrentJITLocker because of the few things that slipped through, like exception throwing.

Also, we notifyWrite() on watchpoint sets while holding the SymbolTable lock, which seems super dangerous.

We should fix this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081256</commentid>
    <comment_count>1</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2015-03-30 11:40:11 -0700</bug_when>
    <thetext>The notifyWrite part will be taken care of by https://bugs.webkit.org/show_bug.cgi?id=143232.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>