134587 2014-07-03 01:12:54 -0700 Broken build with build-webkit --no-video 2014-07-10 07:56:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi benjamin bunhere cdumez cgarcia cmarcelo commit-queue gyuyoung.kim rakuco sergio oldest_to_newest 1020206 0 ryuan.choi 2014-07-03 01:12:54 -0700 MEDIA_CONTROLS_SCRIPT requires VIDEO enabled. There are several error messages including below when building with -no-video (Tested on the EFL port) WebKit/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:228:1: error: control reaches end of non-void function [-Werror=return-type] 1020207 1 234325 ryuan.choi 2014-07-03 01:15:36 -0700 Created attachment 234325 Patch 1020355 2 234325 commit-queue 2014-07-03 13:07:11 -0700 Comment on attachment 234325 Patch Clearing flags on attachment: 234325 Committed r170764: <http://trac.webkit.org/changeset/170764> 1020356 3 commit-queue 2014-07-03 13:07:18 -0700 All reviewed patches have been landed. Closing bug. 1021615 4 234325 cgarcia 2014-07-10 07:54:24 -0700 Comment on attachment 234325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234325&action=review > Source/cmake/WebKitFeatures.cmake:134 > + WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_CONTROLS_SCRIPT ENABLE_VIDEO) I think this is even more restrictive, MediaControlsHost uses TextTrack unconditionally, so I think ENABLE_MEDIA_CONTROLS_SCRIPT depends on ENABLE_VIDEO_TRACK 234325 2014-07-03 01:15:36 -0700 2014-07-10 07:54:24 -0700 Patch bug-134587-20140703171516.patch text/plain 2722 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFjNTEyMjU0MTQ2ZmU2OTNhMmRkNDEw Nzg4YTNkZDhkN2JhNjE0OGYuLmNhZGNkNDI0MGJjY2E0ZmRkOTEwNmJkN2VjOTM2NjQwNjhmYjQw MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDctMDMgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIEJyb2tlbiBidWlsZCB3aXRoIGJ1aWxkLXdlYmtp dCAtLW5vLXZpZGVvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzQ1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNRURJQV9DT05UUk9MU19TQ1JJUFQgcmVxdWlyZXMgVklERU8gZW5hYmxlZC4KKworICAg ICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5lcy5oOiBBZGRlZCBlcnJvciBtZXNzYWdlIGZvciBkZXBl bmRlbmN5IGZhaWx1cmUuCisKIDIwMTQtMDctMDIgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFw cGxlLmNvbT4KIAogICAgICAgICBpT1MgYnVpbGQgZml4IGFmdGVyIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzE3MDY5Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1 cmVEZWZpbmVzLmggYi9Tb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCmluZGV4IGVhZjRj MzQyYjAxOGRkMDM0YTllNTFkODY3NWIxYWJiZTMzODdlZjYuLjNiMGJhODgwZGI4MGQ3ODJmOWFi MjFkMDRhM2Y5NDM5MGI4Nzk1ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVE ZWZpbmVzLmgKKysrIGIvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaApAQCAtODEwLDYg KzgxMCwxMCBAQAogI2Vycm9yICJFTkFCTEUoVklERU9fVFJBQ0spIHJlcXVpcmVzIEVOQUJMRShW SURFTykiCiAjZW5kaWYKIAorI2lmIEVOQUJMRShNRURJQV9DT05UUk9MU19TQ1JJUFQpICYmICFF TkFCTEUoVklERU8pCisjZXJyb3IgIkVOQUJMRShNRURJQV9DT05UUk9MU19TQ1JJUFQpIHJlcXVp cmVzIEVOQUJMRShWSURFTykiCisjZW5kaWYKKwogI2lmIEVOQUJMRShSRU1PVEVfSU5TUEVDVE9S KSAmJiAhRU5BQkxFKElOU1BFQ1RPUikKICNlcnJvciAiRU5BQkxFKFJFTU9URV9JTlNQRUNUT1Ip IHJlcXVpcmVzIEVOQUJMRShJTlNQRUNUT1IpIgogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv Y21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMu Y21ha2UKaW5kZXggYmZiMjY2NmUzYmZlOTlmZGJkNDQyOWZmNzAzODU5ZGQ3MzkxMjM1Yy4uOTY1 ZTFlZWU1ZmJiNTQwYzUxMjNkNjIwODcxZDA3YzcyODE2MDc3OCAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0 dXJlcy5jbWFrZQpAQCAtMTMxLDYgKzEzMSw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4p CiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1NZU1RFTV9NQUxMT0MgIlRvZ2dsZSBzeXN0 ZW0gYWxsb2NhdG9yIGluc3RlYWQgb2YgVENtYWxsb2MiIE9GRikKICAgICBXRUJLSVRfT1BUSU9O X0RFRklORShXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUgIlRvZ2dsZSBUaWxlZCBCYWNraW5n IFN0b3JlIHN1cHBvcnQiIE9GRikKIAorICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9N RURJQV9DT05UUk9MU19TQ1JJUFQgRU5BQkxFX1ZJREVPKQogICAgIFdFQktJVF9PUFRJT05fREVQ RU5EKEVOQUJMRV9WSURFT19UUkFDSyBFTkFCTEVfVklERU8pCiAgICAgV0VCS0lUX09QVElPTl9E RVBFTkQoRU5BQkxFX1RPVUNIX1NMSURFUiBFTkFCTEVfVE9VQ0hfRVZFTlQpCiBlbmRtYWNybygp CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYTVkOGM3ZGU3MjdkMjIw YTU4Y2M0ZDZiNmQ4ODhkZTJjNTk2MjgzMC4uYWE4Nzk0OTE5NWU2ZjI2MjkxZTQzYWI0NWNmMDky YmY1M2FmYjQ3NiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDE2IEBACiAyMDE0LTA3LTAzICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNv bT4KIAorICAgICAgICBCcm9rZW4gYnVpbGQgd2l0aCBidWlsZC13ZWJraXQgLS1uby12aWRlbwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NTg3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTUVESUFfQ09O VFJPTFNfU0NSSVBUIHJlcXVpcmVzIFZJREVPIGVuYWJsZWQuCisKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6IEFkZGVkIHRoZSBkZXBlbmRlbmN5IGZvciBFTkFC TEVfTUVESUFfQ09OVFJPTFNfU0NSSVBULgorCisyMDE0LTA3LTAzICBSeXVhbiBDaG9pICA8cnl1 YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwogICAgICAgICBbQ01BS0VdIEFkZCBXRUJLSVRfT1BUSU9O X0RFUEVORCBtYWNybyB0byByZXNvbHZlIG1hY3JvIGRlcGVuZGVuY3kKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDU3OAogCg==