134578 2014-07-02 18:09:53 -0700 [CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency 2014-07-03 01:05:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere cdumez commit-queue gyuyoung.kim rakuco sergio oldest_to_newest 1020135 0 ryuan.choi 2014-07-02 18:09:53 -0700 For example, VIDEO_TRACK should be disable if VIDEO is disabled. I realized that legacy hack in OptionsEfl.cmake does not work well. Instead, I proposed simple macro, WEBKIT_OPTION_DEPEND to solve these issues. 1020143 1 234304 ryuan.choi 2014-07-02 18:28:22 -0700 Created attachment 234304 Patch 1020150 2 234304 gyuyoung.kim 2014-07-02 18:56:06 -0700 Comment on attachment 234304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234304&action=review Oh, nice. LGTM. > Source/cmake/OptionsEfl.cmake:92 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON) Looks this is not related to this patch. 1020153 3 234304 gyuyoung.kim 2014-07-02 19:04:33 -0700 Comment on attachment 234304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234304&action=review >> Source/cmake/OptionsEfl.cmake:92 >> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON) > > Looks this is not related to this patch. Ah, I misunderstood. 1020204 4 234304 ryuan.choi 2014-07-03 01:05:23 -0700 Comment on attachment 234304 Patch Clearing flags on attachment: 234304 Committed r170749: <http://trac.webkit.org/changeset/170749> 1020205 5 ryuan.choi 2014-07-03 01:05:33 -0700 All reviewed patches have been landed. Closing bug. 234304 2014-07-02 18:28:22 -0700 2014-07-03 01:05:23 -0700 Patch bug-134578-20140703102802.patch text/plain 5277 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDAwYjMx ZGQ4M2MyOTU5NmM1ZDY5ZDE5MmM5NGFjNWI1NDQxNTFjMDYuLjhjZjE4ZTA4OTk4ZTk3ZmRlYmZk MGRlMmU1YjdlNDg0MjA1NTE2ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC04OSw2ICs4OSw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TUEVFQ0hfU1lOVEhF U0lTIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TUEVMTENI RUNLIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1RFTVBMQVRF X0VMRU1FTlQgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVE9V Q0hfRVZFTlRTIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1RP VUNIX1NMSURFUiBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9V U0VSU0VMRUNUX0FMTCBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9WSUJSQVRJT04gT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf VklERU8gT04pCkBAIC0xMDcsMTYgKzEwOCw2IEBAIGlmIChFTkFCTEVfTExJTlRfQ19MT09QKQog ICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GVExfSklUIE9GRikK IGVuZGlmICgpCiAKLWlmIChFTkFCTEVfVE9VQ0hfRVZFTlRTKQotICAgIFdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9UT1VDSF9TTElERVIgT04pCi1lbmRpZiAoKQotCi0j IEZJWE1FOiBQZXJoYXBzIHdlIG5lZWQgYSBtb3JlIGdlbmVyaWMgd2F5IG9mIGRlZmluaW5nIGRl cGVuZGVuY2llcyBiZXR3ZWVuIGZlYXR1cmVzLgotIyBWSURFT19UUkFDSyBkZXBlbmRzIG9uIFZJ REVPLgotaWYgKE5PVCBFTkFCTEVfVklERU8gQU5EIEVOQUJMRV9WSURFT19UUkFDSykKLSAgICBt ZXNzYWdlKFNUQVRVUyAiRGlzYWJsaW5nIFZJREVPX1RSQUNLIHNpbmNlIFZJREVPIHN1cHBvcnQg aXMgZGlzYWJsZWQuIikKLSAgICBzZXQoRU5BQkxFX1ZJREVPX1RSQUNLIE9GRikKLWVuZGlmICgp CiBXRUJLSVRfT1BUSU9OX0VORCgpCiAKIG9wdGlvbihFTkFCTEVfRUNPUkVfWCAiRW5hYmxlIEVj b3JlX1ggc3BlY2lmaWMgdXNhZ2UgKGN1cnNvciwgYmVsbCkiIE9OKQpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr ZQppbmRleCBhMGRjMTNjYzQ3YTIxYzQwODc3ZGFlM2ExZjViNjA1OTFjZWI0NWI1Li5kZTQ4NTA0 MDIwYzlhMGQ5ZTQxMjkxMmE3YjczYWY1NDE5NDFiYjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21h a2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpA QCAtODEsMTMgKzgxLDYgQEAgaWYgKEVOQUJMRV9XQVlMQU5EX1RBUkdFVCkKICAgICBhZGRfZGVm aW5pdGlvbnMoLURXVEZfUExBVEZPUk1fV0FZTEFORD0xKQogZW5kaWYgKCkKIAotIyBGSVhNRTog UGVyaGFwcyB3ZSBuZWVkIGEgbW9yZSBnZW5lcmljIHdheSBvZiBkZWZpbmluZyBkZXBlbmRlbmNp ZXMgYmV0d2VlbiBmZWF0dXJlcy4KLSMgVklERU9fVFJBQ0sgZGVwZW5kcyBvbiBWSURFTy4KLWlm IChOT1QgRU5BQkxFX1ZJREVPIEFORCBFTkFCTEVfVklERU9fVFJBQ0spCi0gICAgbWVzc2FnZShT VEFUVVMgIkRpc2FibGluZyBWSURFT19UUkFDSyBzaW5jZSBWSURFTyBzdXBwb3J0IGlzIGRpc2Fi bGVkLiIpCi0gICAgc2V0KEVOQUJMRV9WSURFT19UUkFDSyBPRkYpCi1lbmRpZiAoKQotCiBpZiAo REVWRUxPUEVSX01PREUpCiAgICAgc2V0KEVOQUJMRV9UT09MUyBPTikKICAgICBzZXQoRU5BQkxF X0FQSV9URVNUUyBPTikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5j bWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQppbmRleCA1MDM3ZmQ4ODE2 YTQxMGJkZmU0NmI4NzAxMzIyZDI1MzlkMzlmZWJjLi5iZmIyNjY2ZTNiZmU5OWZkYmQ0NDI5ZmY3 MDM4NTlkZDczOTEyMzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMu Y21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCkBAIC0xMCw2ICsx MCwxMCBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRSBfbmFtZSBfdmFs dWUpCiAgICAgc2V0KF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSU5JVElBTFZBTFVFXyR7X25h bWV9ICR7X3ZhbHVlfSkKIGVuZG1hY3JvKCkKIAorbWFjcm8oV0VCS0lUX09QVElPTl9ERVBFTkQg X25hbWUgX2RlcGVuZCkKKyAgICBzZXQoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19ERVBFTkRF TkNZX09GXyR7X25hbWV9ICR7X2RlcGVuZH0pCitlbmRtYWNybygpCisKIG1hY3JvKFdFQktJVF9P UFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFXzNEX1JFTkRFUklO RyAiVG9nZ2xlIDNEIHJlbmRlcmluZyBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9E RUZJTkUoRU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyAiVG9nZ2xlIGFjY2VsZXJhdGVkIDJE IGNhbnZhcyBzdXBwb3J0IiBPRkYpCkBAIC0xMjYsNiArMTMwLDkgQEAgbWFjcm8oV0VCS0lUX09Q VElPTl9CRUdJTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfWFNMVCAiVG9nZ2xl IFhTTFQgc3VwcG9ydCIgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1NZU1RFTV9N QUxMT0MgIlRvZ2dsZSBzeXN0ZW0gYWxsb2NhdG9yIGluc3RlYWQgb2YgVENtYWxsb2MiIE9GRikK ICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUgIlRv Z2dsZSBUaWxlZCBCYWNraW5nIFN0b3JlIHN1cHBvcnQiIE9GRikKKworICAgIFdFQktJVF9PUFRJ T05fREVQRU5EKEVOQUJMRV9WSURFT19UUkFDSyBFTkFCTEVfVklERU8pCisgICAgV0VCS0lUX09Q VElPTl9ERVBFTkQoRU5BQkxFX1RPVUNIX1NMSURFUiBFTkFCTEVfVE9VQ0hfRVZFTlQpCiBlbmRt YWNybygpCiAKIG1hY3JvKFdFQktJVF9PUFRJT05fRU5EKQpAQCAtMTMzLDE3ICsxNDAsMjMgQEAg bWFjcm8oV0VCS0lUX09QVElPTl9FTkQpCiAgICAgICAgIG9wdGlvbigke19uYW1lfSAiJHtfV0VC S0lUX0FWQUlMQUJMRV9PUFRJT05TX0RFU0NSSVBUSU9OXyR7X25hbWV9fSIgJHtfV0VCS0lUX0FW QUlMQUJMRV9PUFRJT05TX0lOSVRJQUxWQUxVRV8ke19uYW1lfX0pCiAgICAgZW5kZm9yZWFjaCAo KQogCi0KLSAgICBtZXNzYWdlKFNUQVRVUyAiRW5hYmxlZCBmZWF0dXJlczoiKQotCiAgICAgc2V0 KF9NQVhfRkVBVFVSRV9MRU5HVEggMCkKICAgICBmb3JlYWNoIChfbmFtZSAke19XRUJLSVRfQVZB SUxBQkxFX09QVElPTlN9KQogICAgICAgICBzdHJpbmcoTEVOR1RIICR7X25hbWV9IF9OQU1FX0xF TkdUSCkKICAgICAgICAgaWYgKF9OQU1FX0xFTkdUSCBHUkVBVEVSIF9NQVhfRkVBVFVSRV9MRU5H VEgpCiAgICAgICAgICAgICBzZXQoX01BWF9GRUFUVVJFX0xFTkdUSCAke19OQU1FX0xFTkdUSH0p CiAgICAgICAgIGVuZGlmICgpCisKKyAgICAgICAgaWYgKCR7X25hbWV9IEFORCBERUZJTkVEIF9X RUJLSVRfQVZBSUxBQkxFX09QVElPTlNfREVQRU5ERU5DWV9PRl8ke19uYW1lfSkKKyAgICAgICAg ICAgIGlmIChOT1QgJHske19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfREVQRU5ERU5DWV9PRl8k e19uYW1lfX19KQorICAgICAgICAgICAgICAgIG1lc3NhZ2UoU1RBVFVTICJEaXNhYmxpbmcgJHtf bmFtZX0gc2luY2UgJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0RFUEVOREVOQ1lfT0ZfJHtf bmFtZX19IHN1cHBvcnQgaXMgZGlzYWJsZWQuIikKKyAgICAgICAgICAgICAgICBzZXQoJHtfbmFt ZX0gT0ZGKQorICAgICAgICAgICAgZW5kaWYgKCkKKyAgICAgICAgZW5kaWYgKCkKICAgICBlbmRm b3JlYWNoICgpCiAKKyAgICBtZXNzYWdlKFNUQVRVUyAiRW5hYmxlZCBmZWF0dXJlczoiKQorCiAg ICAgc2V0KF9TSE9VTERfUFJJTlRfUE9JTlRTIE9GRikKICAgICBmb3JlYWNoIChfbmFtZSAke19X RUJLSVRfQVZBSUxBQkxFX09QVElPTlN9KQogICAgICAgICBzdHJpbmcoTEVOR1RIICR7X25hbWV9 IF9OQU1FX0xFTkdUSCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0 MWEyODdiMGUxM2U0YmRkMTBhODNiZDMzZjA2MjMyYzEzMDM4YjEyLi4wZjZmYTQwM2RlZWU2OGRl N2IwM2Y5NDc1MGQ0ZGFmZjNmOGQxNTZhIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDctMDIgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDTUFLRV0gQWRkIFdFQktJVF9PUFRJT05fREVQ RU5EIG1hY3JvIHRvIHJlc29sdmUgbWFjcm8gZGVwZW5kZW5jeQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NTc4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSBvcHRpb25zIGRlcGVuZCBvbiBhbm90 aGVyIG9wdGlvbiBzdWNoIGFzIEVOQUJMRV9WSURFT19UUkFDSyBhbmQgRU5BQkxFX1ZJREVPLgor ICAgICAgICBUaGlzIHBhdGNoIGFkZHMgV0VCS0lUX09QVElPTl9ERVBFTkQgdG8gY2hlY2sgdGhl IGRlcGVuZGluZyBvcHRpb24gYW5kCisgICAgICAgIGRpc2FibGUgcmVsYXRlZCBvcHRpb24gaWYg aXQgaXMgbm90IE9OLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6 IFJlbW92ZWQgaGFjayBmb3Igb3B0aW9uIGRlcGVuZGVuY3kuCisgICAgICAgICogU291cmNlL2Nt YWtlL09wdGlvbnNHVEsuY21ha2U6IERpdHRvLgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJL aXRGZWF0dXJlcy5jbWFrZTogQWRkZWQgV0VCS0lUX09QVElPTl9ERVBFTkQgbWFjcm8uCisKIDIw MTQtMDctMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIG1ha2UgZGlzdCBpcyBicm9rZW4K