134572 2014-07-02 17:38:23 -0700 REGRESSION(WK2): Undo does not work in text fields in Safari 2014-07-02 18:00:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1020115 0 enrica 2014-07-02 17:38:23 -0700 <rdar://problem/17542238> 1020119 1 234300 enrica 2014-07-02 17:42:12 -0700 Created attachment 234300 Patch 1020120 2 commit-queue 2014-07-02 17:45:15 -0700 Attachment 234300 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:65: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1020126 3 234300 benjamin 2014-07-02 17:57:10 -0700 Comment on attachment 234300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234300&action=review Looks reasonable. > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:89 > +- (WebEditCommandProxy*)command Space before the star. 1020128 4 enrica 2014-07-02 18:00:04 -0700 Committed revision 170738. 234300 2014-07-02 17:42:12 -0700 2014-07-02 17:57:10 -0700 Patch wk2undo.txt text/plain 5355 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDczNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA3LTAyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihXSzIpOiBV bmRvIGRvZXMgbm90IHdvcmsgaW4gdGV4dCBmaWVsZHMgaW4gU2FmYXJpLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NTcyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xNzU0MjIzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBmb3IgaU9TIHRoZSBzYW1lIGlt cGxlbWVudGF0aW9uIHdlIGhhdmUgYWxyZWFkeSBmb3IgT1MgWC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1Bh Z2VDbGllbnRJbXBsSU9TLm1tOgorICAgICAgICAoLVtXS0VkaXRDb21tYW5kT2JqQyBpbml0V2l0 aFdlYkVkaXRDb21tYW5kUHJveHk6XSk6CisgICAgICAgICgtW1dLRWRpdENvbW1hbmRPYmpDIGNv bW1hbmRdKToKKyAgICAgICAgKC1bV0tFZGl0b3JVbmRvVGFyZ2V0T2JqQyB1bmRvRWRpdGluZzpd KToKKyAgICAgICAgKC1bV0tFZGl0b3JVbmRvVGFyZ2V0T2JqQyByZWRvRWRpdGluZzpdKToKKyAg ICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OlBhZ2VDbGllbnRJbXBsKToKKyAgICAgICAg KFdlYktpdDo6UGFnZUNsaWVudEltcGw6OnJlZ2lzdGVyRWRpdENvbW1hbmQpOgorICAgICAgICAo V2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6Y2xlYXJBbGxFZGl0Q29tbWFuZHMpOgorICAgICAgICAo V2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6Y2FuVW5kb1JlZG8pOgorICAgICAgICAoV2ViS2l0OjpQ YWdlQ2xpZW50SW1wbDo6ZXhlY3V0ZVVuZG9SZWRvKToKKwogMjAxNC0wNy0wMSAgTWFyayBSb3dl ICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzQ1 MjI+IFJlbW92ZSBkdXBsaWNhdGlvbiBpbiBjb2RlIHRoYXQgcHJlcGFyZXMgdGhlIHVzZXIgYWdl bnQgc3RyaW5nIG9uIE1hYyBhbmQgaU9TCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1BhZ2VDbGllbnRJbXBsSU9TLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5oCShyZXZpc2lvbiAxNzA3MTEpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM0LDYgKzM0LDcgQEAKIAogT0JKQ19DTEFTUyBXS0NvbnRlbnRWaWV3OwogT0JKQ19D TEFTUyBXS1dlYlZpZXc7CitPQkpDX0NMQVNTIFdLRWRpdG9yVW5kb1RhcmdldE9iakM7CiAKIG5h bWVzcGFjZSBXZWJLaXQgewogICAgIApAQCAtMTY4LDYgKzE2OSw3IEBAIHByaXZhdGU6CiAKICAg ICBXS0NvbnRlbnRWaWV3ICptX2NvbnRlbnRWaWV3OwogICAgIFdLV2ViVmlldyAqbV93ZWJWaWV3 OworICAgIFJldGFpblB0cjxXS0VkaXRvclVuZG9UYXJnZXRPYmpDPiBtX3VuZG9UYXJnZXQ7CiB9 OwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbQkocmV2aXNpb24gMTcwNzExKQorKysg U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtNTksMTIgKzU5LDYyIEBAIC0gKENHUmVjdClhY2Nlc3NpYmlsaXR5Q29udmVy dFJlY3RUb1NjZW4KIEBlbmQKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7Cit1c2luZyBuYW1l c3BhY2UgV2ViS2l0OworCitAaW50ZXJmYWNlIFdLRWRpdENvbW1hbmRPYmpDIDogTlNPYmplY3QK K3sKKyAgICBSZWZQdHI8V2ViRWRpdENvbW1hbmRQcm94eT4gbV9jb21tYW5kOworfQorLSAoaWQp aW5pdFdpdGhXZWJFZGl0Q29tbWFuZFByb3h5OihQYXNzUmVmUHRyPFdlYkVkaXRDb21tYW5kUHJv eHk+KWNvbW1hbmQ7CistIChXZWJFZGl0Q29tbWFuZFByb3h5Kiljb21tYW5kOworQGVuZAorCitA aW50ZXJmYWNlIFdLRWRpdG9yVW5kb1RhcmdldE9iakMgOiBOU09iamVjdAorLSAodm9pZCl1bmRv RWRpdGluZzooaWQpc2VuZGVyOworLSAodm9pZClyZWRvRWRpdGluZzooaWQpc2VuZGVyOworQGVu ZAorCitAaW1wbGVtZW50YXRpb24gV0tFZGl0Q29tbWFuZE9iakMKKworLSAoaWQpaW5pdFdpdGhX ZWJFZGl0Q29tbWFuZFByb3h5OihQYXNzUmVmUHRyPFdlYkVkaXRDb21tYW5kUHJveHk+KWNvbW1h bmQKK3sKKyAgICBzZWxmID0gW3N1cGVyIGluaXRdOworICAgIGlmICghc2VsZikKKyAgICAgICAg cmV0dXJuIG5pbDsKKyAgICAKKyAgICBtX2NvbW1hbmQgPSBjb21tYW5kOworICAgIHJldHVybiBz ZWxmOworfQorCistIChXZWJFZGl0Q29tbWFuZFByb3h5Kiljb21tYW5kCit7CisgICAgcmV0dXJu IG1fY29tbWFuZC5nZXQoKTsKK30KKworQGVuZAorCitAaW1wbGVtZW50YXRpb24gV0tFZGl0b3JV bmRvVGFyZ2V0T2JqQworCistICh2b2lkKXVuZG9FZGl0aW5nOihpZClzZW5kZXIKK3sKKyAgICBB U1NFUlQoW3NlbmRlciBpc0tpbmRPZkNsYXNzOltXS0VkaXRDb21tYW5kT2JqQyBjbGFzc11dKTsK KyAgICBbc2VuZGVyIGNvbW1hbmRdLT51bmFwcGx5KCk7Cit9CisKKy0gKHZvaWQpcmVkb0VkaXRp bmc6KGlkKXNlbmRlcgoreworICAgIEFTU0VSVChbc2VuZGVyIGlzS2luZE9mQ2xhc3M6W1dLRWRp dENvbW1hbmRPYmpDIGNsYXNzXV0pOworICAgIFtzZW5kZXIgY29tbWFuZF0tPnJlYXBwbHkoKTsK K30KKworQGVuZAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogUGFnZUNsaWVudEltcGw6OlBhZ2VD bGllbnRJbXBsKFdLQ29udGVudFZpZXcgKmNvbnRlbnRWaWV3LCBXS1dlYlZpZXcgKndlYlZpZXcp CiAgICAgOiBtX2NvbnRlbnRWaWV3KGNvbnRlbnRWaWV3KQogICAgICwgbV93ZWJWaWV3KHdlYlZp ZXcpCisgICAgLCBtX3VuZG9UYXJnZXQoYWRvcHROUyhbW1dLRWRpdG9yVW5kb1RhcmdldE9iakMg YWxsb2NdIGluaXRdKSkKIHsKIH0KIApAQCAtMjMyLDkgKzI4MiwxNyBAQCB2b2lkIFBhZ2VDbGll bnRJbXBsOjpkaWRDaGFuZ2VWaWV3cG9ydFByCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAot dm9pZCBQYWdlQ2xpZW50SW1wbDo6cmVnaXN0ZXJFZGl0Q29tbWFuZChQYXNzUmVmUHRyPFdlYkVk aXRDb21tYW5kUHJveHk+LCBXZWJQYWdlUHJveHk6OlVuZG9PclJlZG8pCit2b2lkIFBhZ2VDbGll bnRJbXBsOjpyZWdpc3RlckVkaXRDb21tYW5kKFBhc3NSZWZQdHI8V2ViRWRpdENvbW1hbmRQcm94 eT4gcHJwQ29tbWFuZCwgV2ViUGFnZVByb3h5OjpVbmRvT3JSZWRvIHVuZG9PclJlZG8pCiB7Ci0g ICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBSZWZQdHI8V2ViRWRpdENvbW1hbmRQcm94eT4gY29t bWFuZCA9IHBycENvbW1hbmQ7CisgICAgCisgICAgUmV0YWluUHRyPFdLRWRpdENvbW1hbmRPYmpD PiBjb21tYW5kT2JqQyA9IGFkb3B0TlMoW1tXS0VkaXRDb21tYW5kT2JqQyBhbGxvY10gaW5pdFdp dGhXZWJFZGl0Q29tbWFuZFByb3h5OmNvbW1hbmRdKTsKKyAgICBTdHJpbmcgYWN0aW9uTmFtZSA9 IFdlYkVkaXRDb21tYW5kUHJveHk6Om5hbWVGb3JFZGl0QWN0aW9uKGNvbW1hbmQtPmVkaXRBY3Rp b24oKSk7CisgICAgCisgICAgTlNVbmRvTWFuYWdlciAqdW5kb01hbmFnZXIgPSBbbV9jb250ZW50 VmlldyB1bmRvTWFuYWdlcl07CisgICAgW3VuZG9NYW5hZ2VyIHJlZ2lzdGVyVW5kb1dpdGhUYXJn ZXQ6bV91bmRvVGFyZ2V0LmdldCgpIHNlbGVjdG9yOigodW5kb09yUmVkbyA9PSBXZWJQYWdlUHJv eHk6OlVuZG8pID8gQHNlbGVjdG9yKHVuZG9FZGl0aW5nOikgOiBAc2VsZWN0b3IocmVkb0VkaXRp bmc6KSkgb2JqZWN0OmNvbW1hbmRPYmpDLmdldCgpXTsKKyAgICBpZiAoIWFjdGlvbk5hbWUuaXNF bXB0eSgpKQorICAgICAgICBbdW5kb01hbmFnZXIgc2V0QWN0aW9uTmFtZTooTlNTdHJpbmcgKilh Y3Rpb25OYW1lXTsKIH0KIAogI2lmIFVTRShJTlNFUlRJT05fVU5ET19HUk9VUElORykKQEAgLTI0 NiwxOCArMzA0LDE3IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OnJlZ2lzdGVySW5zZXJ0aW9uVW4K IAogdm9pZCBQYWdlQ2xpZW50SW1wbDo6Y2xlYXJBbGxFZGl0Q29tbWFuZHMoKQogewotICAgIG5v dEltcGxlbWVudGVkKCk7CisgICAgW1ttX2NvbnRlbnRWaWV3IHVuZG9NYW5hZ2VyXSByZW1vdmVB bGxBY3Rpb25zV2l0aFRhcmdldDptX3VuZG9UYXJnZXQuZ2V0KCldOwogfQogCi1ib29sIFBhZ2VD bGllbnRJbXBsOjpjYW5VbmRvUmVkbyhXZWJQYWdlUHJveHk6OlVuZG9PclJlZG8pCitib29sIFBh Z2VDbGllbnRJbXBsOjpjYW5VbmRvUmVkbyhXZWJQYWdlUHJveHk6OlVuZG9PclJlZG8gdW5kb09y UmVkbykKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBmYWxzZTsKKyAgICBy ZXR1cm4gKHVuZG9PclJlZG8gPT0gV2ViUGFnZVByb3h5OjpVbmRvKSA/IFtbbV9jb250ZW50Vmll dyB1bmRvTWFuYWdlcl0gY2FuVW5kb10gOiBbW21fY29udGVudFZpZXcgdW5kb01hbmFnZXJdIGNh blJlZG9dOwogfQogCi12b2lkIFBhZ2VDbGllbnRJbXBsOjpleGVjdXRlVW5kb1JlZG8oV2ViUGFn ZVByb3h5OjpVbmRvT3JSZWRvKQordm9pZCBQYWdlQ2xpZW50SW1wbDo6ZXhlY3V0ZVVuZG9SZWRv KFdlYlBhZ2VQcm94eTo6VW5kb09yUmVkbyB1bmRvT3JSZWRvKQogewotICAgIG5vdEltcGxlbWVu dGVkKCk7CisgICAgcmV0dXJuICh1bmRvT3JSZWRvID09IFdlYlBhZ2VQcm94eTo6VW5kbykgPyBb W21fY29udGVudFZpZXcgdW5kb01hbmFnZXJdIHVuZG9dIDogW1ttX2NvbnRlbnRWaWV3IHVuZG9N YW5hZ2VyXSByZWRvXTsKIH0KIAogdm9pZCBQYWdlQ2xpZW50SW1wbDo6YWNjZXNzaWJpbGl0eVdl YlByb2Nlc3NUb2tlblJlY2VpdmVkKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgZGF0YSkK