134530 2014-07-01 17:24:56 -0700 [iOS][WK2] Fix a race between the short tap and long tap highlight 2014-07-01 17:49:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1019854 0 benjamin 2014-07-01 17:24:56 -0700 [iOS][WK2] Fix a race between the short tap and long tap highlight 1019857 1 234226 benjamin 2014-07-01 17:35:15 -0700 Created attachment 234226 Patch 1019858 2 234226 enrica 2014-07-01 17:38:25 -0700 Comment on attachment 234226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234226&action=review Looks reasonable, > Source/WebKit2/ChangeLog:23 > + Just invalidating the ID would create an other race: typo 'an other' 1019863 3 benjamin 2014-07-01 17:49:56 -0700 Committed r170684: <http://trac.webkit.org/changeset/170684> 234226 2014-07-01 17:35:15 -0700 2014-07-01 17:38:24 -0700 Patch bug-134530-20140701173440.patch text/plain 4071 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGQ0MTkxZWMwMjM4MWY0 Y2M2NzExNDJlZDE4YmZjZjk2M2Q2MGJhNS4uN2RiN2Q5ZTY3YjhiM2FjNmIzY2QzNjhiMGQwYWQ2 ZDlkNGYxNWM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDE0LTA3LTAxICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbaU9TXVtXSzJd IEZpeCBhIHJhY2UgYmV0d2VlbiB0aGUgc2hvcnQgdGFwIGFuZCBsb25nIHRhcCBoaWdobGlnaHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDUzMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHdh cyBhIHBvdGVudGlhbCByYWNlIG9mIGV2ZW50IHRoYXQgY2FuIHRoZW9yZXRpY2FsbHkgY2F1c2Ug V0tDb250ZW50Vmlld0ludGVyYWN0aW9uCisgICAgICAgIHRvIGNhbGwgW1dLQ29udGVudFZpZXcg X3Nob3dUYXBIaWdobGlnaHRdIGFmdGVyIGFsbCBpbnRlcmFjdGlvbnMgaGF2ZSBiZWVuIGNhbmNl bGxlZC4KKworICAgICAgICBUaGUgcmFjZSB3b3VsZCBiZSBsaWtlIHRoaXM6CisgICAgICAgIDEp IE9uIGEgc2hvcnQgdGFwLCBfc2luZ2xlVGFwUmVjb2duaXplZDogaXMgY2FsbGVkLCBhIHRhcCBo aWdobGlnaHQgSUQgaXMgZGVmaW5lZCBhbmQKKyAgICAgICAgICAgX3BvdGVudGlhbFRhcEluUHJv Z3Jlc3MgaXMgc2V0IHRvIFlFUy4KKyAgICAgICAgMikgRm9yIHNvbWUgcmVhc29uLCB0aGUgZ2Vz dHVyZSBpcyBjYW5jZWxsZWQuIFRoZSBtZXRob2QgX3NpbmdsZVRhcERpZFJlc2V0IGlzIGNhbGxl ZCwgCisgICAgICAgICAgIHNldHRpbmcgX3BvdGVudGlhbFRhcEluUHJvZ3Jlc3MgYnV0IGxlYXZp bmcgdGhlIHRhcCBoaWdobGlnaHQgSUQgYXMgdmFsaWQuCisgICAgICAgIDMpIFRoZSBVSVByb2Nl c3MgcmVjZWl2ZXMgdGhlIHRhcCBoaWdobGlnaHQgaW5mb3JtYXRpb24gZnJvbSB0aGUgV2ViUHJv Y2VzcywgX2RpZEdldFRhcEhpZ2hsaWdodEZvclJlcXVlc3Q6CisgICAgICAgICAgIGhhcyBhIHZh bGlkIElELCBfcG90ZW50aWFsVGFwSW5Qcm9ncmVzcyBpcyBmYWxzZSAtPiB0aGUgaGlnaGxpZ2h0 IGlzIHNob3duIHJpZ2h0IGF3YXkgYXMgaWYgYSBsb25nIHRhcAorICAgICAgICAgICB3YXMgaW4g cHJvZ3Jlc3MuCisKKyAgICAgICAgVGhlIG1pc3NpbmcgcGllY2UgdGhhdCBjYXVzZXMgdGhpcyBp cyBfc2luZ2xlVGFwRGlkUmVzZXQ6IG11c3QgYWxzbyBpbnZhbGlkYXRlIHRoZSB0YXAgaGlnaGxp Z2h0IElELiBUaGlzIGlzIGRvbmUKKyAgICAgICAgaW4gdGhlIG5ldyBzdGF0aWMgZnVuY3Rpb24g Y2FuY2VsUG90ZW50aWFsVGFwSWZOZWNlc3NhcnkoKS4KKworICAgICAgICBKdXN0IGludmFsaWRh dGluZyB0aGUgSUQgd291bGQgY3JlYXRlIGFuIG90aGVyIHJhY2U6CisgICAgICAgIDEpIFNob3J0 IHRhcCBnZXN0dXJlIHJlY29nbml6ZXIgc3RhcnRzLgorICAgICAgICAyKSBUaGUgbG9uZyBwcmVz cyByZWNvZ25pemVyIHN0YXJ0cyBiZWZvcmUgKDEpIGlzIGNvbW1pdGVkLgorICAgICAgICAzKSBU aGUgbG9uZyBwcmVzcyByZWNvZ25pemVycyBzZXRzIHVwIGl0cyBvd24gdGFwIGhpZ2hsaWdodCBJ RC4KKyAgICAgICAgNCkgVGhlIHNob3J0IHRhcCBnZXN0dXJlIHJlY29nbml6ZXIgcmVzZXRzLCBl cmFzaW5nIHRoZSB0YXAgaGlnaGxpZ2h0IElEIGRlZmluZWQgaW4gKDMpLgorCisgICAgICAgIFRv IGF2b2lkIHRoaXMsIHRoZSBsb25nIHByZXNzIGdlc3R1cmUgcmVjb2duaXplcnMgaW1tZWRpYXRl bHkgY2FuY2VscyBhbnkgcG90ZW50aWFsIHRhcCBpbiBwcm9ncmVzcy4KKyAgICAgICAgSWYgX3Np bmdsZVRhcERpZFJlc2V0OiBpcyBjYWxsZWQgYmVmb3JlICgzKSwgdGhpcyBkb2VzIG5vdGhpbmcu IElmIHRoZSByZXNldCBpcyBjYWxsZWQgYWZ0ZXIgKDMpLAorICAgICAgICBfc2luZ2xlVGFwRGlk UmVzZXQgZG9lcyBub3RoaW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2hpZ2hsaWdodExv bmdQcmVzc1JlY29nbml6ZWQ6XSk6CisgICAgICAgIChjYW5jZWxQb3RlbnRpYWxUYXBJZk5lY2Vz c2FyeSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3NpbmdsZVRhcERpZFJlc2V0Ol0pOgor CiAyMDE0LTA3LTAxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFtVSS1zaWRlIGNvbXBvc2l0aW5nXSBCYWQgc3Bpbm5lciBvbiBuZXdzLmdvb2dsZS5j b206IGFuaW1hdGlvbnMgbmVlZCB0byBiZSBvcmRlcmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGY1 YmQ5Yjc2MWZlOTU5N2JkY2YzZTliYzEwZDdlODE4N2UzNjVmYzcuLjQ2MzEwMzhkMDRkODE4NTc0 YjU0YjU1NjU4N2NmYjk0MDg3NDA2Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04NzMsNiArODcz LDcgQEAgc3RhdGljIGlubGluZSBib29sIGlzU2FtZVBhaXIoVUlHZXN0dXJlUmVjb2duaXplciAq YSwgVUlHZXN0dXJlUmVjb2duaXplciAqYiwgVUkKIAogICAgIHN3aXRjaCAoW2dlc3R1cmVSZWNv Z25pemVyIHN0YXRlXSkgewogICAgIGNhc2UgVUlHZXN0dXJlUmVjb2duaXplclN0YXRlQmVnYW46 CisgICAgICAgIGNhbmNlbFBvdGVudGlhbFRhcElmTmVjZXNzYXJ5KHNlbGYpOwogICAgICAgICBf cGFnZS0+dGFwSGlnaGxpZ2h0QXRQb3NpdGlvbihbZ2VzdHVyZVJlY29nbml6ZXIgc3RhcnRQb2lu dF0sICsrX2xhdGVzdFRhcEhpZ2hsaWdodElEKTsKICAgICAgICAgX2lzVGFwSGlnaGxpZ2h0SURW YWxpZCA9IFlFUzsKICAgICAgICAgYnJlYWs7CkBAIC05MTcsMTQgKzkxOCwyMCBAQCBzdGF0aWMg aW5saW5lIGJvb2wgaXNTYW1lUGFpcihVSUdlc3R1cmVSZWNvZ25pemVyICphLCBVSUdlc3R1cmVS ZWNvZ25pemVyICpiLCBVSQogICAgIF9pc1RhcEhpZ2hsaWdodElEVmFsaWQgPSBZRVM7CiB9CiAK K3N0YXRpYyB2b2lkIGNhbmNlbFBvdGVudGlhbFRhcElmTmVjZXNzYXJ5KFdLQ29udGVudFZpZXcq IGNvbnRlbnRWaWV3KQoreworICAgIGlmIChjb250ZW50Vmlldy0+X3BvdGVudGlhbFRhcEluUHJv Z3Jlc3MpIHsKKyAgICAgICAgY29udGVudFZpZXctPl9wb3RlbnRpYWxUYXBJblByb2dyZXNzID0g Tk87CisgICAgICAgIGNvbnRlbnRWaWV3LT5faXNUYXBIaWdobGlnaHRJRFZhbGlkID0gTk87Cisg ICAgICAgIFtjb250ZW50VmlldyBfY2FuY2VsSW50ZXJhY3Rpb25dOworICAgICAgICBjb250ZW50 Vmlldy0+X3BhZ2UtPmNhbmNlbFBvdGVudGlhbFRhcCgpOworICAgIH0KK30KKwogLSAodm9pZClf c2luZ2xlVGFwRGlkUmVzZXQ6KFVJVGFwR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2du aXplcgogewogICAgIEFTU0VSVChnZXN0dXJlUmVjb2duaXplciA9PSBfc2luZ2xlVGFwR2VzdHVy ZVJlY29nbml6ZXIpOwotICAgIGlmIChfcG90ZW50aWFsVGFwSW5Qcm9ncmVzcykgewotICAgICAg ICBfcG90ZW50aWFsVGFwSW5Qcm9ncmVzcyA9IE5POwotICAgICAgICBbc2VsZiBfY2FuY2VsSW50 ZXJhY3Rpb25dOwotICAgICAgICBfcGFnZS0+Y2FuY2VsUG90ZW50aWFsVGFwKCk7Ci0gICAgfQor ICAgIGNhbmNlbFBvdGVudGlhbFRhcElmTmVjZXNzYXJ5KHNlbGYpOwogfQogCiAtICh2b2lkKV9j b21taXRQb3RlbnRpYWxUYXBGYWlsZWQK