134528 2014-07-01 17:12:32 -0700 Improve handling of primary offscreen plugins 2014-07-02 21:35:04 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 roger_fong webkit-unassigned bunhere cdumez clopez commit-queue dino gyuyoung.kim jonlee roger_fong sergio thorton oldest_to_newest 1019847 0 roger_fong 2014-07-01 17:12:32 -0700 I noticed two issues with the handling of the primary off screen plugin case. The first is that the determination of whether or not the plugin started off screen was happening too late, not at the initialization of the plugin as it should have been. The second issue is that the plugin process type was being set to PluginProcessTypeSnapshot for these potential offscreen plugins. This caused them to be muted. The process type should instead be switched to PluginProcessTypeNormal. Note that setting the display state of the plugin to DisplaySnapshot also causes the plugin to be muted. Alternatively, in the case where we do want to display a snapshot I could also recreate and reinitialize the plugin and force the plugin process type to be PluginProcessTypeSnapshot. <rdar://problem/17471864> 1019851 1 234223 roger_fong 2014-07-01 17:16:47 -0700 Created attachment 234223 patch 1019916 2 roger_fong 2014-07-02 00:06:28 -0700 This is a followup to https://bugs.webkit.org/show_bug.cgi?id=133667 1020121 3 234223 dino 2014-07-02 17:45:18 -0700 Comment on attachment 234223 patch Can we test this? PS. GTK failed. Didn't look :) 1020160 4 roger_fong 2014-07-02 19:59:14 -0700 (In reply to comment #3) > (From update of attachment 234223 [details]) > Can we test this? Hmmm I suppose i can write a test which pulls in a fairly largely sized plugin from offscreen and have it play audio. So I'd need a regular layout test result and an audio result...do audio results even work these days? > > PS. GTK failed. Didn't look :) Meh, unrelated failures. 1020166 5 234223 commit-queue 2014-07-02 20:31:27 -0700 Comment on attachment 234223 patch Clearing flags on attachment: 234223 Committed r170743: <http://trac.webkit.org/changeset/170743> 1020167 6 commit-queue 2014-07-02 20:31:31 -0700 All reviewed patches have been landed. Closing bug. 1020169 7 clopez 2014-07-02 20:41:43 -0700 (In reply to comment #4) > > PS. GTK failed. Didn't look :) > Meh, unrelated failures. unrelated failures??? This just broke the GTK build: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/48974/steps/compile-webkit/logs/stdio 1020177 8 clopez 2014-07-02 21:11:05 -0700 (In reply to comment #7) > (In reply to comment #4) > > > PS. GTK failed. Didn't look :) > > Meh, unrelated failures. > > unrelated failures??? This just broke the GTK build: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/48974/steps/compile-webkit/logs/stdio It also broke the EFL build. Reported here: https://bugs.webkit.org/show_bug.cgi?id=134585 1020181 9 roger_fong 2014-07-02 21:35:04 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #4) > > > > PS. GTK failed. Didn't look :) > > > Meh, unrelated failures. > > > > unrelated failures??? This just broke the GTK build: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/48974/steps/compile-webkit/logs/stdio > > It also broke the EFL build. > > Reported here: https://bugs.webkit.org/show_bug.cgi?id=134585 Sorry bout that, I was looking at what I thought was GTK test results which would've implied GTK built successfully. 234223 2014-07-01 17:16:47 -0700 2014-07-02 20:31:27 -0700 patch patch.patch text/plain 3578 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDY1OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA3LTAxICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSW1wcm92ZSBoYW5kbGluZyBv ZiBwcmltYXJ5IG9mZnNjcmVlbiBwbHVnaW5zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NTI4LgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc0 NzE4NjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6IAorICAgICAgICBEZXRlcm1pbmUg d2hldGhlciBvciBub3QgdGhlIHBsdWdpbiBzdGFydHMgb2Zmc2NyZWVuIHdoZW4gdGhlIHBsdWdp biBpcyBpbml0aWFsaXplZC4KKyAgICAgICAgKFdlYktpdDo6UGx1Z2luVmlldzo6aW5pdGlhbGl6 ZVBsdWdpbik6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OnBsdWdpblNuYXBzaG90VGlt ZXJGaXJlZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpjcmVhdGVQbHVnaW4pOgorICAgICAgICBVc2UgdGhlIFBs dWdpblByb2Nlc3NUeXBlTm9ybWFsIGZvciBvZmZzY3JlZW4gcGx1Z2lucyB0aGF0IGFyZSBwb3Rl bnRpYWxseSBwcmltYXJ5IHBsdWdpbnMuCisKIDIwMTQtMDctMDEgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYnVpbGQuCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCShyZXZpc2lv biAxNzA1OTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmll dy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5MSw2ICs1OTEsOCBAQCB2b2lkIFBsdWdpblZpZXc6 OmluaXRpYWxpemVQbHVnaW4oKQogICAgICAgICB9CiAgICAgfQogCisgICAgSFRNTFBsdWdJbklt YWdlRWxlbWVudCogcGx1Z0luSW1hZ2VFbGVtZW50ID0gdG9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50 KG1fcGx1Z2luRWxlbWVudC5nZXQoKSk7CisgICAgbV9kaWRQbHVnSW5TdGFydE9mZlNjcmVlbiA9 ICFtX3dlYlBhZ2UtPnBsdWdJbkludGVyc2VjdHNTZWFyY2hSZWN0KCpwbHVnSW5JbWFnZUVsZW1l bnQpOwogICAgIG1fcGx1Z2luLT5pbml0aWFsaXplKHRoaXMsIG1fcGFyYW1ldGVycyk7CiAgICAg CiAgICAgLy8gUGx1Zy1pbiBpbml0aWFsaXphdGlvbiBjb250aW51ZWQgaW4gZGlkRmFpbFRvSW5p dGlhbGl6ZVBsdWdpbigpIG9yIGRpZEluaXRpYWxpemVQbHVnaW4oKS4KQEAgLTE3MTIsOSArMTcx NCw2IEBAIHZvaWQgUGx1Z2luVmlldzo6cGx1Z2luU25hcHNob3RUaW1lckZpcmUKICNpZiBFTkFC TEUoUFJJTUFSWV9TTkFQU0hPVFRFRF9QTFVHSU5fSEVVUklTVElDKQogICAgIEhUTUxQbHVnSW5J bWFnZUVsZW1lbnQqIHBsdWdJbkltYWdlRWxlbWVudCA9IHRvSFRNTFBsdWdJbkltYWdlRWxlbWVu dChtX3BsdWdpbkVsZW1lbnQuZ2V0KCkpOwogICAgIGJvb2wgaXNQbHVnSW5PblNjcmVlbiA9IG1f d2ViUGFnZS0+cGx1Z0luSW50ZXJzZWN0c1NlYXJjaFJlY3QoKnBsdWdJbkltYWdlRWxlbWVudCk7 Ci0gICAgaWYgKCFtX2NvdW50U25hcHNob3RSZXRyaWVzKQotICAgICAgICBtX2RpZFBsdWdJblN0 YXJ0T2ZmU2NyZWVuID0gIWlzUGx1Z0luT25TY3JlZW47Ci0KICAgICBib29sIHBsdWdJbkNhbWVP blNjcmVlbiA9IGlzUGx1Z0luT25TY3JlZW4gJiYgbV9kaWRQbHVnSW5TdGFydE9mZlNjcmVlbjsK ICAgICBib29sIHNuYXBzaG90Rm91bmQgPSBmYWxzZTsKICNlbmRpZgpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTcwNTk1 KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MTYsMTAgKzYxNiwxMSBAQCB2b2lkIFdlYlBhZ2U6OmluaXRpYWxpemVJ bmplY3RlZEJ1bmRsZURpCiAjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiBQYXNzUmVm UHRyPFBsdWdpbj4gV2ViUGFnZTo6Y3JlYXRlUGx1Z2luKFdlYkZyYW1lKiBmcmFtZSwgSFRNTFBs dWdJbkVsZW1lbnQqIHBsdWdpbkVsZW1lbnQsIGNvbnN0IFBsdWdpbjo6UGFyYW1ldGVycyYgcGFy YW1ldGVycywgU3RyaW5nJiBuZXdNSU1FVHlwZSkKIHsKKyAgICBIVE1MUGx1Z0luSW1hZ2VFbGVt ZW50JiBwbHVnaW5JbWFnZUVsZW1lbnQgPSB0b0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQoKnBsdWdp bkVsZW1lbnQpOwogICAgIFN0cmluZyBmcmFtZVVSTFN0cmluZyA9IGZyYW1lLT5jb3JlRnJhbWUo KS0+bG9hZGVyKCkuZG9jdW1lbnRMb2FkZXIoKS0+cmVzcG9uc2VVUkwoKS5zdHJpbmcoKTsKICAg ICBTdHJpbmcgcGFnZVVSTFN0cmluZyA9IG1fcGFnZS0+bWFpbkZyYW1lKCkubG9hZGVyKCkuZG9j dW1lbnRMb2FkZXIoKS0+cmVzcG9uc2VVUkwoKS5zdHJpbmcoKTsKLSAgICBQbHVnaW5Qcm9jZXNz VHlwZSBwcm9jZXNzVHlwZSA9IHBsdWdpbkVsZW1lbnQtPmRpc3BsYXlTdGF0ZSgpID09IEhUTUxQ bHVnSW5FbGVtZW50OjpXYWl0aW5nRm9yU25hcHNob3QgPyBQbHVnaW5Qcm9jZXNzVHlwZVNuYXBz aG90IDogUGx1Z2luUHJvY2Vzc1R5cGVOb3JtYWw7Ci0KKyAgICB1bnNpZ25lZCBwbHVnaW5BcmVh ID0gMDsKKyAgICBQbHVnaW5Qcm9jZXNzVHlwZSBwcm9jZXNzVHlwZSA9IHBsdWdpbkVsZW1lbnQt PmRpc3BsYXlTdGF0ZSgpID09IEhUTUxQbHVnSW5FbGVtZW50OjpXYWl0aW5nRm9yU25hcHNob3Qg JiYgIShwbHVnSW5Jc1ByaW1hcnlTaXplKHBsdWdpbkltYWdlRWxlbWVudCwgcGx1Z2luQXJlYSkg JiYgIXBsdWdJbkludGVyc2VjdHNTZWFyY2hSZWN0KHBsdWdpbkltYWdlRWxlbWVudCkpPyBQbHVn aW5Qcm9jZXNzVHlwZVNuYXBzaG90IDogUGx1Z2luUHJvY2Vzc1R5cGVOb3JtYWw7CiAgICAgYm9v bCBhbGxvd09ubHlBcHBsaWNhdGlvblBsdWdpbnMgPSAhZnJhbWUtPmNvcmVGcmFtZSgpLT5sb2Fk ZXIoKS5zdWJmcmFtZUxvYWRlcigpLmFsbG93UGx1Z2lucyhOb3RBYm91dFRvSW5zdGFudGlhdGVQ bHVnaW4pOwogCiAgICAgdWludDY0X3QgcGx1Z2luUHJvY2Vzc1Rva2VuOwo=