134485 2014-06-30 21:37:40 -0700 [EFL][WK2] Minibrowser: On opening search bar, show the selected/highlighted text in search bar, if any. 2014-07-04 21:28:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1019557 0 shiva.jm 2014-06-30 21:37:40 -0700 In modern browsers, if user selects/highlights text, On opening search bar, show the selected/highlighted text in search bar field, Implement these functionality in EFL Minibrowser. 1020474 1 234399 shiva.jm 2014-07-04 04:12:04 -0700 Created attachment 234399 Patch Enhance the Minibrowser to show selected/highlighted text in search bar, if any. 1020562 2 234399 gyuyoung.kim 2014-07-04 20:56:40 -0700 Comment on attachment 234399 Patch LGTM 1020566 3 234399 commit-queue 2014-07-04 21:28:24 -0700 Comment on attachment 234399 Patch Clearing flags on attachment: 234399 Committed r170820: <http://trac.webkit.org/changeset/170820> 1020567 4 commit-queue 2014-07-04 21:28:28 -0700 All reviewed patches have been landed. Closing bug. 234399 2014-07-04 04:12:04 -0700 2014-07-04 21:28:24 -0700 Patch bug-134485.patch text/plain 2306 shiva.jm SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MDgwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTA3LTA0ICBTaGl2YWt1bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgW0VGTF1bV0syXSBFbmhhbmNlIHRoZSBNaW5pYnJvd3NlciB0byBzaG93 IHNlbGVjdGVkL2hpZ2hsaWdodGVkIHRleHQgaW4gc2VhcmNoIGJhciwgaWYgYW55LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NDg1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHNjcmlwdF9leGVj dXRlX2NhbGxiYWNrIHRvIGdldCBzZWxlY3RlZC9oaWdobGlnaHRlZCB0ZXh0IGFuZCBzaG93IGlu IHNlYXJjaCBiYXIuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAg ICAoc2NyaXB0X2V4ZWN1dGVfY2FsbGJhY2spOgorICAgICAgICAob25fa2V5X2Rvd24pOgorCiAy MDE0LTA3LTA0ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBUeXBvIGluIHdhdGNobGlzdCBjb25maWcgbWVhbnMgZm91ciBzcGVjaWZpYyBwZW9w bGUgZ2V0IENjJ2Qgb24gZXZlcnl0aGluZwpJbmRleDogVG9vbHMvTWluaUJyb3dzZXIvZWZsL21h aW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCShyZXZpc2lv biAxNzA4MDMpCisrKyBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCSh3b3JraW5nIGNvcHkp CkBAIC00MjYsNiArNDI2LDIyIEBAIHN0YXRpYyB2b2lkIHNhdmVfcGFnZV9jb250ZW50c19jYWxs YmFjaygKICAgICBlaW5hX3N0cmluZ3NoYXJlX2RlbChmaWxlTmFtZSk7CiB9CiAKK3N0YXRpYyB2 b2lkIAorc2NyaXB0X2V4ZWN1dGVfY2FsbGJhY2soRXZhc19PYmplY3QgKmV3a192aWV3LCBjb25z dCBjaGFyICpyZXR1cm5fdmFsdWUsIHZvaWQgKnVzZXJfZGF0YSkKK3sKKyAgICBCcm93c2VyX1dp bmRvdyAqd2luZG93ID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9kYXRhOworCisgICAgRWluYV9T dHJidWYgKnRleHRfYnVmZmVyID0gZWluYV9zdHJidWZfbmV3KCk7CisKKyAgICBpZiAocmV0dXJu X3ZhbHVlKSB7CisgICAgICAgIGVpbmFfc3RyYnVmX2FwcGVuZCh0ZXh0X2J1ZmZlciwgcmV0dXJu X3ZhbHVlKTsKKyAgICAgICAgaW5mbygic2VsZWN0ZWQgdGV4dCBpczogJXMiLCBlaW5hX3N0cmJ1 Zl9zdHJpbmdfZ2V0KHRleHRfYnVmZmVyKSk7CisgICAgICAgIGVsbV9lbnRyeV9lbnRyeV9zZXQo d2luZG93LT5zZWFyY2guc2VhcmNoX2ZpZWxkLCBlaW5hX3N0cmJ1Zl9zdHJpbmdfZ2V0KHRleHRf YnVmZmVyKSk7ICAgCisgICAgfQorICAgIGVpbmFfc3RyYnVmX2ZyZWUodGV4dF9idWZmZXIpOwor ICAgIHNlYXJjaF9ib3hfc2hvdyh3aW5kb3cpOworfQorCiBzdGF0aWMgdm9pZAogb25fa2V5X2Rv d24odm9pZCAqdXNlcl9kYXRhLCBFdmFzICplLCBFdmFzX09iamVjdCAqZXdrX3ZpZXcsIHZvaWQg KmV2ZW50X2luZm8pCiB7CkBAIC00ODQsNyArNTAwLDggQEAgb25fa2V5X2Rvd24odm9pZCAqdXNl cl9kYXRhLCBFdmFzICplLCBFdgogICAgICAgICBld2tfdmlld19pbnNwZWN0b3Jfc2hvdyhld2tf dmlldyk7CiAgICAgfSBlbHNlIGlmICghc3RyY21wKGV2LT5rZXksICJmIikgJiYgY3RybFByZXNz ZWQpIHsKICAgICAgICAgaW5mbygiU2hvdyBTZWFyY2ggQm94IChDdHJsK2YpIHdhcyBwcmVzc2Vk LiIpOwotICAgICAgICBzZWFyY2hfYm94X3Nob3cod2luZG93KTsKKyAgICAgICAgY29uc3QgY2hh ciBnZXRfZGF0YV9zY3JpcHRbXSA9ICJ3aW5kb3cuZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKTsi OworICAgICAgICBld2tfdmlld19zY3JpcHRfZXhlY3V0ZShld2tfdmlldywgZ2V0X2RhdGFfc2Ny aXB0LCBzY3JpcHRfZXhlY3V0ZV9jYWxsYmFjaywgKHZvaWQqKSh3aW5kb3cpKTsKICAgICB9IGVs c2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIkVzY2FwZSIpKSB7CiAgICAgICAgIGlmIChldmFzX29i amVjdF92aXNpYmxlX2dldCh3aW5kb3ctPnNlYXJjaC5zZWFyY2hfYmFyKSkKICAgICAgICAgICAg IHNlYXJjaF9ib3hfaGlkZSh3aW5kb3cpOwo=