13448 2007-04-22 10:30:38 -0700 REGRESSION: setting an input element's value to JavaScript null gives "null" 2007-04-24 09:32:17 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar P1 Normal --- 1 darin sam adele ap sam oldest_to_newest 13279 0 darin 2007-04-22 10:30:38 -0700 While working on another bug, I noticed this regression. Setting an input element's value to JavaScript null now gives us "null" instead of "". I tested Gecko and it works like the old version of Safari -- gives "". 13273 1 14137 darin 2007-04-22 10:31:05 -0700 Created attachment 14137 test case (ready for layout tests directory) 13268 2 darin 2007-04-22 10:31:59 -0700 <rdar://problem/5152055> 13257 3 darin 2007-04-22 12:19:52 -0700 This is actually a bug in the HTML DOM bindings. We have keywords that translate null values into strings with various rules, but I couldn't immediately find the appropriate one to use in HTMLInputElement.idl to fix this. The ones for properties seem to focus on the getter side rather than the setter side. Somehow we overlooked this when converting HTMLInputElement to auto-generated DOM. The old hand-written DOM binding must have handled this. 13186 4 sam 2007-04-23 08:57:12 -0700 The property keyword that is appropriate here is [ConvertNullToNullString]. It seems that the "name" attribute suffers from the same issue. I am going to investigate what other attributes might also be affected. 13007 5 sam 2007-04-24 08:02:58 -0700 It seems that all of the attribute that set/get DOMStrings for HTMLInputElement suffer from the same issue except 'type' which treats any unknown value the same as the empty string so the value 'null' is just ignored. I have a patch which fixes these issues but we should file a followup patch to look into what other elements might also have this issue. We should also consider, if it makes sense, making conversion from js null to the empty string the default. 13006 6 14158 sam 2007-04-24 08:07:34 -0700 Created attachment 14158 patch 13003 7 14158 mitz 2007-04-24 08:15:03 -0700 Comment on attachment 14158 patch r=me 13004 8 sam 2007-04-24 08:26:39 -0700 Landed in r21070. 12991 9 darin 2007-04-24 09:32:17 -0700 I understand that this is right for the setter side. But is it right for the getter side too? 14137 2007-04-22 10:31:05 -0700 2007-04-22 10:31:05 -0700 test case (ready for layout tests directory) input-null.html text/html 740 darin PHNjcmlwdD4KZnVuY3Rpb24gdGVzdCgpIHsKICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCiAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgdmFy IGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lucHV0Jyk7CiAgICBpbnB1dC52YWx1 ZSA9ICJiZWZvcmUiOwogICAgaW5wdXQudmFsdWUgPSBudWxsOwogICAgaWYgKGlucHV0LnZhbHVl ID09ICIiKQogICAgICAgIHJlc3VsdCA9ICJURVNUIFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0 aGUgZW1wdHkgc3RyaW5nLiI7CiAgICBlbHNlCiAgICAgICAgcmVzdWx0ID0gIlRFU1QgRkFJTEVE OiBUaGUgdmFsdWUgc2hvdWxkIGhhdmUgYmVlbiB0aGUgZW1wdHkgc3RyaW5nIGJ1dCB3YXMgJyIg KyBpbnB1dC52YWx1ZSArICInIjsKICAgIHZhciByZXN1bHRFbGVtZW50ID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInJlc3VsdCIpOwogICAgcmVzdWx0RWxlbWVudC5yZXBsYWNlQ2hpbGQoZG9j dW1lbnQuY3JlYXRlVGV4dE5vZGUocmVzdWx0KSwgcmVzdWx0RWxlbWVudC5maXJzdENoaWxkKTsK fQo8L3NjcmlwdD4KPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgo8cD5UaGlzIHRlc3Qgc2V0cyB0aGUg dmFsdWUgb2YgYW4gaW5wdXQgZWxlbWVudCB0byBKYXZhU2NyaXB0IG51bGwuPC9wPgo8cCBpZD0i cmVzdWx0Ij5URVNUIERJRCBOT1QgUlVOPC9wPgo8aW5wdXQgaWQ9ImlucHV0Ij4KPC9ib2R5Pgo= 14158 2007-04-24 08:07:34 -0700 2007-04-24 08:15:03 -0700 patch 13448_r1.diff text/plain 6513 sam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxMDY5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDQtMjQgIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAtIHRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NDQ4CisgICAgICAgICAgUkVHUkVTU0lPTjogc2V0dGluZyBhbiBpbnB1dCBlbGVtZW50J3MgdmFs dWUgdG8gSmF2YVNjcmlwdCBudWxsIGdpdmVzICJudWxsIgorCisgICAgICAgICogZmFzdC9mb3Jt cy9pbnB1dC1udWxsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9p bnB1dC1udWxsLmh0bWw6IEFkZGVkLgorCiAyMDA3LTA0LTI0ICBNaXR6IFBldHRlbCAgPG1pdHpA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1udWxsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LW51bGwtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1udWxsLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBAQAorVGhpcyB0ZXN0IHNldHRpbmcgdmFyaW91cyBh dHRyaWJ1dGVzIG9mIGFuIGlucHV0IGVsZW1lbnQgdG8gSmF2YVNjcmlwdCBudWxsLgorCitURVNU IFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0aGUgZW1wdHkgc3RyaW5nLiBbdGVzdGVkIGlucHV0 LmRlZmF1bHRWYWx1ZV0KK1RFU1QgU1VDQ0VFREVEOiBUaGUgdmFsdWUgd2FzIHRoZSBlbXB0eSBz dHJpbmcuIFt0ZXN0ZWQgaW5wdXQuYWNjZXB0XQorVEVTVCBTVUNDRUVERUQ6IFRoZSB2YWx1ZSB3 YXMgdGhlIGVtcHR5IHN0cmluZy4gW3Rlc3RlZCBpbnB1dC5hY2Nlc3NLZXldCitURVNUIFNVQ0NF RURFRDogVGhlIHZhbHVlIHdhcyB0aGUgZW1wdHkgc3RyaW5nLiBbdGVzdGVkIGlucHV0LmFsaWdu XQorVEVTVCBTVUNDRUVERUQ6IFRoZSB2YWx1ZSB3YXMgdGhlIGVtcHR5IHN0cmluZy4gW3Rlc3Rl ZCBpbnB1dC5hbHRdCitURVNUIFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0aGUgZW1wdHkgc3Ry aW5nLiBbdGVzdGVkIGlucHV0Lm5hbWVdCitURVNUIFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0 aGUgZW1wdHkgc3RyaW5nLiBbdGVzdGVkIGlucHV0LnVzZU1hcF0KK1RFU1QgU1VDQ0VFREVEOiBU aGUgdmFsdWUgd2FzIHRoZSBlbXB0eSBzdHJpbmcuIFt0ZXN0ZWQgaW5wdXQudmFsdWVdCitURVNU IFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0aGUgZW1wdHkgc3RyaW5nLiBbdGVzdGVkIGlucHV0 LnNyY10KKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1udWxsLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1udWxsLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LW51bGwuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw1NSBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGUgdHlwZT0i dGV4dC9jc3MiPgorICAgICAgICAucGFzcyB7IGNvbG9yOiBncmVlbjsgfQorICAgICAgICAuZmFp bCB7IGNvbG9yOiByZWQ7IH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGZ1 bmN0aW9uIHByaW50T3V0KG1zZykgeworICAgICAgICAgICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpOworICAgICAgICAgICAgdmFyIHNwYW4gPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7CisgICAgICAgICAgICBzcGFuLmlubmVySFRNTCA9 IG1zZyArICc8YnI+JzsKKyAgICAgICAgICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQoc3Bhbik7Cisg ICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBudWxsVGVzdChhdHRyKQorICAgICAgICB7Cisg ICAgICAgICAgICB2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaW5wdXQnKTsK KworICAgICAgICAgICAgdmFyIGV4cHIgPSAnaW5wdXQuJyArIGF0dHI7CisKKyAgICAgICAgICAg IGV2YWwoZXhwciArICc9ICJiZWZvcmUiJyk7CisgICAgICAgICAgICBldmFsKGV4cHIgKyAnPSBu dWxsJyk7CisKKyAgICAgICAgICAgIHZhciByZXN1bHQ7CisgICAgICAgICAgICBpZiAoZXZhbChl eHByKSAgPT0gIiIpCisgICAgICAgICAgICAgICAgcmVzdWx0ID0gIjxzcGFuIGNsYXNzPSdwYXNz Jz5URVNUIFNVQ0NFRURFRDo8L3NwYW4+IFRoZSB2YWx1ZSB3YXMgdGhlIGVtcHR5IHN0cmluZy4g W3Rlc3RlZCAiICsgZXhwciArICJdIjsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAg ICByZXN1bHQgPSAiPHNwYW4gY2xhc3M9J2ZhaWwnPlRFU1QgRkFJTEVEOjwvc3Bhbj4gVGhlIHZh bHVlIHNob3VsZCBoYXZlIGJlZW4gdGhlIGVtcHR5IHN0cmluZyBidXQgd2FzICciICsgZXZhbChl eHByKSArICInLiBbdGVzdGVkICIgKyBleHByICsgIl0iOworCisgICAgICAgICAgICBwcmludE91 dChyZXN1bHQpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gcnVuVGVzdHMoKSB7Cisg ICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgICAgICAgICAgbnVs bFRlc3QoJ2RlZmF1bHRWYWx1ZScpOworICAgICAgICAgICAgbnVsbFRlc3QoJ2FjY2VwdCcpOwor ICAgICAgICAgICAgbnVsbFRlc3QoJ2FjY2Vzc0tleScpOworICAgICAgICAgICAgbnVsbFRlc3Qo J2FsaWduJyk7CisgICAgICAgICAgICBudWxsVGVzdCgnYWx0Jyk7CisgICAgICAgICAgICBudWxs VGVzdCgnbmFtZScpOworICAgICAgICAgICAgbnVsbFRlc3QoJ3VzZU1hcCcpOworICAgICAgICAg ICAgbnVsbFRlc3QoJ3ZhbHVlJyk7CisgICAgICAgICAgICBudWxsVGVzdCgnc3JjJyk7CisgICAg ICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdHMoKSI+ CisgICAgPHA+VGhpcyB0ZXN0IHNldHRpbmcgdmFyaW91cyBhdHRyaWJ1dGVzIG9mIGFuIGlucHV0 IGVsZW1lbnQgdG8gSmF2YVNjcmlwdCBudWxsLjwvcD4KKyAgICA8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKyAgICA8aHI+CisgICAgPGlucHV0IGlkPSJpbnB1dCI+Cis8L2JvZHk+Cis8L2h0bWw+ CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gMjEwNjkpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDA3LTA0LTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBmaXgg Zm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQ4CisgICAgICAg ICAgUkVHUkVTU0lPTjogc2V0dGluZyBhbiBpbnB1dCBlbGVtZW50J3MgdmFsdWUgdG8gSmF2YVNj cmlwdCBudWxsIGdpdmVzICJudWxsIgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW5wdXQt bnVsbC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsOiBDb252ZXJ0 IEpTIG51bGwgdG8gdGhlIGVtcHR5IHN0cmluZyBvbiBzZXR0aW5nCisgICAgICAgIERPTVN0cmlu ZyBhdHRyaWJ1dGVzLgorCiAyMDA3LTA0LTI0ICBNaXR6IFBldHRlbCAgPG1pdHpAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpJbmRleDogV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MSW5w dXRFbGVtZW50LmlkbAkocmV2aXNpb24gMjEwNjkpCisrKyBXZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTIxLDI4ICsyMSwyOCBAQAogbW9kdWxlIGh0 bWwgewogCiAgICAgaW50ZXJmYWNlIFtMZWdhY3lQYXJlbnQ9SlNIVE1MSW5wdXRFbGVtZW50QmFz ZSwgR2VuZXJhdGVDb25zdHJ1Y3Rvcl0gSFRNTElucHV0RWxlbWVudCA6IEhUTUxFbGVtZW50IHsK LSAgICAgICAgICAgICAgICAgYXR0cmlidXRlIERPTVN0cmluZyAgICAgICBkZWZhdWx0VmFsdWU7 CisgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERP TVN0cmluZyBkZWZhdWx0VmFsdWU7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBib29sZWFu ICAgICAgICAgZGVmYXVsdENoZWNrZWQ7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1M Rm9ybUVsZW1lbnQgZm9ybTsKLSAgICAgICAgICAgICAgICAgYXR0cmlidXRlIERPTVN0cmluZyAg ICAgICBhY2NlcHQ7Ci0gICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgICAgICAg YWNjZXNzS2V5OwotICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nICAgICAgIGFs aWduOwotICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nICAgICAgIGFsdDsKKyAg ICAgICAgICAgICAgICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3Ry aW5nIGFjY2VwdDsKKyAgICAgICAgICAgICAgICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVs bFN0cmluZ10gRE9NU3RyaW5nIGFjY2Vzc0tleTsKKyAgICAgICAgICAgICAgICAgYXR0cmlidXRl IFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIGFsaWduOworICAgICAgICAgICAg ICAgICBhdHRyaWJ1dGUgW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgYWx0Owog ICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAgICAgIGNoZWNrZWQ7CiAgICAg ICAgICAgICAgICAgIGF0dHJpYnV0ZSBib29sZWFuICAgICAgICAgZGlzYWJsZWQ7CiAgICAgICAg ICAgICAgICAgIGF0dHJpYnV0ZSBsb25nICAgICAgICAgICAgbWF4TGVuZ3RoOwotICAgICAgICAg ICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nICAgICAgIG5hbWU7CisgICAgICAgICAgICAgICAg IGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBuYW1lOwogICAg ICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAgICAgIHJlYWRPbmx5OwogI2lmIGRl ZmluZWQoTEFOR1VBR0VfT0JKRUNUSVZFX0MpCiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBb Q29udmVydFRvU3RyaW5nXSBET01TdHJpbmcgc2l6ZTsgLy8gRE9NIGxldmVsIDIgY2hhbmdlZCB0 aGlzIHRvIGEgbG9uZywgYnV0IG91ciBleGlzdGluZyBBUEkgaXMgYSBzdHJpbmcKICNlbHNlCiAg ICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nICAgc2l6ZTsgLy8gQ2hhbmdl ZCBzdHJpbmcgLT4gbG9uZyBhcyBwYXJ0IG9mIERPTSBsZXZlbCAyCiAjZW5kaWYKLSAgICAgICAg ICAgICAgICAgYXR0cmlidXRlIERPTVN0cmluZyAgICAgICBzcmM7CisgICAgICAgICAgICAgICAg IGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBzcmM7CiAgICAg ICAgICAgICAgICAgIGF0dHJpYnV0ZSBsb25nICAgICAgICAgICAgdGFiSW5kZXg7CiAgICAgICAg ICAgICAgICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgICAgICAgdHlwZTsgLy8gcmVhZG9ubHkgZHJv cHBlZCBhcyBwYXJ0IG9mIERPTSBsZXZlbCAyCi0gICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBE T01TdHJpbmcgICAgICAgdXNlTWFwOwotICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgRE9NU3Ry aW5nICAgICAgIHZhbHVlOworICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgW0NvbnZlcnROdWxs VG9OdWxsU3RyaW5nXSBET01TdHJpbmcgdXNlTWFwOworICAgICAgICAgICAgICAgICBhdHRyaWJ1 dGUgW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgdmFsdWU7CiAgICAgICAgIAog ICAgICAgICB2b2lkICAgICAgICAgICAgICAgYmx1cigpOwogICAgICAgICB2b2lkICAgICAgICAg ICAgICAgZm9jdXMoKTsK