134476 2014-06-30 17:51:16 -0700 [GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding 2014-07-01 02:11:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nilclass webkit-unassigned berto bunhere cdumez cgarcia commit-queue gustavo gyuyoung.kim mrobinson sergio oldest_to_newest 1019515 0 nilclass 2014-06-30 17:51:16 -0700 The get_data method of WebKit.WebResource is currently unusable from Vala code, because the method signature in the .vapi file is incorrect. Currently the generated Vala signature is: public async uint8 get_data (GLib.Cancellable? cancellable, out size_t length) throws GLib.Error; the expected signature is: [CCode (array_length_type = "size_t")] public async uint8[] get_data (GLib.Cancellable? cancellable) throws GLib.Error; I have checked that applying this change to the webkit2gtk-3.0.vapi file manually & linking against webkit2gtk version 2.4.2 works, but I don't have the capacity right now to compile webkit to find out what changes to the annotations are required to reach this result. If someone could point me to the right documentation, I'd be willing to submit a patch. 1019520 1 234132 evan 2014-06-30 18:06:00 -0700 Created attachment 234132 [GTK] fix WebKit.WebResource.get_data_finish return value annotations 1019556 2 commit-queue 2014-06-30 21:21:32 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1019572 3 234132 cgarcia 2014-07-01 00:14:02 -0700 Comment on attachment 234132 [GTK] fix WebKit.WebResource.get_data_finish return value annotations Thanks for the patch. It looks good to me, but you need to fill a changelog entry, see http://www.webkit.org/coding/contributing.html 1019587 4 234151 cgarcia 2014-07-01 01:32:15 -0700 Created attachment 234151 Patch for landing Added changelog entry 1019588 5 234151 commit-queue 2014-07-01 02:11:19 -0700 Comment on attachment 234151 Patch for landing Clearing flags on attachment: 234151 Committed r170633: <http://trac.webkit.org/changeset/170633> 1019589 6 commit-queue 2014-07-01 02:11:24 -0700 All reviewed patches have been landed. Closing bug. 234132 2014-06-30 18:06:00 -0700 2014-07-01 01:32:15 -0700 [GTK] fix WebKit.WebResource.get_data_finish return value annotations 0001-GTK-fix-WebKit.WebResource.get_data_finish-return-va.patch text/plain 1689 evan RnJvbSA2NGYwNmJkY2VjM2Y0YzdkMmY1ZGE5YzUyODYxZjJmYmI0NWRlYTBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFdmFuIE5lbWVyc29uIDxldmFuQG5lbWVyc29uLmNvbT4KRGF0 ZTogTW9uLCAzMCBKdW4gMjAxNCAxODowMjoyOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtHVEtd IGZpeCBXZWJLaXQuV2ViUmVzb3VyY2UuZ2V0X2RhdGFfZmluaXNoIHJldHVybiB2YWx1ZQogYW5u b3RhdGlvbnMKCi0tLQogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi UmVzb3VyY2UuY3BwIHwgNyArKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlJlc291cmNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlJlc291cmNlLmNwcAppbmRleCBiMWRjMjYwLi5mMGNmZmFiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJSZXNvdXJj ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViUmVz b3VyY2UuY3BwCkBAIC0zNTUsMTMgKzM1NSwxNCBAQCB2b2lkIHdlYmtpdF93ZWJfcmVzb3VyY2Vf Z2V0X2RhdGEoV2ViS2l0V2ViUmVzb3VyY2UqIHJlc291cmNlLCBHQ2FuY2VsbGFibGUqIGNhbgog ICogd2Via2l0X3dlYl9yZXNvdXJjZV9nZXRfZGF0YV9maW5pc2g6CiAgKiBAcmVzb3VyY2U6IGEg I1dlYktpdFdlYlJlc291cmNlCiAgKiBAcmVzdWx0OiBhICNHQXN5bmNSZXN1bHQKLSAqIEBsZW5n dGg6IChvdXQpOiByZXR1cm4gbG9jYXRpb24gZm9yIHRoZSBsZW5ndGggb2YgdGhlIHJlc291cmNl IGRhdGEKKyAqIEBsZW5ndGg6IChvdXQpIChhbGxvdy1ub25lKTogcmV0dXJuIGxvY2F0aW9uIGZv ciB0aGUgbGVuZ3RoIG9mIHRoZSByZXNvdXJjZSBkYXRhCiAgKiBAZXJyb3I6IHJldHVybiBsb2Nh dGlvbiBmb3IgZXJyb3Igb3IgJU5VTEwgdG8gaWdub3JlCiAgKgogICogRmluaXNoIGFuIGFzeW5j aHJvbm91cyBvcGVyYXRpb24gc3RhcnRlZCB3aXRoIHdlYmtpdF93ZWJfcmVzb3VyY2VfZ2V0X2Rh dGEoKS4KICAqCi0gKiBSZXR1cm5zOiAodHJhbnNmZXIgZnVsbCk6IGEgc3RyaW5nIHdpdGggdGhl IGRhdGEgb2YgQHJlc291cmNlLCBvciAlTlVMTCBpbiBjYXNlCi0gKiAgICBvZiBlcnJvci4gaWYg QGxlbmd0aCBpcyBub3QgJU5VTEwsIHRoZSBzaXplIG9mIHRoZSBkYXRhIHdpbGwgYmUgYXNzaWdu ZWQgdG8gaXQuCisgKiBSZXR1cm5zOiAodHJhbnNmZXIgZnVsbCkgKGFycmF5IGxlbmd0aD1sZW5n dGgpIChlbGVtZW50LXR5cGUgZ3VpbnQ4KTogYQorICogICAgc3RyaW5nIHdpdGggdGhlIGRhdGEg b2YgQHJlc291cmNlLCBvciAlTlVMTCBpbiBjYXNlIG9mIGVycm9yLiBpZiBAbGVuZ3RoCisgKiAg ICBpcyBub3QgJU5VTEwsIHRoZSBzaXplIG9mIHRoZSBkYXRhIHdpbGwgYmUgYXNzaWduZWQgdG8g aXQuCiAgKi8KIGd1Y2hhciogd2Via2l0X3dlYl9yZXNvdXJjZV9nZXRfZGF0YV9maW5pc2goV2Vi S2l0V2ViUmVzb3VyY2UqIHJlc291cmNlLCBHQXN5bmNSZXN1bHQqIHJlc3VsdCwgZ3NpemUqIGxl bmd0aCwgR0Vycm9yKiogZXJyb3IpCiB7Ci0tIAoxLjkuMwoK 234151 2014-07-01 01:32:15 -0700 2014-07-01 02:11:19 -0700 Patch for landing wk2-get-data-annots.diff text/plain 2085 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5YjQ5OTY4Li5jY2U5YTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDctMDEgIEV2YW4gTmVtZXJzb24gIDxldmFuQG5lbWVyc29uLmNvbT4KKworICAg ICAgICBbR1RLXSBBbm5vdGF0aW9ucyBmb3IgV2ViUmVzb3VyY2UuZ2V0X2RhdGEgcHJvZHVjZSB3 cm9uZyBzaWduYXR1cmUgaW4gVmFsYSBiaW5kaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJs b3MgR2FyY2lhIENhbXBvcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlJlc291cmNlLmNwcDogQWRkIGFycmF5IGxlbmd0aCBhbmQKKyAgICAgICAgZWxlbWVudC10eXBl IGFubm90YXRpb25zIHRvIHJldHVybiB2YWx1ZSBvZiB3ZWJraXRfd2ViX3Jlc291cmNlX2dldF9k YXRhX2ZpbmlzaCgpLgorCiAyMDE0LTA3LTAxICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1A c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW1dLMl0gQ2FuIG5vdCBjb252ZXJ0IOKAmHNlc3Npb25T dGF0ZS5XZWJLaXQ6OlNlc3Npb25TdGF0ZTo6cHJvdmlzaW9uYWxVUkzigJkgZnJvbSDigJhXZWJD b3JlOjpVUkzigJkgdG8g4oCYYm9vbOKAmQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViUmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViUmVzb3VyY2UuY3BwCmluZGV4IGIxZGMyNjAuLmYwY2Zm YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlJlc291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJSZXNvdXJjZS5jcHAKQEAgLTM1NSwxMyArMzU1LDE0IEBAIHZvaWQgd2Via2l0X3dlYl9y ZXNvdXJjZV9nZXRfZGF0YShXZWJLaXRXZWJSZXNvdXJjZSogcmVzb3VyY2UsIEdDYW5jZWxsYWJs ZSogY2FuCiAgKiB3ZWJraXRfd2ViX3Jlc291cmNlX2dldF9kYXRhX2ZpbmlzaDoKICAqIEByZXNv dXJjZTogYSAjV2ViS2l0V2ViUmVzb3VyY2UKICAqIEByZXN1bHQ6IGEgI0dBc3luY1Jlc3VsdAot ICogQGxlbmd0aDogKG91dCk6IHJldHVybiBsb2NhdGlvbiBmb3IgdGhlIGxlbmd0aCBvZiB0aGUg cmVzb3VyY2UgZGF0YQorICogQGxlbmd0aDogKG91dCkgKGFsbG93LW5vbmUpOiByZXR1cm4gbG9j YXRpb24gZm9yIHRoZSBsZW5ndGggb2YgdGhlIHJlc291cmNlIGRhdGEKICAqIEBlcnJvcjogcmV0 dXJuIGxvY2F0aW9uIGZvciBlcnJvciBvciAlTlVMTCB0byBpZ25vcmUKICAqCiAgKiBGaW5pc2gg YW4gYXN5bmNocm9ub3VzIG9wZXJhdGlvbiBzdGFydGVkIHdpdGggd2Via2l0X3dlYl9yZXNvdXJj ZV9nZXRfZGF0YSgpLgogICoKLSAqIFJldHVybnM6ICh0cmFuc2ZlciBmdWxsKTogYSBzdHJpbmcg d2l0aCB0aGUgZGF0YSBvZiBAcmVzb3VyY2UsIG9yICVOVUxMIGluIGNhc2UKLSAqICAgIG9mIGVy cm9yLiBpZiBAbGVuZ3RoIGlzIG5vdCAlTlVMTCwgdGhlIHNpemUgb2YgdGhlIGRhdGEgd2lsbCBi ZSBhc3NpZ25lZCB0byBpdC4KKyAqIFJldHVybnM6ICh0cmFuc2ZlciBmdWxsKSAoYXJyYXkgbGVu Z3RoPWxlbmd0aCkgKGVsZW1lbnQtdHlwZSBndWludDgpOiBhCisgKiAgICBzdHJpbmcgd2l0aCB0 aGUgZGF0YSBvZiBAcmVzb3VyY2UsIG9yICVOVUxMIGluIGNhc2Ugb2YgZXJyb3IuIGlmIEBsZW5n dGgKKyAqICAgIGlzIG5vdCAlTlVMTCwgdGhlIHNpemUgb2YgdGhlIGRhdGEgd2lsbCBiZSBhc3Np Z25lZCB0byBpdC4KICAqLwogZ3VjaGFyKiB3ZWJraXRfd2ViX3Jlc291cmNlX2dldF9kYXRhX2Zp bmlzaChXZWJLaXRXZWJSZXNvdXJjZSogcmVzb3VyY2UsIEdBc3luY1Jlc3VsdCogcmVzdWx0LCBn c2l6ZSogbGVuZ3RoLCBHRXJyb3IqKiBlcnJvcikKIHsK