134473 2014-06-30 16:57:56 -0700 [iOS] languageSpecificFallbackFont() is not consistent 2014-06-30 17:27:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield bunhere cdumez commit-queue darin dino gyuyoung.kim jonlee sergio simon.fraser thorton oldest_to_newest 1019480 0 mmaxfield 2014-06-30 16:57:56 -0700 [iOS] languageSpecificFallbackFont() is not consistent 1019482 1 234121 mmaxfield 2014-06-30 16:59:36 -0700 Created attachment 234121 Patch 1019485 2 commit-queue 2014-06-30 17:02:37 -0700 Attachment 234121 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1019490 3 234121 darin 2014-06-30 17:06:20 -0700 Comment on attachment 234121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review > Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155 > + if (c < 0x1401) > + return LanguageSpecificFont::None; Looks to me like this changes behavior. The old code would return LanguageSpecificFont::Khmer for 0x1200-0x1400. 1019491 4 234124 mmaxfield 2014-06-30 17:07:06 -0700 Created attachment 234124 Patch 1019492 5 234121 mmaxfield 2014-06-30 17:08:35 -0700 Comment on attachment 234121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review >> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155 >> + return LanguageSpecificFont::None; > > Looks to me like this changes behavior. The old code would return LanguageSpecificFont::Khmer for 0x1200-0x1400. Yeah, you're right. Yet another reason why we need to be consistent! 1019493 6 234125 mmaxfield 2014-06-30 17:11:34 -0700 Created attachment 234125 Patch 1019500 7 mmaxfield 2014-06-30 17:27:06 -0700 http://trac.webkit.org/changeset/170618 234121 2014-06-30 16:59:36 -0700 2014-06-30 17:08:35 -0700 Patch bug-134473-20140630165916.patch text/plain 4229 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM2NTBjMGI0MjhmMmMw ZDMxNDNlZGNlNDAwOGQ1ZjcwZTNjNGMwYy4uYjQ3OWM4MTdiZWY2NGI1YzZkMTgwYmM5NGU4MmQz NGZlOThhMzU3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTA2LTMwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgW2lPU10gbGFu Z3VhZ2VTcGVjaWZpY0ZhbGxiYWNrRm9udCgpIGlzIG5vdCBjb25zaXN0ZW50CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgY2FuIHVzZSAiPCIgdGhy b3VnaG91dCB0aGUgZnVuY3Rpb24gYXMgd2VsbCBhcyBrZWVwaW5nIHRoZSBmYWxsdGhyb3VnaCBi ZWhhdmlvciBjb25zaXN0ZW50LgorCisgICAgICAgIE5vIHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMg bm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvaW9zL0Zv bnRDYWNoZUlPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6Omxhbmd1YWdlU3BlY2lmaWNGYWxsYmFj a0ZvbnQpOgorCisyMDE0LTA2LTMwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs ZS5jb20+CisKICAgICAgICAgVGlsZXMgb24gYm90dG9tIG9mIHNjcmVlbiBhcmUgbm90IGFsd2F5 cyBhbGxvY2F0ZWQgd2hlbiBuZWNlc3NhcnkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNDI3MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9pb3MvRm9udENhY2hlSU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvaW9zL0ZvbnRDYWNoZUlPUy5tbQppbmRleCAwMTE3N2YwZjhiZWFjZjFm ZTI2MzU1MTY5NDFjMDdkNzBjNDlmNjZhLi5iYzI0OTkxYWJiOWZjNTgwNjM1MzExZjk5MTk2OWFl YThhM2Q0MGU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9p b3MvRm9udENhY2hlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2lvcy9Gb250Q2FjaGVJT1MubW0KQEAgLTEyOSwyOSArMTI5LDMxIEBAIHN0YXRpYyBMYW5ndWFn ZVNwZWNpZmljRm9udCBsYW5ndWFnZVNwZWNpZmljRmFsbGJhY2tGb250KFVDaGFyMzIgYykKIAog ICAgIGlmIChjIDwgMHg0MDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6 Tm9uZTsKLSAgICBpZiAoYyA8PSAweDUyRikKKyAgICBpZiAoYyA8IDB4NTMwKQogICAgICAgICBy ZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkN5cmlsbGljOwogICAgIGlmIChjIDwgMHg1OTAp CiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKICAgICBpZiAoYyA8 IDB4NjAwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkhlYnJldzsKLSAg ICBpZiAoYyA8PSAweDZGRikKKyAgICBpZiAoYyA8IDB4NzAwKQogICAgICAgICByZXR1cm4gTGFu Z3VhZ2VTcGVjaWZpY0ZvbnQ6OkFyYWJpYzsKICAgICBpZiAoYyA8IDB4OTAwKQogICAgICAgICBy ZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7CiAgICAgaWYgKGMgPCAweEUwMCkKICAg ICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpBcmFiaWM7Ci0gICAgaWYgKGMgPD0g MHhFN0YpCisgICAgaWYgKGMgPCAweEU4MCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lm aWNGb250OjpUaGFpOwogICAgIGlmIChjIDwgMHgwRjAwKQogICAgICAgICByZXR1cm4gTGFuZ3Vh Z2VTcGVjaWZpY0ZvbnQ6OkxhbzsKLSAgICBpZiAoYyA8PSAweDBGRkYpCisgICAgaWYgKGMgPCAw eDEwMDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6VGliZXRhbjsKICAg ICBpZiAoYyA8IDB4MTEwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpO b25lOwotICAgIGlmIChjIDw9IDB4MTFGRikKKyAgICBpZiAoYyA8IDB4MTIwMCkKICAgICAgICAg cmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpLb3JlYW47Ci0gICAgaWYgKGMgPiAweDE0MDAg JiYgYyA8IDB4MTc4MCkKKyAgICBpZiAoYyA8IDB4MTQwMSkKKyAgICAgICAgcmV0dXJuIExhbmd1 YWdlU3BlY2lmaWNGb250OjpOb25lOworICAgIGlmIChjIDwgMHgxNzgwKQogICAgICAgICByZXR1 cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkNhbmFkaWFuQWJvcmlnaW5hbFN5bGxhYmljOwogICAg IGlmIChjIDwgMHgxODAwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Okto bWVyOwpAQCAtMTU5LDI3ICsxNjEsMjUgQEAgc3RhdGljIExhbmd1YWdlU3BlY2lmaWNGb250IGxh bmd1YWdlU3BlY2lmaWNGYWxsYmFja0ZvbnQoVUNoYXIzMiBjKQogICAgICAgICByZXR1cm4gTGFu Z3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7CiAgICAgaWYgKGMgPCAweDMxMzApCiAgICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q2hpbmVzZUphcGFuZXNlOwotICAgIGlmIChjIDw9 IDB4MzE4RikKKyAgICBpZiAoYyA8IDB4MzE5MCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3Bl Y2lmaWNGb250OjpLb3JlYW47CiAgICAgaWYgKGMgPCAweEFDMDApCiAgICAgICAgIHJldHVybiBM YW5ndWFnZVNwZWNpZmljRm9udDo6Q2hpbmVzZUphcGFuZXNlOwotICAgIGlmIChjIDw9IDB4RDdB MykKKyAgICBpZiAoYyA8IDB4RDdBNCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNG b250OjpLb3JlYW47Ci0gICAgaWYgKGMgPD0gMHhERkZGKQotICAgICAgICByZXR1cm4gTGFuZ3Vh Z2VTcGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKICAgICBpZiAoYyA8IDB4RTAwMCkKLSAg ICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpOb25lOworICAgICAgICByZXR1cm4g TGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKICAgICBpZiAoYyA8IDB4RTYw MCkKICAgICAgICAgcmV0dXJuIGlzR0IxODAzMENvbXBsaWFuY2VSZXF1aXJlZCA/IExhbmd1YWdl U3BlY2lmaWNGb250OjpDaGluZXNlSmFwYW5lc2UgOiBMYW5ndWFnZVNwZWNpZmljRm9udDo6RW1v amk7Ci0gICAgaWYgKGMgPD0gMHhFODY0ICYmIGlzR0IxODAzMENvbXBsaWFuY2VSZXF1aXJlZCkK KyAgICBpZiAoYyA8IDB4RTg2NSAmJiBpc0dCMTgwMzBDb21wbGlhbmNlUmVxdWlyZWQpCiAgICAg ICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q2hpbmVzZUphcGFuZXNlOwotICAgIGlm IChjIDw9IDB4RjhGRikKKyAgICBpZiAoYyA8IDB4RjkwMCkKICAgICAgICAgcmV0dXJuIExhbmd1 YWdlU3BlY2lmaWNGb250OjpOb25lOwogICAgIGlmIChjIDwgMHhGQjAwKQogICAgICAgICByZXR1 cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKICAgICBpZiAoYyA8IDB4 RkI1MCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpOb25lOwotICAgIGlm IChjIDw9IDB4RkRGRikKKyAgICBpZiAoYyA8IDB4RkUwMCkKICAgICAgICAgcmV0dXJuIExhbmd1 YWdlU3BlY2lmaWNGb250OjpBcmFiaWM7CiAgICAgaWYgKGMgPCAweEZFMjApCiAgICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKQEAgLTE4OSw3ICsxODksOSBAQCBzdGF0 aWMgTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQgbGFuZ3VhZ2VTcGVjaWZpY0ZhbGxiYWNrRm9udChVQ2hh cjMyIGMpCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6QXJhYmljOwogICAg IGlmIChjIDwgMHhGRkYwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkNo aW5lc2VKYXBhbmVzZTsKLSAgICBpZiAoYyA+PTB4MjAwMDAgJiYgYyA8PSAweDJGRkZGKQorICAg IGlmIChjIDwgMHgyMDAwMCkKKyAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpO b25lOworICAgIGlmIChjIDwgMHgzMDAwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lm aWNGb250OjpDaGluZXNlSmFwYW5lc2U7CiAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250 OjpOb25lOwogfQo= 234124 2014-06-30 17:07:06 -0700 2014-06-30 17:11:29 -0700 Patch bug-134473-20140630170646.patch text/plain 4285 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM2NTBjMGI0MjhmMmMw ZDMxNDNlZGNlNDAwOGQ1ZjcwZTNjNGMwYy4uYmIxODM5ZmEzYzE2YjBhODU1MmQ0MTZlMzE2NjRm Y2QzYzEzODJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA2LTMwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgW2lPU10gbGFu Z3VhZ2VTcGVjaWZpY0ZhbGxiYWNrRm9udCgpIGlzIG5vdCBjb25zaXN0ZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ0NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBjYW4gdXNlICI8IiB0aHJv dWdob3V0IHRoZSBmdW5jdGlvbiBhcyB3ZWxsIGFzIGtlZXBpbmcgdGhlIGZhbGx0aHJvdWdoIGJl aGF2aW9yIGNvbnNpc3RlbnQuCisKKyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9pb3MvRm9u dENhY2hlSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6bGFuZ3VhZ2VTcGVjaWZpY0ZhbGxiYWNr Rm9udCk6CisKKzIwMTQtMDYtMzAgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxl LmNvbT4KKwogICAgICAgICBUaWxlcyBvbiBib3R0b20gb2Ygc2NyZWVuIGFyZSBub3QgYWx3YXlz IGFsbG9jYXRlZCB3aGVuIG5lY2Vzc2FyeQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MjcyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2lvcy9Gb250Q2FjaGVJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9pb3MvRm9udENhY2hlSU9TLm1tCmluZGV4IDAxMTc3ZjBmOGJlYWNmMWZl MjYzNTUxNjk0MWMwN2Q3MGM0OWY2NmEuLmJjMjQ5OTFhYmI5ZmM1ODA2MzUzMTFmOTkxOTY5YWVh OGEzZDQwZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2lv cy9Gb250Q2FjaGVJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv aW9zL0ZvbnRDYWNoZUlPUy5tbQpAQCAtMTI5LDI5ICsxMjksMzEgQEAgc3RhdGljIExhbmd1YWdl U3BlY2lmaWNGb250IGxhbmd1YWdlU3BlY2lmaWNGYWxsYmFja0ZvbnQoVUNoYXIzMiBjKQogCiAg ICAgaWYgKGMgPCAweDQwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpO b25lOwotICAgIGlmIChjIDw9IDB4NTJGKQorICAgIGlmIChjIDwgMHg1MzApCiAgICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q3lyaWxsaWM7CiAgICAgaWYgKGMgPCAweDU5MCkK ICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpOb25lOwogICAgIGlmIChjIDwg MHg2MDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6SGVicmV3OwotICAg IGlmIChjIDw9IDB4NkZGKQorICAgIGlmIChjIDwgMHg3MDApCiAgICAgICAgIHJldHVybiBMYW5n dWFnZVNwZWNpZmljRm9udDo6QXJhYmljOwogICAgIGlmIChjIDwgMHg5MDApCiAgICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKICAgICBpZiAoYyA8IDB4RTAwKQogICAg ICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkFyYWJpYzsKLSAgICBpZiAoYyA8PSAw eEU3RikKKyAgICBpZiAoYyA8IDB4RTgwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZp Y0ZvbnQ6OlRoYWk7CiAgICAgaWYgKGMgPCAweDBGMDApCiAgICAgICAgIHJldHVybiBMYW5ndWFn ZVNwZWNpZmljRm9udDo6TGFvOwotICAgIGlmIChjIDw9IDB4MEZGRikKKyAgICBpZiAoYyA8IDB4 MTAwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpUaWJldGFuOwogICAg IGlmIChjIDwgMHgxMTAwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5v bmU7Ci0gICAgaWYgKGMgPD0gMHgxMUZGKQorICAgIGlmIChjIDwgMHgxMjAwKQogICAgICAgICBy ZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OktvcmVhbjsKLSAgICBpZiAoYyA+IDB4MTQwMCAm JiBjIDwgMHgxNzgwKQorICAgIGlmIChjIDwgMHgxNDAxKQorICAgICAgICByZXR1cm4gTGFuZ3Vh Z2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7CisgICAgaWYgKGMgPCAweDE3ODApCiAgICAgICAgIHJldHVy biBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q2FuYWRpYW5BYm9yaWdpbmFsU3lsbGFiaWM7CiAgICAg aWYgKGMgPCAweDE4MDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6S2ht ZXI7CkBAIC0xNTksMjcgKzE2MSwyNSBAQCBzdGF0aWMgTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQgbGFu Z3VhZ2VTcGVjaWZpY0ZhbGxiYWNrRm9udChVQ2hhcjMyIGMpCiAgICAgICAgIHJldHVybiBMYW5n dWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKICAgICBpZiAoYyA8IDB4MzEzMCkKICAgICAgICAgcmV0 dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpDaGluZXNlSmFwYW5lc2U7Ci0gICAgaWYgKGMgPD0g MHgzMThGKQorICAgIGlmIChjIDwgMHgzMTkwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVj aWZpY0ZvbnQ6OktvcmVhbjsKICAgICBpZiAoYyA8IDB4QUMwMCkKICAgICAgICAgcmV0dXJuIExh bmd1YWdlU3BlY2lmaWNGb250OjpDaGluZXNlSmFwYW5lc2U7Ci0gICAgaWYgKGMgPD0gMHhEN0Ez KQorICAgIGlmIChjIDwgMHhEN0E0KQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0Zv bnQ6OktvcmVhbjsKLSAgICBpZiAoYyA8PSAweERGRkYpCi0gICAgICAgIHJldHVybiBMYW5ndWFn ZVNwZWNpZmljRm9udDo6Q2hpbmVzZUphcGFuZXNlOwogICAgIGlmIChjIDwgMHhFMDAwKQotICAg ICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7CisgICAgICAgIHJldHVybiBM YW5ndWFnZVNwZWNpZmljRm9udDo6Q2hpbmVzZUphcGFuZXNlOwogICAgIGlmIChjIDwgMHhFNjAw KQogICAgICAgICByZXR1cm4gaXNHQjE4MDMwQ29tcGxpYW5jZVJlcXVpcmVkID8gTGFuZ3VhZ2VT cGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZSA6IExhbmd1YWdlU3BlY2lmaWNGb250OjpFbW9q aTsKLSAgICBpZiAoYyA8PSAweEU4NjQgJiYgaXNHQjE4MDMwQ29tcGxpYW5jZVJlcXVpcmVkKQor ICAgIGlmIChjIDwgMHhFODY1ICYmIGlzR0IxODAzMENvbXBsaWFuY2VSZXF1aXJlZCkKICAgICAg ICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpDaGluZXNlSmFwYW5lc2U7Ci0gICAgaWYg KGMgPD0gMHhGOEZGKQorICAgIGlmIChjIDwgMHhGOTAwKQogICAgICAgICByZXR1cm4gTGFuZ3Vh Z2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7CiAgICAgaWYgKGMgPCAweEZCMDApCiAgICAgICAgIHJldHVy biBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q2hpbmVzZUphcGFuZXNlOwogICAgIGlmIChjIDwgMHhG QjUwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7Ci0gICAgaWYg KGMgPD0gMHhGREZGKQorICAgIGlmIChjIDwgMHhGRTAwKQogICAgICAgICByZXR1cm4gTGFuZ3Vh Z2VTcGVjaWZpY0ZvbnQ6OkFyYWJpYzsKICAgICBpZiAoYyA8IDB4RkUyMCkKICAgICAgICAgcmV0 dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpOb25lOwpAQCAtMTg5LDcgKzE4OSw5IEBAIHN0YXRp YyBMYW5ndWFnZVNwZWNpZmljRm9udCBsYW5ndWFnZVNwZWNpZmljRmFsbGJhY2tGb250KFVDaGFy MzIgYykKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpBcmFiaWM7CiAgICAg aWYgKGMgPCAweEZGRjApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q2hp bmVzZUphcGFuZXNlOwotICAgIGlmIChjID49MHgyMDAwMCAmJiBjIDw9IDB4MkZGRkYpCisgICAg aWYgKGMgPCAweDIwMDAwKQorICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5v bmU7CisgICAgaWYgKGMgPCAweDMwMDAwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZp Y0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6 Ok5vbmU7CiB9Cg== 234125 2014-06-30 17:11:34 -0700 2014-06-30 17:12:03 -0700 Patch bug-134473-20140630171115.patch text/plain 4335 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM2NTBjMGI0MjhmMmMw ZDMxNDNlZGNlNDAwOGQ1ZjcwZTNjNGMwYy4uYmIxODM5ZmEzYzE2YjBhODU1MmQ0MTZlMzE2NjRm Y2QzYzEzODJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA2LTMwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgW2lPU10gbGFu Z3VhZ2VTcGVjaWZpY0ZhbGxiYWNrRm9udCgpIGlzIG5vdCBjb25zaXN0ZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ0NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBjYW4gdXNlICI8IiB0aHJv dWdob3V0IHRoZSBmdW5jdGlvbiBhcyB3ZWxsIGFzIGtlZXBpbmcgdGhlIGZhbGx0aHJvdWdoIGJl aGF2aW9yIGNvbnNpc3RlbnQuCisKKyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9pb3MvRm9u dENhY2hlSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6bGFuZ3VhZ2VTcGVjaWZpY0ZhbGxiYWNr Rm9udCk6CisKKzIwMTQtMDYtMzAgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxl LmNvbT4KKwogICAgICAgICBUaWxlcyBvbiBib3R0b20gb2Ygc2NyZWVuIGFyZSBub3QgYWx3YXlz IGFsbG9jYXRlZCB3aGVuIG5lY2Vzc2FyeQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MjcyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2lvcy9Gb250Q2FjaGVJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9pb3MvRm9udENhY2hlSU9TLm1tCmluZGV4IDAxMTc3ZjBmOGJlYWNmMWZl MjYzNTUxNjk0MWMwN2Q3MGM0OWY2NmEuLjQ0ZDlkMzY5NjM4YTdkMTYyN2MyODE0NzRkOTZkMGZl MzcyZmE4MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2lv cy9Gb250Q2FjaGVJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv aW9zL0ZvbnRDYWNoZUlPUy5tbQpAQCAtMTI5LDI5ICsxMjksMzEgQEAgc3RhdGljIExhbmd1YWdl U3BlY2lmaWNGb250IGxhbmd1YWdlU3BlY2lmaWNGYWxsYmFja0ZvbnQoVUNoYXIzMiBjKQogCiAg ICAgaWYgKGMgPCAweDQwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpO b25lOwotICAgIGlmIChjIDw9IDB4NTJGKQorICAgIGlmIChjIDwgMHg1MzApCiAgICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Q3lyaWxsaWM7CiAgICAgaWYgKGMgPCAweDU5MCkK ICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpOb25lOwogICAgIGlmIChjIDwg MHg2MDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6SGVicmV3OwotICAg IGlmIChjIDw9IDB4NkZGKQorICAgIGlmIChjIDwgMHg3MDApCiAgICAgICAgIHJldHVybiBMYW5n dWFnZVNwZWNpZmljRm9udDo6QXJhYmljOwogICAgIGlmIChjIDwgMHg5MDApCiAgICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKICAgICBpZiAoYyA8IDB4RTAwKQogICAg ICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkFyYWJpYzsKLSAgICBpZiAoYyA8PSAw eEU3RikKKyAgICBpZiAoYyA8IDB4RTgwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZp Y0ZvbnQ6OlRoYWk7CiAgICAgaWYgKGMgPCAweDBGMDApCiAgICAgICAgIHJldHVybiBMYW5ndWFn ZVNwZWNpZmljRm9udDo6TGFvOwotICAgIGlmIChjIDw9IDB4MEZGRikKKyAgICBpZiAoYyA8IDB4 MTAwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpUaWJldGFuOwogICAg IGlmIChjIDwgMHgxMTAwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5v bmU7Ci0gICAgaWYgKGMgPD0gMHgxMUZGKQorICAgIGlmIChjIDwgMHgxMjAwKQogICAgICAgICBy ZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OktvcmVhbjsKLSAgICBpZiAoYyA+IDB4MTQwMCAm JiBjIDwgMHgxNzgwKQorICAgIGlmIChjIDwgMHgxNDAxKQorICAgICAgICByZXR1cm4gTGFuZ3Vh Z2VTcGVjaWZpY0ZvbnQ6OktobWVyOyAvLyBGSVhNRTogVGhlc2UgY29kZXBvaW50cyBkb24ndCBi ZWxvbmcgdG8gS2htZXIKKyAgICBpZiAoYyA8IDB4MTc4MCkKICAgICAgICAgcmV0dXJuIExhbmd1 YWdlU3BlY2lmaWNGb250OjpDYW5hZGlhbkFib3JpZ2luYWxTeWxsYWJpYzsKICAgICBpZiAoYyA8 IDB4MTgwMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpLaG1lcjsKQEAg LTE1OSwyNyArMTYxLDI1IEBAIHN0YXRpYyBMYW5ndWFnZVNwZWNpZmljRm9udCBsYW5ndWFnZVNw ZWNpZmljRmFsbGJhY2tGb250KFVDaGFyMzIgYykKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3Bl Y2lmaWNGb250OjpOb25lOwogICAgIGlmIChjIDwgMHgzMTMwKQogICAgICAgICByZXR1cm4gTGFu Z3VhZ2VTcGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKLSAgICBpZiAoYyA8PSAweDMxOEYp CisgICAgaWYgKGMgPCAweDMxOTApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9u dDo6S29yZWFuOwogICAgIGlmIChjIDwgMHhBQzAwKQogICAgICAgICByZXR1cm4gTGFuZ3VhZ2VT cGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKLSAgICBpZiAoYyA8PSAweEQ3QTMpCisgICAg aWYgKGMgPCAweEQ3QTQpCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6S29y ZWFuOwotICAgIGlmIChjIDw9IDB4REZGRikKLSAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lm aWNGb250OjpDaGluZXNlSmFwYW5lc2U7CiAgICAgaWYgKGMgPCAweEUwMDApCi0gICAgICAgIHJl dHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKKyAgICAgICAgcmV0dXJuIExhbmd1YWdl U3BlY2lmaWNGb250OjpDaGluZXNlSmFwYW5lc2U7CiAgICAgaWYgKGMgPCAweEU2MDApCiAgICAg ICAgIHJldHVybiBpc0dCMTgwMzBDb21wbGlhbmNlUmVxdWlyZWQgPyBMYW5ndWFnZVNwZWNpZmlj Rm9udDo6Q2hpbmVzZUphcGFuZXNlIDogTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkVtb2ppOwotICAg IGlmIChjIDw9IDB4RTg2NCAmJiBpc0dCMTgwMzBDb21wbGlhbmNlUmVxdWlyZWQpCisgICAgaWYg KGMgPCAweEU4NjUgJiYgaXNHQjE4MDMwQ29tcGxpYW5jZVJlcXVpcmVkKQogICAgICAgICByZXR1 cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkNoaW5lc2VKYXBhbmVzZTsKLSAgICBpZiAoYyA8PSAw eEY4RkYpCisgICAgaWYgKGMgPCAweEY5MDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNp ZmljRm9udDo6Tm9uZTsKICAgICBpZiAoYyA8IDB4RkIwMCkKICAgICAgICAgcmV0dXJuIExhbmd1 YWdlU3BlY2lmaWNGb250OjpDaGluZXNlSmFwYW5lc2U7CiAgICAgaWYgKGMgPCAweEZCNTApCiAg ICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKLSAgICBpZiAoYyA8PSAw eEZERkYpCisgICAgaWYgKGMgPCAweEZFMDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNp ZmljRm9udDo6QXJhYmljOwogICAgIGlmIChjIDwgMHhGRTIwKQogICAgICAgICByZXR1cm4gTGFu Z3VhZ2VTcGVjaWZpY0ZvbnQ6Ok5vbmU7CkBAIC0xODksNyArMTg5LDkgQEAgc3RhdGljIExhbmd1 YWdlU3BlY2lmaWNGb250IGxhbmd1YWdlU3BlY2lmaWNGYWxsYmFja0ZvbnQoVUNoYXIzMiBjKQog ICAgICAgICByZXR1cm4gTGFuZ3VhZ2VTcGVjaWZpY0ZvbnQ6OkFyYWJpYzsKICAgICBpZiAoYyA8 IDB4RkZGMCkKICAgICAgICAgcmV0dXJuIExhbmd1YWdlU3BlY2lmaWNGb250OjpDaGluZXNlSmFw YW5lc2U7Ci0gICAgaWYgKGMgPj0weDIwMDAwICYmIGMgPD0gMHgyRkZGRikKKyAgICBpZiAoYyA8 IDB4MjAwMDApCisgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsKKyAg ICBpZiAoYyA8IDB4MzAwMDApCiAgICAgICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6 Q2hpbmVzZUphcGFuZXNlOwogICAgIHJldHVybiBMYW5ndWFnZVNwZWNpZmljRm9udDo6Tm9uZTsK IH0K