134468 2014-06-30 16:30:35 -0700 Make TransformIterator::TransformIterator() take rvalue references 2014-06-30 17:01:05 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates andersca benjamin bunhere cdumez cmarcelo commit-queue darin gyuyoung.kim sergio oldest_to_newest 1019465 0 dbates 2014-06-30 16:30:35 -0700 We should add a constructor for TransformIterator::TransformIterator() that takes rvalue references so that we can actually use move semantics to move its passed arguments. Currently TransformIterator::TransformIterator() always copies its arguments. 1019466 1 234113 dbates 2014-06-30 16:31:25 -0700 Created attachment 234113 Patch 1019471 2 234113 darin 2014-06-30 16:34:26 -0700 Comment on attachment 234113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234113&action=review > Source/WTF/ChangeLog:3 > + Actually use move semantics when calling TransformIterator::TransformIterator() with rvalue references I don’t understand the point of the word “actually” here. 1019479 3 234120 dbates 2014-06-30 16:54:25 -0700 Created attachment 234120 Patch 1019481 4 dbates 2014-06-30 16:58:41 -0700 (In reply to comment #2) > (From update of attachment 234113 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234113&action=review > > > Source/WTF/ChangeLog:3 > > + Actually use move semantics when calling TransformIterator::TransformIterator() with rvalue references > > I don’t understand the point of the word “actually” here. As we discussed in-person today (06/30), the purpose of this patch is to support a constructor that takes rvalue-references. It's actually sufficient to only have such a constructor. I updated the title of this bug and attached an updated patch. 1019484 5 dbates 2014-06-30 17:01:05 -0700 Committed r170615: <http://trac.webkit.org/changeset/170615> 234113 2014-06-30 16:31:25 -0700 2014-06-30 16:54:21 -0700 Patch bug-134468-20140630163113.patch text/plain 1716 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGViN2FkMDFhZDYzZGEzNTRmMmY0MWU3 YWY0MzczNjFhZTA5ZDJjODIuLjcyMjI1NDA4ZTI1OTE4MDhkNGEwYmUxZmVmYWFiOTg5M2I0ZDE2 MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDYtMzAgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEFjdHVhbGx5IHVzZSBtb3ZlIHNlbWFudGljcyB3aGVu IGNhbGxpbmcgVHJhbnNmb3JtSXRlcmF0b3I6OlRyYW5zZm9ybUl0ZXJhdG9yKCkgd2l0aCBydmFs dWUgcmVmZXJlbmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM0NDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudGx5IGNhbGxpbmcgVHJhbnNmb3JtSXRlcmF0b3I6OlRyYW5zZm9ybUl0ZXJh dG9yIGFsd2F5cyBpbnZva2VzIHRoZSBjb3B5IGNvbnN0cnVjdG9ycyBmb3IgaXRzCisgICAgICAg IGFyZ3VtZW50cyBzaW5jZSBpdHMgYXJndW1lbnRzIGFyZSBjb25zdC4gV2Ugc2hvdWxkIGFkZCBh IGNvbnN0cnVjdG9yIHRoYXQgdGFrZXMgcnZhbHVlIHJlZmVyZW5jZXMKKyAgICAgICAgZm9yIGl0 cyBhcmd1bWVudHMgc28gdGhhdCB3ZSBjYW4gYWN0dWFsbHkgdXNlIG1vdmUgc2VtYW50aWNzIHdo ZW4gaW5zdGFudGlhdGVkIHdpdGggcnZhbHVlIHJlZmVyZW5jZXMuCisKKyAgICAgICAgKiB3dGYv SXRlcmF0b3JBZGFwdG9ycy5oOgorICAgICAgICAoV1RGOjpUcmFuc2Zvcm1JdGVyYXRvcjo6VHJh bnNmb3JtSXRlcmF0b3IpOgorCiAyMDE0LTA2LTI3ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFw cGxlLmNvbT4KIAogICAgICAgICBbQVJNdjddIFNraXAgb25lIHBhcnRpY3VsYXJseSBleHBlbnNp dmUgZmFzdEZyZWUoKSBhbGlnbm1lbnQgY2hlY2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9JdGVyYXRvckFkYXB0b3JzLmggYi9Tb3VyY2UvV1RGL3d0Zi9JdGVyYXRvckFkYXB0b3JzLmgK aW5kZXggYTVlZGUxMWFkYmM1MmI4NmEyNzUzNDYzYmI4NTEwMTQ1NWMzMDY0NC4uZjU3ZTY0ZTkx YWI3OTQ5NzM3OWU3Y2UxY2MzNzdkNjUwYWNhMGU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvSXRlcmF0b3JBZGFwdG9ycy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0l0ZXJhdG9yQWRhcHRv cnMuaApAQCAtNzgsNiArNzgsMTIgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVHJhbnNmb3JtLCB0eXBl bmFtZSBJdGVyYXRvcj4KIGNsYXNzIFRyYW5zZm9ybUl0ZXJhdG9yIHsKIHB1YmxpYzoKICAgICBU cmFuc2Zvcm1JdGVyYXRvcihjb25zdCBUcmFuc2Zvcm0mIHRyYW5zZm9ybSwgY29uc3QgSXRlcmF0 b3ImIGl0ZXIpCisgICAgICAgIDogbV90cmFuc2Zvcm0odHJhbnNmb3JtKQorICAgICAgICAsIG1f aXRlcihpdGVyKQorICAgIHsKKyAgICB9CisKKyAgICBUcmFuc2Zvcm1JdGVyYXRvcihUcmFuc2Zv cm0mJiB0cmFuc2Zvcm0sIEl0ZXJhdG9yJiYgaXRlcikKICAgICAgICAgOiBtX3RyYW5zZm9ybShz dGQ6Om1vdmUodHJhbnNmb3JtKSkKICAgICAgICAgLCBtX2l0ZXIoc3RkOjptb3ZlKGl0ZXIpKQog ICAgIHsK 234120 2014-06-30 16:54:25 -0700 2014-06-30 16:55:16 -0700 Patch bug-134468-20140630165413.patch text/plain 2169 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGViN2FkMDFhZDYzZGEzNTRmMmY0MWU3 YWY0MzczNjFhZTA5ZDJjODIuLjY4OTVlNTkwNDQ1ZGQzYTNiZGYyYzcxMjkxNWE4YmU3MzhmMzc5 OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDYtMzAgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgVHJhbnNmb3JtSXRlcmF0b3I6OlRyYW5zZm9y bUl0ZXJhdG9yKCkgdGFrZSBydmFsdWUgcmVmZXJlbmNlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyB1bm5lY2Vzc2FyeSB0byBzdXBwb3J0IFRy YW5zZm9ybUl0ZXJhdG9yOjpUcmFuc2Zvcm1JdGVyYXRvcigpIHRha2luZyBjb25zdCBsdmFsdWUg cmVmZXJlbmNlcworICAgICAgICBhcyB3ZSBvbmx5IGNhbGwgaXQgd2l0aCBydmFsdWVzLiBBcyBh IHNpZGUgYmVuZWZpdCwgd2UgY2FuIHVzZSBtb3ZlIHNlbWFudGljcyB0byBpbml0aWFsaXplIHRo ZQorICAgICAgICBtZW1iZXJzIG9mIFRyYW5zZm9ybUl0ZXJhdG9yLgorCisgICAgICAgICogd3Rm L0l0ZXJhdG9yQWRhcHRvcnMuaDoKKyAgICAgICAgKFdURjo6VHJhbnNmb3JtSXRlcmF0b3I6OlRy YW5zZm9ybUl0ZXJhdG9yKTogTWFrZSBjb25zdHJ1Y3RvciB0YWtlIGFyZ3VtZW50cyBhcyBydmFs dWUgcmVmZXJlbmNlcy4KKyAgICAgICAgKFdURjo6bWFrZVRyYW5zZm9ybUl0ZXJhdG9yKTogU3Vi c3RpdHV0ZSBzdGQ6Om1vdmUoKSBmb3Igc3RkOjpmb3J3YXJkKCkuCisKIDIwMTQtMDYtMjcgIEFu ZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtBUk12N10gU2tpcCBv bmUgcGFydGljdWxhcmx5IGV4cGVuc2l2ZSBmYXN0RnJlZSgpIGFsaWdubWVudCBjaGVjay4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0l0ZXJhdG9yQWRhcHRvcnMuaCBiL1NvdXJjZS9XVEYv d3RmL0l0ZXJhdG9yQWRhcHRvcnMuaAppbmRleCBhNWVkZTExYWRiYzUyYjg2YTI3NTM0NjNiYjg1 MTAxNDU1YzMwNjQ0Li5jMmQ2NzAzOTY0ODllMGZlMDZjNTRmYWVhOWRlOTE4YTUwYjQwMmI5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9JdGVyYXRvckFkYXB0b3JzLmgKKysrIGIvU291cmNl L1dURi93dGYvSXRlcmF0b3JBZGFwdG9ycy5oCkBAIC03Nyw3ICs3Nyw3IEBAIGlubGluZSBGaWx0 ZXJJdGVyYXRvcjxQcmVkaWNhdGUsIEl0ZXJhdG9yPiBtYWtlRmlsdGVySXRlcmF0b3IoUHJlZGlj YXRlJiYgcHJlZCwKIHRlbXBsYXRlPHR5cGVuYW1lIFRyYW5zZm9ybSwgdHlwZW5hbWUgSXRlcmF0 b3I+CiBjbGFzcyBUcmFuc2Zvcm1JdGVyYXRvciB7CiBwdWJsaWM6Ci0gICAgVHJhbnNmb3JtSXRl cmF0b3IoY29uc3QgVHJhbnNmb3JtJiB0cmFuc2Zvcm0sIGNvbnN0IEl0ZXJhdG9yJiBpdGVyKQor ICAgIFRyYW5zZm9ybUl0ZXJhdG9yKFRyYW5zZm9ybSYmIHRyYW5zZm9ybSwgSXRlcmF0b3ImJiBp dGVyKQogICAgICAgICA6IG1fdHJhbnNmb3JtKHN0ZDo6bW92ZSh0cmFuc2Zvcm0pKQogICAgICAg ICAsIG1faXRlcihzdGQ6Om1vdmUoaXRlcikpCiAgICAgewpAQCAtMTA1LDcgKzEwNSw3IEBAIHBy aXZhdGU6CiB0ZW1wbGF0ZTx0eXBlbmFtZSBUcmFuc2Zvcm0sIHR5cGVuYW1lIEl0ZXJhdG9yPgog aW5saW5lIFRyYW5zZm9ybUl0ZXJhdG9yPFRyYW5zZm9ybSwgSXRlcmF0b3I+IG1ha2VUcmFuc2Zv cm1JdGVyYXRvcihUcmFuc2Zvcm0mJiB0cmFuc2Zvcm0sIEl0ZXJhdG9yJiYgaXRlcikKIHsKLSAg ICByZXR1cm4gVHJhbnNmb3JtSXRlcmF0b3I8VHJhbnNmb3JtLCBJdGVyYXRvcj4oc3RkOjpmb3J3 YXJkPFRyYW5zZm9ybT4odHJhbnNmb3JtKSwgc3RkOjpmb3J3YXJkPEl0ZXJhdG9yPihpdGVyKSk7 CisgICAgcmV0dXJuIFRyYW5zZm9ybUl0ZXJhdG9yPFRyYW5zZm9ybSwgSXRlcmF0b3I+KHN0ZDo6 bW92ZSh0cmFuc2Zvcm0pLCBzdGQ6Om1vdmUoaXRlcikpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBX VEYK