134467 2014-06-30 16:14:08 -0700 WebBackForwardListItems should hold on to PageState objects 2014-06-30 16:27:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1019454 0 andersca 2014-06-30 16:14:08 -0700 WebBackForwardListItems should hold on to PageState objects 1019455 1 234111 andersca 2014-06-30 16:14:25 -0700 Created attachment 234111 Patch 1019459 2 234111 darin 2014-06-30 16:19:42 -0700 Comment on attachment 234111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review OK > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41 > + m_pageState.mainFrameState.originalURLString = originalURL; > + m_pageState.mainFrameState.urlString = url; > + m_pageState.title = title; No constructor for PageState? Is it just a struct? > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69 > + encoder << m_pageState.mainFrameState.originalURLString; > + encoder << m_pageState.mainFrameState.urlString; > + encoder << m_pageState.title; No helper function for pageState? Doesn’t have to be a member function. 1019461 3 andersca 2014-06-30 16:23:54 -0700 (In reply to comment #2) > (From update of attachment 234111 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review > > OK > > > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41 > > + m_pageState.mainFrameState.originalURLString = originalURL; > > + m_pageState.mainFrameState.urlString = url; > > + m_pageState.title = title; > > No constructor for PageState? Is it just a struct? Yes. > > > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69 > > + encoder << m_pageState.mainFrameState.originalURLString; > > + encoder << m_pageState.mainFrameState.urlString; > > + encoder << m_pageState.title; > > No helper function for pageState? Doesn’t have to be a member function. This is just temporary - we don't want to encode and decode WebBackForwardListItems. 1019462 4 andersca 2014-06-30 16:27:04 -0700 Committed r170613: <http://trac.webkit.org/changeset/170613> 234111 2014-06-30 16:14:25 -0700 2014-06-30 16:19:42 -0700 Patch bug-134467-20140630161406.patch text/plain 4638 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQ3MzZlZDM0ZDAyNTVi NGYxZWMwZDg4ZGZjYzVlZjYyNGJlODFlYi4uN2FhNTFkZGI5MzFlYTljODFlNjkwYmM3MTk2NGIw ZWNmOWU3ZjhlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE0LTA2LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViQmFja0Zvcndh cmRMaXN0SXRlbXMgc2hvdWxkIGhvbGQgb24gdG8gUGFnZVN0YXRlIG9iamVjdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQ2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1dlYkJhY2tG b3J3YXJkTGlzdEl0ZW0uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3RJ dGVtOjpXZWJCYWNrRm9yd2FyZExpc3RJdGVtKToKKyAgICAgICAgKFdlYktpdDo6V2ViQmFja0Zv cndhcmRMaXN0SXRlbTo6ZW5jb2RlKToKKyAgICAgICAgKiBTaGFyZWQvV2ViQmFja0ZvcndhcmRM aXN0SXRlbS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3RJdGVtOjpzZXRP cmlnaW5hbFVSTCk6CisgICAgICAgIChXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdEl0ZW06Om9y aWdpbmFsVVJMKToKKyAgICAgICAgKFdlYktpdDo6V2ViQmFja0ZvcndhcmRMaXN0SXRlbTo6c2V0 VVJMKToKKyAgICAgICAgKFdlYktpdDo6V2ViQmFja0ZvcndhcmRMaXN0SXRlbTo6dXJsKToKKyAg ICAgICAgKFdlYktpdDo6V2ViQmFja0ZvcndhcmRMaXN0SXRlbTo6c2V0VGl0bGUpOgorICAgICAg ICAoV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3RJdGVtOjp0aXRsZSk6CisKKzIwMTQtMDYtMzAg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBBZG9wdCB0 aGUgbGVnYWN5IHNlc3Npb24gZGVjb2RpbmcgaW5zaWRlIFdlYlBhZ2U6OnJlc3RvcmVTZXNzaW9u IGZvciBub3cKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNDQ2NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQmFja0Zvcndh cmRMaXN0SXRlbS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQmFja0ZvcndhcmRMaXN0 SXRlbS5jcHAKaW5kZXggNThlNTRjZTY0MmIzNDA4NjljYTk0MDcxYWMxMzkyODk5OWY1N2ZkOC4u NjU2ZTE3YmU3MzA3ZjA2ODQyNGE5NzQ3ZmZmZDlmY2NlYjU1ZWEzYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvU2hhcmVkL1dlYkJhY2tGb3J3YXJkTGlzdEl0ZW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmNwcApAQCAtMzQsMTEgKzM0 LDEyIEBAIG5hbWVzcGFjZSBXZWJLaXQgewogc3RhdGljIHVpbnQ2NF90IGhpZ2hlc3RVc2VkSXRl bUlEID0gMDsKIAogV2ViQmFja0ZvcndhcmRMaXN0SXRlbTo6V2ViQmFja0ZvcndhcmRMaXN0SXRl bShjb25zdCBTdHJpbmcmIG9yaWdpbmFsVVJMLCBjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgU3Ry aW5nJiB0aXRsZSwgY29uc3QgdWludDhfdCogYmFja0ZvcndhcmREYXRhLCBzaXplX3QgYmFja0Zv cndhcmREYXRhU2l6ZSwgdWludDY0X3QgaXRlbUlEKQotICAgIDogbV9vcmlnaW5hbFVSTChvcmln aW5hbFVSTCkKLSAgICAsIG1fdXJsKHVybCkKLSAgICAsIG1fdGl0bGUodGl0bGUpCi0gICAgLCBt X2l0ZW1JRChpdGVtSUQpCisgICAgOiBtX2l0ZW1JRChpdGVtSUQpCiB7CisgICAgbV9wYWdlU3Rh dGUubWFpbkZyYW1lU3RhdGUub3JpZ2luYWxVUkxTdHJpbmcgPSBvcmlnaW5hbFVSTDsKKyAgICBt X3BhZ2VTdGF0ZS5tYWluRnJhbWVTdGF0ZS51cmxTdHJpbmcgPSB1cmw7CisgICAgbV9wYWdlU3Rh dGUudGl0bGUgPSB0aXRsZTsKKwogICAgIGlmIChtX2l0ZW1JRCA+IGhpZ2hlc3RVc2VkSXRlbUlE KQogICAgICAgICBoaWdoZXN0VXNlZEl0ZW1JRCA9IG1faXRlbUlEOwogCkBAIC02Myw5ICs2NCw5 IEBAIHZvaWQgV2ViQmFja0ZvcndhcmRMaXN0SXRlbTo6c2V0QmFja0ZvcndhcmREYXRhKGNvbnN0 IHVpbnQ4X3QqIGRhdGEsIHNpemVfdCBzaXplCiAKIHZvaWQgV2ViQmFja0ZvcndhcmRMaXN0SXRl bTo6ZW5jb2RlKElQQzo6QXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyKSBjb25zdAogewotICAgIGVu Y29kZXIgPDwgbV9vcmlnaW5hbFVSTDsKLSAgICBlbmNvZGVyIDw8IG1fdXJsOwotICAgIGVuY29k ZXIgPDwgbV90aXRsZTsKKyAgICBlbmNvZGVyIDw8IG1fcGFnZVN0YXRlLm1haW5GcmFtZVN0YXRl Lm9yaWdpbmFsVVJMU3RyaW5nOworICAgIGVuY29kZXIgPDwgbV9wYWdlU3RhdGUubWFpbkZyYW1l U3RhdGUudXJsU3RyaW5nOworICAgIGVuY29kZXIgPDwgbV9wYWdlU3RhdGUudGl0bGU7CiAgICAg ZW5jb2RlciA8PCBtX2l0ZW1JRDsKICAgICBlbmNvZGVyIDw8IElQQzo6RGF0YVJlZmVyZW5jZSht X2JhY2tGb3J3YXJkRGF0YSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv V2ViQmFja0ZvcndhcmRMaXN0SXRlbS5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkJhY2tG b3J3YXJkTGlzdEl0ZW0uaAppbmRleCA1YWJjOTViNTRkYTgxOWEwMTljMmM0Y2Q2ZDlmN2EyYjgz NTdiYmNlLi5hMDEyNzFhNTM0MGU5ODAwMTY5ZmIzNjg1YmVlOWUzMTNlZDNhYjZkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQmFja0ZvcndhcmRMaXN0SXRlbS5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgKQEAgLTI3LDYg KzI3LDcgQEAKICNkZWZpbmUgV2ViQmFja0ZvcndhcmRMaXN0SXRlbV9oCiAKICNpbmNsdWRlICJB UElPYmplY3QuaCIKKyNpbmNsdWRlICJTZXNzaW9uU3RhdGUuaCIKICNpbmNsdWRlIDx3dGYvUGFz c1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCkBAIC00OCwxNCAr NDksMTQgQEAgcHVibGljOgogCiAgICAgdWludDY0X3QgaXRlbUlEKCkgY29uc3QgeyByZXR1cm4g bV9pdGVtSUQ7IH0KIAotICAgIHZvaWQgc2V0T3JpZ2luYWxVUkwoY29uc3QgU3RyaW5nJiBvcmln aW5hbFVSTCkgeyBtX29yaWdpbmFsVVJMID0gb3JpZ2luYWxVUkw7IH0KLSAgICBjb25zdCBTdHJp bmcmIG9yaWdpbmFsVVJMKCkgY29uc3QgeyByZXR1cm4gbV9vcmlnaW5hbFVSTDsgfQorICAgIHZv aWQgc2V0T3JpZ2luYWxVUkwoY29uc3QgU3RyaW5nJiBvcmlnaW5hbFVSTCkgeyBtX3BhZ2VTdGF0 ZS5tYWluRnJhbWVTdGF0ZS5vcmlnaW5hbFVSTFN0cmluZyA9IG9yaWdpbmFsVVJMOyB9CisgICAg Y29uc3QgU3RyaW5nJiBvcmlnaW5hbFVSTCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZVN0YXRlLm1h aW5GcmFtZVN0YXRlLm9yaWdpbmFsVVJMU3RyaW5nOyB9CiAKLSAgICB2b2lkIHNldFVSTChjb25z dCBTdHJpbmcmIHVybCkgeyBtX3VybCA9IHVybDsgfQotICAgIGNvbnN0IFN0cmluZyYgdXJsKCkg Y29uc3QgeyByZXR1cm4gbV91cmw7IH0KKyAgICB2b2lkIHNldFVSTChjb25zdCBTdHJpbmcmIHVy bCkgeyBtX3BhZ2VTdGF0ZS5tYWluRnJhbWVTdGF0ZS51cmxTdHJpbmcgPSB1cmw7IH0KKyAgICBj b25zdCBTdHJpbmcmIHVybCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZVN0YXRlLm1haW5GcmFtZVN0 YXRlLnVybFN0cmluZzsgfQogCi0gICAgdm9pZCBzZXRUaXRsZShjb25zdCBTdHJpbmcmIHRpdGxl KSB7IG1fdGl0bGUgPSB0aXRsZTsgfQotICAgIGNvbnN0IFN0cmluZyYgdGl0bGUoKSBjb25zdCB7 IHJldHVybiBtX3RpdGxlOyB9CisgICAgdm9pZCBzZXRUaXRsZShjb25zdCBTdHJpbmcmIHRpdGxl KSB7IG1fcGFnZVN0YXRlLnRpdGxlID0gdGl0bGU7IH0KKyAgICBjb25zdCBTdHJpbmcmIHRpdGxl KCkgY29uc3QgeyByZXR1cm4gbV9wYWdlU3RhdGUudGl0bGU7IH0KICAgICAKICAgICB2b2lkIHNl dEJhY2tGb3J3YXJkRGF0YShjb25zdCB1aW50OF90KiBidWZmZXIsIHNpemVfdCBzaXplKTsKICAg ICBjb25zdCBWZWN0b3I8dWludDhfdD4mIGJhY2tGb3J3YXJkRGF0YSgpIGNvbnN0IHsgcmV0dXJu IG1fYmFja0ZvcndhcmREYXRhOyB9CkBAIC03MSw5ICs3Miw3IEBAIHB1YmxpYzoKIHByaXZhdGU6 CiAgICAgV2ViQmFja0ZvcndhcmRMaXN0SXRlbShjb25zdCBTdHJpbmcmIG9yaWdpbmFsVVJMLCBj b25zdCBTdHJpbmcmIHVybCwgY29uc3QgU3RyaW5nJiB0aXRsZSwgY29uc3QgdWludDhfdCogYmFj a0ZvcndhcmREYXRhLCBzaXplX3QgYmFja0ZvcndhcmREYXRhU2l6ZSwgdWludDY0X3QgaXRlbUlE KTsKIAotICAgIFN0cmluZyBtX29yaWdpbmFsVVJMOwotICAgIFN0cmluZyBtX3VybDsKLSAgICBT dHJpbmcgbV90aXRsZTsKKyAgICBQYWdlU3RhdGUgbV9wYWdlU3RhdGU7CiAgICAgdWludDY0X3Qg bV9pdGVtSUQ7CiAgICAgVmVjdG9yPHVpbnQ4X3Q+IG1fYmFja0ZvcndhcmREYXRhOwogICAgIFN0 cmluZyBtX3NuYXBzaG90VVVJRDsK