134460 2014-06-30 14:51:06 -0700 Implement the last pieces of encodeFrameStateNode 2014-06-30 15:15:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1019405 0 andersca 2014-06-30 14:51:06 -0700 Implement the last pieces of encodeFrameStateNode 1019408 1 234098 andersca 2014-06-30 14:57:11 -0700 Created attachment 234098 Patch 1019409 2 commit-queue 2014-06-30 15:00:11 -0700 Attachment 234098 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:178: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1019418 3 andersca 2014-06-30 15:15:00 -0700 Committed r170603: <http://trac.webkit.org/changeset/170603> 234098 2014-06-30 14:57:11 -0700 2014-06-30 15:11:44 -0700 Patch bug-134460-20140630145652.patch text/plain 6452 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTlhYWFjZjhmZGM1YjUx NmVmNzM1ZmRhZGFiZDFkMGI5NGNjOGIxYS4uZTc5NWQ0YjU3ZTBkNDY0YTA4MDk3ODU3OWMwNDYx YzMyYzRmMjk5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA2LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgSW1wbGVtZW50IHRo ZSBsYXN0IHBpZWNlcyBvZiBlbmNvZGVGcmFtZVN0YXRlTm9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NDYwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL0xlZ2FjeVNlc3Np b25TdGF0ZUNvZGluZy5jcHA6CisgICAgICAgIChXZWJLaXQ6Okhpc3RvcnlFbnRyeURhdGFFbmNv ZGVyOjpvcGVyYXRvcjw8KToKKyAgICAgICAgKFdlYktpdDo6aXNWYWxpZEVudW0pOgorICAgICAg ICAoV2ViS2l0OjplbmNvZGVGb3JtRGF0YUVsZW1lbnQpOgorICAgICAgICAoV2ViS2l0OjplbmNv ZGVGb3JtRGF0YSk6CisgICAgICAgIChXZWJLaXQ6OmVuY29kZUZyYW1lU3RhdGVOb2RlKToKKwor MjAxNC0wNi0zMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAg ICAgIEFkZCBjb2RlIGZvciBlbmNvZGluZyBsZWdhY3kgc2Vzc2lvbiBoaXN0b3J5IGVudHJpZXMK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQ1Mgog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0xlZ2FjeVNlc3Npb25T dGF0ZUNvZGluZy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0xlZ2FjeVNlc3Np b25TdGF0ZUNvZGluZy5jcHAKaW5kZXggOTRkMGQ1YzE1NWI4NTY1YjM1MWJjZDUxOGIzMjA5OTZl ZDlhMWNkYy4uZjFiMDBhNmQ2OWNlMzFlZTZiODk0NWM3NWVlZjY1MzQ5NDdiMDI1MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9MZWdhY3lTZXNzaW9uU3RhdGVDb2Rp bmcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvTGVnYWN5U2Vzc2lvblN0 YXRlQ29kaW5nLmNwcApAQCAtMTE5LDYgKzExOSwyMiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVy biAqdGhpczsKICAgICB9CiAKKyAgICBIaXN0b3J5RW50cnlEYXRhRW5jb2RlciYgb3BlcmF0b3I8 PChjb25zdCBWZWN0b3I8dWludDhfdD4mIHZhbHVlKQorICAgIHsKKyAgICAgICAgKnRoaXMgPDwg c3RhdGljX2Nhc3Q8dWludDY0X3Q+KHZhbHVlLnNpemUoKSk7CisgICAgICAgIGVuY29kZUZpeGVk TGVuZ3RoRGF0YSh2YWx1ZS5kYXRhKCksIHZhbHVlLnNpemUoKSwgMSk7CisKKyAgICAgICAgcmV0 dXJuICp0aGlzOworICAgIH0KKworICAgIEhpc3RvcnlFbnRyeURhdGFFbmNvZGVyJiBvcGVyYXRv cjw8KGNvbnN0IFZlY3RvcjxjaGFyPiYgdmFsdWUpCisgICAgeworICAgICAgICAqdGhpcyA8PCBz dGF0aWNfY2FzdDx1aW50NjRfdD4odmFsdWUuc2l6ZSgpKTsKKyAgICAgICAgZW5jb2RlRml4ZWRM ZW5ndGhEYXRhKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHZhbHVlLmRhdGEoKSks IHZhbHVlLnNpemUoKSwgMSk7CisKKyAgICAgICAgcmV0dXJuICp0aGlzOworICAgIH0KKwogI2lm IFBMQVRGT1JNKElPUykKICAgICBIaXN0b3J5RW50cnlEYXRhRW5jb2RlciYgb3BlcmF0b3I8PChX ZWJDb3JlOjpGbG9hdFJlY3QgdmFsdWUpCiAgICAgewpAQCAtMTU3LDYgKzE3MywxMiBAQCBwdWJs aWM6CiAgICAgfQogI2VuZGlmCiAKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgorICAgIGF1dG8g b3BlcmF0b3I8PChUIHZhbHVlKSAtPiB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX2Vu dW08VD46OnZhbHVlLCBIaXN0b3J5RW50cnlEYXRhRW5jb2RlciY+Ojp0eXBlCisgICAgeworICAg ICAgICByZXR1cm4gKnRoaXMgPDwgc3RhdGljX2Nhc3Q8dWludDMyX3Q+KHZhbHVlKTsKKyAgICB9 CisKICAgICBNYWxsb2NQdHI8dWludDhfdD4gZmluaXNoRW5jb2Rpbmcoc2l6ZV90JiBzaXplKQog ICAgIHsKICAgICAgICAgc2l6ZSA9IG1fYnVmZmVyU2l6ZTsKQEAgLTIxMiwyOSArMjM0LDk4IEBA IHByaXZhdGU6CiAgICAgdWludDhfdCogbV9idWZmZXJQb2ludGVyOwogfTsKIAorZW51bSBjbGFz cyBGb3JtRGF0YUVsZW1lbnRUeXBlIHsKKyAgICBEYXRhID0gMCwKKyAgICBFbmNvZGVkRmlsZSA9 IDEsCisgICAgRW5jb2RlZEJsb2IgPSAyLAorfTsKKworc3RhdGljIGJvb2wgaXNWYWxpZEVudW0o Rm9ybURhdGFFbGVtZW50VHlwZSB0eXBlKQoreworICAgIHN3aXRjaCAodHlwZSkgeworICAgIGNh c2UgRm9ybURhdGFFbGVtZW50VHlwZTo6RGF0YToKKyAgICBjYXNlIEZvcm1EYXRhRWxlbWVudFR5 cGU6OkVuY29kZWRGaWxlOgorICAgIGNhc2UgRm9ybURhdGFFbGVtZW50VHlwZTo6RW5jb2RlZEJs b2I6CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgIHJldHVybiBmYWxzZTsKK30K Kworc3RhdGljIHZvaWQgZW5jb2RlRm9ybURhdGFFbGVtZW50KEhpc3RvcnlFbnRyeURhdGFFbmNv ZGVyJiBlbmNvZGVyLCBjb25zdCBIVFRQQm9keTo6RWxlbWVudCYgZWxlbWVudCkKK3sKKyAgICBz d2l0Y2ggKGVsZW1lbnQudHlwZSkgeworICAgIGNhc2UgSFRUUEJvZHk6OkVsZW1lbnQ6OlR5cGU6 OkRhdGE6CisgICAgICAgIGVuY29kZXIgPDwgRm9ybURhdGFFbGVtZW50VHlwZTo6RGF0YTsKKyAg ICAgICAgZW5jb2RlciA8PCBlbGVtZW50LmRhdGE7CisgICAgICAgIGJyZWFrOworCisgICAgY2Fz ZSBIVFRQQm9keTo6RWxlbWVudDo6VHlwZTo6RmlsZToKKyAgICAgICAgZW5jb2RlciA8PCBGb3Jt RGF0YUVsZW1lbnRUeXBlOjpFbmNvZGVkRmlsZTsKKyAgICAgICAgZW5jb2RlciA8PCBlbGVtZW50 LmZpbGVQYXRoOworCisgICAgICAgIC8vIFVzZWQgdG8gYmUgZ2VuZXJhdGVkRmlsZW5hbWUuCisg ICAgICAgIGVuY29kZXIgPDwgU3RyaW5nKCk7CisKKyAgICAgICAgLy8gVXNlZCB0byBiZSBzaG91 bGRHZW5lcmF0ZUZpbGUuCisgICAgICAgIGVuY29kZXIgPDwgZmFsc2U7CisKKyAgICAgICAgZW5j b2RlciA8PCBlbGVtZW50LmZpbGVTdGFydDsKKyAgICAgICAgZW5jb2RlciA8PCBlbGVtZW50LmZp bGVMZW5ndGgudmFsdWVPcigtMSk7CisgICAgICAgIGVuY29kZXIgPDwgZWxlbWVudC5leHBlY3Rl ZEZpbGVNb2RpZmljYXRpb25UaW1lLnZhbHVlT3Ioc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+ OjpxdWlldF9OYU4oKSk7CisgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBIVFRQQm9keTo6RWxl bWVudDo6VHlwZTo6QmxvYjoKKyAgICAgICAgZW5jb2RlciA8PCBGb3JtRGF0YUVsZW1lbnRUeXBl OjpFbmNvZGVkQmxvYjsKKyAgICAgICAgZW5jb2RlciA8PCBlbGVtZW50LmJsb2JVUkxTdHJpbmc7 CisgICAgICAgIGJyZWFrOworICAgIH0KK30KKworc3RhdGljIHZvaWQgZW5jb2RlRm9ybURhdGEo SGlzdG9yeUVudHJ5RGF0YUVuY29kZXImIGVuY29kZXIsIGNvbnN0IEhUVFBCb2R5JiBmb3JtRGF0 YSkKK3sKKyAgICAvLyBVc2VkIHRvIGJlIGFsd2F5c1N0cmVhbS4KKyAgICBlbmNvZGVyIDw8IGZh bHNlOworCisgICAgLy8gVXNlZCB0byBiZSBib3VuZGFyeS4KKyAgICBlbmNvZGVyIDw8IFZlY3Rv cjx1aW50OF90PigpOworCisgICAgZW5jb2RlciA8PCBzdGF0aWNfY2FzdDx1aW50NjRfdD4oZm9y bURhdGEuZWxlbWVudHMuc2l6ZSgpKTsKKyAgICBmb3IgKGNvbnN0IGF1dG8mIGVsZW1lbnQgOiBm b3JtRGF0YS5lbGVtZW50cykKKyAgICAgICAgZW5jb2RlRm9ybURhdGFFbGVtZW50KGVuY29kZXIs IGVsZW1lbnQpOworCisgICAgLy8gVXNlZCB0byBiZSBoYXNHZW5lcmF0ZWRGaWxlcy4KKyAgICBl bmNvZGVyIDw8IGZhbHNlOworCisgICAgLy8gVXNlZCB0byBiZSBpZGVudGlmaWVyLgorICAgIGVu Y29kZXIgPDwgc3RhdGljX2Nhc3Q8aW50NjRfdD4oMCk7Cit9CisKIHN0YXRpYyB2b2lkIGVuY29k ZUZyYW1lU3RhdGVOb2RlKEhpc3RvcnlFbnRyeURhdGFFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBG cmFtZVN0YXRlJiBmcmFtZVN0YXRlKQogewogICAgIGVuY29kZXIgPDwgc3RhdGljX2Nhc3Q8dWlu dDY0X3Q+KGZyYW1lU3RhdGUuY2hpbGRyZW4uc2l6ZSgpKTsKIAogICAgIGZvciAoY29uc3QgYXV0 byYgY2hpbGRGcmFtZVN0YXRlIDogZnJhbWVTdGF0ZS5jaGlsZHJlbikgewotICAgICAgICAvLyBG SVhNRTogSW1wbGVtZW50LgotICAgICAgICAodm9pZCljaGlsZEZyYW1lU3RhdGU7Ci0gICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBlbmNvZGVyIDw8IGNoaWxkRnJhbWVTdGF0 ZS5vcmlnaW5hbFVSTFN0cmluZzsKKyAgICAgICAgZW5jb2RlciA8PCBjaGlsZEZyYW1lU3RhdGUu dXJsU3RyaW5nOworCisgICAgICAgIGVuY29kZUZyYW1lU3RhdGVOb2RlKGVuY29kZXIsIGNoaWxk RnJhbWVTdGF0ZSk7CiAgICAgfQogCiAgICAgZW5jb2RlciA8PCBmcmFtZVN0YXRlLmRvY3VtZW50 U2VxdWVuY2VOdW1iZXI7CiAKICAgICBlbmNvZGVyIDw8IHN0YXRpY19jYXN0PHVpbnQ2NF90Pihm cmFtZVN0YXRlLmRvY3VtZW50U3RhdGUuc2l6ZSgpKTsKLSAgICBmb3IgKGNvbnN0IGF1dG8mIGRv Y3VtZW50U3RhdGUgOiBmcmFtZVN0YXRlLmRvY3VtZW50U3RhdGUpIHsKLSAgICAgICAgLy8gRklY TUU6IEltcGxlbWVudC4KLSAgICAgICAgKHZvaWQpZG9jdW1lbnRTdGF0ZTsKLSAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgfQorICAgIGZvciAoY29uc3QgYXV0byYgZG9jdW1lbnRT dGF0ZSA6IGZyYW1lU3RhdGUuZG9jdW1lbnRTdGF0ZSkKKyAgICAgICAgZW5jb2RlciA8PCBkb2N1 bWVudFN0YXRlOwogCi0gICAgZW5jb2RlciA8PCAhIWZyYW1lU3RhdGUuaHR0cEJvZHk7CiAgICAg aWYgKGZyYW1lU3RhdGUuaHR0cEJvZHkpIHsKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVudC4K LSAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGVuY29kZXIgPDwgZnJhbWVT dGF0ZS5odHRwQm9keS52YWx1ZSgpLmNvbnRlbnRUeXBlOworICAgICAgICBlbmNvZGVyIDw8IHRy dWU7CisKKyAgICAgICAgZW5jb2RlRm9ybURhdGEoZW5jb2RlciwgZnJhbWVTdGF0ZS5odHRwQm9k eS52YWx1ZSgpKTsKKyAgICB9IGVsc2UgeworICAgICAgICBlbmNvZGVyIDw8IFN0cmluZygpOwor ICAgICAgICBlbmNvZGVyIDw8IGZhbHNlOwogICAgIH0KIAogICAgIGVuY29kZXIgPDwgZnJhbWVT dGF0ZS5pdGVtU2VxdWVuY2VOdW1iZXI7CkBAIC0yNDcsMTAgKzMzOCw4IEBAIHN0YXRpYyB2b2lk IGVuY29kZUZyYW1lU3RhdGVOb2RlKEhpc3RvcnlFbnRyeURhdGFFbmNvZGVyJiBlbmNvZGVyLCBj b25zdCBGcmFtZVN0CiAgICAgZW5jb2RlciA8PCBmcmFtZVN0YXRlLnBhZ2VTY2FsZUZhY3RvcjsK IAogICAgIGVuY29kZXIgPDwgISFmcmFtZVN0YXRlLnN0YXRlT2JqZWN0RGF0YTsKLSAgICBpZiAo ZnJhbWVTdGF0ZS5zdGF0ZU9iamVjdERhdGEpIHsKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVu dC4KLSAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgfQorICAgIGlmIChmcmFtZVN0 YXRlLnN0YXRlT2JqZWN0RGF0YSkKKyAgICAgICAgZW5jb2RlciA8PCBmcmFtZVN0YXRlLnN0YXRl T2JqZWN0RGF0YS52YWx1ZSgpOwogCiAgICAgZW5jb2RlciA8PCBmcmFtZVN0YXRlLnRhcmdldDsK IApAQCAtNTUzLDI0ICs2NDIsNiBAQCBwcml2YXRlOgogICAgIGNvbnN0IHVpbnQ4X3QqIG1fYnVm ZmVyRW5kOwogfTsKIAotZW51bSBjbGFzcyBGb3JtRGF0YUVsZW1lbnRUeXBlIHsKLSAgICBEYXRh ID0gMCwKLSAgICBFbmNvZGVkRmlsZSA9IDEsCi0gICAgRW5jb2RlZEJsb2IgPSAyLAotfTsKLQot c3RhdGljIGJvb2wgaXNWYWxpZEVudW0oRm9ybURhdGFFbGVtZW50VHlwZSB0eXBlKQotewotICAg IHN3aXRjaCAodHlwZSkgewotICAgIGNhc2UgRm9ybURhdGFFbGVtZW50VHlwZTo6RGF0YToKLSAg ICBjYXNlIEZvcm1EYXRhRWxlbWVudFR5cGU6OkVuY29kZWRGaWxlOgotICAgIGNhc2UgRm9ybURh dGFFbGVtZW50VHlwZTo6RW5jb2RlZEJsb2I6Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0K LQotICAgIHJldHVybiBmYWxzZTsKLX0KLQogc3RhdGljIHZvaWQgZGVjb2RlRm9ybURhdGFFbGVt ZW50KEhpc3RvcnlFbnRyeURhdGFEZWNvZGVyJiBkZWNvZGVyLCBIVFRQQm9keTo6RWxlbWVudCYg Zm9ybURhdGFFbGVtZW50KQogewogICAgIE9wdGlvbmFsPEZvcm1EYXRhRWxlbWVudFR5cGU+IGVs ZW1lbnRUeXBlOwo=