134455 2014-06-30 14:24:54 -0700 CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences 2014-06-30 15:22:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg bunhere cdumez commit-queue fpizlo gyuyoung.kim sergio oldest_to_newest 1019393 0 mhahnenberg 2014-06-30 14:24:54 -0700 Otherwise we get hanging pointers which can cause us to die later. 1019394 1 234093 mhahnenberg 2014-06-30 14:26:52 -0700 Created attachment 234093 Patch 1019397 2 234093 ggaren 2014-06-30 14:34:17 -0700 Comment on attachment 234093 Patch r=me Any way to regression test this? Maybe even something that only crashes in Zombie mode? 1019406 3 mhahnenberg 2014-06-30 14:51:52 -0700 (In reply to comment #2) > (From update of attachment 234093 [details]) > r=me > > Any way to regression test this? Maybe even something that only crashes in Zombie mode? It was a pre-existing regression test that caught this, so I think we're ok. 1019421 4 mhahnenberg 2014-06-30 15:22:59 -0700 Committed r170604: <http://trac.webkit.org/changeset/170604> 234093 2014-06-30 14:26:52 -0700 2014-06-30 14:34:16 -0700 Patch bug-134455-20140630142632.patch text/plain 1378 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcwNTk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA2LTMwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29kZUJsb2NrOjpzdHJvbmdseVZpc2l0V2Vha1JlZmVyZW5jZXMgc2hvdWxkIG1h cmsgREZHOjpDb21tb25EYXRhOjp3ZWFrU3RydWN0dXJlUmVmZXJlbmNlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NDU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3RoZXJ3aXNlIHdlIGdldCBoYW5n aW5nIHBvaW50ZXJzIHdoaWNoIGNhbiBjYXVzZSB1cyB0byBkaWUgbGF0ZXIuCisKKyAgICAgICAg KiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OnN0cm9u Z2x5VmlzaXRXZWFrUmVmZXJlbmNlcyk6CisKIDIwMTQtMDYtMjcgIEZpbGlwIFBpemxvICA8ZnBp emxvQGFwcGxlLmNvbT4KIAogICAgICAgICBbZnRsb3B0XSBSZWR1Y2UgdGhlIEdDJ3MgaW5mbHVl bmNlIG9uIG9wdGltaXphdGlvbiBkZWNpc2lvbnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAxNzA1OTUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjY5MSw2ICsyNjkxLDkgQEAgdm9pZCBDb2RlQmxvY2s6OnN0cm9uZ2x5VmlzaXRXZWFrUmVmZXJl bgogICAgIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBkZmdDb21tb24tPndlYWtSZWZl cmVuY2VzLnNpemUoKTsgKytpKQogICAgICAgICB2aXNpdG9yLmFwcGVuZCgmZGZnQ29tbW9uLT53 ZWFrUmVmZXJlbmNlc1tpXSk7CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZGZnQ29t bW9uLT53ZWFrU3RydWN0dXJlUmVmZXJlbmNlcy5zaXplKCk7ICsraSkKKyAgICAgICAgdmlzaXRv ci5hcHBlbmQoJmRmZ0NvbW1vbi0+d2Vha1N0cnVjdHVyZVJlZmVyZW5jZXNbaV0pOwogI2VuZGlm ICAgIAogfQogCg==