134453 2014-06-30 14:02:06 -0700 Add encodeInteger and decodeInteger for remote object encoder and decoder. 2014-07-01 10:15:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca bunhere cdumez commit-queue gyuyoung.kim mitz sam sergio oldest_to_newest 1019385 0 yongjun_zhang 2014-06-30 14:02:06 -0700 In 64bit system, encodeInteger/decodeInteger is by default mapped into encodeInt64/decodeInt64. For 32bit system, they are mapped to encodeInt32/decodeInt32. However, since we don't have encodeInt32/decodeInt32 implementation in WKRemoteObjectCoder, we could hit crash in 32bit systems. 1019389 1 234091 yongjun_zhang 2014-06-30 14:08:51 -0700 Created attachment 234091 Patch. 1019391 2 yongjun_zhang 2014-06-30 14:14:51 -0700 <rdar://problem/16964074> 1019650 3 234091 commit-queue 2014-07-01 10:15:01 -0700 Comment on attachment 234091 Patch. Clearing flags on attachment: 234091 Committed r170645: <http://trac.webkit.org/changeset/170645> 1019651 4 commit-queue 2014-07-01 10:15:05 -0700 All reviewed patches have been landed. Closing bug. 234091 2014-06-30 14:08:51 -0700 2014-07-01 10:15:01 -0700 Patch. 32bit_encoder_nsinteger.patch text/plain 2973 yongjun_zhang Y29tbWl0IDFiM2E3MzA0YTMwNjBkYTU0Yjk4ODcxYTg4MzNhNjI2Nzk2ZjI2YTYKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSnVuIDMw IDEzOjA2OjQ0IDIwMTQgLTA3MDAKCiAgICBBZGQgZW5jb2RlSW50ZWdlciBhbmQgZGVjb2RlSW50 ZWdlciBmb3IgcmVtb3RlIG9iamVjdCBlbmNvZGVyIGFuZCBkZWNvZGVyLgogICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQ1MwogICAgCiAgICBJbiA2NC1iaXQg c3lzdGVtLCBlbmNvZGVJbnRlZ2VyL2RlY29kZUludGVnZXIgaXMgYnkgZGVmYXVsdCBtYXBwZWQg aW50byBlbmNvZGVJbnQ2NC9kZWNvZGVJbnQ2NC4gIEZvcgogICAgMzItYml0IHN5c3RlbSwgdGhl eSBhcmUgbWFwcGVkIHRvIGVuY29kZUludDMyL2RlY29kZUludDMyLiAgSG93ZXZlciwgc2luY2Ug d2UgZG9uJ3QgaGF2ZSBlbmNvZGVJbnQzMi9kZWNvZGVJbnQzMgogICAgaW1wbGVtZW50YXRpb24g aW4gV0tSZW1vdGVPYmplY3RDb2Rlciwgd2UgY291bGQgaGl0IGNyYXNoIGluIDMyLWJpdCBzeXN0 ZW1zLgogICAgCiAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbToK ICAgICgtW1dLUmVtb3RlT2JqZWN0RW5jb2RlciBlbmNvZGVJbnRlZ2VyOmZvcktleTpdKTogSW5z dGVhZCBvZiBjcmVhdGluZyBhIG5ldyBudW1iZXIgdHlwZSBVSW50MzIsIHVzZSBlbmNvZGVJbnQ2 NCBmb3IKICAgICAgICBlbmNvZGluZyBOU0ludGVnZXIuCiAgICAoLVtXS1JlbW90ZU9iamVjdERl Y29kZXIgZGVjb2RlSW50ZWdlckZvcktleTpdKToKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWY1NjI5Ny4uMGFl ZjIwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA2LTMwICBZb25nanVuIFpo YW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGVuY29kZUludGVn ZXIgYW5kIGRlY29kZUludGVnZXIgZm9yIHJlbW90ZSBvYmplY3QgZW5jb2RlciBhbmQgZGVjb2Rl ci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQ1 MworCisgICAgICAgIEluIDY0Yml0IHN5c3RlbSwgZW5jb2RlSW50ZWdlci9kZWNvZGVJbnRlZ2Vy IGlzIGJ5IGRlZmF1bHQgbWFwcGVkIGludG8gZW5jb2RlSW50NjQvZGVjb2RlSW50NjQuICBGb3IK KyAgICAgICAgMzJiaXQgc3lzdGVtLCB0aGV5IGFyZSBtYXBwZWQgdG8gZW5jb2RlSW50MzIvZGVj b2RlSW50MzIuICBIb3dldmVyLCBzaW5jZSB3ZSBkb24ndCBoYXZlIGVuY29kZUludDMyL2RlY29k ZUludDMyCisgICAgICAgIGltcGxlbWVudGF0aW9uIGluIFdLUmVtb3RlT2JqZWN0Q29kZXIsIHdl IGNvdWxkIGhpdCBjcmFzaCBpbiAzMmJpdCBzeXN0ZW1zLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9i amVjdENvZGVyLm1tOgorICAgICAgICAoLVtXS1JlbW90ZU9iamVjdEVuY29kZXIgZW5jb2RlSW50 ZWdlcjpmb3JLZXk6XSk6IEluc3RlYWQgb2YgY3JlYXRpbmcgYSBuZXcgbnVtYmVyIHR5cGUgVUlu dDMyLCB1c2UgZW5jb2RlSW50NjQgZm9yCisgICAgICAgICAgICBlbmNvZGluZyBOU0ludGVnZXIu CisgICAgICAgICgtW1dLUmVtb3RlT2JqZWN0RGVjb2RlciBkZWNvZGVJbnRlZ2VyRm9yS2V5Ol0p OgorCiAyMDE0LTA2LTI5ICBZb2F2IFdlaXNzICA8eW9hdkB5b2F2LndzPgogCiAgICAgICAgIEFk ZCBzdXBwb3J0IGZvciBIVE1MSW1hZ2VFbGVtZW50J3Mgc2l6ZXMgYXR0cmlidXRlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIu bW0KaW5kZXggNTA3MTdiMi4uNzc1ZGFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQpAQCAtMjk1LDYgKzI5NSwx MSBAQCBzdGF0aWMgTlNTdHJpbmcgKmVzY2FwZUtleShOU1N0cmluZyAqa2V5KQogICAgIF9jdXJy ZW50RGljdGlvbmFyeS0+c2V0KGVzY2FwZUtleShrZXkpLCBBUEk6OlVJbnQ2NDo6Y3JlYXRlKHZh bHVlKSk7CiB9CiAKKy0gKHZvaWQpZW5jb2RlSW50ZWdlcjooTlNJbnRlZ2VyKWludHYgZm9yS2V5 OihOU1N0cmluZyAqKWtleQoreworICAgIHJldHVybiBbc2VsZiBlbmNvZGVJbnQ2NDppbnR2IGZv cktleTprZXldOworfQorCiAtICh2b2lkKWVuY29kZURvdWJsZTooZG91YmxlKXZhbHVlIGZvcktl eTooTlNTdHJpbmcgKilrZXkKIHsKICAgICBfY3VycmVudERpY3Rpb25hcnktPnNldChlc2NhcGVL ZXkoa2V5KSwgQVBJOjpEb3VibGU6OmNyZWF0ZSh2YWx1ZSkpOwpAQCAtNTc1LDYgKzU4MCwxMSBA QCBzdGF0aWMgaWQgZGVjb2RlT2JqZWN0KFdLUmVtb3RlT2JqZWN0RGVjb2RlciAqZGVjb2Rlciwg Y29uc3QgSW1tdXRhYmxlRGljdGlvbmFyeQogICAgIHJldHVybiB2YWx1ZS0+dmFsdWUoKTsKIH0K IAorLSAoTlNJbnRlZ2VyKWRlY29kZUludGVnZXJGb3JLZXk6KE5TU3RyaW5nICopa2V5Cit7Cisg ICAgcmV0dXJuIFtzZWxmIGRlY29kZUludDY0Rm9yS2V5OmtleV07Cit9CisKIC0gKGRvdWJsZSlk ZWNvZGVEb3VibGVGb3JLZXk6KE5TU3RyaW5nICopa2V5CiB7CiAgICAgY29uc3QgQVBJOjpEb3Vi bGUqIHZhbHVlID0gX2N1cnJlbnREaWN0aW9uYXJ5LT5nZXQ8QVBJOjpEb3VibGU+KGVzY2FwZUtl eShrZXkpKTsK