<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>13444</bug_id>
          
          <creation_ts>2007-04-22 01:42:15 -0700</creation_ts>
          <short_desc>REGRESSION: &quot;No parent frame&quot; error messages during layout tests</short_desc>
          <delta_ts>2007-07-15 23:34:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>beidson</cc>
    
    <cc>mbritto</cc>
    
    <cc>sroret</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>13315</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2007-04-22 01:42:15 -0700</bug_when>
    <thetext>I haven&apos;t investigated these.

fast/dom/Window ..........ERROR: No parent frame in transitionToCommitted:, FrameLoadTypeInternal
(/Users/ap/WebKit/WebCore/loader/FrameLoader.cpp:4054 updateHistoryForInternalLoad)
.....ERROR: No parent frame in transitionToCommitted:, FrameLoadTypeInternal
(/Users/ap/WebKit/WebCore/loader/FrameLoader.cpp:4054 updateHistoryForInternalLoad)
.ERROR: No parent frame in transitionToCommitted:, FrameLoadTypeInternal
(/Users/ap/WebKit/WebCore/loader/FrameLoader.cpp:4054 updateHistoryForInternalLoad)
..ERROR: No parent frame in transitionToCommitted:, FrameLoadTypeInternal
(/Users/ap/WebKit/WebCore/loader/FrameLoader.cpp:4054 updateHistoryForInternalLoad)
.....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13185</commentid>
    <comment_count>1</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-04-23 08:40:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/5153031&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>11808</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2007-04-29 11:05:31 -0700</bug_when>
    <thetext>*** Bug 13330 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>7951</commentid>
    <comment_count>3</comment_count>
    <who name="Maxime BRITTO">mbritto</who>
    <bug_when>2007-06-11 07:25:14 -0700</bug_when>
    <thetext>The layout test affected by theses logs is setting-properties-on-closed-window.html which :
    1 -  creates a variable (w) and give it a new page : w = open(&apos;about:blank&apos;);
    2 -  closes this page : w.close();
    3 -  try to access the variable to test if it crashes : w.status = i;

At step 1 : the webcore handle the loading as a FrameLoadTypeStandard an there is no problem.
At step 3 : the webcore loads the formely closed page as a FrameLoadTypeInternal an when it&apos;s trying to update history for internal loads the error is logged.

I don&apos;t know why it is forbidden to load an empty page internaly. There is a comment in the code (just before the log expression) which is mentionning the bug 3556159 (rdar?) as a justification.

I tried to replace the about:blank by http://www.google.fr in the setting-properties-on-closed-window.html and it works fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>7841</commentid>
    <comment_count>4</comment_count>
    <who name="Maxime BRITTO">mbritto</who>
    <bug_when>2007-06-12 06:50:41 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; I don&apos;t know why it is forbidden to load an empty page internaly. There is a
&gt; comment in the code (just before the log expression) which is mentionning the
&gt; bug 3556159 (rdar?) as a justification.
&gt; 
&gt; I tried to replace the about:blank by http://www.google.fr in the
&gt; setting-properties-on-closed-window.html and it works fine.
&gt; 
I came back on this and I discovered that the frame loaded Internaly with no parent is not necessarily empty. 
The comment in the code was relative to frame based web pages as sub-frame loading was the only user of FrameLoadTypeInternal. But JS uses it when it reloads a page to access a variable (like in the test)

There is still one problem : this rdar bug number in the code comments.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>4654</commentid>
    <comment_count>5</comment_count>
    <who name="">mitz</who>
    <bug_when>2007-07-15 23:34:33 -0700</bug_when>
    <thetext>Fixed in &lt;http://trac.webkit.org/projects/webkit/changeset/24299&gt;.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>