134437 2014-06-29 13:14:59 -0700 No need to lazily initialize ResourceResponse internals when accessing timing data. 2014-06-30 07:28:57 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 1 kling kling bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1019254 0 kling 2014-06-29 13:14:59 -0700 <rdar://problem/17499876> 1019255 1 234062 kling 2014-06-29 13:15:48 -0700 Created attachment 234062 Patch 1019259 2 234062 commit-queue 2014-06-29 14:51:29 -0700 Comment on attachment 234062 Patch Clearing flags on attachment: 234062 Committed r170575: <http://trac.webkit.org/changeset/170575> 1019260 3 commit-queue 2014-06-29 14:51:33 -0700 All reviewed patches have been landed. Closing bug. 1019321 4 234062 darin 2014-06-30 07:28:57 -0700 Comment on attachment 234062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234062&action=review > Source/WebCore/platform/network/ResourceResponseBase.h:120 > + ResourceLoadTiming& resourceLoadTiming() const { return m_resourceLoadTiming; } I would have expected the return value to be const& rather than just &. 234062 2014-06-29 13:15:48 -0700 2014-06-30 07:28:57 -0700 Patch bug-134437.diff text/plain 4114 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2Njk2N2I5Li4yMTliMjQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTQtMDYtMjkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIE5vIG5lZWQgdG8gbGF6aWx5IGluaXRpYWxpemUgUmVzb3VyY2VSZXNwb25zZSBpbnRlcm5h bHMgd2hlbiBhY2Nlc3NpbmcgdGltaW5nIGRhdGEuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMzQ0Mzc+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzQ5OTg3Nj4KKworICAgICAg ICBXaGVuIGJ1aWxkaW5nIHdpdGggRU5BQkxFKFdFQl9USU1JTkcpLCB0aGUgbGFzdCB0aGluZyB0 aGF0IHdvdWxkIGhhcHBlbiB3aGVuCisgICAgICAgIHNlcmlhbGl6aW5nIGEgUmVzb3VyY2VSZXNw b25zZSBpbiB0aGUgbmV0d29yayBwcm9jZXNzIGlzIHRoYXQgd2UnZCByZXRyaWV2ZQorICAgICAg ICB0aGUgUmVzb3VyY2VMb2FkVGltaW5nIHRvIGVuY29kZSBpdCBhcyBwYXJ0IG9mIHRoZSByZXNw b25zZS4gRG9pbmcgc28gd291bGQKKyAgICAgICAgdHJpZ2dlciB0aGUgbGF6eSBpbnN0YW50aWF0 aW9uIG9mIFJlc291cmNlUmVzcG9uc2UncyBpbnRlcm5hbCBkYXRhIHN0cnVjdHVyZXMuCisKKyAg ICAgICAgU2luY2UgdGltaW5nIGRhdGEgaXMgbm90IGFjdHVhbGx5IGxhemlseSBpbnN0YW50aWF0 ZWQsIHdlIGNhbiBqdXN0IG5vdCBkbyB0aGF0LgorCisgICAgICAgIFRoaXMgc2hhdmVzIG9mZiB+ NTUwbXMgb2YgbmV0d29yayBwcm9jZXNzIG1haW4gdGhyZWFkIHRpbWUgb24gUExULCByZWR1Y2lu ZworICAgICAgICByZXNwb25zZSBsYXRlbmN5IGJ5IG5vdCBkb2luZyB1bm5lY2Vzc2FyeSBzdHVm ZiBiZWZvcmUgbGV0dGluZyB0aGUgd2ViIHByb2Nlc3MKKyAgICAgICAgbG9vayBhdCB0aGUgZG93 bmxvYWRlZCBkYXRhLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViQ29yZS5leHAuaW46CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9SZXNv dXJjZVJlc3BvbnNlQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNl QmFzZTo6YWRvcHQpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZUJhc2U6OnJl c291cmNlTG9hZFRpbWluZyk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJl c3BvbnNlQmFzZTo6c2V0UmVzb3VyY2VMb2FkVGltaW5nKTogRGVsZXRlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisgICAgICAgIChXZWJDb3Jl OjpSZXNvdXJjZVJlc3BvbnNlQmFzZTo6cmVzb3VyY2VMb2FkVGltaW5nKToKKwogMjAxNC0wNi0y NyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T IFdLMl0gcG9zaXRpb246Zml4ZWQgaW5zaWRlIGFjY2VsZXJhdGVkIG92ZXJmbG93OnNjcm9sbCBp cyBqdW1weQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4gYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCAwZGY1YWQ5Li5jM2Q1Yjk5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9X ZWJDb3JlLmV4cC5pbgpAQCAtMzQ0NSw3ICszNDQ1LDMgQEAgX19aTjdXZWJDb3JlOVBhZ2VHcm91 cDE4Y2FwdGlvblByZWZlcmVuY2VzRXYKICNpZiBFTkFCTEUoVklFV19NT0RFX0NTU19NRURJQSkK IF9fWk43V2ViQ29yZTRQYWdlMTFzZXRWaWV3TW9kZUVOUzBfOFZpZXdNb2RlRQogI2VuZGlmCi0K LSNpZiBFTkFCTEUoV0VCX1RJTUlORykKLV9fWk5LN1dlYkNvcmUyMFJlc291cmNlUmVzcG9uc2VC YXNlMThyZXNvdXJjZUxvYWRUaW1pbmdFdgotI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuY3BwCmluZGV4IGEw ZjcxNjkuLjAxZWU1M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuY3BwCkBAIC0xMDgsNyArMTA4LDcgQEAgUGFz c093blB0cjxSZXNvdXJjZVJlc3BvbnNlPiBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6YWRvcHQoUGFz c093blB0cjxDcm9zc1RocmVhZFIKIAogICAgIHJlc3BvbnNlLT5sYXp5SW5pdChDb21tb25BbmRV bmNvbW1vbkZpZWxkcyk7CiAgICAgcmVzcG9uc2UtPm1faHR0cEhlYWRlckZpZWxkcy5hZG9wdChz dGQ6Om1vdmUoZGF0YS0+bV9odHRwSGVhZGVycykpOwotICAgIHJlc3BvbnNlLT5zZXRSZXNvdXJj ZUxvYWRUaW1pbmcoZGF0YS0+bV9yZXNvdXJjZUxvYWRUaW1pbmcpOworICAgIHJlc3BvbnNlLT5t X3Jlc291cmNlTG9hZFRpbWluZyA9IGRhdGEtPm1fcmVzb3VyY2VMb2FkVGltaW5nOwogICAgIHJl c3BvbnNlLT5kb1BsYXRmb3JtQWRvcHQoZGF0YSk7CiAgICAgcmV0dXJuIHJlc3BvbnNlLnJlbGVh c2UoKTsKIH0KQEAgLTU1OSwyMCArNTU5LDYgQEAgdm9pZCBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6 c2V0Q29ubmVjdGlvbklEKHVuc2lnbmVkIGNvbm5lY3Rpb25JRCkKICAgICBtX2Nvbm5lY3Rpb25J RCA9IGNvbm5lY3Rpb25JRDsKIH0KIAotUmVzb3VyY2VMb2FkVGltaW5nJiBSZXNvdXJjZVJlc3Bv bnNlQmFzZTo6cmVzb3VyY2VMb2FkVGltaW5nKCkgY29uc3QKLXsKLSAgICBsYXp5SW5pdChDb21t b25BbmRVbmNvbW1vbkZpZWxkcyk7Ci0KLSAgICByZXR1cm4gbV9yZXNvdXJjZUxvYWRUaW1pbmc7 Ci19Ci0KLXZvaWQgUmVzb3VyY2VSZXNwb25zZUJhc2U6OnNldFJlc291cmNlTG9hZFRpbWluZyhj b25zdCBSZXNvdXJjZUxvYWRUaW1pbmcmIHJlc291cmNlTG9hZFRpbWluZykKLXsKLSAgICBsYXp5 SW5pdChDb21tb25BbmRVbmNvbW1vbkZpZWxkcyk7Ci0KLSAgICBtX3Jlc291cmNlTG9hZFRpbWlu ZyA9IHJlc291cmNlTG9hZFRpbWluZzsKLX0KLQogdm9pZCBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6 bGF6eUluaXQoSW5pdExldmVsIGluaXRMZXZlbCkgY29uc3QKIHsKICAgICBjb25zdF9jYXN0PFJl c291cmNlUmVzcG9uc2UqPihzdGF0aWNfY2FzdDxjb25zdCBSZXNvdXJjZVJlc3BvbnNlKj4odGhp cykpLT5wbGF0Zm9ybUxhenlJbml0KGluaXRMZXZlbCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmgKaW5kZXggZjcxMTMz Yi4uZDEyNDg0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9S ZXNvdXJjZVJlc3BvbnNlQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaApAQCAtMTE3LDggKzExNyw3IEBAIHB1YmxpYzoKICAg ICBib29sIHdhc0NhY2hlZCgpIGNvbnN0OwogICAgIHZvaWQgc2V0V2FzQ2FjaGVkKGJvb2wpOwog Ci0gICAgUmVzb3VyY2VMb2FkVGltaW5nJiByZXNvdXJjZUxvYWRUaW1pbmcoKSBjb25zdDsKLSAg ICB2b2lkIHNldFJlc291cmNlTG9hZFRpbWluZyhjb25zdCBSZXNvdXJjZUxvYWRUaW1pbmcmKTsK KyAgICBSZXNvdXJjZUxvYWRUaW1pbmcmIHJlc291cmNlTG9hZFRpbWluZygpIGNvbnN0IHsgcmV0 dXJuIG1fcmVzb3VyY2VMb2FkVGltaW5nOyB9CiAKICAgICAvLyBUaGUgUmVzb3VyY2VSZXNwb25z ZSBzdWJjbGFzcyBtYXkgInNoYWRvdyIgdGhpcyBtZXRob2QgdG8gcHJvdmlkZSBwbGF0Zm9ybS1z cGVjaWZpYyBtZW1vcnkgdXNhZ2UgaW5mb3JtYXRpb24KICAgICB1bnNpZ25lZCBtZW1vcnlVc2Fn ZSgpIGNvbnN0Cg==