<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134428</bug_id>
          
          <creation_ts>2014-06-27 22:47:51 -0700</creation_ts>
          <short_desc>check-webkit-style should check the order of #imports as well as #includes</short_desc>
          <delta_ts>2014-06-27 22:51:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>bunhere</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>glenn</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mitz</cc>
    
    <cc>sergio</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1019191</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2014-06-27 22:47:51 -0700</bug_when>
    <thetext>The rules are the same.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019192</commentid>
    <comment_count>1</comment_count>
      <attachid>234045</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2014-06-27 22:49:21 -0700</bug_when>
    <thetext>Created attachment 234045
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019193</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2014-06-27 22:51:55 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/170565</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>234045</attachid>
            <date>2014-06-27 22:49:21 -0700</date>
            <delta_ts>2014-06-27 22:50:14 -0700</delta_ts>
            <desc>patch</desc>
            <filename>checker.diff</filename>
            <type>text/plain</type>
            <size>1555</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MjI5
ZjAxLi40MzRjM2VlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDYtMjcgIFRpbSBIb3J0b24gIDx0aW1vdGh5
X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCBj
aGVjayB0aGUgb3JkZXIgb2YgI2ltcG9ydHMgYXMgd2VsbCBhcyAjaW5jbHVkZXMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQyOAorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw
eS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIEFsbG93ICJpbXBvcnQiIGluIGFkZGl0
aW9uIHRvICJpbmNsdWRlIiwgc28gdGhhdCB0aGUgc29ydCBvcmRlciBvZiBoZWFkZXJzIGluIE9i
akMgZmlsZXMgaXMgY2hlY2tlZC4KKwogMjAxNC0wNi0yNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91
bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0ZSBteSBzcGVj
aWFsaXR5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy
cy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpp
bmRleCBlYTU5NzgzLi4xYjllMGRhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl
L2NoZWNrZXJzL2NwcC5weQpAQCAtMjc3MSw4ICsyNzcxLDggQEAgZGVmIGNoZWNrX3N0eWxlKGNs
ZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGNsYXNzX3N0YXRlLCBmaWxl
X3N0YXQKICAgICBjaGVja19lbnVtX2Nhc2luZyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVu
dW1fc3RhdGUsIGVycm9yKQogCiAKLV9SRV9QQVRURVJOX0lOQ0xVREVfTkVXX1NUWUxFID0gcmUu
Y29tcGlsZShyJyNpbmNsdWRlICsiW14vXStcLmgiJykKLV9SRV9QQVRURVJOX0lOQ0xVREUgPSBy
ZS5jb21waWxlKHInXlxzKiNccyppbmNsdWRlXHMqKFs8Il0pKFtePiJdKilbPiJdLiokJykKK19S
RV9QQVRURVJOX0lOQ0xVREVfTkVXX1NUWUxFID0gcmUuY29tcGlsZShyJyMoPzppbmNsdWRlfGlt
cG9ydCkgKyJbXi9dK1wuaCInKQorX1JFX1BBVFRFUk5fSU5DTFVERSA9IHJlLmNvbXBpbGUocide
XHMqI1xzKig/OmluY2x1ZGV8aW1wb3J0KVxzKihbPCJdKShbXj4iXSopWz4iXS4qJCcpCiAjIE1h
dGNoZXMgdGhlIGZpcnN0IGNvbXBvbmVudCBvZiBhIGZpbGVuYW1lIGRlbGltaXRlZCBieSAtcyBh
bmQgX3MuIFRoYXQgaXM6CiAjICBfUkVfRklSU1RfQ09NUE9ORU5ULm1hdGNoKCdmb28nKS5ncm91
cCgwKSA9PSAnZm9vJwogIyAgX1JFX0ZJUlNUX0NPTVBPTkVOVC5tYXRjaCgnZm9vLmNwcCcpLmdy
b3VwKDApID09ICdmb28nCg==
</data>
<flag name="review"
          id="258575"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>