<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134417</bug_id>
          
          <creation_ts>2014-06-27 15:23:32 -0700</creation_ts>
          <short_desc>Add test to ensure that SVGDocumentExtensions::rebuildElements() doesn&apos;t rebuild invalid elements</short_desc>
          <delta_ts>2014-07-07 10:53:01 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>134500</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>andersca</cc>
    
    <cc>bunhere</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>d-r</cc>
    
    <cc>fmalita</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>je_julie.kim</cc>
    
    <cc>pdr</cc>
    
    <cc>sam</cc>
    
    <cc>schenney</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1019120</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-06-27 15:23:32 -0700</bug_when>
    <thetext>We should use Vector::swap() instead of std::move() to explicitly swap Vector objects in SVGDocumentExtensions::rebuildElements(). Currently we use std::move() to implicitly swap Vector objects. This is error prone as a const lvalue reference can bind to an rvalue so calling T t = std::move(t_1) &lt;=&gt; T t = t_1 &lt;=&gt; T t(t_1) where t_1 is const T&amp;&amp;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019121</commentid>
    <comment_count>1</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-06-27 15:24:00 -0700</bug_when>
    <thetext>&lt;rdar://problem/17479854&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019123</commentid>
    <comment_count>2</comment_count>
      <attachid>234024</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-06-27 15:27:30 -0700</bug_when>
    <thetext>Created attachment 234024
Patch and layout test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019150</commentid>
    <comment_count>3</comment_count>
      <attachid>234024</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2014-06-27 16:50:17 -0700</bug_when>
    <thetext>Comment on attachment 234024
Patch and layout test

I don’t think this is an improvement.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019151</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2014-06-27 16:51:17 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; Currently we use std::move() to implicitly swap Vector objects.

No, we use it to move a vector. There is no swapping going on; we move the vector from the object into a local variable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019496</commentid>
    <comment_count>5</comment_count>
      <attachid>234024</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-06-30 17:14:48 -0700</bug_when>
    <thetext>Comment on attachment 234024
Patch and layout test

Clearing review flag. After talking with Darin Adler and Anders Carlsson today (06/30), a better approach is to come up with a WTF::move() function that asserts we aren&apos;t called with a const value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019821</commentid>
    <comment_count>6</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-07-01 16:27:44 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 234024 [details])
&gt; Clearing review flag. After talking with Darin Adler and Anders Carlsson today (06/30), a better approach is to come up with a WTF::move() function that asserts we aren&apos;t called with a const value.

Filed bug #134500 to add WTF::move(). I&apos;ll repurpose this bug for adding the layout test, included in attachment #234024.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1020401</commentid>
    <comment_count>7</comment_count>
      <attachid>234378</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-07-03 16:26:54 -0700</bug_when>
    <thetext>Created attachment 234378
Layout test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1020427</commentid>
    <comment_count>8</comment_count>
      <attachid>234378</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2014-07-03 18:26:30 -0700</bug_when>
    <thetext>Comment on attachment 234378
Layout test

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1020839</commentid>
    <comment_count>9</comment_count>
      <attachid>234378</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-07-07 10:52:54 -0700</bug_when>
    <thetext>Comment on attachment 234378
Layout test

Clearing flags on attachment: 234378

Committed r170847: &lt;http://trac.webkit.org/changeset/170847&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1020840</commentid>
    <comment_count>10</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2014-07-07 10:53:01 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>234024</attachid>
            <date>2014-06-27 15:27:30 -0700</date>
            <delta_ts>2014-07-03 16:26:49 -0700</delta_ts>
            <desc>Patch and layout test</desc>
            <filename>Bug134417.patch</filename>
            <type>text/plain</type>
            <size>6595</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">RnJvbSA0NjE0NzU0M2YzNzVlZWZkNWNjNWFkN2U4NGQzNTYxNmI5YTMwN2U4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgQmF0ZXMgPGRiYXRlc0B3ZWJraXQub3JnPgpEYXRl
OiBGcmksIDI3IEp1biAyMDE0IDE1OjI2OjIwIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRXhwbGlj
aXRseSB1c2UgVmVjdG9yOjpzd2FwKCkgaW5zdGVhZCBvZiBzdGQ6Om1vdmUoKSBpbgogU1ZHRG9j
dW1lbnRFeHRlbnNpb25zOjpyZWJ1aWxkRWxlbWVudHMoKQogaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEzNDQxNyA8cmRhcjovL3Byb2JsZW0vMTc0Nzk4NTQ+CgpSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClNvdXJjZS9XZWJDb3JlOgpNYWtlIGl0IGV4cGxpY2l0
IHRoYXQgd2Ugd2FudCB0byBzd2FwIGFuIGVtcHR5IHZlY3RvciB3aXRoIHRoZSBleGlzdGluZyB2
ZWN0b3Igb2YgZWxlbWVudHMgdG8KYmUgcmVidWlsdCBiZWZvcmUgcHJvY2Vzc2luZyB0aGVtLiBB
IHNpZGUgYmVuZWZpdCBvZiB0aGlzIGNoYW5nZSBpcyB0aGF0IG1ha2luZwpTVkdEb2N1bWVudEV4
dGVuc2lvbnM6OnJlYnVpbGRFbGVtZW50cyBjb25zdCB3aWxsIGNhdXNlIGEgY29tcGlsZSBlcnJv
ci4KClRlc3Q6IHN2Zy9jdXN0b20vb3ZlcndyaXRlLXBhZ2UtdGhhdC1oYXMtdXNlLWVsZW1lbnRz
Lmh0bWwKCiogc3ZnL1NWR0RvY3VtZW50RXh0ZW5zaW9ucy5jcHA6CihXZWJDb3JlOjpTVkdEb2N1
bWVudEV4dGVuc2lvbnM6OnJlYnVpbGRFbGVtZW50cyk6IFVzZSBWZWN0b3I6OnN3YXAoKSBpbnN0
ZWFkIG9mIHN0ZDo6bW92ZSgpLgoKTGF5b3V0VGVzdHM6CkFkZCBhIHRlc3QgdGhhdCBpbXBsaWNp
dGx5IGNoZWNrcyB0aGF0IHRoZSBsaXN0IG9mIFNWRyBlbGVtZW50cyB0byBiZSByZWJ1aWx0IGRv
ZXNuJ3QgY29udGFpbgpyZW1vdmVkIGVsZW1lbnRzLgoKKiBzdmcvY3VzdG9tL292ZXJ3cml0ZS1w
YWdlLXRoYXQtaGFzLXVzZS1lbGVtZW50cy1leHBlY3RlZC50eHQ6IEFkZGVkLgoqIHN2Zy9jdXN0
b20vb3ZlcndyaXRlLXBhZ2UtdGhhdC1oYXMtdXNlLWVsZW1lbnRzLmh0bWw6IEFkZGVkLgotLS0K
IExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTQg
KysrKysrCiAuLi5lcndyaXRlLXBhZ2UtdGhhdC1oYXMtdXNlLWVsZW1lbnRzLWV4cGVjdGVkLnR4
dCB8ICAxICsKIC4uLi9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMuaHRtbCAg
ICAgIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxNyArKysrKysrKwogU291cmNlL1dlYkNvcmUv
c3ZnL1NWR0RvY3VtZW50RXh0ZW5zaW9ucy5jcHAgICAgICAgfCAgNCArLQogNSBmaWxlcyBjaGFu
Z2VkLCA4NiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQg
TGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVu
dHMtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvc3ZnL2N1c3Rv
bS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMuaHRtbAoKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3MGJk
ZmIxLi41ODMwOTRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDYtMjcgIERhbmllbCBC
YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEV4cGxpY2l0bHkgdXNlIFZlY3Rv
cjo6c3dhcCgpIGluc3RlYWQgb2Ygc3RkOjptb3ZlKCkgaW4gU1ZHRG9jdW1lbnRFeHRlbnNpb25z
OjpyZWJ1aWxkRWxlbWVudHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTM0NDE3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzQ3OTg1ND4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0
IHRoYXQgaW1wbGljaXRseSBjaGVja3MgdGhhdCB0aGUgbGlzdCBvZiBTVkcgZWxlbWVudHMgdG8g
YmUgcmVidWlsdCBkb2Vzbid0IGNvbnRhaW4KKyAgICAgICAgcmVtb3ZlZCBlbGVtZW50cy4KKwor
ICAgICAgICAqIHN2Zy9jdXN0b20vb3ZlcndyaXRlLXBhZ2UtdGhhdC1oYXMtdXNlLWVsZW1lbnRz
LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFn
ZS10aGF0LWhhcy11c2UtZWxlbWVudHMuaHRtbDogQWRkZWQuCisKIDIwMTQtMDYtMjcgIE1hbnVl
bCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlk
IExheW91dF0gSW50ZXJhY3Rpb24gYmV0d2VlbiBhdXRvLXBsYWNlbWVudCBhbmQgY29sdW1uIC8g
cm93IHNwYW5uaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL292ZXJ3cml0
ZS1wYWdlLXRoYXQtaGFzLXVzZS1lbGVtZW50cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9z
dmcvY3VzdG9tL292ZXJ3cml0ZS1wYWdlLXRoYXQtaGFzLXVzZS1lbGVtZW50cy1leHBlY3RlZC50
eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZjQ5MzU0MgotLS0gL2Rldi9u
dWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vb3ZlcndyaXRlLXBhZ2UtdGhhdC1oYXMt
dXNlLWVsZW1lbnRzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTLCBkaWQgbm90IGNy
YXNoCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL292ZXJ3cml0ZS1wYWdlLXRo
YXQtaGFzLXVzZS1lbGVtZW50cy5odG1sIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9vdmVyd3Jp
dGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp
bmRleCAwMDAwMDAwLi5hNGRlZDgyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3Zn
L2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMuaHRtbApAQCAtMCww
ICsxLDUxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYg
KHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAg
dGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5
PgorIDwhLS0gVGhpcyB0ZXN0cyB0aGF0IHdlIGRvbid0IGNyYXNoIHdoZW4gb3ZlcndyaXRpbmcg
dGhlIGNvbnRlbnRzIG9mIHBhZ2UgdGhhdCBoYXMgYW4gU1ZHIHRyZWUgY29udGFpbmluZyA8dXNl
PiBlbGVtZW50cworIHdpdGggcmVmZXJlbmNlcyAoaS5lLiB4bGluazpocmVmKS4gLS0+Cis8c3Zn
PgorICAgIDxkZWZzPgorICAgICAgICA8ZyBpZD0iYmcxIj4KKyAgICAgICAgICAgIDx1c2UgeGxp
bms6aHJlZj0iI2ZpbGwtcmduIi8+CisgICAgICAgIDwvZz4KKyAgICA8L2RlZnM+CisgICAgPHVz
ZSBpZD0iQSIgeGxpbms6aHJlZj0iI2JnMSIvPgorICAgIDx0ZXh0IGlkPSJCIiB4PSIwIiB5PSIy
MCI+RkFJTDwvdGV4dD4KKzwvc3ZnPgorPHNjcmlwdD4KKy8vIFN5bmNocm9ub3VzIHdyaXRlOyBt
YXJrIDx1c2UgaWQ9IkEiPiBhcyBuZWVkaW5nIHRvIGJlIHJlYnVpbHQgYmVjYXVzZSA8ZyBpZD0i
YmcxIj4gaXMgcmVtb3ZlZCBmcm9tIHRoZSBkb2N1bWVudC4KK2RvY3VtZW50LndyaXRlKCJGQUlM
Iik7Cit3aW5kb3cuc2V0VGltZW91dChjcmFzaCwgMCk7CisKK2Z1bmN0aW9uIGNyYXNoKCkgewor
ICAgIGRvY3VtZW50LmRlc2lnbk1vZGUgPSAib24iOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5k
KCJTZWxlY3RBbGwiKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiRm9udE5hbWUiLCB0cnVl
LCAiSDUiKTsgLy8gUmVidWlsZHMgdGFyZ2V0cyBmb3IgU1ZHIG5vZGVzLgorCisgICAgLy8gUmVt
b3ZlIHRoZSBjb250ZW50cyBiZXR3ZWVuIDx1c2UgaWQ9IkEiPiBhbmQgPHRleHQgaWQ9IkIiPiAo
aW5jbHVzaXZlbHkpLiBOb3RpY2UgdGhhdCB0aGVzZSBub2RlcyBoYXZlIGFscmVhZHkgYmVlbgor
ICAgIC8vIHJlbW92ZWQgYnkgdGhlIHN5bmNocm9ub3VzIGRvY3VtZW50LndyaXRlKCkgY2FsbCBh
Ym92ZS4KKyAgICB2YXIgcmFuZ2UgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOworICAgIHJhbmdl
LnNldFN0YXJ0QmVmb3JlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJBIikpOworICAgIHJhbmdl
LnNldEVuZEFmdGVyKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJCIikpOworICAgIHJhbmdlLmRl
bGV0ZUNvbnRlbnRzKCk7IC8vIFJlYnVpbGRzIHRhcmdldHMgZm9yIFNWRyBub2Rlcy4KKworICAg
IGlmICh3aW5kb3cuR0NDb250cm9sbGVyKQorICAgICAgICBHQ0NvbnRyb2xsZXIuY29sbGVjdCgp
OworCisgICAgLy8gQ3Jhc2g7IHJlYnVpbGRzIHRhcmdldHMgZm9yIFNWRyBub2RlcywgaW5jbHVk
aW5nIHRoZSAiZWxlbWVudCIgYXQgdGhlIG1lbW9yeSBsb2NhdGlvbiBmb3JtZXJseSBvY2N1cGll
ZCBieSA8dXNlIGlkPSJBIj4uCisgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiUEFTUywg
ZGlkIG5vdCBjcmFzaCI7CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRl
c3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKaW5kZXggMGI5MzVkZS4uNjFhN2ZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA
CisyMDE0LTA2LTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAg
ICBFeHBsaWNpdGx5IHVzZSBWZWN0b3I6OnN3YXAoKSBpbnN0ZWFkIG9mIHN0ZDo6bW92ZSgpIGlu
IFNWR0RvY3VtZW50RXh0ZW5zaW9uczo6cmVidWlsZEVsZW1lbnRzKCkKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDQxNworICAgICAgICA8cmRhcjov
L3Byb2JsZW0vMTc0Nzk4NTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgTWFrZSBpdCBleHBsaWNpdCB0aGF0IHdlIHdhbnQgdG8gc3dhcCBhbiBlbXB0
eSB2ZWN0b3Igd2l0aCB0aGUgZXhpc3RpbmcgdmVjdG9yIG9mIGVsZW1lbnRzIHRvCisgICAgICAg
IGJlIHJlYnVpbHQgYmVmb3JlIHByb2Nlc3NpbmcgdGhlbS4gQSBzaWRlIGJlbmVmaXQgb2YgdGhp
cyBjaGFuZ2UgaXMgdGhhdCBtYWtpbmcKKyAgICAgICAgU1ZHRG9jdW1lbnRFeHRlbnNpb25zOjpy
ZWJ1aWxkRWxlbWVudHMgY29uc3Qgd2lsbCBjYXVzZSBhIGNvbXBpbGUgZXJyb3IuCisKKyAgICAg
ICAgVGVzdDogc3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMu
aHRtbAorCisgICAgICAgICogc3ZnL1NWR0RvY3VtZW50RXh0ZW5zaW9ucy5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpTVkdEb2N1bWVudEV4dGVuc2lvbnM6OnJlYnVpbGRFbGVtZW50cyk6IFVzZSBW
ZWN0b3I6OnN3YXAoKSBpbnN0ZWFkIG9mIHN0ZDo6bW92ZSgpLgorCiAyMDE0LTA2LTI3ICBNYW51
ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDU1MgR3Jp
ZCBMYXlvdXRdIEludGVyYWN0aW9uIGJldHdlZW4gYXV0by1wbGFjZW1lbnQgYW5kIGNvbHVtbiAv
IHJvdyBzcGFubmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50
RXh0ZW5zaW9ucy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnRFeHRlbnNpb25z
LmNwcAppbmRleCA0YjQyODM4Li4yZTA5NzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9z
dmcvU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH
RG9jdW1lbnRFeHRlbnNpb25zLmNwcApAQCAtMzM0LDcgKzMzNCw5IEBAIHZvaWQgU1ZHRG9jdW1l
bnRFeHRlbnNpb25zOjpyZW1vdmVBbGxUYXJnZXRSZWZlcmVuY2VzRm9yRWxlbWVudChTVkdFbGVt
ZW50KiByZWZlCiAKIHZvaWQgU1ZHRG9jdW1lbnRFeHRlbnNpb25zOjpyZWJ1aWxkRWxlbWVudHMo
KQogewotICAgIFZlY3RvcjxTVkdFbGVtZW50Kj4gc2hhZG93UmVidWlsZEVsZW1lbnRzID0gc3Rk
Ojptb3ZlKG1fcmVidWlsZEVsZW1lbnRzKTsKKyAgICBWZWN0b3I8U1ZHRWxlbWVudCo+IHNoYWRv
d1JlYnVpbGRFbGVtZW50czsKKyAgICBzaGFkb3dSZWJ1aWxkRWxlbWVudHMuc3dhcChtX3JlYnVp
bGRFbGVtZW50cyk7CisKICAgICBmb3IgKGF1dG8qIGVsZW1lbnQgOiBzaGFkb3dSZWJ1aWxkRWxl
bWVudHMpCiAgICAgICAgIGVsZW1lbnQtPnN2Z0F0dHJpYnV0ZUNoYW5nZWQoWExpbmtOYW1lczo6
aHJlZkF0dHIpOwogfQotLSAKMS45LjMgKEFwcGxlIEdpdC01MCkKCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>234378</attachid>
            <date>2014-07-03 16:26:54 -0700</date>
            <delta_ts>2014-07-07 10:52:54 -0700</delta_ts>
            <desc>Layout test</desc>
            <filename>bug-134417-20140703162636.patch</filename>
            <type>text/plain</type>
            <size>3574</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNzc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzQ5NDkyZTM2ZmNkODg5OGQ3MmY0
MWI1M2JiNDUzZjhlNTQ4ZGUwNS4uMTU3MGI1YTYxZmVmNDJjY2UyMThiYzIwMjNhMDNhNDI0Y2Vm
YTU1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA3LTAzICBEYW5pZWwgQmF0ZXMgIDxk
YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgdGVzdCB0byBlbnN1cmUgdGhhdCBTVkdE
b2N1bWVudEV4dGVuc2lvbnM6OnJlYnVpbGRFbGVtZW50cygpIGRvZXNuJ3QgcmVidWlsZCBpbnZh
bGlkIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xMzQ0MTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3NDc5ODU0PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QgdGhhdCBp
bXBsaWNpdGx5IGNoZWNrcyB0aGF0IHRoZSBsaXN0IG9mIFNWRyBlbGVtZW50cyB0byBiZSByZWJ1
aWx0IGRvZXNuJ3QgY29udGFpbgorICAgICAgICByZW1vdmVkIGVsZW1lbnRzLiBSdW4gdGhpcyB0
ZXN0IGluIERSVCB3aXRoIEd1YXJkIE1hbGxvYy9NYWxsb2NTY3JpYmJsZSAob3IgdGhlIHBsYXRm
b3JtLQorICAgICAgICBzcGVjaWZpYyBlcXVpdmFsZW50KSBlbmFibGVkLgorCisgICAgICAgICog
c3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMtZXhwZWN0ZWQu
dHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdmcvY3VzdG9tL292ZXJ3cml0ZS1wYWdlLXRoYXQtaGFz
LXVzZS1lbGVtZW50cy5odG1sOiBBZGRlZC4KKwogMjAxNC0wNy0wMiAgQnJlbnQgRnVsZ2hhbSAg
PGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBXZWJLaXQxIFdlYlZpZXcgaWZy
YW1lIG5vdCByZXNwb25kaW5nIHRvIHNjcm9sbCBnZXN0dXJlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvc3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMtZXhw
ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhh
cy11c2UtZWxlbWVudHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY0OTM1NDJmNzU1NjZkZmEz
Nzg0Nzc3YTRlNjA5MWVhMTc2ZjMyMzMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9z
dmcvY3VzdG9tL292ZXJ3cml0ZS1wYWdlLXRoYXQtaGFzLXVzZS1lbGVtZW50cy1leHBlY3RlZC50
eHQKQEAgLTAsMCArMSBAQAorUEFTUywgZGlkIG5vdCBjcmFzaApkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvc3ZnL2N1c3RvbS9vdmVyd3JpdGUtcGFnZS10aGF0LWhhcy11c2UtZWxlbWVudHMuaHRt
bCBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vb3ZlcndyaXRlLXBhZ2UtdGhhdC1oYXMtdXNlLWVs
ZW1lbnRzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODljZDY0YjQ5NWQ2MTllYzEyYmE4MDIyMDUzODM2MDc5
YTE3MjljMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vb3Zlcndy
aXRlLXBhZ2UtdGhhdC1oYXMtdXNlLWVsZW1lbnRzLmh0bWwKQEAgLTAsMCArMSw1MiBAQAorPCFE
T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1
bm5lcikgeworICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2Fp
dFVudGlsRG9uZSgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyA8IS0tIFRoaXMg
dGVzdHMgdGhhdCB3ZSBkb24ndCBjcmFzaCB3aGVuIG92ZXJ3cml0aW5nIHRoZSBjb250ZW50cyBv
ZiBwYWdlIHRoYXQgaGFzIGFuIFNWRyB0cmVlIGNvbnRhaW5pbmcgPHVzZT4gZWxlbWVudHMKKyB3
aXRoIHJlZmVyZW5jZXMgKGkuZS4geGxpbms6aHJlZikuIFlvdSBtdXN0IHJ1biB0aGlzIHRlc3Qg
aW4gRFJUIHdpdGggR3VhcmQgTWFsbG9jL01hbGxvY1NjcmliYmxlIChvciB0aGUgcGxhdGZvcm0t
Cisgc3BlY2lmaWMgZXF1aXZhbGVudCkgZW5hYmxlZC4gLS0+Cis8c3ZnPgorICAgIDxkZWZzPgor
ICAgICAgICA8ZyBpZD0iYmcxIj4KKyAgICAgICAgICAgIDx1c2UgeGxpbms6aHJlZj0iI2ZpbGwt
cmduIi8+CisgICAgICAgIDwvZz4KKyAgICA8L2RlZnM+CisgICAgPHVzZSBpZD0iQSIgeGxpbms6
aHJlZj0iI2JnMSIvPgorICAgIDx0ZXh0IGlkPSJCIiB4PSIwIiB5PSIyMCI+RkFJTDwvdGV4dD4K
Kzwvc3ZnPgorPHNjcmlwdD4KKy8vIFN5bmNocm9ub3VzIHdyaXRlOyBtYXJrIDx1c2UgaWQ9IkEi
PiBhcyBuZWVkaW5nIHRvIGJlIHJlYnVpbHQgYmVjYXVzZSA8ZyBpZD0iYmcxIj4gaXMgcmVtb3Zl
ZCBmcm9tIHRoZSBkb2N1bWVudC4KK2RvY3VtZW50LndyaXRlKCJGQUlMIik7Cit3aW5kb3cuc2V0
VGltZW91dChjcmFzaCwgMCk7CisKK2Z1bmN0aW9uIGNyYXNoKCkgeworICAgIGRvY3VtZW50LmRl
c2lnbk1vZGUgPSAib24iOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiKTsK
KyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiRm9udE5hbWUiLCB0cnVlLCAiSDUiKTsgLy8gUmVi
dWlsZHMgdGFyZ2V0cyBmb3IgU1ZHIG5vZGVzLgorCisgICAgLy8gUmVtb3ZlIHRoZSBjb250ZW50
cyBiZXR3ZWVuIDx1c2UgaWQ9IkEiPiBhbmQgPHRleHQgaWQ9IkIiPiAoaW5jbHVzaXZlbHkpLiBO
b3RpY2UgdGhhdCB0aGVzZSBub2RlcyBoYXZlIGFscmVhZHkgYmVlbgorICAgIC8vIHJlbW92ZWQg
YnkgdGhlIHN5bmNocm9ub3VzIGRvY3VtZW50LndyaXRlKCkgY2FsbCBhYm92ZS4KKyAgICB2YXIg
cmFuZ2UgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOworICAgIHJhbmdlLnNldFN0YXJ0QmVmb3Jl
KGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJBIikpOworICAgIHJhbmdlLnNldEVuZEFmdGVyKGRv
Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJCIikpOworICAgIHJhbmdlLmRlbGV0ZUNvbnRlbnRzKCk7
IC8vIFJlYnVpbGRzIHRhcmdldHMgZm9yIFNWRyBub2Rlcy4KKworICAgIGlmICh3aW5kb3cuR0ND
b250cm9sbGVyKQorICAgICAgICBHQ0NvbnRyb2xsZXIuY29sbGVjdCgpOworCisgICAgLy8gQ3Jh
c2g7IHJlYnVpbGRzIHRhcmdldHMgZm9yIFNWRyBub2RlcywgaW5jbHVkaW5nIHRoZSAiZWxlbWVu
dCIgYXQgdGhlIG1lbW9yeSBsb2NhdGlvbiBmb3JtZXJseSBvY2N1cGllZCBieSA8dXNlIGlkPSJB
Ij4uCisgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiUEFTUywgZGlkIG5vdCBjcmFzaCI7
CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5
RG9uZSgpOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>