134415 2014-06-27 15:06:05 -0700 ScrollView::rootViewToTotalContents() needs to take topContentInset into account 2014-06-27 15:13:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned bdakin bunhere cdumez commit-queue gyuyoung.kim sam sergio simon.fraser thorton oldest_to_newest 1019113 0 bdakin 2014-06-27 15:06:05 -0700 Much like the other coordinate conversation functions, ScrollView::rootViewToTotalContents() needs to take topContentInset into account. <rdar://problem/17473633> 1019115 1 234022 bdakin 2014-06-27 15:08:20 -0700 Created attachment 234022 Patch 1019116 2 234022 simon.fraser 2014-06-27 15:10:53 -0700 Comment on attachment 234022 Patch Maybe say what the visible impact of this was? 1019118 3 bdakin 2014-06-27 15:13:36 -0700 (In reply to comment #2) > (From update of attachment 234022 [details]) > Maybe say what the visible impact of this was? Thanks! I added a line to the changelog about that. http://trac.webkit.org/changeset/170558 234022 2014-06-27 15:08:20 -0700 2014-06-27 15:10:53 -0700 Patch for-review.txt text/plain 1509 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDU1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTI3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JvbGxWaWV3Ojpyb290Vmlld1Rv VG90YWxDb250ZW50cygpIG5lZWRzIHRvIHRha2UgdG9wQ29udGVudEluc2V0IGludG8gYWNjb3Vu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NDE1 CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3 NDczNjMzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSByb290IHZpZXcgd2lsbCBiZSBhbmNob3JlZCBhYm92ZSB0aGUgc3RhcnQgb2YgdGhlIHRv dGFsIGNvbnRlbnRzIGlmIHRoZXJlIGlzIGEgCisgICAgICAgIHRvcENvbnRlbnRJbnNldCwgc28g dGhlIGluc2V0IHZhbHVlIHNob3VsZCBiZSBzdWJ0cmFjdGVkIHRvIGdldCBpbnRvIHRoZSByaWdo dCAKKyAgICAgICAgY29vcmRpbmF0ZSBzcGFjZSBoZXJlLgorICAgICAgICAqIHBsYXRmb3JtL1Nj cm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cm9vdFZpZXdUb1Rv dGFsQ29udGVudHMpOgorCiAyMDE0LTA2LTI3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICBGbHVzaCB0aHJvdHRsaW5nIHdpdGggcmVtb3RlIGxheWVycwpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAJKHJldmlzaW9uIDE3MDUzMykK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC04NjAsNyArODYwLDcgQEAgSW50UG9pbnQgU2Nyb2xsVmlldzo6cm9vdFZpZXdUb1RvdGFs Q29udAogICAgICAgICByZXR1cm4gY29udmVydEZyb21Sb290Vmlldyhyb290Vmlld1BvaW50KTsK IAogICAgIEludFBvaW50IHZpZXdQb2ludCA9IGNvbnZlcnRGcm9tUm9vdFZpZXcocm9vdFZpZXdQ b2ludCk7Ci0gICAgcmV0dXJuIHZpZXdQb2ludCArIHNjcm9sbE9mZnNldCgpOworICAgIHJldHVy biB2aWV3UG9pbnQgKyBzY3JvbGxPZmZzZXQoKSAtIEludFNpemUoMCwgdG9wQ29udGVudEluc2V0 KCkpOwogfQogCiBJbnRQb2ludCBTY3JvbGxWaWV3Ojp3aW5kb3dUb0NvbnRlbnRzKGNvbnN0IElu dFBvaW50JiB3aW5kb3dQb2ludCkgY29uc3QK