134409 2014-06-27 13:42:08 -0700 [iOS][WK2] <select> tapping "next" does not save new picker value 2016-09-07 21:49:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck enrica joepeck oldest_to_newest 1019071 0 joepeck 2014-06-27 13:42:08 -0700 * TEST: <select> <option>Cyan</option> <option>Magenta</option> <option>Yellow</option> <option>Black</option> </select> <br><br> <select> <option>Red</option> <option>Green</option> <option>Blue</option> </select> * STEPS 1. Tap the first <select> 2. Move the wheel to a "Yellow" 3. Tap Next in accessory => "Cyan" is still selected. Expected "Yellow" to be selected. 1019072 1 joepeck 2014-06-27 13:42:52 -0700 <rdar://problem/17379745> 1019073 2 joepeck 2014-06-27 13:46:48 -0700 So, two potential issues here. 1. We were accidentally not calling endEditing in -_stopAssistingNode in WK2. - I think this should always be the case to ensure we call -controlEndEditing which only <select> cares about 2. Calling endEditing in -_stopAssistingNode is too late in this case. It seem in the WK2 model: - UIProcess tells the WebProcess to move focus to the next field - WebProcess updates the assisted node - WebProcess tells the UIProcess to start assisting a new node - if the UIProcess at this point says "update the value of the assisted node" it updates the wrong node So it seems like we should handle -accessoryTab in a special way. We don't want to do everything that stopAssistingNode does (it starts dismissing the keyboard) but we do want the control to endEditing. I say we trigger the endEditing at this point because we know we are going to change focus and run the rest anyways. Patch to follow. 1019076 3 234013 joepeck 2014-06-27 13:50:55 -0700 Created attachment 234013 [PATCH] Proposed Fix 1019078 4 234013 enrica 2014-06-27 13:55:44 -0700 Comment on attachment 234013 [PATCH] Proposed Fix Sounds very reasonable to me. 1019099 5 234013 commit-queue 2014-06-27 14:36:58 -0700 Comment on attachment 234013 [PATCH] Proposed Fix Clearing flags on attachment: 234013 Committed r170554: <http://trac.webkit.org/changeset/170554> 234013 2014-06-27 13:50:55 -0700 2014-06-27 14:36:57 -0700 [PATCH] Proposed Fix form-fix.patch text/plain 3123 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNGY3NDk1Li44ODMzNDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYg QEAKIDIwMTQtMDYtMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBbaU9TXVtXSzJdIDxzZWxlY3Q+IHRhcHBpbmcgIm5leHQiIGRvZXMgbm90IHNhdmUg bmV3IHBpY2tlciB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM0NDA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAg ICAgICAgKC1bV0tDb250ZW50VmlldyBhY2Nlc3NvcnlUYWI6XSk6CisgICAgICAgIFdlIGtub3cg dGhlIGFzc2lzdGVkIG5vZGUgd2lsbCBjaGFuZ2UsIHNvIGNhbGwgZW5kRWRpdGluZworICAgICAg ICBiZWZvcmUgdGhlIGFzc2lzdGVkIG5vZGUgY2hhbmdlcyBpbiB0aGUgV2ViUHJvY2Vzcy4KKwor ICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9zdG9wQXNzaXN0aW5nTm9kZV0pOgorICAgICAgICBF bnN1cmUgd2UgY2FsbCBlbmRFZGl0aW5nIHRvIHRyaWdnZXIgY29udHJvbEVuZEVkaXRpbmcuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbToKKyAg ICAgICAgKC1bV0tNdWx0aXBsZVNlbGVjdFBpY2tlciBpbml0V2l0aFZpZXc6XSk6CisgICAgICAg ICgtW1dLTXVsdGlwbGVTZWxlY3RQaWNrZXIgcGlja2VyVmlldzpyb3c6Y29sdW1uOmNoZWNrZWQ6 XSk6CisgICAgICAgICgtW1dLU2VsZWN0U2luZ2xlUGlja2VyIGRlYWxsb2NdKToKKyAgICAgICAg U3R5bGUgZml4ZXMuCisKKzIwMTQtMDYtMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKwogICAgICAgICBGaXggdmFyaW91cyBsZWFrcywgUmV0YWluUHRycyBzaG91bGQg YWRvcHQgYWxsb2NzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzQzMDgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCAzNmI5NTQ0Li4yZjU0Yzc2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQpAQCAtMTczMSw2ICsxNzMxLDkgQEAgc3RhdGljIHZvaWQgc2VsZWN0aW9u Q2hhbmdlZFdpdGhUb3VjaChXS0NvbnRlbnRWaWV3ICp2aWV3LCBjb25zdCBXZWJDb3JlOjpJbnRQ b2kKIAogLSAodm9pZClhY2Nlc3NvcnlUYWI6KEJPT0wpaXNOZXh0CiB7CisgICAgW19pbnB1dFBl cmlwaGVyYWwgZW5kRWRpdGluZ107CisgICAgX2lucHV0UGVyaXBoZXJhbCA9IG5pbDsKKwogICAg IF9kaWRBY2Nlc3NvcnlUYWJJbml0aWF0ZUZvY3VzID0gWUVTOyAvLyBXaWxsIGJlIGNsZWFyZWQg aW4gZWl0aGVyIC1fZGlzcGxheUZvcm1Ob2RlSW5wdXRWaWV3IG9yIC1jbGVhbnVwSW50ZXJhY3Rp b24uCiAgICAgX3BhZ2UtPmZvY3VzTmV4dEFzc2lzdGVkTm9kZShpc05leHQpOwogfQpAQCAtMjM5 MSw2ICsyMzk0LDcgQEAgc3RhdGljIFVJVGV4dEF1dG9jYXBpdGFsaXphdGlvblR5cGUgdG9VSVRl eHRBdXRvY2FwaXRhbGl6ZShXZWJBdXRvY2FwaXRhbGl6ZVR5cGUKICAgICBfZm9ybUlucHV0U2Vz c2lvbiA9IG5pbDsKICAgICBfaXNFZGl0YWJsZSA9IE5POwogICAgIF9hc3Npc3RlZE5vZGVJbmZv cm1hdGlvbi5lbGVtZW50VHlwZSA9IElucHV0VHlwZTo6Tm9uZTsKKyAgICBbX2lucHV0UGVyaXBo ZXJhbCBlbmRFZGl0aW5nXTsKICAgICBfaW5wdXRQZXJpcGhlcmFsID0gbmlsOwogCiAgICAgW3Nl bGYgX3N0b3BBc3Npc3RpbmdLZXlib2FyZF07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbSBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtU2VsZWN0UGlja2VyLm1tCmluZGV4IGE5Y2UwNTIu LjNkNDRkMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMv V0tGb3JtU2VsZWN0UGlja2VyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv Zm9ybXMvV0tGb3JtU2VsZWN0UGlja2VyLm1tCkBAIC0xODEsNyArMTgxLDcgQEAgc3RhdGljIGNv bnN0IGZsb2F0IERpc2FibGVkT3B0aW9uQWxwaGEgPSAwLjM7CiAKICAgICBpZiAoX3NpbmdsZVNl bGVjdGlvbkluZGV4ICE9IE5TTm90Rm91bmQpCiAgICAgICAgIFtzZWxmIHNlbGVjdFJvdzpfc2lu Z2xlU2VsZWN0aW9uSW5kZXggaW5Db21wb25lbnQ6MCBhbmltYXRlZDpOT107Ci0gICAgCisKICAg ICByZXR1cm4gc2VsZjsKIH0KIApAQCAtMjc1LDcgKzI3NSw2IEBAIHN0YXRpYyBjb25zdCBmbG9h dCBEaXNhYmxlZE9wdGlvbkFscGhhID0gMC4zOwogCiAtICh2b2lkKXBpY2tlclZpZXc6KFVJUGlj a2VyVmlldyAqKXBpY2tlclZpZXcgcm93OihpbnQpcm93SW5kZXggY29sdW1uOihpbnQpY29sdW1u SW5kZXggY2hlY2tlZDooQk9PTClpc0NoZWNrZWQKIHsKLQogICAgIGlmICgoc2l6ZV90KXJvd0lu ZGV4ID49IFtfdmlldyBhc3Npc3RlZE5vZGVTZWxlY3RPcHRpb25zXS5zaXplKCkpCiAgICAgICAg IHJldHVybjsKIApAQCAtMzM1LDcgKzMzNCw3IEBAIHN0YXRpYyBjb25zdCBmbG9hdCBEaXNhYmxl ZE9wdGlvbkFscGhhID0gMC4zOwogLSAodm9pZClkZWFsbG9jCiB7CiAgICAgW3NlbGYgc2V0RGVs ZWdhdGU6bmlsXTsKLSAgICAgW3NlbGYgc2V0RGF0YVNvdXJjZTpuaWxdOworICAgIFtzZWxmIHNl dERhdGFTb3VyY2U6bmlsXTsKIAogICAgIFtzdXBlciBkZWFsbG9jXTsKIH0K