134403 2014-06-27 10:48:46 -0700 Update policy for Inactive Committer and Reviewer status 2014-07-23 11:51:00 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe bdakin bunhere cdumez commit-queue gyuyoung.kim sergio zecke oldest_to_newest 1019005 0 bjonesbe 2014-06-27 10:48:46 -0700 Update policy for Inactive Committer and Reviewer status 1019006 1 233996 bjonesbe 2014-06-27 10:49:09 -0700 Created attachment 233996 Patch 1019017 2 233996 bdakin 2014-06-27 11:02:08 -0700 Comment on attachment 233996 Patch This looks good to me! 1019042 3 233996 rniwa 2014-06-27 11:59:53 -0700 Comment on attachment 233996 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233996&action=review > Websites/webkit.org/coding/commit-review-policy.html:108 > +landing at least one patch in the past year.</p> or reviewing a patch for the reviewer status. > Websites/webkit.org/coding/commit-review-policy.html:111 > +<p>Inactive Committers can regain Active Committer status by simply landing a > +non-trivial patch and asking to return to Active status.</p> We might want to separately mention that subversion account not used to commit patches into the repository for more than one year will be deactivated for security reasons. 1019045 4 zecke 2014-06-27 12:09:16 -0700 What is the issue you are trying to solve? I am a WebKit reviewer, I look at the commits from time to time, I read the webkit-dev mailinglist but I have not reviewed or landed a patch in a very long time. Given the above definition I count as inactive contributor. On the other hand I am certainly not qualified to land or review patches right now. For me it would be natural to get more familiar with the code before landing patches again. 1019087 5 234015 bjonesbe 2014-06-27 14:22:30 -0700 Created attachment 234015 Patch 1019091 6 bjonesbe 2014-06-27 14:27:57 -0700 (In reply to comment #3) > (From update of attachment 233996 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233996&action=review > > > Websites/webkit.org/coding/commit-review-policy.html:108 > > +landing at least one patch in the past year.</p> > > or reviewing a patch for the reviewer status. > > > Websites/webkit.org/coding/commit-review-policy.html:111 > > +<p>Inactive Committers can regain Active Committer status by simply landing a > > +non-trivial patch and asking to return to Active status.</p> > > We might want to separately mention that subversion account not used to commit patches into the repository for more than one year will be deactivated for security reasons. I've uploaded a new version that incorporates these comments. 1019092 7 bjonesbe 2014-06-27 14:30:19 -0700 (In reply to comment #4) > What is the issue you are trying to solve? I am a WebKit reviewer, I look at the commits from time to time, I read the webkit-dev mailinglist but I have not reviewed or landed a patch in a very long time. Given the above definition I count as inactive contributor. > > On the other hand I am certainly not qualified to land or review patches right now. For me it would be natural to get more familiar with the code before landing patches again. The only issue I personally am trying to solve is that for new people it can be hard to know who to talk to for reviews, since the reviewer list is long and lists many people that are no longer even as active as you are. It would satisfy me if we just made it so that these inactive reviewers were listed separately on the team.html page. There was a security concern about having lots of inactive subversion accounts, and even with having inactive accounts that have access to things like EWS. I believe that's the main point in this, but hopefully some of those that feel more strongly about it than I can elaborate. 1021094 8 234565 bjonesbe 2014-07-08 09:10:15 -0700 Created attachment 234565 Patch 1021112 9 234565 thakis 2014-07-08 10:11:15 -0700 Comment on attachment 234565 Patch I feel it's in the spirit of this discussion if this is r+d by a (now no longer :-P) inactive reviewer. 1021243 10 234565 commit-queue 2014-07-08 16:58:32 -0700 Comment on attachment 234565 Patch Clearing flags on attachment: 234565 Committed r170904: <http://trac.webkit.org/changeset/170904> 1021244 11 commit-queue 2014-07-08 16:58:36 -0700 All reviewed patches have been landed. Closing bug. 1021363 12 234565 rniwa 2014-07-09 07:34:28 -0700 Comment on attachment 234565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234565&action=review > Websites/webkit.org/coding/commit-review-policy.html:127 > +Reviewer can send an email to webkit-reviewers requesting it.</p> This should be webkit-dev as committers can't post messages to webkit-reviewers. 1021374 13 234565 bjonesbe 2014-07-09 09:12:24 -0700 Comment on attachment 234565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234565&action=review >> Websites/webkit.org/coding/commit-review-policy.html:127 >> +Reviewer can send an email to webkit-reviewers requesting it.</p> > > This should be webkit-dev as committers can't post messages to webkit-reviewers. Or maybe webkit-committers? (same with committers wanting to be reactivated?) 1024277 14 bjonesbe 2014-07-23 11:51:00 -0700 (In reply to comment #13) > (From update of attachment 234565 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234565&action=review > > >> Websites/webkit.org/coding/commit-review-policy.html:127 > >> +Reviewer can send an email to webkit-reviewers requesting it.</p> > > > > This should be webkit-dev as committers can't post messages to webkit-reviewers. > > Or maybe webkit-committers? (same with committers wanting to be reactivated?) Haven't heard back, so I've created a patch with this change: https://bugs.webkit.org/show_bug.cgi?id=135203 233996 2014-06-27 10:49:09 -0700 2014-06-27 14:22:23 -0700 Patch bug-134403-20140627104848.patch text/plain 2072 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTMzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDQzZjky Yzk5YTlkZjM0NWIyNDYzNDAzMzFhNGU1Y2I2NTgyZDk3YjUuLjczOGEyMDZmMjQ0MTZlZTljZTQ0 NTMzNGFiNTkzOGFlYmJkZDdjNmMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDYtMjcgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAg ICAgICAgVXBkYXRlIHBvbGljeSBmb3IgSW5hY3RpdmUgQ29tbWl0dGVyIGFuZCBSZXZpZXdlciBz dGF0dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NDQwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Y29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWw6CisKIDIwMTQtMDYtMjYgIFZpdmVrIEdh bGF0YWdlICA8dml2ZWsudmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3ZlIFF0IGluc3Ry dWN0aW9ucyBmcm9tIGh0dHA6Ly93d3cud2Via2l0Lm9yZy9idWlsZGluZy90b29scy5odG1sIApk aWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xp Y3kuaHRtbCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5 Lmh0bWwKaW5kZXggY2NiNTBkZDM1OTU2MGI2OTJlMWE4NzRmOWJmMzk3NDQwZTZiY2FiYS4uMDc0 NDJmYTdkODcwMjhhNTUyYjNlY2UwODYwNmViYWFhZGZjMmMzZCAxMDA2NDQKLS0tIGEvV2Vic2l0 ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJz aXRlcy93ZWJraXQub3JnL2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC0xMDEs NiArMTAxLDIxIEBAIHVub2ZmaWNpYWwgcmV2aWV3cy48L3A+CiA8cD5BbGwgcmV2aWV3ZXIgbm9t aW5hdGlvbnMgcmVxdWlyZSB0aGUgc3VwcG9ydCBvZiBmb3VyIHJldmlld2Vycy4gT25lIHJldmll d2VyCiBub21pbmF0ZXMsIHRocmVlIHJldmlld2VycyBzZWNvbmQuPC9wPgogCis8aDM+SW5hY3Rp dmUgQ29tbWl0dGVyIG9yIFJldmlld2VyIFN0YXR1czwvaDM+CisKKzxwPkEgV2ViS2l0IENvbW1p dHRlciBvciBSZXZpZXdlciB0aGF0IGhhcyBub3QgYmVlbiBhY3RpdmUgaW4gdGhlIHByb2plY3Qg Zm9yCitvdmVyIGEgeWVhciBpcyBjb25zaWRlcmVkIGluYWN0aXZlLiBBY3Rpdml0eSBmb3IgdGhp cyBwdXJwb3NlIGlzIGRlZmluZWQgYXMKK2xhbmRpbmcgYXQgbGVhc3Qgb25lIHBhdGNoIGluIHRo ZSBwYXN0IHllYXIuPC9wPgorCis8cD5JbmFjdGl2ZSBDb21taXR0ZXJzIGNhbiByZWdhaW4gQWN0 aXZlIENvbW1pdHRlciBzdGF0dXMgYnkgc2ltcGx5IGxhbmRpbmcgYQorbm9uLXRyaXZpYWwgcGF0 Y2ggYW5kIGFza2luZyB0byByZXR1cm4gdG8gQWN0aXZlIHN0YXR1cy48L3A+CisKKzxwPkluYWN0 aXZlIFJldmlld2VycyBuZWVkIHRvIHNob3cgdGhhdCB0aGV5IGFyZSBtYWtpbmcgYW4gZWZmb3J0 IHRvIGdldAorZmFtaWxpYXIgd2l0aCB0aGUgY2hhbmdlcyB0aGF0IGhhdmUgaGFwcGVuZWQgaW4g dGhlIHByb2plY3Qgc2luY2UgdGhleSB3ZXJlCitsYXN0IGFjdGl2ZSBieSBsYW5kaW5nIGF0IGxl YXN0IDMgbm9uLXRyaXZpYWwgcGF0Y2hlcy4gT25jZSB0aGV5IGhhdmUgbGFuZGVkCit0aGUgcGF0 Y2hlcywgdGhleSBqdXN0IG5lZWQgdG8gZ2V0IHRoZSBzdXBwb3J0IG9mIDIgQWN0aXZlIFJldmll d2VycyB0byBiZQorcmVpbnN0YXRlZCBhcyBhbiBBY3RpdmUgUmV2aWV3ZXIuPC9wPgorCiA8aDM+ U3VzcGVuc2lvbiBhbmQgUmV2b2NhdGlvbiBvZiBDb21taXR0ZXIgb3IgUmV2aWV3ZXIgU3RhdHVz PC9oMz4KIAogPHA+V2ViS2l0IENvbW1pdHRlciBvciBXZWJLaXQgUmV2aWV3ZXIgc3RhdHVzIGNh biBiZSByZXZva2VkIGJ5IDIvMwo= 234015 2014-06-27 14:22:30 -0700 2014-07-08 09:10:10 -0700 Patch bug-134403-20140627142209.patch text/plain 2559 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNTMzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDQzZjky Yzk5YTlkZjM0NWIyNDYzNDAzMzFhNGU1Y2I2NTgyZDk3YjUuLjczOGEyMDZmMjQ0MTZlZTljZTQ0 NTMzNGFiNTkzOGFlYmJkZDdjNmMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDYtMjcgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAg ICAgICAgVXBkYXRlIHBvbGljeSBmb3IgSW5hY3RpdmUgQ29tbWl0dGVyIGFuZCBSZXZpZXdlciBz dGF0dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NDQwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Y29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWw6CisKIDIwMTQtMDYtMjYgIFZpdmVrIEdh bGF0YWdlICA8dml2ZWsudmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3ZlIFF0IGluc3Ry dWN0aW9ucyBmcm9tIGh0dHA6Ly93d3cud2Via2l0Lm9yZy9idWlsZGluZy90b29scy5odG1sIApk aWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xp Y3kuaHRtbCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5 Lmh0bWwKaW5kZXggY2NiNTBkZDM1OTU2MGI2OTJlMWE4NzRmOWJmMzk3NDQwZTZiY2FiYS4uMmUw MTE3YjZhZGQ5MjFjM2JkZjRlZGUwMTZhZDMxNTllYWQyOTRlOSAxMDA2NDQKLS0tIGEvV2Vic2l0 ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJz aXRlcy93ZWJraXQub3JnL2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC0xMDEs NiArMTAxLDI5IEBAIHVub2ZmaWNpYWwgcmV2aWV3cy48L3A+CiA8cD5BbGwgcmV2aWV3ZXIgbm9t aW5hdGlvbnMgcmVxdWlyZSB0aGUgc3VwcG9ydCBvZiBmb3VyIHJldmlld2Vycy4gT25lIHJldmll d2VyCiBub21pbmF0ZXMsIHRocmVlIHJldmlld2VycyBzZWNvbmQuPC9wPgogCis8aDM+SW5hY3Rp dmUgQ29tbWl0dGVyIG9yIFJldmlld2VyIFN0YXR1czwvaDM+CisKKzxwPkEgV2ViS2l0IENvbW1p dHRlciBvciBSZXZpZXdlciB0aGF0IGhhcyBub3QgYmVlbiBhY3RpdmUgaW4gdGhlIHByb2plY3Qg Zm9yCitvdmVyIGEgeWVhciBpcyBjb25zaWRlcmVkIGluYWN0aXZlLiBBY3Rpdml0eSBmb3IgdGhp cyBwdXJwb3NlIGlzIGRlZmluZWQgYXMKK2xhbmRpbmcgYXQgbGVhc3Qgb25lIHBhdGNoIGluIHRo ZSBwYXN0IHllYXIuIFJldmlld2VycyB3aG8gaGF2ZSByZXZpZXdlZCBhCitwYXRjaCBpbiB0aGUg cGFzdCB5ZWFyIHdpbGwgYWxzbyBiZSBjb25zaWRlcmVkIGFjdGl2ZS48L3A+CisKKzxwPkluYWN0 aXZlIENvbW1pdHRlcnMgY2FuIHJlZ2FpbiBBY3RpdmUgQ29tbWl0dGVyIHN0YXR1cyBieSBzaW1w bHkgbGFuZGluZyBhCitub24tdHJpdmlhbCBwYXRjaCBhbmQgYXNraW5nIHRvIHJldHVybiB0byBB Y3RpdmUgc3RhdHVzLjwvcD4KKworPHA+SW5hY3RpdmUgUmV2aWV3ZXJzIG5lZWQgdG8gc2hvdyB0 aGF0IHRoZXkgYXJlIG1ha2luZyBhbiBlZmZvcnQgdG8gZ2V0CitmYW1pbGlhciB3aXRoIHRoZSBj aGFuZ2VzIHRoYXQgaGF2ZSBoYXBwZW5lZCBpbiB0aGUgcHJvamVjdCBzaW5jZSB0aGV5IHdlcmUK K2xhc3QgYWN0aXZlIGJ5IGxhbmRpbmcgYXQgbGVhc3QgMyBub24tdHJpdmlhbCBwYXRjaGVzLiBP bmNlIHRoZXkgaGF2ZSBsYW5kZWQKK3RoZSBwYXRjaGVzLCB0aGV5IGp1c3QgbmVlZCB0byBnZXQg dGhlIHN1cHBvcnQgb2YgMiBBY3RpdmUgUmV2aWV3ZXJzIHRvIGJlCityZWluc3RhdGVkIGFzIGFu IEFjdGl2ZSBSZXZpZXdlci48L3A+CisKKzxwPk5vdGUgdGhhdCByZWdhcmRsZXNzIG9mIGEgQ29t bWl0dGVyIG9yIFJldmlld2VyJ3MgYWN0aXZpdHkgc3RhdHVzLCBhbnkKK3N1YnZlcnNpb24gYWNj b3VudCB0aGF0IGhhcyBub3QgYmVlbiB1c2VkIGluIHRoZSBwYXN0IHllYXIgd2lsbCBiZSBkZWFj dGl2YXRlZAorZm9yIHNlY3VyaXR5IHB1cnBvc2VzLiBGb3IgZXhhbXBsZSwgYSBSZXZpZXdlciB0 aGF0IGhhcyByZXZpZXdlZCBhIHBhdGNoIGluIHRoZQorcGFzdCB5ZWFyIGJ1dCBoYXMgbm90IGNv bW1pdHRlZCBtYXkgaGF2ZSB0aGVpciBzdWJ2ZXJzaW9uIGFjY291bnQgZGVhY3RpdmF0ZWQuCitS ZWFjdGl2YXRpbmcgYSBkZWFjdGl2YXRlZCBzdWJ2ZXJzaW9uIGFjY291bnQgaXMgYXMgc2ltcGxl IGFzIHJlcXVlc3RpbmcKK2l0LjwvcD4KKwogPGgzPlN1c3BlbnNpb24gYW5kIFJldm9jYXRpb24g b2YgQ29tbWl0dGVyIG9yIFJldmlld2VyIFN0YXR1czwvaDM+CiAKIDxwPldlYktpdCBDb21taXR0 ZXIgb3IgV2ViS2l0IFJldmlld2VyIHN0YXR1cyBjYW4gYmUgcmV2b2tlZCBieSAyLzMK 234565 2014-07-08 09:10:15 -0700 2014-07-09 09:12:24 -0700 Patch bug-134403-20140708090957.patch text/plain 2707 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODQ0CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDQzZjky Yzk5YTlkZjM0NWIyNDYzNDAzMzFhNGU1Y2I2NTgyZDk3YjUuLjljZjhhYWY2N2RkNzliMjI4ZjFk YjE4ZTkyNWIzMTBhMTI3NzQ1ZjAgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDctMDggIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAg ICAgICAgVXBkYXRlIHBvbGljeSBmb3IgSW5hY3RpdmUgQ29tbWl0dGVyIGFuZCBSZXZpZXdlciBz dGF0dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NDQwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Y29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWw6CisKIDIwMTQtMDYtMjYgIFZpdmVrIEdh bGF0YWdlICA8dml2ZWsudmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3ZlIFF0IGluc3Ry dWN0aW9ucyBmcm9tIGh0dHA6Ly93d3cud2Via2l0Lm9yZy9idWlsZGluZy90b29scy5odG1sIApk aWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xp Y3kuaHRtbCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5 Lmh0bWwKaW5kZXggY2NiNTBkZDM1OTU2MGI2OTJlMWE4NzRmOWJmMzk3NDQwZTZiY2FiYS4uMTU4 MmU1MGE3N2RmZTAxMDE5YjAwMGEzYmY1YjVkYTc3ZWZmNGNlYSAxMDA2NDQKLS0tIGEvV2Vic2l0 ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJz aXRlcy93ZWJraXQub3JnL2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC0xMDEs NiArMTAxLDMxIEBAIHVub2ZmaWNpYWwgcmV2aWV3cy48L3A+CiA8cD5BbGwgcmV2aWV3ZXIgbm9t aW5hdGlvbnMgcmVxdWlyZSB0aGUgc3VwcG9ydCBvZiBmb3VyIHJldmlld2Vycy4gT25lIHJldmll d2VyCiBub21pbmF0ZXMsIHRocmVlIHJldmlld2VycyBzZWNvbmQuPC9wPgogCis8aDM+SW5hY3Rp dmUgQ29tbWl0dGVyIG9yIFJldmlld2VyIFN0YXR1czwvaDM+CisKKzxwPkEgV2ViS2l0IENvbW1p dHRlciBvciBSZXZpZXdlciB0aGF0IGhhcyBub3QgYmVlbiBhY3RpdmUgaW4gdGhlIHByb2plY3Qg Zm9yCitvdmVyIGEgeWVhciBpcyBjb25zaWRlcmVkIGluYWN0aXZlLiBBY3Rpdml0eSBmb3IgdGhp cyBwdXJwb3NlIGlzIGRlZmluZWQgYXMKK2xhbmRpbmcgYXQgbGVhc3Qgb25lIHBhdGNoIGluIHRo ZSBwYXN0IHllYXIuIFJldmlld2VycyB3aG8gaGF2ZSByZXZpZXdlZCBhCitwYXRjaCBpbiB0aGUg cGFzdCB5ZWFyIHdpbGwgYWxzbyBiZSBjb25zaWRlcmVkIGFjdGl2ZS48L3A+CisKKzxwPkluYWN0 aXZlIENvbW1pdHRlcnMgY2FuIHJlZ2FpbiBBY3RpdmUgQ29tbWl0dGVyIHN0YXR1cyBieSBsYW5k aW5nICh2aWEgdGhlCitDb21taXQgUXVldWUpIGEgbm9uLXRyaXZpYWwgcGF0Y2ggYW5kIGFza2lu ZyBvbiB3ZWJraXQtcmV2aWV3ZXJzIGZvciBhIHJldHVybgordG8gQWN0aXZlIHN0YXR1cy48L3A+ CisKKzxwPkluYWN0aXZlIFJldmlld2VycyBuZWVkIHRvIHNob3cgdGhhdCB0aGV5IGFyZSBtYWtp bmcgYW4gZWZmb3J0IHRvIGdldAorZmFtaWxpYXIgd2l0aCB0aGUgY2hhbmdlcyB0aGF0IGhhdmUg aGFwcGVuZWQgaW4gdGhlIHByb2plY3Qgc2luY2UgdGhleSB3ZXJlCitsYXN0IGFjdGl2ZSBieSBs YW5kaW5nIGF0IGxlYXN0IDMgbm9uLXRyaXZpYWwgcGF0Y2hlcy4gT25jZSB0aGV5IGhhdmUgbGFu ZGVkCit0aGUgcGF0Y2hlcywgdGhleSBuZWVkIHRvIHNlbmQgYW4gZW1haWwgcmVxdWVzdGluZyBy ZWFjdGl2YXRpb24gdG8KK3dlYmtpdC1yZXZpZXdlcnMuIFRoaXMgcmVxdWVzdCBuZWVkcyB0aGUg c3VwcG9ydCBvZiAyIEFjdGl2ZSBSZXZpZXdlcnMgdG8gYmUKK2dyYW50ZWQuPC9wPgorCis8cD5O b3RlIHRoYXQgcmVnYXJkbGVzcyBvZiBhIENvbW1pdHRlciBvciBSZXZpZXdlcidzIGFjdGl2aXR5 IHN0YXR1cywgYW55CitzdWJ2ZXJzaW9uIGFjY291bnQgdGhhdCBoYXMgbm90IGJlZW4gdXNlZCBp biB0aGUgcGFzdCB5ZWFyIHdpbGwgYmUgZGVhY3RpdmF0ZWQKK2ZvciBzZWN1cml0eSBwdXJwb3Nl cy4gRm9yIGV4YW1wbGUsIGEgUmV2aWV3ZXIgdGhhdCBoYXMgcmV2aWV3ZWQgYSBwYXRjaCBpbiB0 aGUKK3Bhc3QgeWVhciBidXQgaGFzIG5vdCBjb21taXR0ZWQgbWF5IGhhdmUgdGhlaXIgc3VidmVy c2lvbiBhY2NvdW50IGRlYWN0aXZhdGVkLgorVG8gcmVhY3RpdmF0ZSBhIGRlYWN0aXZhdGVkIHN1 YnZlcnNpb24gYWNjb3VudCwgYW4gQWN0aXZlIENvbW1pdHRlciBvciBBY3RpdmUKK1Jldmlld2Vy IGNhbiBzZW5kIGFuIGVtYWlsIHRvIHdlYmtpdC1yZXZpZXdlcnMgcmVxdWVzdGluZyBpdC48L3A+ CisKIDxoMz5TdXNwZW5zaW9uIGFuZCBSZXZvY2F0aW9uIG9mIENvbW1pdHRlciBvciBSZXZpZXdl ciBTdGF0dXM8L2gzPgogCiA8cD5XZWJLaXQgQ29tbWl0dGVyIG9yIFdlYktpdCBSZXZpZXdlciBz dGF0dXMgY2FuIGJlIHJldm9rZWQgYnkgMi8zCg==