13440 2007-04-21 17:21:57 -0700 minmax width "optimization" is completely bogus. 2007-04-25 15:24:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 13431 1 hyatt hyatt oldest_to_newest 13369 0 hyatt 2007-04-21 17:21:57 -0700 recalcMinMaxWidth contains an optimization where it attempts to avoid doing a recalc if a block child's minwidth and maxwidth stay the same. This is a bogus optimization, since a child can have any number of properties change on it (such as float or clear or overflow) that will affect the parent's min max width computations 13370 1 14128 hyatt 2007-04-21 17:23:15 -0700 Created attachment 14128 Test case showing the problem Here is a test case illustrating the issue. Maxwidth is computed for a container with two floats inside it. If you then dynamically unfloat one of the children, its minwidth/maxwidth don't change. Therefore the parent does not bother to recomputed its maxwidth, even though the new result would be different. 13345 2 hyatt 2007-04-21 17:25:54 -0700 Relating this to 13431, since my rework of calcMinMaxWidth should fix this problem without adversely affecting performance. 12438 3 hyatt 2007-04-25 15:24:56 -0700 Fixed by lazy minmaxwidth patch. I landed this test case in r21100. 14128 2007-04-21 17:23:15 -0700 2007-04-21 17:23:15 -0700 Test case showing the problem minmax.html text/html 410 hyatt PGhlYWQ+CjxzdHlsZT4KI2NvbnRhaW5lciB7IGJvcmRlcjoycHggc29saWQgYmx1ZTsgfQojY29u dGFpbmVyOmhvdmVyIHsgYm9yZGVyOjVweCBzb2xpZCBsaW1lOyB9CiNvbmUgeyBib3JkZXI6MnB4 IHNvbGlkIG9yYW5nZSB9Cjwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+CjxkaXYgaWQ9ImNvbnRhaW5l ciIgc3R5bGU9InBvc2l0aW9uOmFic29sdXRlOyI+CjxkaXYgaWQ9Im9uZSIgc3R5bGU9ImZsb2F0 OmxlZnQiPk9uZTwvZGl2PjxkaXYgc3R5bGU9ImZsb2F0OmxlZnQ7Ij5Ud288L2Rpdj4KPC9kaXY+ Cgo8cCBzdHlsZT0icGFkZGluZy10b3A6NTBweCI+CjxpbnB1dCB0eXBlPWJ1dHRvbiB2YWx1ZT0i VW5mbG9hdCIgb25jbGljaz0iZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ29uZScpLnN0eWxlLmNz c0Zsb2F0PScnIj4=