<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134381</bug_id>
          
          <creation_ts>2014-06-26 20:58:12 -0700</creation_ts>
          <short_desc>HIDGamepads should populate themselves with initial input values</short_desc>
          <delta_ts>2022-03-01 02:54:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>134076</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Brady Eidson">beidson</reporter>
          <assigned_to name="Brady Eidson">beidson</assigned_to>
          <cc>bunhere</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1018857</commentid>
    <comment_count>0</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 20:58:12 -0700</bug_when>
    <thetext>HIDGamepads should populate themselves with initial input values.

At construction time, for each element they own they should query the HIDElement on the device.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018872</commentid>
    <comment_count>1</comment_count>
      <attachid>233961</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 22:27:07 -0700</bug_when>
    <thetext>Created attachment 233961
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018873</commentid>
    <comment_count>2</comment_count>
      <attachid>233962</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 22:30:26 -0700</bug_when>
    <thetext>Created attachment 233962
Patch v2 - Now with 100% more ChangeLog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018889</commentid>
    <comment_count>3</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 23:02:33 -0700</bug_when>
    <thetext>Ignore the can&apos;t-buildness that EWS sees - In my tree this patch is built on previous patches.  I will pass it through EWS before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018986</commentid>
    <comment_count>4</comment_count>
      <attachid>233962</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2014-06-27 09:54:45 -0700</bug_when>
    <thetext>Comment on attachment 233962
Patch v2 - Now with 100% more ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=233962&amp;action=review

Patch didn’t apply in EWS.

&gt; Source/WebCore/platform/mac/HIDGamepad.cpp:75
&gt; +    IOHIDValueRef value;

I think a local just before each call to IOHIDDeviceGetValue would be nicer than sharing this local.

&gt; Source/WebCore/platform/mac/HIDGamepad.cpp:79
&gt; +        IOHIDElementRef element = button-&gt;iohidElement.get();
&gt; +        if (IOHIDDeviceGetValue(IOHIDElementGetDevice(element), element, &amp;value) == kIOReturnSuccess)
&gt; +            valueChanged(value);

I know this sounds a little silly, but a helper that takes an const HIDGamepadElement&amp; and does all this would make the code tigther and easier to read.

&gt; Source/WebCore/platform/mac/HIDGamepad.h:80
&gt;  struct HIDGamepadAxis : public HIDGamepadElement {

Normally with struct inheritance we would omit the &quot;public&quot; (it&apos;s the default).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019077</commentid>
    <comment_count>5</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-27 13:53:59 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/170551</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>233961</attachid>
            <date>2014-06-26 22:27:07 -0700</date>
            <delta_ts>2014-06-26 22:30:26 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>3413</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9ISURHYW1lcGFkLmNwcCBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9ISURHYW1lcGFkLmNwcAppbmRleCBkZWM3YjQw
Li5mZmUxZTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSElER2Ft
ZXBhZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuY3Bw
CkBAIC03MSw2ICs3MSwxOSBAQCB2b2lkIEhJREdhbWVwYWQ6OmluaXRFbGVtZW50cygpCiAKICAg
ICBtX2F4aXNWYWx1ZXMucmVzaXplKG1fYXhlcy5zaXplKCkpOwogICAgIG1fYnV0dG9uVmFsdWVz
LnJlc2l6ZShtX2J1dHRvbnMuc2l6ZSgpKTsKKworICAgIElPSElEVmFsdWVSZWYgdmFsdWU7Cisg
ICAgZm9yIChhdXRvJiBidXR0b24gOiBtX2J1dHRvbnMpIHsKKyAgICAgICAgSU9ISURFbGVtZW50
UmVmIGVsZW1lbnQgPSBidXR0b24tPmlvaGlkRWxlbWVudC5nZXQoKTsKKyAgICAgICAgaWYgKElP
SElERGV2aWNlR2V0VmFsdWUoSU9ISURFbGVtZW50R2V0RGV2aWNlKGVsZW1lbnQpLCBlbGVtZW50
LCAmdmFsdWUpID09IGtJT1JldHVyblN1Y2Nlc3MpCisgICAgICAgICAgICB2YWx1ZUNoYW5nZWQo
dmFsdWUpOworICAgIH0KKworICAgIGZvciAoYXV0byYgYXhpcyA6IG1fYXhlcykgeworICAgICAg
ICBJT0hJREVsZW1lbnRSZWYgZWxlbWVudCA9IGF4aXMtPmlvaGlkRWxlbWVudC5nZXQoKTsKKyAg
ICAgICAgaWYgKElPSElERGV2aWNlR2V0VmFsdWUoSU9ISURFbGVtZW50R2V0RGV2aWNlKGVsZW1l
bnQpLCBlbGVtZW50LCAmdmFsdWUpID09IGtJT1JldHVyblN1Y2Nlc3MpCisgICAgICAgICAgICB2
YWx1ZUNoYW5nZWQodmFsdWUpOworICAgIH0KIH0KIAogdm9pZCBISURHYW1lcGFkOjppbml0RWxl
bWVudHNGcm9tQXJyYXkoQ0ZBcnJheVJlZiBlbGVtZW50cykKQEAgLTExMyw3ICsxMjYsNyBAQCBi
b29sIEhJREdhbWVwYWQ6Om1heWJlQWRkQnV0dG9uKElPSElERWxlbWVudFJlZiBlbGVtZW50KQog
ICAgIENGSW5kZXggbWluID0gSU9ISURFbGVtZW50R2V0TG9naWNhbE1pbihlbGVtZW50KTsKICAg
ICBDRkluZGV4IG1heCA9IElPSElERWxlbWVudEdldExvZ2ljYWxNYXgoZWxlbWVudCk7CiAKLSAg
ICBtX2J1dHRvbnMuYXBwZW5kKHN0ZDo6bWFrZV91bmlxdWU8SElER2FtZXBhZEJ1dHRvbj4odXNh
Z2UsIG1pbiwgbWF4KSk7CisgICAgbV9idXR0b25zLmFwcGVuZChzdGQ6Om1ha2VfdW5pcXVlPEhJ
REdhbWVwYWRCdXR0b24+KHVzYWdlLCBtaW4sIG1heCwgZWxlbWVudCkpOwogCiAgICAgSU9ISURF
bGVtZW50Q29va2llIGNvb2tpZSA9IElPSElERWxlbWVudEdldENvb2tpZShlbGVtZW50KTsKICAg
ICBtX2VsZW1lbnRNYXAuc2V0KGNvb2tpZSwgbV9idXR0b25zLmxhc3QoKS5nZXQoKSk7CkBAIC0x
MzUsNyArMTQ4LDcgQEAgYm9vbCBISURHYW1lcGFkOjptYXliZUFkZEF4aXMoSU9ISURFbGVtZW50
UmVmIGVsZW1lbnQpCiAgICAgQ0ZJbmRleCBtaW4gPSBJT0hJREVsZW1lbnRHZXRQaHlzaWNhbE1p
bihlbGVtZW50KTsKICAgICBDRkluZGV4IG1heCA9IElPSElERWxlbWVudEdldFBoeXNpY2FsTWF4
KGVsZW1lbnQpOwogCi0gICAgbV9heGVzLmFwcGVuZChzdGQ6Om1ha2VfdW5pcXVlPEhJREdhbWVw
YWRBeGlzPihtaW4sIG1heCkpOworICAgIG1fYXhlcy5hcHBlbmQoc3RkOjptYWtlX3VuaXF1ZTxI
SURHYW1lcGFkQXhpcz4obWluLCBtYXgsIGVsZW1lbnQpKTsKIAogICAgIElPSElERWxlbWVudENv
b2tpZSBjb29raWUgPSBJT0hJREVsZW1lbnRHZXRDb29raWUoZWxlbWVudCk7CiAgICAgbV9lbGVt
ZW50TWFwLnNldChjb29raWUsIG1fYXhlcy5sYXN0KCkuZ2V0KCkpOwpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL21hYy9ISURHYW1lcGFkLmgKaW5kZXggMmQ4MGZlZi4uNDhmMTQwZSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuaAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9tYWMvSElER2FtZXBhZC5oCkBAIC0zNiwxMCArMzYsMTEgQEAKIG5h
bWVzcGFjZSBXZWJDb3JlIHsKIAogc3RydWN0IEhJREdhbWVwYWRFbGVtZW50IHsKLSAgICBISURH
YW1lcGFkRWxlbWVudChkb3VibGUgdGhlTWluLCBkb3VibGUgdGhlTWF4KQorICAgIEhJREdhbWVw
YWRFbGVtZW50KGRvdWJsZSB0aGVNaW4sIGRvdWJsZSB0aGVNYXgsIElPSElERWxlbWVudFJlZiBl
bGVtZW50KQogICAgICAgICA6IG1pbih0aGVNaW4pCiAgICAgICAgICwgbWF4KHRoZU1heCkKICAg
ICAgICAgLCByYXdWYWx1ZSh0aGVNaW4pCisgICAgICAgICwgaW9oaWRFbGVtZW50KGVsZW1lbnQp
CiAgICAgewogICAgIH0KICAgICAKQEAgLTUwLDYgKzUxLDcgQEAgc3RydWN0IEhJREdhbWVwYWRF
bGVtZW50IHsKICAgICBkb3VibGUgbWluOwogICAgIGRvdWJsZSBtYXg7CiAgICAgZG91YmxlIHJh
d1ZhbHVlOworICAgIFJldGFpblB0cjxJT0hJREVsZW1lbnRSZWY+IGlvaGlkRWxlbWVudDsKIAog
ICAgIHZpcnR1YWwgYm9vbCBpc0J1dHRvbigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAg
dmlydHVhbCBib29sIGlzQXhpcygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CkBAIC01OCw4ICs2
MCw4IEBAIHN0cnVjdCBISURHYW1lcGFkRWxlbWVudCB7CiB9OwogCiBzdHJ1Y3QgSElER2FtZXBh
ZEJ1dHRvbiA6IHB1YmxpYyBISURHYW1lcGFkRWxlbWVudCB7Ci0gICAgSElER2FtZXBhZEJ1dHRv
bih1aW50MzJfdCB0aGVQcmlvcml0eSwgZG91YmxlIG1pbiwgZG91YmxlIG1heCkKLSAgICAgICAg
OiBISURHYW1lcGFkRWxlbWVudChtaW4sIG1heCkKKyAgICBISURHYW1lcGFkQnV0dG9uKHVpbnQz
Ml90IHRoZVByaW9yaXR5LCBkb3VibGUgbWluLCBkb3VibGUgbWF4LCBJT0hJREVsZW1lbnRSZWYg
ZWxlbWVudCkKKyAgICAgICAgOiBISURHYW1lcGFkRWxlbWVudChtaW4sIG1heCwgZWxlbWVudCkK
ICAgICAgICAgLCBwcmlvcml0eSh0aGVQcmlvcml0eSkKICAgICB7CiAgICAgfQpAQCAtNzYsOCAr
NzgsOCBAQCBzdHJ1Y3QgSElER2FtZXBhZEJ1dHRvbiA6IHB1YmxpYyBISURHYW1lcGFkRWxlbWVu
dCB7CiB9OwogCiBzdHJ1Y3QgSElER2FtZXBhZEF4aXMgOiBwdWJsaWMgSElER2FtZXBhZEVsZW1l
bnQgewotICAgIEhJREdhbWVwYWRBeGlzKGRvdWJsZSBtaW4sIGRvdWJsZSBtYXgpCi0gICAgICAg
IDogSElER2FtZXBhZEVsZW1lbnQobWluLCBtYXgpCisgICAgSElER2FtZXBhZEF4aXMoZG91Ymxl
IG1pbiwgZG91YmxlIG1heCwgSU9ISURFbGVtZW50UmVmIGVsZW1lbnQpCisgICAgICAgIDogSElE
R2FtZXBhZEVsZW1lbnQobWluLCBtYXgsIGVsZW1lbnQpCiAgICAgewogICAgIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>233962</attachid>
            <date>2014-06-26 22:30:26 -0700</date>
            <delta_ts>2022-03-01 02:54:08 -0800</delta_ts>
            <desc>Patch v2 - Now with 100% more ChangeLog</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>4360</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA2NmQ5ZjI1Li41OWEzZDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDEgKzEsMjEg
QEAKKyAyMDE0LTA2LTI2ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAg
ICAgICBISURHYW1lcGFkcyBzaG91bGQgcG9wdWxhdGUgdGhlbXNlbHZlcyB3aXRoIGluaXRpYWwg
aW5wdXQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xMzQzODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBObyBuZXcgdGVzdHMgKE5vdCB5ZXQgYSB0ZXN0ZWQgY29uZmlnKQorCisgICAgICAgICog
cGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SElER2FtZXBh
ZDo6aW5pdEVsZW1lbnRzKTogTG9vcCB0aHJvdWdoIGFsbCB0aGUgc2F2ZWQgZWxlbWVudHMgdG8g
Z2V0IGN1cnJlbnQgdmFsdWVzLgorICAgICAgICAoV2ViQ29yZTo6SElER2FtZXBhZDo6bWF5YmVB
ZGRCdXR0b24pOgorICAgICAgICAoV2ViQ29yZTo6SElER2FtZXBhZDo6bWF5YmVBZGRBeGlzKToK
KworICAgICAgICAqIHBsYXRmb3JtL21hYy9ISURHYW1lcGFkLmg6CisgICAgICAgIChXZWJDb3Jl
OjpISURHYW1lcGFkRWxlbWVudDo6SElER2FtZXBhZEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29y
ZTo6SElER2FtZXBhZEJ1dHRvbjo6SElER2FtZXBhZEJ1dHRvbik6CisgICAgICAgIChXZWJDb3Jl
OjpISURHYW1lcGFkQXhpczo6SElER2FtZXBhZEF4aXMpOgogCiAyMDE0LTA2LTI2ICBCYWxhenMg
S2VsZW1lbiAgPGIua2VsZW1lbkBzYW1zdW5nLmNvbT4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vbWFjL0hJREdhbWVwYWQuY3BwCmluZGV4IGRlYzdiNDAuLmZmZTFlNTQgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9ISURHYW1lcGFkLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9tYWMvSElER2FtZXBhZC5jcHAKQEAgLTcxLDYgKzcxLDE5IEBAIHZv
aWQgSElER2FtZXBhZDo6aW5pdEVsZW1lbnRzKCkKIAogICAgIG1fYXhpc1ZhbHVlcy5yZXNpemUo
bV9heGVzLnNpemUoKSk7CiAgICAgbV9idXR0b25WYWx1ZXMucmVzaXplKG1fYnV0dG9ucy5zaXpl
KCkpOworCisgICAgSU9ISURWYWx1ZVJlZiB2YWx1ZTsKKyAgICBmb3IgKGF1dG8mIGJ1dHRvbiA6
IG1fYnV0dG9ucykgeworICAgICAgICBJT0hJREVsZW1lbnRSZWYgZWxlbWVudCA9IGJ1dHRvbi0+
aW9oaWRFbGVtZW50LmdldCgpOworICAgICAgICBpZiAoSU9ISUREZXZpY2VHZXRWYWx1ZShJT0hJ
REVsZW1lbnRHZXREZXZpY2UoZWxlbWVudCksIGVsZW1lbnQsICZ2YWx1ZSkgPT0ga0lPUmV0dXJu
U3VjY2VzcykKKyAgICAgICAgICAgIHZhbHVlQ2hhbmdlZCh2YWx1ZSk7CisgICAgfQorCisgICAg
Zm9yIChhdXRvJiBheGlzIDogbV9heGVzKSB7CisgICAgICAgIElPSElERWxlbWVudFJlZiBlbGVt
ZW50ID0gYXhpcy0+aW9oaWRFbGVtZW50LmdldCgpOworICAgICAgICBpZiAoSU9ISUREZXZpY2VH
ZXRWYWx1ZShJT0hJREVsZW1lbnRHZXREZXZpY2UoZWxlbWVudCksIGVsZW1lbnQsICZ2YWx1ZSkg
PT0ga0lPUmV0dXJuU3VjY2VzcykKKyAgICAgICAgICAgIHZhbHVlQ2hhbmdlZCh2YWx1ZSk7Cisg
ICAgfQogfQogCiB2b2lkIEhJREdhbWVwYWQ6OmluaXRFbGVtZW50c0Zyb21BcnJheShDRkFycmF5
UmVmIGVsZW1lbnRzKQpAQCAtMTEzLDcgKzEyNiw3IEBAIGJvb2wgSElER2FtZXBhZDo6bWF5YmVB
ZGRCdXR0b24oSU9ISURFbGVtZW50UmVmIGVsZW1lbnQpCiAgICAgQ0ZJbmRleCBtaW4gPSBJT0hJ
REVsZW1lbnRHZXRMb2dpY2FsTWluKGVsZW1lbnQpOwogICAgIENGSW5kZXggbWF4ID0gSU9ISURF
bGVtZW50R2V0TG9naWNhbE1heChlbGVtZW50KTsKIAotICAgIG1fYnV0dG9ucy5hcHBlbmQoc3Rk
OjptYWtlX3VuaXF1ZTxISURHYW1lcGFkQnV0dG9uPih1c2FnZSwgbWluLCBtYXgpKTsKKyAgICBt
X2J1dHRvbnMuYXBwZW5kKHN0ZDo6bWFrZV91bmlxdWU8SElER2FtZXBhZEJ1dHRvbj4odXNhZ2Us
IG1pbiwgbWF4LCBlbGVtZW50KSk7CiAKICAgICBJT0hJREVsZW1lbnRDb29raWUgY29va2llID0g
SU9ISURFbGVtZW50R2V0Q29va2llKGVsZW1lbnQpOwogICAgIG1fZWxlbWVudE1hcC5zZXQoY29v
a2llLCBtX2J1dHRvbnMubGFzdCgpLmdldCgpKTsKQEAgLTEzNSw3ICsxNDgsNyBAQCBib29sIEhJ
REdhbWVwYWQ6Om1heWJlQWRkQXhpcyhJT0hJREVsZW1lbnRSZWYgZWxlbWVudCkKICAgICBDRklu
ZGV4IG1pbiA9IElPSElERWxlbWVudEdldFBoeXNpY2FsTWluKGVsZW1lbnQpOwogICAgIENGSW5k
ZXggbWF4ID0gSU9ISURFbGVtZW50R2V0UGh5c2ljYWxNYXgoZWxlbWVudCk7CiAKLSAgICBtX2F4
ZXMuYXBwZW5kKHN0ZDo6bWFrZV91bmlxdWU8SElER2FtZXBhZEF4aXM+KG1pbiwgbWF4KSk7Cisg
ICAgbV9heGVzLmFwcGVuZChzdGQ6Om1ha2VfdW5pcXVlPEhJREdhbWVwYWRBeGlzPihtaW4sIG1h
eCwgZWxlbWVudCkpOwogCiAgICAgSU9ISURFbGVtZW50Q29va2llIGNvb2tpZSA9IElPSElERWxl
bWVudEdldENvb2tpZShlbGVtZW50KTsKICAgICBtX2VsZW1lbnRNYXAuc2V0KGNvb2tpZSwgbV9h
eGVzLmxhc3QoKS5nZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t
YWMvSElER2FtZXBhZC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQu
aAppbmRleCAyZDgwZmVmLi40OGYxNDBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9tYWMvSElER2FtZXBhZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9I
SURHYW1lcGFkLmgKQEAgLTM2LDEwICszNiwxMSBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBz
dHJ1Y3QgSElER2FtZXBhZEVsZW1lbnQgewotICAgIEhJREdhbWVwYWRFbGVtZW50KGRvdWJsZSB0
aGVNaW4sIGRvdWJsZSB0aGVNYXgpCisgICAgSElER2FtZXBhZEVsZW1lbnQoZG91YmxlIHRoZU1p
biwgZG91YmxlIHRoZU1heCwgSU9ISURFbGVtZW50UmVmIGVsZW1lbnQpCiAgICAgICAgIDogbWlu
KHRoZU1pbikKICAgICAgICAgLCBtYXgodGhlTWF4KQogICAgICAgICAsIHJhd1ZhbHVlKHRoZU1p
bikKKyAgICAgICAgLCBpb2hpZEVsZW1lbnQoZWxlbWVudCkKICAgICB7CiAgICAgfQogICAgIApA
QCAtNTAsNiArNTEsNyBAQCBzdHJ1Y3QgSElER2FtZXBhZEVsZW1lbnQgewogICAgIGRvdWJsZSBt
aW47CiAgICAgZG91YmxlIG1heDsKICAgICBkb3VibGUgcmF3VmFsdWU7CisgICAgUmV0YWluUHRy
PElPSElERWxlbWVudFJlZj4gaW9oaWRFbGVtZW50OwogCiAgICAgdmlydHVhbCBib29sIGlzQnV0
dG9uKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNBeGlzKCkg
Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0KQEAgLTU4LDggKzYwLDggQEAgc3RydWN0IEhJREdhbWVw
YWRFbGVtZW50IHsKIH07CiAKIHN0cnVjdCBISURHYW1lcGFkQnV0dG9uIDogcHVibGljIEhJREdh
bWVwYWRFbGVtZW50IHsKLSAgICBISURHYW1lcGFkQnV0dG9uKHVpbnQzMl90IHRoZVByaW9yaXR5
LCBkb3VibGUgbWluLCBkb3VibGUgbWF4KQotICAgICAgICA6IEhJREdhbWVwYWRFbGVtZW50KG1p
biwgbWF4KQorICAgIEhJREdhbWVwYWRCdXR0b24odWludDMyX3QgdGhlUHJpb3JpdHksIGRvdWJs
ZSBtaW4sIGRvdWJsZSBtYXgsIElPSElERWxlbWVudFJlZiBlbGVtZW50KQorICAgICAgICA6IEhJ
REdhbWVwYWRFbGVtZW50KG1pbiwgbWF4LCBlbGVtZW50KQogICAgICAgICAsIHByaW9yaXR5KHRo
ZVByaW9yaXR5KQogICAgIHsKICAgICB9CkBAIC03Niw4ICs3OCw4IEBAIHN0cnVjdCBISURHYW1l
cGFkQnV0dG9uIDogcHVibGljIEhJREdhbWVwYWRFbGVtZW50IHsKIH07CiAKIHN0cnVjdCBISURH
YW1lcGFkQXhpcyA6IHB1YmxpYyBISURHYW1lcGFkRWxlbWVudCB7Ci0gICAgSElER2FtZXBhZEF4
aXMoZG91YmxlIG1pbiwgZG91YmxlIG1heCkKLSAgICAgICAgOiBISURHYW1lcGFkRWxlbWVudCht
aW4sIG1heCkKKyAgICBISURHYW1lcGFkQXhpcyhkb3VibGUgbWluLCBkb3VibGUgbWF4LCBJT0hJ
REVsZW1lbnRSZWYgZWxlbWVudCkKKyAgICAgICAgOiBISURHYW1lcGFkRWxlbWVudChtaW4sIG1h
eCwgZWxlbWVudCkKICAgICB7CiAgICAgfQogCg==
</data>
<flag name="review"
          id="258486"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>