134368 2014-06-26 16:51:02 -0700 Don't leak WKBrowsingContextControllers 2014-06-26 17:01:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 thorton thorton andersca mitz sam oldest_to_newest 1018796 0 thorton 2014-06-26 16:51:02 -0700 This regressed in http://trac.webkit.org/changeset/162580/trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm <rdar://problem/17476582> 1018799 1 233945 thorton 2014-06-26 16:52:32 -0700 Created attachment 233945 patch 1018800 2 233945 thorton 2014-06-26 16:53:05 -0700 Comment on attachment 233945 patch Sam reviewed this in person. 1018801 3 thorton 2014-06-26 16:54:12 -0700 http://trac.webkit.org/changeset/170508 233945 2014-06-26 16:52:32 -0700 2014-06-26 16:53:04 -0700 patch leak.diff text/plain 1349 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNjFmODRhLi5lYTE0YzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDYtMjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRG9uJ3QgbGVhayBXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQzNjgKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE3NDc2NTgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAg ICAoLVtXS1ZpZXcgYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlcl0pOgorICAgICAgICBBZG9wdGlv biBpcyBpbXBvcnRhbnQuCisKIDIwMTQtMDYtMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRv bkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gU2hhZG93IGxheWVyIGlzIGluIHRoZSB3cm9u ZyBwbGFjZSB3aGlsZSBwaW5jaC16b29taW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW0KaW5kZXggNWJlNjA1Ni4uMGUxZDk0YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpAQCAtMzE1LDcgKzMxNSw3IEBAIC0gKHZvaWQp ZGVhbGxvYwogLSAoV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICopYnJvd3NpbmdDb250ZXh0 Q29udHJvbGxlcgogewogICAgIGlmICghX2RhdGEtPl9icm93c2luZ0NvbnRleHRDb250cm9sbGVy KQotICAgICAgICBfZGF0YS0+X2Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgPSBbW1dLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlciBhbGxvY10gX2luaXRXaXRoUGFnZVJlZjp0b0FQSShfZGF0YS0+ X3BhZ2UuZ2V0KCkpXTsKKyAgICAgICAgX2RhdGEtPl9icm93c2luZ0NvbnRleHRDb250cm9sbGVy ID0gYWRvcHROUyhbW1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciBhbGxvY10gX2luaXRXaXRo UGFnZVJlZjp0b0FQSShfZGF0YS0+X3BhZ2UuZ2V0KCkpXSk7CiAKICAgICByZXR1cm4gX2RhdGEt Pl9icm93c2luZ0NvbnRleHRDb250cm9sbGVyLmdldCgpOwogfQo=