134362 2014-06-26 14:43:02 -0700 Skip memcmp()ing fully downloaded resources after they become mmap()able. 2014-06-26 23:05:42 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling ap beidson bunhere cdumez commit-queue gyuyoung.kim japhet kling sergio oldest_to_newest 1018745 0 kling 2014-06-26 14:43:02 -0700 CachedResource::tryReplaceEncodedData() does a memcmp() to check that the data being replaced is exactly equal to the disk-cached version. This is always the case, and we're wasting a bunch of time doing these comparisons. Let's turn them into assertions. 1018747 1 233936 kling 2014-06-26 14:44:37 -0700 Created attachment 233936 Patch 1018754 2 233936 ggaren 2014-06-26 14:55:59 -0700 Comment on attachment 233936 Patch r=me 1018763 3 kling 2014-06-26 15:23:07 -0700 Committed r170499: <http://trac.webkit.org/changeset/170499> 233936 2014-06-26 14:44:37 -0700 2014-06-26 14:55:59 -0700 Patch bug-134362.diff text/plain 2093 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NjY0N2JjLi41MjY4NDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTQtMDYtMjYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFNraXAgbWVtY21wKClpbmcgZnVsbHkgZG93bmxvYWRlZCByZXNvdXJjZXMgYWZ0ZXIgdGhl eSBiZWNvbWUgbW1hcCgpYWJsZS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNDM2 Mj4KKworICAgICAgICBXaGVuIHdlIHJlY2VpdmUgd29yZCB0aGF0IGEgZG93bmxvYWRlZCByZXNv dXJjZSBpcyBub3cgYXZhaWxhYmxlIGZvciBtbWFwKClpbmcKKyAgICAgICAgZnJvbSB0aGUgZmls ZSBzeXN0ZW0sIHdlIGRvbid0IG5lZWQgdG8gY29tcGFyZSBhZ2FpbnN0IHRoZSBidWZmZXJlZCBk YXRhLAorICAgICAgICBzaW5jZSBldmVuIGlmIHRoZXJlIHdlcmUgYSBtaXNtYXRjaCwgdGhlIGNh Y2hlZCB2ZXJzaW9uIHNob3VsZCBiZSB0aGUgY2Fub25pY2FsIG9uZS4KKworICAgICAgICBUaGlz IHdhcyBhZGRlZCBhcyBiZWx0LWFuZC1zdXNwZW5kZXJzIHdoaWxlIHRoZSBzdXBwb3J0aW5nIG1l Y2hhbmlzbSB3YXMgYmVpbmcKKyAgICAgICAgZGV2ZWxvcGVkIGluIENGTmV0d29yaywgYW5kIHRo ZXJlJ3Mgbm8gZXZpZGVuY2Ugb2YgYSByYWNlIHRvZGF5LiBUaGlzIGNoYW5nZQorICAgICAgICB0 dXJucyB0aGUgcnVudGltZSBjaGVja3MgaW50byBkZWJ1Zy1vbmx5IGFzc2VydGlvbnMuCisKKyAg ICAgICAgU2F2ZXMgfjMwMG1zIG9mIG1haW4gdGhyZWFkIHRpbWUgb24gUExULgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlOjp0cnlS ZXBsYWNlRW5jb2RlZERhdGEpOgorCiAyMDE0LTA2LTI2ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVp emFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFuIHVuZG8gZ3JvdXAgZm9yIGVhY2ggZGlj dGF0ZWQgdXR0ZXJhbmNlIGluIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRSZXNvdXJjZS5jcHAKaW5kZXggNWQxOTE3Ny4uOWViMWJjYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCkBAIC05MDAsMTEgKzkw MCw5IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2U6OnRyeVJlcGxhY2VFbmNvZGVkRGF0YShQYXNzUmVm UHRyPFNoYXJlZEJ1ZmZlcj4gbmV3QnVmZmVyKQogICAgIAogICAgIGlmICghbWF5VHJ5UmVwbGFj ZUVuY29kZWREYXRhKCkpCiAgICAgICAgIHJldHVybjsKLSAgICAKLSAgICAvLyBCZWNhdXNlIHRo ZSBkaXNrIGNhY2hlIGlzIGFzeW5jaHJvbm91cyBhbmQgcmFjZXkgd2l0aCByZWdhcmRzIHRvIHRo ZSBkYXRhIHdlIG1pZ2h0IGJlIGFza2VkIHRvIHJlcGxhY2UsCi0gICAgLy8gd2UgbmVlZCB0byB2 ZXJpZnkgdGhhdCB0aGUgbmV3IGJ1ZmZlciBoYXMgdGhlIHNhbWUgY29udGVudHMgYXMgb3VyIG9s ZCBidWZmZXIuCi0gICAgaWYgKG1fZGF0YS0+c2l6ZSgpICE9IG5ld0J1ZmZlci0+c2l6ZSgpIHx8 IG1lbWNtcChtX2RhdGEtPmRhdGEoKSwgbmV3QnVmZmVyLT5kYXRhKCksIG1fZGF0YS0+c2l6ZSgp KSkKLSAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKG1fZGF0YS0+c2l6ZSgpID09IG5ld0J1 ZmZlci0+c2l6ZSgpKTsKKyAgICBBU1NFUlQoIW1lbWNtcChtX2RhdGEtPmRhdGEoKSwgbmV3QnVm ZmVyLT5kYXRhKCksIG1fZGF0YS0+c2l6ZSgpKSk7CiAKICAgICBtX2RhdGEtPnRyeVJlcGxhY2VT aGFyZWRCdWZmZXJDb250ZW50cyhuZXdCdWZmZXIuZ2V0KCkpOwogfQo=