13436 2007-04-21 12:57:55 -0700 Make Option-clicking a disclosure triangle expand the entire subtree 2007-04-22 15:31:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P4 Enhancement --- 1 mitz timothy oldest_to_newest 13352 0 mitz 2007-04-21 12:57:55 -0700 Make Option-clicking a disclosure triangle in the web inspector's DOM tree view recursively expand all levels below the element being clicked. This is in fact how NSOutlineView behaves and I've found it very convenient. 13254 1 14140 timothy 2007-04-22 14:40:06 -0700 Created attachment 14140 Patch Makes option-click recursively expand and collapse the sub-tree. Pressing option-left and -right also recursively expand and collapse the sub-tree. * WebInspector/webInspector/treeoutline.js: 13236 2 14140 mitz 2007-04-22 15:27:09 -0700 Comment on attachment 14140 Patch r=me 13237 3 timothy 2007-04-22 15:31:50 -0700 Fixed in r21007. http://trac.webkit.org/projects/webkit/changeset/21007 14140 2007-04-22 14:40:06 -0700 2007-04-22 15:27:09 -0700 Patch 13436.patch text/plain 4186 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDA1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMDctMDQt MjIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxMzQzNjogTWFrZSBPcHRpb24t Y2xpY2tpbmcgYSBkaXNjbG9zdXJlIHRyaWFuZ2xlIGV4cGFuZCB0aGUgZW50aXJlIHN1YnRyZWUK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MzYKKwor ICAgICAgICBNYWtlcyBvcHRpb24tY2xpY2sgcmVjdXJzaXZlbHkgZXhwYW5kIGFuZCBjb2xsYXBz ZSB0aGUgc3ViLXRyZWUuIFByZXNzaW5nIG9wdGlvbi1sZWZ0CisgICAgICAgIGFuZCAtcmlnaHQg YWxzbyByZWN1cnNpdmVseSBleHBhbmQgYW5kIGNvbGxhcHNlIHRoZSBzdWItdHJlZS4KKworICAg ICAgICAqIFdlYkluc3BlY3Rvci93ZWJJbnNwZWN0b3IvdHJlZW91dGxpbmUuanM6CisKIDIwMDct MDQtMjIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkZWxlLgpJbmRleDogV2ViSW5zcGVjdG9yL3dlYkluc3BlY3Rvci90cmVlb3V0bGluZS5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJJbnNwZWN0b3Ivd2ViSW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpz CShyZXZpc2lvbiAyMTAwNSkKKysrIFdlYkluc3BlY3Rvci93ZWJJbnNwZWN0b3IvdHJlZW91dGxp bmUuanMJKHdvcmtpbmcgY29weSkKQEAgLTE4NywyMCArMTg3LDIzIEBAIFRyZWVPdXRsaW5lLnBy b3RvdHlwZS5maW5kVHJlZUVsZW1lbnQgPSAKIAogVHJlZU91dGxpbmUucHJvdG90eXBlLmhhbmRs ZUtleUV2ZW50ID0gZnVuY3Rpb24oZXZlbnQpCiB7Ci0gICAgaWYgKCF0aGlzLnNlbGVjdGVkVHJl ZUVsZW1lbnQgfHwgZXZlbnQuc2hpZnRLZXkgfHwgZXZlbnQubWV0YUtleSB8fCBldmVudC5hbHRL ZXkgfHwgZXZlbnQuY3RybEtleSkKKyAgICBpZiAoIXRoaXMuc2VsZWN0ZWRUcmVlRWxlbWVudCB8 fCBldmVudC5zaGlmdEtleSB8fCBldmVudC5tZXRhS2V5IHx8IGV2ZW50LmN0cmxLZXkpCiAgICAg ICAgIHJldHVybjsKIAogICAgIHZhciBoYW5kbGVkID0gZmFsc2U7CiAgICAgdmFyIG5leHRTZWxl Y3RlZEVsZW1lbnQ7Ci0gICAgaWYgKGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVcCIpIHsKKyAg ICBpZiAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIlVwIiAmJiAhZXZlbnQuYWx0S2V5KSB7CiAg ICAgICAgIG5leHRTZWxlY3RlZEVsZW1lbnQgPSB0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQudHJh dmVyc2VQcmV2aW91c1RyZWVFbGVtZW50KHRydWUpOwogICAgICAgICBoYW5kbGVkID0gdHJ1ZTsK LSAgICB9IGVsc2UgaWYgKGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJEb3duIikgeworICAgIH0g ZWxzZSBpZiAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIkRvd24iICYmICFldmVudC5hbHRLZXkp IHsKICAgICAgICAgbmV4dFNlbGVjdGVkRWxlbWVudCA9IHRoaXMuc2VsZWN0ZWRUcmVlRWxlbWVu dC50cmF2ZXJzZU5leHRUcmVlRWxlbWVudCh0cnVlKTsKICAgICAgICAgaGFuZGxlZCA9IHRydWU7 CiAgICAgfSBlbHNlIGlmIChldmVudC5rZXlJZGVudGlmaWVyID09PSAiTGVmdCIpIHsKICAgICAg ICAgaWYgKHRoaXMuc2VsZWN0ZWRUcmVlRWxlbWVudC5leHBhbmRlZCkgewotICAgICAgICAgICAg dGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LmNvbGxhcHNlKCk7CisgICAgICAgICAgICBpZiAoZXZl bnQuYWx0S2V5KQorICAgICAgICAgICAgICAgIHRoaXMuc2VsZWN0ZWRUcmVlRWxlbWVudC5jb2xs YXBzZVJlY3Vyc2l2ZWx5KCk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhp cy5zZWxlY3RlZFRyZWVFbGVtZW50LmNvbGxhcHNlKCk7CiAgICAgICAgICAgICBoYW5kbGVkID0g dHJ1ZTsKICAgICAgICAgfSBlbHNlIGlmICh0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQucGFyZW50 ICYmICF0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQucGFyZW50LnJvb3QpIHsKICAgICAgICAgICAg IG5leHRTZWxlY3RlZEVsZW1lbnQgPSB0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQucGFyZW50OwpA QCAtMjA4LDcgKzIxMSwxMCBAQCBUcmVlT3V0bGluZS5wcm90b3R5cGUuaGFuZGxlS2V5RXZlbnQg PSBmCiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJS aWdodCIpIHsKICAgICAgICAgaWYgKHRoaXMuc2VsZWN0ZWRUcmVlRWxlbWVudC5oYXNDaGlsZHJl bikgewotICAgICAgICAgICAgdGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LmV4cGFuZCgpOworICAg ICAgICAgICAgaWYgKGV2ZW50LmFsdEtleSkKKyAgICAgICAgICAgICAgICB0aGlzLnNlbGVjdGVk VHJlZUVsZW1lbnQuZXhwYW5kUmVjdXJzaXZlbHkoKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICB0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQuZXhwYW5kKCk7CiAgICAgICAgICAg ICBoYW5kbGVkID0gdHJ1ZTsKICAgICAgICAgfQogICAgIH0KQEAgLTM0Niw5ICszNTIsMTUgQEAg VHJlZUVsZW1lbnQudHJlZUVsZW1lbnRUb2dnbGVkID0gZnVuY3RpbwogCiAgICAgaWYgKGV2ZW50 Lm9mZnNldFggPD0gMjAgJiYgZWxlbWVudC50cmVlRWxlbWVudC5oYXNDaGlsZHJlbikgewogICAg ICAgICBpZiAoZWxlbWVudC50cmVlRWxlbWVudC5leHBhbmRlZCkgewotICAgICAgICAgICAgZWxl bWVudC50cmVlRWxlbWVudC5jb2xsYXBzZSgpOworICAgICAgICAgICAgaWYgKGV2ZW50LmFsdEtl eSkKKyAgICAgICAgICAgICAgICBlbGVtZW50LnRyZWVFbGVtZW50LmNvbGxhcHNlUmVjdXJzaXZl bHkoKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBlbGVtZW50LnRyZWVFbGVt ZW50LmNvbGxhcHNlKCk7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBlbGVtZW50LnRy ZWVFbGVtZW50LmV4cGFuZCgpOworICAgICAgICAgICAgaWYgKGV2ZW50LmFsdEtleSkKKyAgICAg ICAgICAgICAgICBlbGVtZW50LnRyZWVFbGVtZW50LmV4cGFuZFJlY3Vyc2l2ZWx5KCk7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgZWxlbWVudC50cmVlRWxlbWVudC5leHBhbmQo KTsKICAgICAgICAgfQogICAgIH0KIH0KQEAgLTM4MSw2ICszOTMsMTYgQEAgVHJlZUVsZW1lbnQu cHJvdG90eXBlLmNvbGxhcHNlID0gZnVuY3RpbwogICAgICAgICB0aGlzLm9uY29sbGFwc2UodGhp cyk7CiB9CiAKK1RyZWVFbGVtZW50LnByb3RvdHlwZS5jb2xsYXBzZVJlY3Vyc2l2ZWx5ID0gZnVu Y3Rpb24oKQoreworICAgIHZhciBpdGVtID0gdGhpczsKKyAgICB3aGlsZSAoaXRlbSkgeworICAg ICAgICBpZiAoaXRlbS5leHBhbmRlZCkKKyAgICAgICAgICAgIGl0ZW0uY29sbGFwc2UoKTsKKyAg ICAgICAgaXRlbSA9IGl0ZW0udHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQoZmFsc2UsIHRoaXMsIHRy dWUpOworICAgIH0KK30KKwogVHJlZUVsZW1lbnQucHJvdG90eXBlLmV4cGFuZCA9IGZ1bmN0aW9u KCkKIHsKICAgICBpZiAoIXRoaXMuaGFzQ2hpbGRyZW4gfHwgKHRoaXMuZXhwYW5kZWQgJiYgIXRo aXMucmVmcmVzaENoaWxkcmVuICYmIHRoaXMuX2NoaWxkcmVuTGlzdE5vZGUpKQpAQCAtNDI0LDYg KzQ0NiwxNSBAQCBUcmVlRWxlbWVudC5wcm90b3R5cGUuZXhwYW5kID0gZnVuY3Rpb24oCiAgICAg ICAgIHRoaXMub25leHBhbmQodGhpcyk7CiB9CiAKK1RyZWVFbGVtZW50LnByb3RvdHlwZS5leHBh bmRSZWN1cnNpdmVseSA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgaXRlbSA9IHRoaXM7CisgICAg d2hpbGUgKGl0ZW0pIHsKKyAgICAgICAgaXRlbS5leHBhbmQoKTsKKyAgICAgICAgaXRlbSA9IGl0 ZW0udHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQoZmFsc2UsIHRoaXMpOworICAgIH0KK30KKwogVHJl ZUVsZW1lbnQucHJvdG90eXBlLnJldmVhbCA9IGZ1bmN0aW9uKCkKIHsKICAgICB2YXIgY3VycmVu dEFuY2VzdG9yID0gdGhpcy5wYXJlbnQ7Cg==