134354 2014-06-26 12:20:36 -0700 [iOS] Add API for opting into character selection granularity 2014-06-26 14:23:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca bunhere cdumez commit-queue enrica ggaren gyuyoung.kim sam sergio oldest_to_newest 1018705 0 mitz 2014-06-26 12:20:36 -0700 [iOS] Add API for opting into character selection granularity 1018707 1 233924 mitz 2014-06-26 12:25:24 -0700 Created attachment 233924 Add selectionGranularity property to WKWebViewConfiguration 1018727 2 233924 ggaren 2014-06-26 13:42:23 -0700 Comment on attachment 233924 Add selectionGranularity property to WKWebViewConfiguration r=me 1018738 3 mitz 2014-06-26 14:23:45 -0700 Committed <http://trac.webkit.org/r170495>. 233924 2014-06-26 12:25:24 -0700 2014-06-26 13:42:23 -0700 Add selectionGranularity property to WKWebViewConfiguration bug-134354-20140626122504.patch text/plain 7461 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDQ4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA2LTI2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWRkIEFQSSBmb3Igb3B0 aW5nIGludG8gY2hhcmFjdGVyIHNlbGVjdGlvbiBncmFudWxhcml0eQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MzU0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1dLRm91 bmRhdGlvbi5oOiBBZGRlZCBhIGRlZmluaXRpb24gb2YgV0tfRU5VTV9BVkFJTEFCTEVfSU9TLgor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5oOgor ICAgICAgICAoV0tTZWxlY3Rpb25HcmFudWxhcml0eSk6IEFkZGVkIHRoaXMgZW51bSB3aXRoIHR3 byB2YWx1ZXMsIG9uZSByZXByZXNlbnRpbmcgZHluYW1pYworICAgICAgICBncmFudWxhcml0eSgg dGhlIGN1cnJlbnQsIGRlZmF1bHQgYmVoYXZpb3IpIGFuZCBvbmUgcmVwcmVzZW50aW5nIGNoYXJh Y3RlciBncmFudWxhcml0eS4KKyAgICAgICAgRGVsY2FyZWQgbmV3IHNlbGVjdGlvbkdyYW51bGFy aXR5IHByb3BlcnR5LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29u ZmlndXJhdGlvbi5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBjb3B5V2l0 aFpvbmU6XSk6IENvcHkgdGhlIF9zZWxlY3Rpb25HcmFudWxhcml0eSBpdmFyLgorCisgICAgICAg ICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICh0 b1VJV2ViU2VsZWN0aW9uTW9kZSk6IEFkZGVkIHRoaXMgaGVscGVyIGZ1bmN0aW9uIGZvciBtYXBw aW5nIFdLU2VsZWN0aW9uR3JhbnVsYXJpdHkgdmFsdWVzCisgICAgICAgIHRvIFVJV2ViU2VsZWN0 aW9uTW9kZSB2YWx1ZXMuCisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc2V0dXBJbnRlcmFjdGlv bl0pOiBVc2UgYSBzZWxlY3Rpb24gYXNzaXN0YW50IHdpdGggdGhlIG1vZGUgc3BlY2lmaWVkIGlu CisgICAgICAgIHRoZSBjb25maWd1cmF0aW9uLgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9z dG9wQXNzaXN0aW5nS2V5Ym9hcmRdKTogRGl0dG8uCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNlbGVj dFdpdGhHZXN0dXJlKTogQ2hhbmdlZCB0aGUgYmVoYXZpb3Igb2YgdGhlIGxvdXBlIGdlc3R1cmUg dHlwZSBpbgorICAgICAgICBub24tZWRpdGFibGUgdGV4dCB0byBzZWxlY3QgYSB3b3JkLCByYXRo ZXIgdGhhbiBhbiBlbXB0eSByYW5nZSwgbWF0Y2hpbmcgdGhlIFVJVGV4dFZpZXcKKyAgICAgICAg YmVoYXZpb3IuCisKIDIwMTQtMDYtMjYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgYW4gdW5kbyBncm91cCBmb3IgZWFjaCBkaWN0YXRlZCB1dHRl cmFuY2UgaW4gV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dL Rm91bmRhdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29j b2EvV0tGb3VuZGF0aW9uLmgJKHJldmlzaW9uIDE3MDQ4MykKKysrIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9BUEkvQ29jb2EvV0tGb3VuZGF0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDYgKzQ0 LDcgQEAKICNkZWZpbmUgV0tfQVZBSUxBQkxFKF9tYWMsIF9pb3MpCiAjZGVmaW5lIFdLX0NMQVNT X0FWQUlMQUJMRShfbWFjLCBfaW9zKSBfX2F0dHJpYnV0ZV9fKCh2aXNpYmlsaXR5ICgiZGVmYXVs dCIpKSkKICNkZWZpbmUgV0tfRU5VTV9BVkFJTEFCTEUoX21hYywgX2lvcykKKyNkZWZpbmUgV0tf RU5VTV9BVkFJTEFCTEVfSU9TKF9pb3MpCiAKICNpZiBkZWZpbmVkKF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPD0gMTA5 MAogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0Nv bmZpZ3VyYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24uaAkocmV2aXNpb24gMTcwNDgzKQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLmgJ KHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDIxIEBACiBAY2xhc3MgV0tQcm9jZXNzUG9vbDsK IEBjbGFzcyBXS1VzZXJDb250ZW50Q29udHJvbGxlcjsKIAorI2lmIFRBUkdFVF9PU19JUEhPTkUK Ky8qISBAZW51bSBXS1NlbGVjdGlvbkdyYW51bGFyaXR5CisgQGFic3RyYWN0IFRoZSBncmFudWxh cml0eSB3aXRoIHdoaWNoIGEgc2VsZWN0aW9uIGNhbiBiZSBjcmVhdGVkIGFuZCBtb2RpZmllZCBp bnRlcmFjdGl2ZWx5LgorIEBjb25zdGFudCBXS1NlbGVjdGlvbkdyYW51bGFyaXR5RHluYW1pYyAg ICBTZWxlY3Rpb24gZ3JhbnVsYXJpdHkgdmFyaWVzIGF1dG9tYXRpY2FsbHkgYmFzZWQgb24gdGhl IHNlbGVjdGlvbi4KKyBAY29uc3RhbnQgV0tTZWxlY3Rpb25HcmFudWxhcml0eUNoYXJhY3RlciAg U2VsZWN0aW9uIGVuZHBvaW50cyBjYW4gYmUgcGxhY2VkIGF0IGFueSBjaGFyYWN0ZXIgYm91bmRh cnkuCisgQGRpc2N1c3Npb24gQW4gZXhhbXBsZSBvZiBob3cgZ3JhbnVsYXJpdHkgbWF5IHZhcnkg d2hlbiBXS1NlbGVjdGlvbkdyYW51bGFyaXR5RHluYW1pYyBpcyB1c2VkIGlzCisgdGhhdCB3aGVu IHRoZSBzZWxlY3Rpb24gaXMgd2l0aGluIGEgc2luZ2xlIGJsb2NrLCB0aGUgZ3JhbnVsYXJpdHkg bWF5IGJlIHNpbmdsZSBjaGFyYWN0ZXIsIGFuZCB3aGVuCisgdGhlIHNlbGVjdGlvbiBpcyBub3Qg Y29uZmluZWQgdG8gYSBzaW5nbGUgYmxvY2ssIHRoZSBzZWxlY3Rpb24gZ3JhbnVsYXJpdHkgbWF5 IGJlIHNpbmdsZSBibG9jay4KKyAqLwordHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgV0tTZWxl Y3Rpb25HcmFudWxhcml0eSkgeworICAgIFdLU2VsZWN0aW9uR3JhbnVsYXJpdHlEeW5hbWljLAor ICAgIFdLU2VsZWN0aW9uR3JhbnVsYXJpdHlDaGFyYWN0ZXIsCit9IFdLX0VOVU1fQVZBSUxBQkxF X0lPUyg4XzApOworI2VuZGlmCisKIC8qISBBIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gb2JqZWN0 IGlzIGEgY29sbGVjdGlvbiBvZiBwcm9wZXJ0aWVzIHdpdGgKICB3aGljaCB0byBpbml0aWFsaXpl IGEgd2ViIHZpZXcuCiAgQGhlbHBzIENvbnRhaW5zIHByb3BlcnRpZXMgdXNlZCB0byBjb25maWd1 cmUgYSBAbGluayBXS1dlYlZpZXcgQC9saW5rLgpAQCAtODAsNiArOTUsMTMgQEAgV0tfQ0xBU1Nf QVZBSUxBQkxFKDEwXzEwLCA4XzApCiAgKi8KIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIG1l ZGlhUGxheWJhY2tBbGxvd3NBaXJQbGF5OwogCisvKiEgQGFic3RyYWN0IFRoZSBsZXZlbCBvZiBn cmFudWxhcml0eSB3aXRoIHdoaWNoIHRoZSB1c2VyIGNhbiBpbnRlcmFjdGl2ZWx5Cisgc2VsZWN0 IGNvbnRlbnQgaW4gdGhlIHdlYiB2aWV3LgorIEBkaXNjdXNzaW9uIFBvc3NpYmxlIHZhbHVlcyBh cmUgZGVzY3JpYmVkIGluIFdLU2VsZWN0aW9uR3JhbnVsYXJpdHkuCisgVGhlIGRlZmF1bHQgdmFs dWUgaXMgV0tTZWxlY3Rpb25HcmFudWxhcml0eUR5bmFtaWMuCisgKi8KK0Bwcm9wZXJ0eSAobm9u YXRvbWljKSBXS1NlbGVjdGlvbkdyYW51bGFyaXR5IHNlbGVjdGlvbkdyYW51bGFyaXR5OworCiAj ZW5kaWYKIAogQGVuZApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQkocmV2aXNpb24gMTcw NDgzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25m aWd1cmF0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNiArMTE2LDcgQEAgLSAoaWQpY29w eVdpdGhab25lOihOU1pvbmUgKil6b25lCiAgICAgY29uZmlndXJhdGlvbi0+X2FsbG93c0lubGlu ZU1lZGlhUGxheWJhY2sgPSBzZWxmLT5fYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjazsKICAgICBj b25maWd1cmF0aW9uLT5fbWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckFjdGlvbiA9IHNlbGYtPl9t ZWRpYVBsYXliYWNrUmVxdWlyZXNVc2VyQWN0aW9uOwogICAgIGNvbmZpZ3VyYXRpb24tPl9tZWRp YVBsYXliYWNrQWxsb3dzQWlyUGxheSA9IHNlbGYtPl9tZWRpYVBsYXliYWNrQWxsb3dzQWlyUGxh eTsKKyAgICBjb25maWd1cmF0aW9uLT5fc2VsZWN0aW9uR3JhbnVsYXJpdHkgPSBzZWxmLT5fc2Vs ZWN0aW9uR3JhbnVsYXJpdHk7CiAjZW5kaWYKIAogICAgIHJldHVybiBjb25maWd1cmF0aW9uOwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE3MDQ4MykKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0zNiw2ICszNiw3IEBACiAjaW1wb3J0ICJXS0Zvcm1JbnB1dENvbnRyb2wuaCIKICNpbXBv cnQgIldLRm9ybVNlbGVjdENvbnRyb2wuaCIKICNpbXBvcnQgIldLSW5zcGVjdG9yTm9kZVNlYXJj aEdlc3R1cmVSZWNvZ25pemVyLmgiCisjaW1wb3J0ICJXS1dlYlZpZXdDb25maWd1cmF0aW9uLmgi CiAjaW1wb3J0ICJXS1dlYlZpZXdQcml2YXRlLmgiCiAjaW1wb3J0ICJXZWJFdmVudC5oIgogI2lt cG9ydCAiV2ViSU9TRXZlbnRGYWN0b3J5LmgiCkBAIC0xOTAsNiArMTkxLDE5IEBAIC0gKHZvaWQp aW52YWxpZGF0ZQogCiBAaW1wbGVtZW50YXRpb24gV0tDb250ZW50VmlldyAoV0tJbnRlcmFjdGlv bikKIAorc3RhdGljIFVJV2ViU2VsZWN0aW9uTW9kZSB0b1VJV2ViU2VsZWN0aW9uTW9kZShXS1Nl bGVjdGlvbkdyYW51bGFyaXR5IGdyYW51bGFyaXR5KQoreworICAgIHN3aXRjaCAoZ3JhbnVsYXJp dHkpIHsKKyAgICBjYXNlIFdLU2VsZWN0aW9uR3JhbnVsYXJpdHlEeW5hbWljOgorICAgICAgICBy ZXR1cm4gVUlXZWJTZWxlY3Rpb25Nb2RlV2ViOworICAgIGNhc2UgV0tTZWxlY3Rpb25HcmFudWxh cml0eUNoYXJhY3RlcjoKKyAgICAgICAgcmV0dXJuIFVJV2ViU2VsZWN0aW9uTW9kZVRleHRPbmx5 OworICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBVSVdlYlNl bGVjdGlvbk1vZGVXZWI7Cit9CisKIC0gKHZvaWQpc2V0dXBJbnRlcmFjdGlvbgogewogICAgIGlm ICghX2ludmVyc2VTY2FsZVJvb3RWaWV3KSB7CkBAIC0yMzcsNyArMjUxLDcgQEAgLSAodm9pZClz ZXR1cEludGVyYWN0aW9uCiAgICAgX3Nob3dpbmdUZXh0U3R5bGVPcHRpb25zID0gTk87CiAKICAg ICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgY2FsbGVkIHdoZW4gd2UgZ2V0IG5vdGlmaWVkIHRo YXQgbG9hZGluZyBoYXMgY29tcGxldGVkLgotICAgIFtzZWxmIHVzZVNlbGVjdGlvbkFzc2lzdGFu dFdpdGhNb2RlOlVJV2ViU2VsZWN0aW9uTW9kZVdlYl07CisgICAgW3NlbGYgdXNlU2VsZWN0aW9u QXNzaXN0YW50V2l0aE1vZGU6dG9VSVdlYlNlbGVjdGlvbk1vZGUoW1tfd2ViVmlldyBjb25maWd1 cmF0aW9uXSBzZWxlY3Rpb25HcmFudWxhcml0eV0pXTsKICAgICAKICAgICBfYWN0aW9uU2hlZXRB c3Npc3RhbnQgPSBhZG9wdE5TKFtbV0tBY3Rpb25TaGVldEFzc2lzdGFudCBhbGxvY10gaW5pdFdp dGhWaWV3OnNlbGZdKTsKICAgICBfc21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlciA9IHN0ZDo6 bWFrZV91bmlxdWU8U21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlcj4oc2VsZik7CkBAIC0yMzA2 LDcgKzIzMjAsNyBAQCAtICh2b2lkKV9zdGFydEFzc2lzdGluZ0tleWJvYXJkCiAKIC0gKHZvaWQp X3N0b3BBc3Npc3RpbmdLZXlib2FyZAogewotICAgIFtzZWxmIHVzZVNlbGVjdGlvbkFzc2lzdGFu dFdpdGhNb2RlOlVJV2ViU2VsZWN0aW9uTW9kZVdlYl07CisgICAgW3NlbGYgdXNlU2VsZWN0aW9u QXNzaXN0YW50V2l0aE1vZGU6dG9VSVdlYlNlbGVjdGlvbk1vZGUoW1tfd2ViVmlldyBjb25maWd1 cmF0aW9uXSBzZWxlY3Rpb25HcmFudWxhcml0eV0pXTsKIH0KIAogLSAoY29uc3QgQXNzaXN0ZWRO b2RlSW5mb3JtYXRpb24mKWFzc2lzdGVkTm9kZUluZm9ybWF0aW9uCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCShyZXZp c2lvbiAxNzA0ODMpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTg1Niw3ICs4NTYsMTAgQEAgdm9pZCBXZWJQ YWdlOjpzZWxlY3RXaXRoR2VzdHVyZShjb25zdCBJbgogICAgICAgICBicmVhazsKIAogICAgIGNh c2UgR2VzdHVyZVR5cGU6OkxvdXBlOgotICAgICAgICByYW5nZSA9IFJhbmdlOjpjcmVhdGUoKmZy YW1lLmRvY3VtZW50KCksIHBvc2l0aW9uLCBwb3NpdGlvbik7CisgICAgICAgIGlmIChwb3NpdGlv bi5yb290RWRpdGFibGVFbGVtZW50KCkpCisgICAgICAgICAgICByYW5nZSA9IFJhbmdlOjpjcmVh dGUoKmZyYW1lLmRvY3VtZW50KCksIHBvc2l0aW9uLCBwb3NpdGlvbik7CisgICAgICAgIGVsc2UK KyAgICAgICAgICAgIHJhbmdlID0gd29yZFJhbmdlRnJvbVBvc2l0aW9uKHBvc2l0aW9uKTsKICAg ICAgICAgYnJlYWs7CiAKICAgICBjYXNlIEdlc3R1cmVUeXBlOjpUYXBBbmRBSGFsZjoK