134350 2014-06-26 10:37:46 -0700 [iOS] no need to deactivate audio session 2014-06-26 11:31:29 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson bunhere cdumez commit-queue glenn gyuyoung.kim jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1018664 0 eric.carlson 2014-06-26 10:37:46 -0700 There is no need to call setActive:NO on the audio session, WebCore's session will automatically be deactivated if another application begins playing audio. 1018665 1 eric.carlson 2014-06-26 10:38:36 -0700 <rdar://problem/16853657> 1018678 2 233916 eric.carlson 2014-06-26 11:00:41 -0700 Created attachment 233916 Proposed patch. 1018679 3 233916 jer.noble 2014-06-26 11:02:32 -0700 Comment on attachment 233916 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=233916&action=review r=me > Source/WebCore/ChangeLog:9 > + [iOS] no need to deactivate audio session > + https://bugs.webkit.org/show_bug.cgi?id=134350 > + > + Reviewed by NOBODY (OOPS!). > + > + * platform/audio/mac/MediaSessionManagerMac.cpp: > + (MediaSessionManager::updateSessionState): Never call setActive:false. nit: Why not? (Maybe: "Embedding WebView apps may want to enable the audio session outside of the WebView, and since the AudioSession is global to the app, disabling the audio session can interrupt that audio." 1018686 4 eric.carlson 2014-06-26 11:31:29 -0700 Committed r170485: https://trac.webkit.org/r170485 233916 2014-06-26 11:00:41 -0700 2014-06-26 11:02:32 -0700 Proposed patch. set_active_patch_2.txt text/plain 1267 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDQ4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA2LTI2ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIG5vIG5lZWQg dG8gZGVhY3RpdmF0ZSBhdWRpbyBzZXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQzNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL21hYy9NZWRpYVNlc3Npb25NYW5h Z2VyTWFjLmNwcDoKKyAgICAgICAgKE1lZGlhU2Vzc2lvbk1hbmFnZXI6OnVwZGF0ZVNlc3Npb25T dGF0ZSk6IE5ldmVyIGNhbGwgc2V0QWN0aXZlOmZhbHNlLgorCiAyMDE0LTA2LTI2ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFuIHVuZG8gZ3Jv dXAgZm9yIGVhY2ggZGljdGF0ZWQgdXR0ZXJhbmNlIGluIFdlYktpdApJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9NZWRpYVNlc3Npb25N YW5hZ2VyTWFjLmNwcAkocmV2aXNpb24gMTcwMzkyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01NSw3ICs1NSw4IEBAIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcjo6dXBkYXRlU2Vzc2lvblMK ICNlbmRpZgogCiAjaWYgUExBVEZPUk0oSU9TKQotICAgIEF1ZGlvU2Vzc2lvbjo6c2hhcmVkU2Vz c2lvbigpLnNldEFjdGl2ZShoYXNBY3RpdmUoKSk7CisgICAgaWYgKGhhc0FjdGl2ZSgpKQorICAg ICAgICBBdWRpb1Nlc3Npb246OnNoYXJlZFNlc3Npb24oKS5zZXRBY3RpdmUodHJ1ZSk7CiAKICAg ICBpZiAoIVNldHRpbmdzOjpzaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb25DYXRlZ29yeSgpKQogICAg ICAgICByZXR1cm47Cg==