134347 2014-06-26 09:00:38 -0700 Define TARGET_OS_IPHONE to 0 for non-darwin ports 2014-06-26 15:19:27 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned benjamin bunhere cdumez cmarcelo commit-queue gyuyoung.kim ossy sergio oldest_to_newest 1018637 0 laszlo.gombos 2014-06-26 09:00:38 -0700 Follow-up for http://trac.webkit.org/changeset/169880 to make it a bit more future proof and easier to read and reason about it. 1018638 1 233904 laszlo.gombos 2014-06-26 09:08:40 -0700 Created attachment 233904 It reads slightly better.. 1018690 2 233904 darin 2014-06-26 11:39:38 -0700 Comment on attachment 233904 It reads slightly better.. View in context: https://bugs.webkit.org/attachment.cgi?id=233904&action=review It’s worth noting why this is different from our usual strategy. Unlike, say, WebCore, WebKit2 has public header files, and in public header files we need to use conditionals that don’t rely on WebKit internals such as Platform.h. Understanding that leads to the thought that for EFL and GTK, this use of TARGET_OS_IPHONE in public header files might pose a problem, for the same reason that PLATFORM(IOS) would be a problem on the Mac and iOS platform. We may need to run a script to strip those out for those platforms as part of the “installing public headers” process. > Source/WTF/wtf/Platform.h:1049 > +/* Set TARGET_OS_IPHONE to 0 by default to allow using it as a guard > + * in cross-platform the same way as it is used in OS(DARWIN) code */ Normally we’d put a period at the end of a sentence. 1018742 3 233934 laszlo.gombos 2014-06-26 14:39:32 -0700 Created attachment 233934 for cq incorporating Darin's feedback 1018761 4 233934 commit-queue 2014-06-26 15:19:22 -0700 Comment on attachment 233934 for cq incorporating Darin's feedback Clearing flags on attachment: 233934 Committed r170498: <http://trac.webkit.org/changeset/170498> 1018762 5 commit-queue 2014-06-26 15:19:27 -0700 All reviewed patches have been landed. Closing bug. 233904 2014-06-26 09:08:40 -0700 2014-06-26 14:39:32 -0700 It reads slightly better.. TARGET_IPHONE.patch text/plain 1227 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzA0ODApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA2LTI2ICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgRGVmaW5lIFRBUkdFVF9PU19JUEhPTkUgdG8g MCBmb3Igbm9uLWRhcndpbiBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM0MzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQSBmb2xsb3ctdXAgdG8gcjE2OTg4MCB0byBtYWtlIGl0IGVhc2llciB0 byByZWFzb24gYWJvdXQKKyAgICAgICAgdGhlIGNvZGUuIFRoZSBwdXJwb3NlIG9mIHRoaXMgY2hh bmdlIHRvIGFsbG93CisgICAgICAgICIjaWYgVEFSR0VUX09TX0lQSE9ORSIgaW4gY3Jvc3MtcGxh dGZvcm0gY29kZS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE0LTA2LTI1ICBH ZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjE2Njg3Ni4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMTcwNDI3KQor KysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTA0NSw3ICsx MDQ1LDkgQEAKICNkZWZpbmUgRU5BQkxFX09QRU5UWVBFX01BVEggMQogI2VuZGlmCiAKLSNpZiBQ TEFURk9STShFRkwpIHx8IFBMQVRGT1JNKEdUSykKKy8qIFNldCBUQVJHRVRfT1NfSVBIT05FIHRv IDAgYnkgZGVmYXVsdCB0byBhbGxvdyB1c2luZyBpdCBhcyBhIGd1YXJkIAorICogaW4gY3Jvc3Mt cGxhdGZvcm0gdGhlIHNhbWUgd2F5IGFzIGl0IGlzIHVzZWQgaW4gT1MoREFSV0lOKSBjb2RlICov IAorI2lmICFkZWZpbmVkKFRBUkdFVF9PU19JUEhPTkUpICYmICFPUyhEQVJXSU4pCiAjZGVmaW5l IFRBUkdFVF9PU19JUEhPTkUgMAogI2VuZGlmCiAK 233934 2014-06-26 14:39:32 -0700 2014-06-26 15:19:22 -0700 for cq incorporating Darin's feedback TARGET_IPHONE.patch text/plain 1225 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzA0ODApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA2LTI2ICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgRGVmaW5lIFRBUkdFVF9PU19JUEhPTkUgdG8g MCBmb3Igbm9uLWRhcndpbiBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM0MzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CisKKyAgICAgICAgQSBmb2xsb3ctdXAgdG8gcjE2OTg4MCB0byBtYWtlIGl0IGVhc2llciB0byBy ZWFzb24gYWJvdXQKKyAgICAgICAgdGhlIGNvZGUuIFRoZSBwdXJwb3NlIG9mIHRoaXMgY2hhbmdl IHRvIGFsbG93CisgICAgICAgICIjaWYgVEFSR0VUX09TX0lQSE9ORSIgaW4gcHVibGljIGhlYWRl ciBmaWxlcy4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE0LTA2LTI1ICBHZW9m ZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE2Njg3Ni4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMTcwNDI3KQorKysg U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTA0NSw3ICsxMDQ1 LDkgQEAKICNkZWZpbmUgRU5BQkxFX09QRU5UWVBFX01BVEggMQogI2VuZGlmCiAKLSNpZiBQTEFU Rk9STShFRkwpIHx8IFBMQVRGT1JNKEdUSykKKy8qIFNldCBUQVJHRVRfT1NfSVBIT05FIHRvIDAg YnkgZGVmYXVsdCB0byBhbGxvdyB1c2luZyBpdCBhcyBhIGd1YXJkIAorICogaW4gY3Jvc3MtcGxh dGZvcm0gdGhlIHNhbWUgd2F5IGFzIGl0IGlzIHVzZWQgaW4gT1MoREFSV0lOKSBjb2RlLiAqLyAK KyNpZiAhZGVmaW5lZChUQVJHRVRfT1NfSVBIT05FKSAmJiAhT1MoREFSV0lOKQogI2RlZmluZSBU QVJHRVRfT1NfSVBIT05FIDAKICNlbmRpZgogCg==