134345 2014-06-26 03:04:00 -0700 Fix Debug Build Error in Webcore module 2014-06-26 08:00:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned bunhere cdumez commit-queue d-r gyuyoung.kim mmaxfield mrobinson sergio zalan oldest_to_newest 1018611 0 shiva.jm 2014-06-26 03:04:00 -0700 Found Build Error in WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp during webkit-efl port debug build. from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:31: /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp: In member function ‘void WebCore::HarfBuzzShaper::setDrawRange(int, int)’: /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:335:57: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ASSERT_WITH_SECURITY_IMPLICATION(to <= m_run.length()); ^ /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WTF/wtf/Assertions.h:268:8: note: in definition of macro ‘ASSERT_WITH_SECURITY_IMPLICATION’ (!(assertion) ? \ ^ [ 68%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/texmap/coordinated/AreaAllocator.cpp.o 1018612 1 233898 shiva.jm 2014-06-26 03:14:12 -0700 Created attachment 233898 Patch Use static cast to change the type of variable to fix error 1018614 2 commit-queue 2014-06-26 03:15:27 -0700 Attachment 233898 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1018618 3 233900 shiva.jm 2014-06-26 03:24:47 -0700 Created attachment 233900 Patch-Updated Updated the patch since no tests are needed 1018625 4 233900 zalan 2014-06-26 07:29:16 -0700 Comment on attachment 233900 Patch-Updated I'd rather have both 'from' and 'to' unsigned, but this is good for now to get the build fixed. 1018626 5 233900 commit-queue 2014-06-26 08:00:45 -0700 Comment on attachment 233900 Patch-Updated Clearing flags on attachment: 233900 Committed r170479: <http://trac.webkit.org/changeset/170479> 1018627 6 commit-queue 2014-06-26 08:00:51 -0700 All reviewed patches have been landed. Closing bug. 233898 2014-06-26 03:14:12 -0700 2014-06-26 03:24:47 -0700 Patch bug-134345.patch text/plain 1412 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDQ3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTI2ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IERlYnVnIEJ1aWxk IEVycm9yIGluIFdlYmNvcmUgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgVXNlIHN0 YXRpYyBjYXN0IHRvIGNoYW5nZSB0aGUgdHlwZSBvZiB2YXJpYWJsZSB0byBmaXggZXJyb3IKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hhcmZCdXp6U2hhcGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhhcmZCdXp6U2hhcGVyOjpzZXREcmF3UmFuZ2UpOgorCiAyMDE0 LTA2LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBBZGQgcGFkZGluZyBmb3IgZnV0dXJlIGV4cGFuc2lvbiB0byBXZWJLaXRET01F dmVudFRhcmdldElmYWNlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9o YXJmYnV6ei9IYXJmQnV6elNoYXBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXIuY3BwCShyZXZpc2lvbiAx NzA0NzcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9IYXJm QnV6elNoYXBlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzMiw3ICszMzIsNyBAQCB2b2lkIEhh cmZCdXp6U2hhcGVyOjpzZXRQYWRkaW5nKGludCBwYWRkCiB2b2lkIEhhcmZCdXp6U2hhcGVyOjpz ZXREcmF3UmFuZ2UoaW50IGZyb20sIGludCB0bykKIHsKICAgICBBU1NFUlRfV0lUSF9TRUNVUklU WV9JTVBMSUNBVElPTihmcm9tID49IDApOwotICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJ Q0FUSU9OKHRvIDw9IG1fcnVuLmxlbmd0aCgpKTsKKyAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9J TVBMSUNBVElPTih0byA8PSBzdGF0aWNfY2FzdDxpbnQ+KG1fcnVuLmxlbmd0aCgpKSk7CiAgICAg bV9mcm9tSW5kZXggPSBmcm9tOwogICAgIG1fdG9JbmRleCA9IHRvOwogfQo= 233900 2014-06-26 03:24:47 -0700 2014-06-26 08:00:45 -0700 Patch-Updated bug-134345-updated.patch text/plain 1390 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDQ3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA2LTI2ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXgg RGVidWcgQnVpbGQgRXJyb3IgaW4gV2ViY29yZSBtb2R1bGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQzNDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc3RhdGljIGNhc3QgdG8gY2hhbmdlIHRo ZSB0eXBlIG9mIHZhcmlhYmxlIHRvIGZpeCBlcnJvcgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGFy ZkJ1enpTaGFwZXI6OnNldERyYXdSYW5nZSk6CisKIDIwMTQtMDYtMjYgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBwYWRkaW5n IGZvciBmdXR1cmUgZXhwYW5zaW9uIHRvIFdlYktpdERPTUV2ZW50VGFyZ2V0SWZhY2UKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hhcmZCdXp6U2hhcGVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJm YnV6ei9IYXJmQnV6elNoYXBlci5jcHAJKHJldmlzaW9uIDE3MDQ3NykKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hhcmZCdXp6U2hhcGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzMyLDcgKzMzMiw3IEBAIHZvaWQgSGFyZkJ1enpTaGFwZXI6OnNldFBhZGRp bmcoaW50IHBhZGQKIHZvaWQgSGFyZkJ1enpTaGFwZXI6OnNldERyYXdSYW5nZShpbnQgZnJvbSwg aW50IHRvKQogewogICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGZyb20gPj0g MCk7Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04odG8gPD0gbV9ydW4ubGVu Z3RoKCkpOworICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHRvIDw9IHN0YXRp Y19jYXN0PGludD4obV9ydW4ubGVuZ3RoKCkpKTsKICAgICBtX2Zyb21JbmRleCA9IGZyb207CiAg ICAgbV90b0luZGV4ID0gdG87CiB9Cg==