<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134343</bug_id>
          
          <creation_ts>2014-06-26 01:20:34 -0700</creation_ts>
          <short_desc>DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file</short_desc>
          <delta_ts>2014-06-26 08:30:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>bunhere</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>msaboff</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1018596</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2014-06-26 01:20:34 -0700</bug_when>
    <thetext>DFG::FunctionWhitelist::parseFunctionNamesInFile returns without calling fclose(f), so the file descriptor leaks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018597</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2014-06-26 01:20:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/17459487&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018598</commentid>
    <comment_count>2</comment_count>
      <attachid>233892</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2014-06-26 01:22:56 -0700</bug_when>
    <thetext>Created attachment 233892
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018632</commentid>
    <comment_count>3</comment_count>
      <attachid>233892</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-06-26 08:30:47 -0700</bug_when>
    <thetext>Comment on attachment 233892
Patch v1

Clearing flags on attachment: 233892

Committed r170480: &lt;http://trac.webkit.org/changeset/170480&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018633</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-06-26 08:30:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>233892</attachid>
            <date>2014-06-26 01:22:56 -0700</date>
            <delta_ts>2014-06-26 08:30:46 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-134343-20140626012235.patch</filename>
            <type>text/plain</type>
            <size>1478</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5
NGMwMTcwYjkxZGQyZmIyNTA5YjY4YzJjZjRiYTU0YmQ3ZDEwNGM4Li4yZWY3ZGU3ZmM0NmFjMjA5
ODI5Y2YwZTNjYTU2ZDM1N2ZmMWE3YjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxNC0wNi0yNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t
PgorCisgICAgICAgIERGRzo6RnVuY3Rpb25XaGl0ZWxpc3Q6OnBhcnNlRnVuY3Rpb25OYW1lc0lu
RmlsZSBkb2VzIG5vdCBjbG9zZSBmaWxlCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEz
NDM0Mz4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3NDU5NDg3PgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0Z1bmN0aW9uV2hpdGVs
aXN0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGdW5jdGlvbldoaXRlbGlzdDo6cGFyc2VGdW5j
dGlvbk5hbWVzSW5GaWxlKToKKyAgICAgICAgQ2xvc2UgdGhlIGZpbGUgaGFuZGxlLCBhbmQgbG9n
IGFuIGVycm9yIG9uIGZhaWx1cmUuCisKIDIwMTQtMDYtMjUgIERhbmEgQnVya2FydCAgPGRidXJr
YXJ0QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgNS10dXBsZSB2ZXJzaW9u
aW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGdW5jdGlvbldo
aXRlbGlzdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Z1bmN0aW9uV2hpdGVs
aXN0LmNwcAppbmRleCAwYmNiNGEwMTEzM2JkNDVjYzRiZDczMjEwNzkyNjlhZWE4M2ZjYjhhLi5j
MDAzZjRjYTg2ZGZjZjA3MjdhYTAyOTA0MzJhYWU0Y2U1OThlZjA1IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Z1bmN0aW9uV2hpdGVsaXN0LmNwcAorKysgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Z1bmN0aW9uV2hpdGVsaXN0LmNwcApAQCAtODEsNiAr
ODEsMTAgQEAgdm9pZCBGdW5jdGlvbldoaXRlbGlzdDo6cGFyc2VGdW5jdGlvbk5hbWVzSW5GaWxl
KGNvbnN0IGNoYXIqIGZpbGVuYW1lKQogICAgICAgICAKICAgICAgICAgbV9lbnRyaWVzLmFkZChT
dHJpbmcobGluZSwgbGVuZ3RoKSk7CiAgICAgfQorCisgICAgaW50IHJlc3VsdCA9IGZjbG9zZShm
KTsKKyAgICBpZiAocmVzdWx0KQorICAgICAgICBkYXRhTG9nRigiRmFpbGVkIHRvIGNsb3NlIGZp
bGUgJXM6ICVzXG4iLCBmaWxlbmFtZSwgc3RyZXJyb3IoZXJybm8pKTsKIH0KIAogYm9vbCBGdW5j
dGlvbldoaXRlbGlzdDo6Y29udGFpbnMoQ29kZUJsb2NrKiBjb2RlQmxvY2spIGNvbnN0IAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>