134337 2014-06-25 22:42:57 -0700 HIDGamepad should use CFIndex when looping 2014-09-12 16:54:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1018561 0 dino 2014-06-25 22:42:57 -0700 HIDGamepad should use CFIndex when looping 1018562 1 233884 dino 2014-06-25 22:45:46 -0700 Created attachment 233884 Patch 1018565 2 233884 mitz 2014-06-25 22:48:14 -0700 Comment on attachment 233884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233884&action=review > Source/WebCore/platform/mac/HIDGamepad.cpp:79 > + CFIndex count = CFArrayGetCount(elements); > + for (CFIndex i = 0; i < count; ++i) { Our usual style for this is for (CFIndex i = 0, count = CFArrayGetCount(elements); i < count; ++i) 1018568 3 233887 dino 2014-06-25 22:55:43 -0700 Created attachment 233887 Patch 1018574 4 233887 commit-queue 2014-06-25 23:35:48 -0700 Comment on attachment 233887 Patch Clearing flags on attachment: 233887 Committed r170469: <http://trac.webkit.org/changeset/170469> 233884 2014-06-25 22:45:46 -0700 2014-06-25 22:48:14 -0700 Patch bug-134337-20140625224518.patch text/plain 1463 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThjZmRjNzY3Yjk3NmE1 Y2Q1ZDVlYTVhM2MwOTk3NzY3MDZiYTY0Ny4uOTgyYTQzZmMzOTllODMwMjFmZTdhOWIxOGE1YmI4 NWZhZTE5MzNlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA2LTI1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBISURHYW1lcGFkIHNob3VsZCB1 c2UgQ0ZJbmRleCB3aGVuIGxvb3BpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNDMzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SElER2FtZXBhZDo6aW5pdEVsZW1lbnRzRnJvbUFycmF5KTogUmVwbGFjZSBpbnQg d2l0aCBDRkluZGV4LCBhbmQgdXNlCisgICAgICAgIGEgbG9jYWwgdmFyaWFibGUgZm9yIENGQXJy YXlDb3VudC4KKwogMjAxNC0wNi0yNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBCdWlsZCBmaXggYXR0ZW1wdCBhZnRlciByMTcwNDY1LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQuY3BwCmluZGV4IGExMDQ5Y2JmYTZlNDM4ZmQ1OWY1 MTI0YTczZDZkMzUxMzFiMTJhMmIuLmUxMDQ0N2JiODEzNTI1N2MyZjBkMjYwM2Y5NjU5MGI1MWYz MjgxNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9ISURHYW1lcGFk LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSElER2FtZXBhZC5jcHAKQEAg LTc1LDcgKzc1LDggQEAgdm9pZCBISURHYW1lcGFkOjppbml0RWxlbWVudHMoKQogCiB2b2lkIEhJ REdhbWVwYWQ6OmluaXRFbGVtZW50c0Zyb21BcnJheShDRkFycmF5UmVmIGVsZW1lbnRzKQogewot ICAgIGZvciAoaW50IGkgPSAwOyBpIDwgQ0ZBcnJheUdldENvdW50KGVsZW1lbnRzKTsgKytpKSB7 CisgICAgQ0ZJbmRleCBjb3VudCA9IENGQXJyYXlHZXRDb3VudChlbGVtZW50cyk7CisgICAgZm9y IChDRkluZGV4IGkgPSAwOyBpIDwgY291bnQ7ICsraSkgewogICAgICAgICBJT0hJREVsZW1lbnRS ZWYgZWxlbWVudCA9IChJT0hJREVsZW1lbnRSZWYpQ0ZBcnJheUdldFZhbHVlQXRJbmRleChlbGVt ZW50cywgaSk7CiAgICAgICAgIGlmIChDRkdldFR5cGVJRChlbGVtZW50KSAhPSBJT0hJREVsZW1l bnRHZXRUeXBlSUQoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwo= 233887 2014-06-25 22:55:43 -0700 2014-06-25 23:35:48 -0700 Patch bug-134337-20140625225515.patch text/plain 1449 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThjZmRjNzY3Yjk3NmE1 Y2Q1ZDVlYTVhM2MwOTk3NzY3MDZiYTY0Ny4uOWU0ZDdjOWU4NGQwY2ZhYmJkMDc3N2ZhOTMxMjJj NTg2YjNkMWU4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA2LTI1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBISURHYW1lcGFkIHNob3VsZCB1 c2UgQ0ZJbmRleCB3aGVuIGxvb3BpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNDMzNworCisgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3Rl aW4uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvSElER2FtZXBhZC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpISURHYW1lcGFkOjppbml0RWxlbWVudHNGcm9tQXJyYXkpOiBSZXBsYWNlIGludCB3 aXRoIENGSW5kZXgsIGFuZCB1c2UKKyAgICAgICAgYSBsb2NhbCB2YXJpYWJsZSBmb3IgQ0ZBcnJh eUNvdW50LgorCiAyMDE0LTA2LTI1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIEJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHIxNzA0NjUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSElER2FtZXBhZC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvSElER2FtZXBhZC5jcHAKaW5kZXggYTEwNDljYmZhNmU0MzhmZDU5ZjUx MjRhNzNkNmQzNTEzMWIxMmEyYi4uZGVjN2I0MDJmMDUwOWQ1YTEwZDFmNzdiMTc4OGNiOGExM2Zk ZWU4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9ISURHYW1lcGFkLmNwcApAQCAt NzUsNyArNzUsNyBAQCB2b2lkIEhJREdhbWVwYWQ6OmluaXRFbGVtZW50cygpCiAKIHZvaWQgSElE R2FtZXBhZDo6aW5pdEVsZW1lbnRzRnJvbUFycmF5KENGQXJyYXlSZWYgZWxlbWVudHMpCiB7Ci0g ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBDRkFycmF5R2V0Q291bnQoZWxlbWVudHMpOyArK2kpIHsK KyAgICBmb3IgKENGSW5kZXggaSA9IDAsIGNvdW50ID0gQ0ZBcnJheUdldENvdW50KGVsZW1lbnRz KTsgaSA8IGNvdW50OyArK2kpIHsKICAgICAgICAgSU9ISURFbGVtZW50UmVmIGVsZW1lbnQgPSAo SU9ISURFbGVtZW50UmVmKUNGQXJyYXlHZXRWYWx1ZUF0SW5kZXgoZWxlbWVudHMsIGkpOwogICAg ICAgICBpZiAoQ0ZHZXRUeXBlSUQoZWxlbWVudCkgIT0gSU9ISURFbGVtZW50R2V0VHlwZUlEKCkp CiAgICAgICAgICAgICBjb250aW51ZTsK