134329 2014-06-25 20:31:54 -0700 [Mac] allow host application to canonicalize media urls 2014-06-26 09:46:18 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson bunhere cdumez commit-queue glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 1018508 0 eric.carlson 2014-06-25 20:31:54 -0700 OSX and iOS applications can modify load request with an NSURLProtocol subclass. This is supported for data that is loaded with WebCore's resource loader classes but because WebCore on iOS and OS X uses the system media engines to load media data, we should canonicalize a media url before passing it to the media framework. 1018512 1 233869 eric.carlson 2014-06-25 20:40:27 -0700 Created attachment 233869 Proposed patch. 1018537 2 233869 jer.noble 2014-06-25 21:19:02 -0700 Comment on attachment 233869 Proposed patch. Before you check this in, is there a way to make it conditional on whether a custom protocol handler is installed for the scheme in question? 1018539 3 jer.noble 2014-06-25 21:30:00 -0700 Drat, looks like there's not API for determining if there's a custom NSURLProtocol registered for a given scheme. Carry on. 1018620 4 233869 commit-queue 2014-06-26 07:06:16 -0700 Comment on attachment 233869 Proposed patch. Clearing flags on attachment: 233869 Committed r170478: <http://trac.webkit.org/changeset/170478> 1018621 5 commit-queue 2014-06-26 07:06:21 -0700 All reviewed patches have been landed. Closing bug. 1018648 6 233869 darin 2014-06-26 09:46:18 -0700 Comment on attachment 233869 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=233869&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:754 > - NSURL *cocoaURL = URL(ParsedURLString, url); > + NSURL *cocoaURL = canonicalURL(url); Where does the guarantee that this URL string came from a URL object come from? Can we change this to pass in the URL if we really need to rely on it being a parsed URL? Generally we need to avoid the pattern of using ParsedURLString. 233869 2014-06-25 20:40:27 -0700 2014-06-26 09:46:18 -0700 Proposed patch. patch_2.txt text/plain 2267 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDQ1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA2LTI1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGFsbG93IGhv c3QgYXBwbGljYXRpb24gdG8gY2Fub25pY2FsaXplIG1lZGlhIHVybHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDMyOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OmNhbm9uaWNhbFVSTCk6IE5ldywgdXNlIE5TVVJMUHJvdG9jb2wgdG8g Y2Fub25pY2FsaXplIGEgVVJMLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uT2JqQzo6Y3JlYXRlQVZBc3NldEZvclVSTCk6IENhbGwgY2Fub25pY2FsVVJM LgorCiAyMDE0LTA2LTI1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgQXNzZXJ0aW9uIGZhaWxlZDogQ0dQYXRoQWRkUm91bmRlZFJlY3QgYXNzZXJ0cyBvbiBub24t cmVuZGVyYWJsZSByb3VuZGVkIHJlY3RhbmdsZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbk9iakMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bQkocmV2aXNpb24gMTcwMzkyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQko d29ya2luZyBjb3B5KQpAQCAtNjcxLDYgKzY3MSwyNCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbk9iakM6CiB9CiAjZW5kaWYKIAorCitzdGF0aWMgTlNVUkwgKmNhbm9uaWNh bFVSTChjb25zdCBTdHJpbmcmIHVybCkKK3sKKyAgICBOU1VSTCAqY29jb2FVUkwgPSBVUkwoUGFy c2VkVVJMU3RyaW5nLCB1cmwpOworICAgIGlmICh1cmwuaXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gY29jb2FVUkw7CisKKyAgICBSZXRhaW5QdHI8TlNVUkxSZXF1ZXN0PiByZXF1ZXN0ID0gYWRv cHROUyhbW05TVVJMUmVxdWVzdCBhbGxvY10gaW5pdFdpdGhVUkw6Y29jb2FVUkxdKTsKKyAgICBp ZiAoIXJlcXVlc3QpCisgICAgICAgIHJldHVybiBjb2NvYVVSTDsKKworICAgIE5TVVJMUmVxdWVz dCAqY2Fub25pY2FsUmVxdWVzdCA9IFtOU1VSTFByb3RvY29sIGNhbm9uaWNhbFJlcXVlc3RGb3JS ZXF1ZXN0OnJlcXVlc3QuZ2V0KCldOworICAgIGlmICghY2Fub25pY2FsUmVxdWVzdCkKKyAgICAg ICAgcmV0dXJuIGNvY29hVVJMOworCisgICAgcmV0dXJuIFtjYW5vbmljYWxSZXF1ZXN0IFVSTF07 Cit9CisKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6Y3JlYXRlQVZB c3NldEZvclVSTChjb25zdCBTdHJpbmcmIHVybCkKIHsKICAgICBpZiAobV9hdkFzc2V0KQpAQCAt NzMzLDcgKzc1MSw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzoK ICAgICAgICAgW29wdGlvbnMgc2V0T2JqZWN0Om5ldHdvcmtJbnRlcmZhY2VOYW1lIGZvcktleTpB VlVSTEFzc2V0Qm91bmROZXR3b3JrSW50ZXJmYWNlTmFtZV07CiAjZW5kaWYKIAotICAgIE5TVVJM ICpjb2NvYVVSTCA9IFVSTChQYXJzZWRVUkxTdHJpbmcsIHVybCk7CisgICAgTlNVUkwgKmNvY29h VVJMID0gY2Fub25pY2FsVVJMKHVybCk7CiAgICAgbV9hdkFzc2V0ID0gYWRvcHROUyhbW0FWVVJM QXNzZXQgYWxsb2NdIGluaXRXaXRoVVJMOmNvY29hVVJMIG9wdGlvbnM6b3B0aW9ucy5nZXQoKV0p OwogCiAjaWYgSEFWRShBVkZPVU5EQVRJT05fTE9BREVSX0RFTEVHQVRFKQo=