<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134322</bug_id>
          
          <creation_ts>2014-06-25 18:09:49 -0700</creation_ts>
          <short_desc>After r170428, offline assembler sometimes creates empty LLIntAssembly.h</short_desc>
          <delta_ts>2014-06-26 17:32:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Saboff">msaboff</reporter>
          <assigned_to name="Michael Saboff">msaboff</assigned_to>
          <cc>peavo</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1018472</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2014-06-25 18:09:49 -0700</bug_when>
    <thetext>After r170428, the offline assembler will sometimes create an LLIntAssembly.h file with just the hash line:
// offlineasm input hash: cb3be4a5c6bc8076a46396599fba7c070d00cdf8 1fdc12e5c4851899db57a32e840ba77f46a9fa29 283b8172f1ff6e5e115dbe22d5c7494f289ea2da</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018649</commentid>
    <comment_count>1</comment_count>
    <who name="">peavo</who>
    <bug_when>2014-06-26 09:48:25 -0700</bug_when>
    <thetext>This is just a guess, but could it be caused by an exception being thrown,
caused by for example the change in asm.rb?


--- Source/JavaScriptCore/offlineasm/asm.rb	(revision 170426)
+++ Source/JavaScriptCore/offlineasm/asm.rb	(working copy)
@@ -262,7 +262,7 @@ class Assembler
             @codeOrigin = nil
             @commentState = :many
         when :many
-            @outp.puts &quot;// #{text}&quot; if $enableCodeOriginComments
+            @outp.puts $commentPrefix + &quot; #{text}&quot; if $enableCodeOriginComments
         else
             raise
         end</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018816</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2014-06-26 17:32:57 -0700</bug_when>
    <thetext>I can no longer get this to fail.  When I filed, I performed the following steps:

svn up -r 170424
Tools/Scripts/build-webkit --debug
svn up -r 170431
Tools/Scripts/build-webkit --debug

The second build failed.

Today, those steps work fine.  I tried multiple times, but can&apos;t reproduce.

We can file another bug if the problem reappears.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>