134319 2014-06-25 17:34:39 -0700 [iOS]: Tapping <button> outside of a form is no longer working 2014-06-26 11:34:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned benjamin bunhere cdumez commit-queue dbates ddkilzer esprehn+autocc gyuyoung.kim joepeck sergio oldest_to_newest 1018457 0 joepeck 2014-06-25 17:34:39 -0700 Reduction: <button>Test Button</button> <script> document.addEventListener('click', function() { alert('click'); }, false); </script> This is no longer working. It looks like when upstreaming iOS WebKit we changed HTMLButtonElement::willRespondToMouseClickEvents away from the iOS implementation to the OpenSource (Chromium / Android implementation). We should revert back to the iOS implementation that supports <button> outside of a <form>. 1018458 1 joepeck 2014-06-25 17:34:50 -0700 <rdar://problem/17213346> 1018459 2 233856 joepeck 2014-06-25 17:37:04 -0700 Created attachment 233856 [PATCH] Proposed Fix 1018480 3 233856 dbates 2014-06-25 18:38:10 -0700 Comment on attachment 233856 [PATCH] Proposed Fix Can we write a DRT test for this? 1018481 4 233856 dbates 2014-06-25 18:39:16 -0700 Comment on attachment 233856 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=233856&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=134319 Please list the radar URL under the WebKit bug URL. 1018687 5 joepeck 2014-06-26 11:34:15 -0700 <http://trac.webkit.org/changeset/170487> 1018688 6 joepeck 2014-06-26 11:34:37 -0700 (In reply to comment #3) > (From update of attachment 233856 [details]) > Can we write a DRT test for this? Hmm, probably. I'll look into this. 233856 2014-06-25 17:37:04 -0700 2014-06-25 18:39:15 -0700 [PATCH] Proposed Fix button.patch text/plain 1594 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZjI1NDUyLi5iNDhkNjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTQtMDYtMjUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBbaU9TXTogVGFwcGluZyA8YnV0dG9uPiBvdXRzaWRlIG9mIGEgZm9ybSBpcyBubyBs b25nZXIgd29ya2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM0MzE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVzdG9yZSBiZWhhdmlvciBvZiBhbGxvd2luZyA8YnV0dG9uPiBjbGlja3Mgb3V0c2lk ZSBvZiA8Zm9ybT4uCisgICAgICAgIFRoaXMgdXNlZCB0byBiZSBpT1MgYmVoYXZpb3IgYmVmb3Jl IGl0IHdhcyByZW1vdmVkIGluIGZhdm9yIG9mIHRoZQorICAgICAgICBPcGVuU291cmNlIChBbmRy b2lkPykgYmVoYXZpb3IuIE5vdywgd2lsbFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMKKyAgICAg ICAgaXMgb25seSB1c2VkIGJ5IGlPUywgc28gbGV0cyByZXN0b3JlIHRoZSBpT1MgYmVoYXZpb3Iu CisKKyAgICAgICAgKiBodG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxCdXR0b25FbGVtZW50Ojp3aWxsUmVzcG9uZFRvTW91c2VDbGlja0V2ZW50cyk6CisK KzIwMTQtMDYtMjUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICBbaU9TXTogV0syIEluc3BlY3RvciBOb2RlIFNlYXJjaAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0Mjc5CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MQnV0dG9uRWxlbWVudC5jcHAKaW5kZXggZjk4MWQzNi4uYjYyNWQ3ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5jcHAKQEAgLTE1NCw5ICsxNTQsNyBAQCB2 b2lkIEhUTUxCdXR0b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkK IAogYm9vbCBIVE1MQnV0dG9uRWxlbWVudDo6d2lsbFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMo KQogewotICAgIGlmICghaXNEaXNhYmxlZEZvcm1Db250cm9sKCkgJiYgZm9ybSgpICYmIChtX3R5 cGUgPT0gU1VCTUlUIHx8IG1fdHlwZSA9PSBSRVNFVCkpCi0gICAgICAgIHJldHVybiB0cnVlOwot ICAgIHJldHVybiBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojp3aWxsUmVzcG9uZFRvTW91c2VDbGlj a0V2ZW50cygpOworICAgIHJldHVybiAhaXNEaXNhYmxlZEZvcm1Db250cm9sKCk7CiB9CiAKIGJv b2wgSFRNTEJ1dHRvbkVsZW1lbnQ6OmlzU3VjY2Vzc2Z1bFN1Ym1pdEJ1dHRvbigpIGNvbnN0Cg==