134308 2014-06-25 14:54:44 -0700 Fix various leaks, RetainPtrs should adopt allocs 2014-06-27 11:14:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim joepeck sergio thorton oldest_to_newest 1018415 0 joepeck 2014-06-25 14:54:44 -0700 Fix a few leaks searching around WebKit2 code where RetainPtr ivars should adopt alloc objects. 1018416 1 233838 joepeck 2014-06-25 14:55:43 -0700 Created attachment 233838 [PATCH] Proposed Fix 1018891 2 ap 2014-06-26 23:02:55 -0700 Tim fixed one of these leaks in bug 134368 later. Can you please land the other part of the fix? 1018893 3 thorton 2014-06-26 23:07:34 -0700 Heh, didn't know about this patch, sorry! 1019018 4 joepeck 2014-06-27 11:06:09 -0700 I can land today. 1019028 5 joepeck 2014-06-27 11:14:57 -0700 r170540: <http://trac.webkit.org/changeset/170540> 233838 2014-06-25 14:55:43 -0700 2014-06-26 01:08:56 -0700 [PATCH] Proposed Fix fix-leaks.patch text/plain 2530 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NGEzOWZmLi42MjgwZjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMDYtMjUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBGaXggdmFyaW91cyBsZWFrcywgUmV0YWluUHRycyBzaG91bGQgYWRvcHQgYWxsb2Nz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQzMDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IGJyb3dzaW5nQ29udGV4 dENvbnRyb2xsZXJdKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9t YWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyLm1tOgorICAgICAg ICAoLVtXS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIgX3JlbW90ZU9i amVjdFJlZ2lzdHJ5XSk6CisKKzIwMTQtMDYtMjUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBbaU9TXTogV0syIEluc3BlY3RvciBOb2RlIFNlYXJjaAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0Mjc5CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbSBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQppbmRleCBkZTQxMDU0 Li41YmVjMjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t CkBAIC0zMTQsNyArMzE0LDcgQEAgc3RydWN0IFdLVmlld0ludGVycHJldEtleUV2ZW50c1BhcmFt ZXRlcnMgewogLSAoV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICopYnJvd3NpbmdDb250ZXh0 Q29udHJvbGxlcgogewogICAgIGlmICghX2RhdGEtPl9icm93c2luZ0NvbnRleHRDb250cm9sbGVy KQotICAgICAgICBfZGF0YS0+X2Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgPSBbW1dLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlciBhbGxvY10gX2luaXRXaXRoUGFnZVJlZjp0b0FQSShfZGF0YS0+ X3BhZ2UuZ2V0KCkpXTsKKyAgICAgICAgX2RhdGEtPl9icm93c2luZ0NvbnRleHRDb250cm9sbGVy ID0gYWRvcHROUyhbW1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciBhbGxvY10gX2luaXRXaXRo UGFnZVJlZjp0b0FQSShfZGF0YS0+X3BhZ2UuZ2V0KCkpXSk7CiAKICAgICByZXR1cm4gX2RhdGEt Pl9icm93c2luZ0NvbnRleHRDb250cm9sbGVyLmdldCgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1Bs dWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4 dENvbnRyb2xsZXIubW0KaW5kZXggZmIyMDMzMS4uZjMzNGRjZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1Bs dWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNv bnRleHRDb250cm9sbGVyLm1tCkBAIC0zODQsNyArMzg0LDcgQEAgc3RhdGljIHZvaWQgc2V0VXBS ZXNvdXJjZUxvYWRDbGllbnQoV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9s bGVyICoKIC0gKF9XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5ICopX3JlbW90ZU9iamVjdFJlZ2lzdHJ5 CiB7CiAgICAgaWYgKCFfcmVtb3RlT2JqZWN0UmVnaXN0cnkpIHsKLSAgICAgICAgX3JlbW90ZU9i amVjdFJlZ2lzdHJ5ID0gW1tfV0tSZW1vdGVPYmplY3RSZWdpc3RyeSBhbGxvY10gX2luaXRXaXRo TWVzc2FnZVNlbmRlcjoqX3BhZ2VdOworICAgICAgICBfcmVtb3RlT2JqZWN0UmVnaXN0cnkgPSBh ZG9wdE5TKFtbX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkgYWxsb2NdIF9pbml0V2l0aE1lc3NhZ2VT ZW5kZXI6Kl9wYWdlXSk7CiAgICAgICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLmFkZE1lc3NhZ2VS ZWNlaXZlcihNZXNzYWdlczo6UmVtb3RlT2JqZWN0UmVnaXN0cnk6Om1lc3NhZ2VSZWNlaXZlck5h bWUoKSwgX3BhZ2UtPnBhZ2VJRCgpLCBbX3JlbW90ZU9iamVjdFJlZ2lzdHJ5IHJlbW90ZU9iamVj dFJlZ2lzdHJ5XSk7CiAgICAgfQogCg==