134297 2014-06-25 05:24:18 -0700 [GTK] Do not add forward declaration of class struct for interfaces 2014-07-02 00:09:59 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 134028 1 cgarcia webkit-unassigned gustavo pnormand svillar oldest_to_newest 1018307 0 cgarcia 2014-06-25 05:24:18 -0700 There's no class struct for interfaces, it should be FooIface instead. 1018310 1 233805 cgarcia 2014-06-25 05:28:06 -0700 Created attachment 233805 Patch 1019917 2 cgarcia 2014-07-02 00:09:59 -0700 Committed r170701: <http://trac.webkit.org/changeset/170701> 233805 2014-06-25 05:28:06 -0700 2014-06-25 07:59:50 -0700 Patch wkdom-interfaces.diff text/plain 6887 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwOGM5ODNhLi5kYzFiMjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDYtMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvIG5vdCBhZGQgZm9yd2FyZCBkZWNsYXJhdGlvbiBvZiBjbGFz cyBzdHJ1Y3QgZm9yIGludGVyZmFjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNDI5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6IE1ha2UgZmlsZXMgZ2VuZXJhdGVk IGJ5CisgICAgICAgIGdvYmplY3QtZ2VuZXJhdGUtaGVhZGVycy5wbCBzY3JpcHQgZGVwZW5kIG9u IGl0LgorICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRXZlbnRUYXJnZXQuaDog UmVtb3ZlIGZvcndhcmQgZGVjbGFyYXRpb24uCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9X ZWJLaXRET01Ob2RlRmlsdGVyLmg6IERpdHRvCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9X ZWJLaXRET01YUGF0aE5TUmVzb2x2ZXIuaDogRGl0dG8uCisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9nb2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMucGw6IFVzZSBJZmFjZSBpbnN0ZWFkCisgICAg ICAgIG9mIENsYXNzIHN1ZmZpeCBmb3IgaW50ZXJmYWNlcy4KKwogMjAxNC0wNi0yNCAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gWFBh dGhOU1Jlc29sdmVyIHNob3VsZCBiZSBleHBvc2VkIGFzIGFuIGludGVyZmFjZSBpbnN0ZWFkIG9m IGFzIGEgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtl IGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNDAyZWE4Yy4uMjVkMjE3 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291 cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTY4OCwxNiArNjg4LDE5IEBAIGZpbGUo TUFLRV9ESVJFQ1RPUlkgJHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklORElOR1NfRElS fSkKIAogYWRkX2N1c3RvbV9jb21tYW5kKAogICAgIE9VVFBVVCAke0RFUklWRURfU09VUkNFU19H T0JKRUNUX0RPTV9CSU5ESU5HU19ESVJ9L3dlYmtpdGRvbWRlZmluZXMuaAorICAgIERFUEVORFMg JHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMu cGwKICAgICBDT01NQU5EIGVjaG8gJHtHT2JqZWN0RE9NQmluZGluZ3NTdGFibGVfQ0xBU1NfTElT VH0gfCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9n b2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMucGwgZGVmaW5lcyA+ICR7REVSSVZFRF9TT1VSQ0VTX0dP QkpFQ1RfRE9NX0JJTkRJTkdTX0RJUn0vd2Via2l0ZG9tZGVmaW5lcy5oCiApCiAKIGFkZF9jdXN0 b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfR09CSkVDVF9ET01fQklO RElOR1NfRElSfS93ZWJraXRkb21kZWZpbmVzLXVuc3RhYmxlLmgKKyAgICBERVBFTkRTICR7V0VC Q09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMvZ29iamVjdC1nZW5lcmF0ZS1oZWFkZXJzLnBsCiAg ICAgQ09NTUFORCBlY2hvICR7R09iamVjdERPTUJpbmRpbmdzVW5zdGFibGVfQ0xBU1NfTElTVH0g fCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9nb2Jq ZWN0LWdlbmVyYXRlLWhlYWRlcnMucGwgZGVmaW5lcy11bnN0YWJsZSA+ICR7REVSSVZFRF9TT1VS Q0VTX0dPQkpFQ1RfRE9NX0JJTkRJTkdTX0RJUn0vd2Via2l0ZG9tZGVmaW5lcy11bnN0YWJsZS5o CiApCiAKIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNf R09CSkVDVF9ET01fQklORElOR1NfRElSfS93ZWJraXRkb20uaAorICAgIERFUEVORFMgJHtXRUJD T1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMucGwKICAg ICBDT01NQU5EIGVjaG8gJHtHT2JqZWN0RE9NQmluZGluZ3NTdGFibGVfQ0xBU1NfTElTVH0gfCAk e1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0 LWdlbmVyYXRlLWhlYWRlcnMucGwgZ2RvbSA+ICR7REVSSVZFRF9TT1VSQ0VTX0dPQkpFQ1RfRE9N X0JJTkRJTkdTX0RJUn0vd2Via2l0ZG9tLmgKICkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01FdmVudFRhcmdldC5oIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01FdmVudFRhcmdldC5oCmluZGV4IDM0MjBmMTU3 Li4yYmI0ZDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dl YktpdERPTUV2ZW50VGFyZ2V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVj dC9XZWJLaXRET01FdmVudFRhcmdldC5oCkBAIC0zMCw4ICszMCw2IEBAIEdfQkVHSU5fREVDTFMK ICNkZWZpbmUgV0VCS0lUX0RPTV9JU19FVkVOVF9UQVJHRVQob2JqKSAgICAgICAgIChHX1RZUEVf Q0hFQ0tfSU5TVEFOQ0VfVFlQRSAoKG9iaiksIFdFQktJVF9ET01fVFlQRV9FVkVOVF9UQVJHRVQp KQogI2RlZmluZSBXRUJLSVRfRE9NX0VWRU5UX1RBUkdFVF9HRVRfSUZBQ0Uob2JqKSAgKEdfVFlQ RV9JTlNUQU5DRV9HRVRfSU5URVJGQUNFICgob2JqKSwgV0VCS0lUX0RPTV9UWVBFX0VWRU5UX1RB UkdFVCwgV2ViS2l0RE9NRXZlbnRUYXJnZXRJZmFjZSkpCiAKLXR5cGVkZWYgc3RydWN0IF9XZWJL aXRET01FdmVudFRhcmdldElmYWNlIFdlYktpdERPTUV2ZW50VGFyZ2V0SWZhY2U7Ci0KIHN0cnVj dCBfV2ViS2l0RE9NRXZlbnRUYXJnZXRJZmFjZSB7CiAgICAgR1R5cGVJbnRlcmZhY2UgZ0lmYWNl OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERP TU5vZGVGaWx0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9N Tm9kZUZpbHRlci5oCmluZGV4IDVkMWQzZmQuLjJkODhmOGZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTU5vZGVGaWx0ZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTU5vZGVGaWx0ZXIuaApAQCAtMTc5 LDggKzE3OSw2IEBAIEdfQkVHSU5fREVDTFMKICAqLwogI2RlZmluZSBXRUJLSVRfRE9NX05PREVf RklMVEVSX1NIT1dfTk9UQVRJT04gICAgICAgICAgICAgICAweDAwMDAwODAwCiAKLXR5cGVkZWYg c3RydWN0IF9XZWJLaXRET01Ob2RlRmlsdGVySWZhY2UgV2ViS2l0RE9NTm9kZUZpbHRlcklmYWNl OwotCiBzdHJ1Y3QgX1dlYktpdERPTU5vZGVGaWx0ZXJJZmFjZSB7CiAgICAgR1R5cGVJbnRlcmZh Y2UgZ0lmYWNlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0 L1dlYktpdERPTVhQYXRoTlNSZXNvbHZlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01YUGF0aE5TUmVzb2x2ZXIuaAppbmRleCBiY2MzOTcxLi4yYzE2NDZkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTVhQYXRo TlNSZXNvbHZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0 RE9NWFBhdGhOU1Jlc29sdmVyLmgKQEAgLTMwLDggKzMwLDYgQEAgR19CRUdJTl9ERUNMUwogI2Rl ZmluZSBXRUJLSVRfRE9NX0lTX1hQQVRIX05TX1JFU09MVkVSKG9iaikgICAgICAgICAoR19UWVBF X0NIRUNLX0lOU1RBTkNFX1RZUEUgKChvYmopLCBXRUJLSVRfRE9NX1RZUEVfWFBBVEhfTlNfUkVT T0xWRVIpKQogI2RlZmluZSBXRUJLSVRfRE9NX1hQQVRIX05TX1JFU09MVkVSX0dFVF9JRkFDRShv YmopICAoR19UWVBFX0lOU1RBTkNFX0dFVF9JTlRFUkZBQ0UgKChvYmopLCBXRUJLSVRfRE9NX1RZ UEVfWFBBVEhfTlNfUkVTT0xWRVIsIFdlYktpdERPTVhQYXRoTlNSZXNvbHZlcklmYWNlKSkKIAot dHlwZWRlZiBzdHJ1Y3QgX1dlYktpdERPTVhQYXRoTlNSZXNvbHZlcklmYWNlIFdlYktpdERPTVhQ YXRoTlNSZXNvbHZlcklmYWNlOwotCiBzdHJ1Y3QgX1dlYktpdERPTVhQYXRoTlNSZXNvbHZlcklm YWNlIHsKICAgICBHVHlwZUludGVyZmFjZSBnSWZhY2U7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ29iamVjdC1nZW5lcmF0ZS1oZWFkZXJzLnBsIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMucGwK aW5kZXggNDI5ODA1ZC4uYzdhZDc4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9nb2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMucGwKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0LWdlbmVyYXRlLWhlYWRlcnMucGwKQEAgLTgyLDcg KzgyLDExIEBAIGlmICgkb3V0VHlwZSBlcSAiZGVmaW5lcyIpIHsKICAgICBwcmludCAiI2VuZGlm XG4iOwogCiAgICAgZm9yZWFjaCBteSAkY2xhc3MgKEBjbGFzc2VzKSB7Ci0gICAgICAgIGlmICgk Y2xhc3MgbmUgIkRlcHJlY2F0ZWQiICYmICRjbGFzcyBuZSAiQ3VzdG9tIikgeworICAgICAgICBp ZiAoJGNsYXNzIGVxICJFdmVudFRhcmdldCIgfHwgJGNsYXNzIGVxICJOb2RlRmlsdGVyIiB8fCAk Y2xhc3MgZXEgIlhQYXRoTlNSZXNvbHZlciIpIHsKKyAgICAgICAgICAgIHByaW50ICJ0eXBlZGVm IHN0cnVjdCBfV2ViS2l0RE9NJHtjbGFzc30gV2ViS2l0RE9NJHtjbGFzc307XG4iOworICAgICAg ICAgICAgcHJpbnQgInR5cGVkZWYgc3RydWN0IF9XZWJLaXRET00ke2NsYXNzfUlmYWNlIFdlYktp dERPTSR7Y2xhc3N9SWZhY2U7XG4iOworICAgICAgICAgICAgcHJpbnQgIlxuIjsKKyAgICAgICAg fSBlbHNpZiAoJGNsYXNzIG5lICJEZXByZWNhdGVkIiAmJiAkY2xhc3MgbmUgIkN1c3RvbSIpIHsK ICAgICAgICAgICAgIHByaW50ICJ0eXBlZGVmIHN0cnVjdCBfV2ViS2l0RE9NJHtjbGFzc30gV2Vi S2l0RE9NJHtjbGFzc307XG4iOwogICAgICAgICAgICAgcHJpbnQgInR5cGVkZWYgc3RydWN0IF9X ZWJLaXRET00ke2NsYXNzfUNsYXNzIFdlYktpdERPTSR7Y2xhc3N9Q2xhc3M7XG4iOwogICAgICAg ICAgICAgcHJpbnQgIlxuIjsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0No YW5nZUxvZwppbmRleCBhNjFkZmExLi43NWYxMWZmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDYtMjUgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtd IERvIG5vdCBhZGQgZm9yd2FyZCBkZWNsYXJhdGlvbiBvZiBjbGFzcyBzdHJ1Y3QgZm9yIGludGVy ZmFjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NDI5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBJZmFjZSBzeW1ib2wgdG8gZG9jdW1lbnRhdGlvbiBpbnN0ZWFkIG9mIENsYXNzIGZvciBpbnRl cmZhY2VzLgorCisgICAgICAgICogZ3RrL3dlYmtpdGRvbS5weToKKyAgICAgICAgKFdlYktpdERP TURvY0dlbmVyYXRvclNlY3Rpb25zLndyaXRlX3NlY3Rpb24pOgorCiAyMDE0LTA2LTI0ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBY UGF0aE5TUmVzb2x2ZXIgc2hvdWxkIGJlIGV4cG9zZWQgYXMgYW4gaW50ZXJmYWNlIGluc3RlYWQg b2YgYXMgYSBjbGFzcwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL3dlYmtpdGRvbS5weSBiL1Rvb2xz L2d0ay93ZWJraXRkb20ucHkKaW5kZXggYzQ2YzcyYi4uZWJkNTYzYyAxMDA3NTUKLS0tIGEvVG9v bHMvZ3RrL3dlYmtpdGRvbS5weQorKysgYi9Ub29scy9ndGsvd2Via2l0ZG9tLnB5CkBAIC0xNDMs NyArMTQzLDEwIEBAIGNsYXNzIFdlYktpdERPTURvY0dlbmVyYXRvclNlY3Rpb25zKFdlYktpdERP TURvY0dlbmVyYXRvcik6CiAgICAgICAgIHNlbGYud3JpdGUoJ1xuJy5qb2luKHNlbGYuX3N5bWJv bF9saXN0KHN5bWJvbF9maWxlKSkgKyAnXG4nKQogICAgICAgICBpZiBub3QgaXNfY3VzdG9tOgog ICAgICAgICAgICAgc2VsZi53cml0ZSgnXG48U1VCU0VDVElPTiBTdGFuZGFyZD5cbicpCi0gICAg ICAgICAgICBzZWxmLndyaXRlKCclc0NsYXNzXG4nICUgY2xhc3NfbmFtZSkKKyAgICAgICAgICAg IGlmIGlzX2ludGVyZmFjZToKKyAgICAgICAgICAgICAgICBzZWxmLndyaXRlKCclc0lmYWNlXG4n ICUgY2xhc3NfbmFtZSkKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgc2VsZi53 cml0ZSgnJXNDbGFzc1xuJyAlIGNsYXNzX25hbWUpCiAgICAgICAgICAgICBkb21fY2xhc3MgPSBz ZWxmLl9kb21fY2xhc3NfZGVjYW1lbGl6ZShjbGFzc19uYW1lKS51cHBlcigpCiAgICAgICAgICAg ICBzZWxmLndyaXRlKCdXRUJLSVRfRE9NX1RZUEVfJXNcbicgJSBkb21fY2xhc3MpCiAgICAgICAg ICAgICBzZWxmLndyaXRlKCdXRUJLSVRfRE9NXyVzXG4nICUgZG9tX2NsYXNzKQo=