134293 2014-06-24 23:56:26 -0700 [Mac] Update the time base of event's timestamp when the system time changes 2014-06-25 13:42:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin andersca bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1018277 0 benjamin 2014-06-24 23:56:26 -0700 [Mac] Update the time base of event's timestamp when the system time changes 1018278 1 233793 benjamin 2014-06-25 00:01:41 -0700 Created attachment 233793 Patch 1018279 2 commit-queue 2014-06-25 00:03:08 -0700 Attachment 233793 did not pass style-queue: ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:338: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:339: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:340: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1018322 3 233793 andersca 2014-06-25 07:18:22 -0700 Comment on attachment 233793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233793&action=review > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332 > + void (^updateBlock)(NSNotification *) = Block_copy(^(NSNotification *){ updateSystemStartupTimeIntervalSince1970(); }); There's no need to copy the block, it will be copied by addObserverForName. I'd just use a lambda instead of a block too (they're implicitly converted to blocks, so something like): auto updateBlock = [](NSNotification *) { updateSystemStartupTimeIntervalSince1970(); }; 1018351 4 benjamin 2014-06-25 09:40:15 -0700 (In reply to comment #3) > (From update of attachment 233793 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233793&action=review > > > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:332 > > + void (^updateBlock)(NSNotification *) = Block_copy(^(NSNotification *){ updateSystemStartupTimeIntervalSince1970(); }); > > There's no need to copy the block, it will be copied by addObserverForName. I'd just use a lambda instead of a block too (they're implicitly converted to blocks, so something like): The reason I did that is to avoid having the block copied twice with 2 separate heap allocation. 1018399 5 233793 benjamin 2014-06-25 13:42:45 -0700 Comment on attachment 233793 Patch Clearing flags on attachment: 233793 Committed r170434: <http://trac.webkit.org/changeset/170434> 1018400 6 benjamin 2014-06-25 13:42:49 -0700 All reviewed patches have been landed. Closing bug. 233793 2014-06-25 00:01:41 -0700 2014-06-25 13:42:45 -0700 Patch bug-134293-20140625000120.patch text/plain 2437 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVlNTEyZjJlZTI5ZDRk MGQ1OWY3NjM1MGY3Nzc4MzNlMzM1NzZiOC4uMDgzM2RhNGE5Njk0NWUzZThlM2RhMjA3ZjAzODFi M2MwODkzMjEwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA2LTI0ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbTWFjXSBVcGRh dGUgdGhlIHRpbWUgYmFzZSBvZiBldmVudCdzIHRpbWVzdGFtcCB3aGVuIHRoZSBzeXN0ZW0gdGlt ZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzQyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL21hYy9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1hYy5tbToKKyAgICAgICAgKFdl YkNvcmU6OmNhY2hlZFN0YXJ0dXBUaW1lSW50ZXJ2YWxTaW5jZTE5NzApOiBTaW5jZSBldmVudHMg dGltZXN0YW1wcyBhcmUgYWJzb2x1dGUgdGltZSwgdGhleSBhbHNvCisgICAgICAgIG5lZWQgdG8g YmUgdXBkYXRlZCBpZiB0aGUgc3lzdGVtIGNsb2NrIGNoYW5nZXMuCisKIDIwMTQtMDYtMTYgIFNh bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBFeHRyYWN0IHByb3RvdHlwZSBk ZWNsYXJhdGlvbiBnZW5lcmF0aW9uIGludG8gYSBoZWxwZXIgZnVuY3Rpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1hYy5tbSBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1hYy5tbQpp bmRleCBiZTgyYTlhNDA0MDA0YmVjOGY2ZmM3MjNkZmI5NGM2NjgyYmY3ZjBmLi4xNTgyODA3NDJh NmE3NzFhYzEzZDFlYzg0ZmVlMTQ0M2E3M2JkMTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1FdmVudEZhY3RvcnlNYWMubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtRXZlbnRGYWN0b3J5TWFjLm1tCkBAIC0zMjksMTAg KzMyOSwxNyBAQCBzdGF0aWMgQ0ZUaW1lSW50ZXJ2YWwgY2FjaGVkU3RhcnR1cFRpbWVJbnRlcnZh bFNpbmNlMTk3MCgpCiB7CiAgICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBvbmNlOwogICAgIGRp c3BhdGNoX29uY2UoJm9uY2UsIF57CisgICAgICAgIHZvaWQgKF51cGRhdGVCbG9jaykoTlNOb3Rp ZmljYXRpb24gKikgPSBCbG9ja19jb3B5KF4oTlNOb3RpZmljYXRpb24gKil7IHVwZGF0ZVN5c3Rl bVN0YXJ0dXBUaW1lSW50ZXJ2YWxTaW5jZTE5NzAoKTsgfSk7CiAgICAgICAgIFtbW05TV29ya3Nw YWNlIHNoYXJlZFdvcmtzcGFjZV0gbm90aWZpY2F0aW9uQ2VudGVyXSBhZGRPYnNlcnZlckZvck5h bWU6TlNXb3Jrc3BhY2VEaWRXYWtlTm90aWZpY2F0aW9uCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvYmplY3Q6 bmlsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcXVldWU6bmlsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVzaW5nQmxvY2s6XihO U05vdGlmaWNhdGlvbiAqKXsgdXBkYXRlU3lzdGVtU3RhcnR1cFRpbWVJbnRlcnZhbFNpbmNlMTk3 MCgpOyB9XTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdXNpbmdCbG9jazp1cGRhdGVCbG9ja107CisgICAgICAgIFtb TlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXJGb3JOYW1lOk5T U3lzdGVtQ2xvY2tEaWRDaGFuZ2VOb3RpZmljYXRpb24KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvYmplY3Q6bmlsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHF1ZXVlOm5p bAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dXNpbmdCbG9jazp1cGRhdGVCbG9ja107CisgICAgICAgIEJsb2NrX3JlbGVhc2UodXBkYXRlQmxv Y2spOworCiAgICAgICAgIHVwZGF0ZVN5c3RlbVN0YXJ0dXBUaW1lSW50ZXJ2YWxTaW5jZTE5NzAo KTsKICAgICB9KTsKICAgICByZXR1cm4gc3lzdGVtU3RhcnR1cFRpbWU7Cg==