134289 2014-06-24 20:09:23 -0700 Rearrange conditions to find invalid protocol in NavigatorContentUtils::verifyProtocolHandlerScheme() 2014-06-26 17:27:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim bunhere cdumez commit-queue darin gyuyoung.kim sergio oldest_to_newest 1018234 0 gyuyoung.kim 2014-06-24 20:09:23 -0700 I think it would be good to do "early return" if there is invalid protocol. 1018235 1 233780 gyuyoung.kim 2014-06-24 20:13:41 -0700 Created attachment 233780 Patch 1018777 2 gyuyoung.kim 2014-06-26 15:50:11 -0700 CC'ing Darin. 1018811 3 233780 commit-queue 2014-06-26 17:27:35 -0700 Comment on attachment 233780 Patch Clearing flags on attachment: 233780 Committed r170511: <http://trac.webkit.org/changeset/170511> 1018812 4 commit-queue 2014-06-26 17:27:41 -0700 All reviewed patches have been landed. Closing bug. 233780 2014-06-24 20:13:41 -0700 2014-06-26 17:27:35 -0700 Patch bug-134289-20140625121319.patch text/plain 1994 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTUzNzNmMjYwODI1YjM5 M2MwMzUyNDI2YjhlYTNjYzBhYmY4Zjc1MS4uNWE2MzA3MWJhZjMyZjBjYTVkYTFkYzBjYWVlODM5 ZjhlMmVkNWYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTI0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVhcnJhbmdl IGNvbmRpdGlvbnMgdG8gZmluZCBpbnZhbGlkIHByb3RvY29sIGluIE5hdmlnYXRvckNvbnRlbnRV dGlsczo6dmVyaWZ5UHJvdG9jb2xIYW5kbGVyU2NoZW1lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDI4OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHdlIGRvIGVhcmx5IHJldHVybiB3aGVuIHRo ZXJlIGlzIGludmFsaWQgcHJvdG9jb2wsIHdlJ3JlIGFibGUgdG8gYXZvaWQgdW5uZWNlc3Nhcnkg Y2FsbCBmbG93LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0aWxzL05hdmlnYXRv ckNvbnRlbnRVdGlscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2ZXJpZnlQcm90b2NvbEhhbmRs ZXJTY2hlbWUpOgorCiAyMDE0LTA2LTI0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBh cHBsZS5jb20+CiAKICAgICAgICAgVGlsZXMgb24gYm90dG9tIG9mIHNjcmVlbiBhcmUgbm90IGFs d2F5cyBhbGxvY2F0ZWQgd2hlbiBuZWNlc3NhcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0aWxzL05hdmlnYXRvckNvbnRlbnRVdGlscy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25hdmlnYXRvcmNvbnRlbnR1dGlscy9OYXZpZ2F0b3JD b250ZW50VXRpbHMuY3BwCmluZGV4IDljNjg4YjZmNmFiZDk0Y2JmMmI1ZGM0ZTg2Mzk4ZWU3OGNk NWY1NDEuLmM0MmUwYWMwODNiMDAxYzYyMDc5ODAzNmQ1YjQzMDJlYjgwMzU2YmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0aWxzL05hdmlnYXRv ckNvbnRlbnRVdGlscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9uYXZpZ2F0b3Jj b250ZW50dXRpbHMvTmF2aWdhdG9yQ29udGVudFV0aWxzLmNwcApAQCAtMTAzLDE3ICsxMDMsMTUg QEAgc3RhdGljIGJvb2wgaXNQcm90b2NvbFdoaXRlbGlzdGVkKGNvbnN0IFN0cmluZyYgc2NoZW1l KQogCiBzdGF0aWMgYm9vbCB2ZXJpZnlQcm90b2NvbEhhbmRsZXJTY2hlbWUoY29uc3QgU3RyaW5n JiBzY2hlbWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogeworICAgIGlmIChpc1Byb3RvY29sV2hpdGVs aXN0ZWQoc2NoZW1lKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICBpZiAoc2NoZW1lLnN0 YXJ0c1dpdGgoIndlYisiKSkgewogICAgICAgICAvLyBUaGUgc3BlY2lmaWNhdGlvbiByZXF1aXJl cyB0aGF0IHRoZSBsZW5ndGggb2Ygc2NoZW1lIGlzIGF0IGxlYXN0IGZpdmUgY2hhcmFjdGVycyAo aW5jbHVkaW5nICd3ZWIrJyBwcmVmaXgpLgogICAgICAgICBpZiAoc2NoZW1lLmxlbmd0aCgpID49 IDUgJiYgaXNWYWxpZFByb3RvY29sKHNjaGVtZSkpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK LSAgICAgICAgZWMgPSBTRUNVUklUWV9FUlI7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 CiAKLSAgICBpZiAoaXNQcm90b2NvbFdoaXRlbGlzdGVkKHNjaGVtZSkpCi0gICAgICAgIHJldHVy biB0cnVlOwotCiAgICAgZWMgPSBTRUNVUklUWV9FUlI7CiAgICAgcmV0dXJuIGZhbHNlOwogfQo=