134276 2014-06-24 15:53:39 -0700 Provide javascript aware backtrace script for lldb 2014-06-25 10:36:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 134278 1 msaboff msaboff bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1018144 0 msaboff 2014-06-24 15:53:39 -0700 lldb provides the ability to augment lldb functionality via python scripts. This can be used to make backtraces JavaScript aware. Consider the backtrace while running deltablue.js from jsc: (lldb) bt * thread #1: tid = 0x2c103b, 0x000025c288a61720, queue = 'com.apple.main-thread, stop reason = signal SIGSTOP frame #0: 0x000025c288a61720 frame #1: 0x000025c288a57c40 frame #2: 0x000025c288a6e050 frame #3: 0x000025c288a5d654 frame #4: 0x0000000100647550 JavaScriptCore`llint_entry + 25930 frame #5: 0x0000000100640d94 JavaScriptCore`callToJavaScript + 356 ... A more informative backtrace could be: (lldb) bt * thread \#1: tid = 0x2c103b, 0x000025c288a61720, queue = 'com.apple.main-thread, stop reason = signal SIGSTOP frame #0: 0x000025c288a61720 chooseMethod#EmCrCd [DFG](Cell[Object ID: 448]: 0x10994ca70, 97) frame #1: 0x000025c288a57c40 satisfy#A7Z1GK [FTL](Cell[Object ID: 448]: 0x10994ca70, 97) frame #2: 0x000025c288a6e050 chainTest#BRCzIm [DFG](Cell[global ID: 353]: 0x101cdf970, 100) frame #3: 0x000025c288a5d654 deltaBlue#DNE2LT [Baseline](Cell[global ID: 353]: 0x101cdf970) frame #4: 0x0000000100647550 <global>#AxbsUM [LLInt](Cell[JSProxy ID: 322]: 0x101cffb90) frame #5: 0x0000000100640d94 JavaScriptCore`callToJavaScript + 356 ... 1018362 1 233823 msaboff 2014-06-25 10:27:16 -0700 Created attachment 233823 Patch 1018363 2 commit-queue 2014-06-25 10:28:48 -0700 Attachment 233823 did not pass style-queue: ERROR: Tools/lldb/lldb_webkit.py:101: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/lldb/lldb_webkit.py:127: trailing whitespace [pep8/W291] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1018365 3 233823 jer.noble 2014-06-25 10:31:31 -0700 Comment on attachment 233823 Patch nice! r=me. 1018366 4 msaboff 2014-06-25 10:36:46 -0700 Committed r170432: <http://trac.webkit.org/changeset/170432> 233823 2014-06-25 10:27:16 -0700 2014-06-25 10:31:31 -0700 Patch 134276.patch text/plain 3402 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MDQzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTA2LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIFByb3ZpZGUgamF2YXNjcmlwdCBhd2FyZSBiYWNrdHJhY2Ugc2NyaXB0IGZv ciBsbGRiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzQyNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGxsZGIvbGxkYl93ZWJraXQucHk6CisgICAgICAgIChfX2xsZGJfaW5pdF9tb2R1bGUpOgorICAg ICAgICAoYnRqcyk6IE5ldyBzY3JpcHRlZCBjb21tYW5kIHRvIGRpc3BsYXkgYSBiYWNrdHJhY2Ug dGhhdCBzaG93cyBKYXZhU2NyaXB0IGZyYW1lcyB3aXRoIGRldGFpbHMuCisKIDIwMTQtMDYtMjUg IE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMTcwNDI2KSBCcm9rZSB0d28gcHl0aG9uIHRlc3RzCkluZGV4OiBU b29scy9sbGRiL2xsZGJfd2Via2l0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2xsZGIvbGxkYl93 ZWJraXQucHkJKHJldmlzaW9uIDE3MDQyMCkKKysrIFRvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkJ KHdvcmtpbmcgY29weSkKQEAgLTMwLDkgKzMwLDExIEBACiAiIiIKIAogaW1wb3J0IGxsZGIKK2lt cG9ydCBzdHJpbmcKIGltcG9ydCBzdHJ1Y3QKIAogZGVmIF9fbGxkYl9pbml0X21vZHVsZShkZWJ1 Z2dlciwgZGljdCk6CisgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFuZCgnY29tbWFuZCBzY3JpcHQg YWRkIC1mIGxsZGJfd2Via2l0LmJ0anMgYnRqcycpCiAgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFu ZCgndHlwZSBzdW1tYXJ5IGFkZCAtLWV4cGFuZCAtRiBsbGRiX3dlYmtpdC5XVEZTdHJpbmdfU3Vt bWFyeVByb3ZpZGVyIFdURjo6U3RyaW5nJykKICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0 eXBlIHN1bW1hcnkgYWRkIC0tZXhwYW5kIC1GIGxsZGJfd2Via2l0LldURlN0cmluZ0ltcGxfU3Vt bWFyeVByb3ZpZGVyIFdURjo6U3RyaW5nSW1wbCcpCiAgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFu ZCgndHlwZSBzdW1tYXJ5IGFkZCAtLWV4cGFuZCAtRiBsbGRiX3dlYmtpdC5XVEZBdG9taWNTdHJp bmdfU3VtbWFyeVByb3ZpZGVyIFdURjo6QXRvbWljU3RyaW5nJykKQEAgLTk2LDYgKzk4LDQyIEBA IGRlZiBXZWJDb3JlTGF5b3V0UG9pbnRfU3VtbWFyeVByb3ZpZGVyKHYKICAgICBwcm92aWRlciA9 IFdlYkNvcmVMYXlvdXRQb2ludFByb3ZpZGVyKHZhbG9iaiwgZGljdCkKICAgICByZXR1cm4gInsg eCA9ICVzLCB5ID0gJXMgfSIgJSAocHJvdmlkZXIuZ2V0X3goKSwgcHJvdmlkZXIuZ2V0X3koKSkK IAorZGVmIGJ0anMoZGVidWdnZXIsIGNvbW1hbmQsIHJlc3VsdCwgaW50ZXJuYWxfZGljdCk6Cisg ICAgJycnUHJpbnRzIGEgc3RhY2sgdHJhY2Ugb2YgY3VycmVudCB0aHJlYWQgd2l0aCBKYXZhU2Ny aXB0IGZyYW1lcyBkZWNvZGVkLiAgVGFrZXMgb3B0aW9uYWwgZnJhbWUgY291bnQgYXJndW1lbnQn JycKKworICAgIHRhcmdldCA9IGRlYnVnZ2VyLkdldFNlbGVjdGVkVGFyZ2V0KCkKKyAgICBhZGRy ZXNzRm9ybWF0ID0gJyMwe3dpZHRofXgnLmZvcm1hdCh3aWR0aD10YXJnZXQuR2V0QWRkcmVzc0J5 dGVTaXplKCkgKiAyICsgMikKKyAgICBwcm9jZXNzID0gdGFyZ2V0LkdldFByb2Nlc3MoKQorICAg IHRocmVhZCA9IHByb2Nlc3MuR2V0U2VsZWN0ZWRUaHJlYWQoKQorCisgICAgYmFja3RyYWNlRGVw dGggPSB0aHJlYWQuR2V0TnVtRnJhbWVzKCkKKworICAgIGlmIGxlbihjb21tYW5kKSA9PSAxOgor ICAgICAgICB0cnk6CisgICAgICAgICAgICBiYWNrdHJhY2VEZXB0aCA9IGludChjb21tYW5kKQor ICAgICAgICBleGNlcHQgVmFsdWVFcnJvcjoKKyAgICAgICAgICAgIHJldHVybgorCisgICAgdGhy ZWFkRm9ybWF0ID0gJyogdGhyZWFkICN7bnVtfTogdGlkID0ge3RpZDojeH0sIHtwY0FkZHI6JyAr IGFkZHJlc3NGb3JtYXQgKyAnfSwgcXVldWUgPSBcJ3txdWV1ZU5hbWV9LCBzdG9wIHJlYXNvbiA9 IHtzdG9wUmVhc29ufScKKyAgICBwcmludCB0aHJlYWRGb3JtYXQuZm9ybWF0KG51bT10aHJlYWQu R2V0SW5kZXhJRCgpLCB0aWQ9dGhyZWFkLkdldFRocmVhZElEKCksIHBjQWRkcj10aHJlYWQuR2V0 RnJhbWVBdEluZGV4KDApLkdldFBDKCksIHF1ZXVlTmFtZT10aHJlYWQuR2V0UXVldWVOYW1lKCks IHN0b3BSZWFzb249dGhyZWFkLkdldFN0b3BEZXNjcmlwdGlvbigzMCkpCisKKyAgICBmb3IgZnJh bWUgaW4gdGhyZWFkOgorICAgICAgICBpZiBiYWNrdHJhY2VEZXB0aCA8IDE6CisgICAgICAgICAg ICBicmVhaworCisgICAgICAgIGJhY2t0cmFjZURlcHRoID0gYmFja3RyYWNlRGVwdGggLSAxCisK KyAgICAgICAgZnVuY3Rpb24gPSBmcmFtZS5HZXRGdW5jdGlvbigpCisgICAgICAgIAorICAgICAg ICBpZiBub3QgZnJhbWUgb3Igbm90IGZyYW1lLkdldFN5bWJvbCgpIG9yIGZyYW1lLkdldFN5bWJv bCgpLkdldE5hbWUoKSA9PSAibGxpbnRfZW50cnkiOgorICAgICAgICAgICAgY2FsbEZyYW1lID0g ZnJhbWUuR2V0U1AoKQorICAgICAgICAgICAgSlNGcmFtZURlc2NyaXB0aW9uID0gZnJhbWUuRXZh bHVhdGVFeHByZXNzaW9uKCIoKEpTQzo6Q2FsbEZyYW1lKikweCV4KS0+ZGVzY3JpYmVGcmFtZSgp IiAlIGZyYW1lLkdldEZQKCkpLkdldFN1bW1hcnkoKQorICAgICAgICAgICAgSlNGcmFtZURlc2Ny aXB0aW9uID0gc3RyaW5nLnN0cmlwKEpTRnJhbWVEZXNjcmlwdGlvbiwgJyInKQorICAgICAgICAg ICAgZnJhbWVGb3JtYXQgPSAnICAgIGZyYW1lICN7bnVtfToge2FkZHI6JyArIGFkZHJlc3NGb3Jt YXQgKyAnfSB7ZGVzY30nCisgICAgICAgICAgICBwcmludCBmcmFtZUZvcm1hdC5mb3JtYXQobnVt PWZyYW1lLkdldEZyYW1lSUQoKSwgYWRkcj1mcmFtZS5HZXRQQygpLCBkZXNjPUpTRnJhbWVEZXNj cmlwdGlvbikKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIHByaW50ICcgICAgJXMnICUgZnJh bWUKKwogIyBGSVhNRTogUHJvdmlkZSBzdXBwb3J0IGZvciB0aGUgZm9sbG93aW5nIHR5cGVzOgog IyBkZWYgV1RGVmVjdG9yX1N1bW1hcnlQcm92aWRlcih2YWxvYmosIGRpY3QpOgogIyBkZWYgV1RG Q1N0cmluZ19TdW1tYXJ5UHJvdmlkZXIodmFsb2JqLCBkaWN0KToK