134270 2014-06-24 14:56:10 -0700 [Fullscreen][Mac] WKView is not firstResponder after entering fullscreen mode 2014-06-24 15:39:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1018107 0 jer.noble 2014-06-24 14:56:10 -0700 [Fullscreen][Mac] WKView is not firstResponder after entering fullscreen mode 1018110 1 233745 jer.noble 2014-06-24 14:58:05 -0700 Created attachment 233745 Patch 1018112 2 233745 jhoneycutt 2014-06-24 15:01:50 -0700 Comment on attachment 233745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233745&action=review r=me > Source/WebCore/ChangeLog:10 > + the window's view heirarchy after the style changes, reset it to the firstResponder. hierarchy > Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:81 > +- (void)setStyleMask:(NSUInteger)styleMask > +{ > + NSResponder* savedFirstResponder = [self firstResponder]; > + > + [super setStyleMask:styleMask]; > + > + if ([self firstResponder] != savedFirstResponder > + && [savedFirstResponder isKindOfClass:[NSView class]] > + && [(NSView*)savedFirstResponder isDescendantOf:[self contentView]]) > + [self makeFirstResponder:savedFirstResponder]; > +} This would benefit from an inline comment explaining why it's done. 1018133 3 jer.noble 2014-06-24 15:32:28 -0700 <rdar://problem/17043094> 1018141 4 jer.noble 2014-06-24 15:39:07 -0700 Committed r170397: <http://trac.webkit.org/changeset/170397> 233745 2014-06-24 14:58:05 -0700 2014-06-24 15:02:01 -0700 Patch bug-134270-20140624145744.patch text/plain 1968 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNiZjQwYzUyZDFiMzI3 ZTBmYTEzM2U0N2U1YmViZTA5OGUwOTVkMy4uNDEzMjk3NTg5YjYwMGZlMTM5M2ZkODljOGM3NDEy NGJkYzljZWU3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA2LTI0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtGdWxsc2NyZWVuXVtNYWNd IFdLVmlldyBpcyBub3QgZmlyc3RSZXNwb25kZXIgYWZ0ZXIgZW50ZXJpbmcgZnVsbHNjcmVlbiBt b2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQy NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg V2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cncyBmaXJzdFJlc3BvbmRlciBpcyByZXNldCB3aGVuIHRo ZSBmdWxsIHNjcmVlbiBhbmltYXRpb24gY29tcGxldGVzIGFuZAorICAgICAgICB0aGUgd2luZG93 J3Mgc3R5bGUgaXMgY2hhbmdlZCB0byBhIGZ1bGxzY3JlZW4gc3R5bGUuIFNhdmUgdGhlIGZpcnN0 UmVzcG9uZGVyLCBhbmQgaWYgaXQncyBzdGlsbCBpbgorICAgICAgICB0aGUgd2luZG93J3Mgdmll dyBoZWlyYXJjaHkgYWZ0ZXIgdGhlIHN0eWxlIGNoYW5nZXMsIHJlc2V0IGl0IHRvIHRoZSBmaXJz dFJlc3BvbmRlci4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldp bmRvdy5tbToKKyAgICAgICAgKC1bV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cgc2V0U3R5bGVNYXNr Ol0pOgorCisyMDE0LTA2LTI0ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCiAg ICAgICAgIFJFR1JFU1NJT04ocjE3MDMzNik6IENyYXNoIGluIEhUTUxNZWRpYUVsZW1lbnQ6OnNl ZWtUaW1lckZpcmVkKCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNDI1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv V2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv V2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cubW0KaW5kZXggNTMwMmNkYTJlYTFlNDY3NWE5NzcyMTc5 NWRkZmNkMTIxMmJmNjIzOC4uMTcwZGFkZjczOWYyNDIyZTIzMzE3MzBhY2IyMGEyZjJlNzY5Nzcz NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVGdWxsU2Ny ZWVuV2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVs bFNjcmVlbldpbmRvdy5tbQpAQCAtNjcsNiArNjcsMTggQEAKIHsKICAgICBbW3NlbGYgd2luZG93 Q29udHJvbGxlcl0gcGVyZm9ybUNsb3NlOnNlbmRlcl07CiB9CisKKy0gKHZvaWQpc2V0U3R5bGVN YXNrOihOU1VJbnRlZ2VyKXN0eWxlTWFzaworeworICAgIE5TUmVzcG9uZGVyKiBzYXZlZEZpcnN0 UmVzcG9uZGVyID0gW3NlbGYgZmlyc3RSZXNwb25kZXJdOworCisgICAgW3N1cGVyIHNldFN0eWxl TWFzazpzdHlsZU1hc2tdOworCisgICAgaWYgKFtzZWxmIGZpcnN0UmVzcG9uZGVyXSAhPSBzYXZl ZEZpcnN0UmVzcG9uZGVyCisgICAgICAgICYmIFtzYXZlZEZpcnN0UmVzcG9uZGVyIGlzS2luZE9m Q2xhc3M6W05TVmlldyBjbGFzc11dCisgICAgICAgICYmIFsoTlNWaWV3KilzYXZlZEZpcnN0UmVz cG9uZGVyIGlzRGVzY2VuZGFudE9mOltzZWxmIGNvbnRlbnRWaWV3XV0pCisgICAgICAgIFtzZWxm IG1ha2VGaXJzdFJlc3BvbmRlcjpzYXZlZEZpcnN0UmVzcG9uZGVyXTsKK30KIEBlbmQKIAogI2Vu ZGlmIC8vIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK