134267 2014-06-24 13:21:42 -0700 iOS WebKit2: block selection tends to prefer block to single words even when the page is zoomed. 2014-06-24 13:45:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 1018078 0 enrica 2014-06-24 13:21:42 -0700 This is easily reproduced on pages like reddit.com, browsing through the comments, zooming the page and trying to select a word. <rdar://problem/17138059> 1018079 1 233734 enrica 2014-06-24 13:27:44 -0700 Created attachment 233734 Patch 1018082 2 233734 benjamin 2014-06-24 13:33:11 -0700 Comment on attachment 233734 Patch The change makes sense. I would create a second rect (a FloatRect) especially for that purpose. Something like: FloatRect boundingRectInScrollViewCoordinates(boundingRect); boundingRectInScrollViewCoordinates.scale(...). To make it explicit which that rect is not in document coordinates. 1018086 3 enrica 2014-06-24 13:45:33 -0700 Committed revision 170388. 233734 2014-06-24 13:27:44 -0700 2014-06-24 13:33:10 -0700 Patch scaledselection.txt text/plain 2093 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDM4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTI0ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIFdlYktpdDI6IGJsb2Nr IHNlbGVjdGlvbiB0ZW5kcyB0byBwcmVmZXIgYmxvY2sgdG8gc2luZ2xlIHdvcmRzIGV2ZW4gd2hl biB0aGUgcGFnZSBpcyB6b29tZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzQyNjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3MTM4MDU5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdHJ5 aW5nIHRvIGZpbmQgdGhlIGJlc3Qgc2VsZWN0aW9uIG1hdGNoIGZvciB0aGUgcG9zaXRpb24gd2hl cmUgdGhlIHRhcCBvY2N1cnMsCisgICAgICAgIHdlIG5lZWQgdG8gdGFrZSBpbnRvIGFjY291bnQg dGhlIHBhZ2Ugc2NhbGUuIFRoaXMgcGF0Y2ggYXBwbGllcyB0aGUgc2NhbGUgZmFjdG9yCisgICAg ICAgIHRvIHRoZSBzZWxlY3Rpb24gcmVjdCBiZWZvcmUgY29tcGFyaW5nIGl0IHdpdGggdGhlIGRl c2lyZWQgc2l6ZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlP Uy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cmFuZ2VGb3JXZWJTZWxlY3Rpb25BdFBv c2l0aW9uKToKKwogMjAxNC0wNi0yNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPUyBXZWJLaXQyXSBEaXNhYmxlIHNjcmVlbiBmb250IHN1YnN0aXR1dGlv biBieSBkZWZhdWx0LgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lv cy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2aXNpb24gMTcwMzcyKQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3b3JraW5nIGNvcHkp CkBAIC02OTUsNiArNjk1LDcgQEAgUGFzc1JlZlB0cjxSYW5nZT4gV2ViUGFnZTo6cmFuZ2VGb3JX ZWJTZQogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIGJvdW5kaW5nUmVjdC51bml0 ZShjb3JlUmVjdCk7CiAgICAgICAgIH0KKyAgICAgICAgYm91bmRpbmdSZWN0LnNjYWxlKG1fcGFn ZS0+cGFnZVNjYWxlRmFjdG9yKCkpOwogICAgICAgICBpZiAoYm91bmRpbmdSZWN0LndpZHRoKCkg PiBtX2Jsb2NrU2VsZWN0aW9uRGVzaXJlZFNpemUud2lkdGgoKSAmJiBib3VuZGluZ1JlY3QuaGVp Z2h0KCkgPiBtX2Jsb2NrU2VsZWN0aW9uRGVzaXJlZFNpemUuaGVpZ2h0KCkpCiAgICAgICAgICAg ICByZXR1cm4gd29yZFJhbmdlRnJvbVBvc2l0aW9uKHBvc2l0aW9uKTsKIApAQCAtNzA3LDYgKzcw OCw3IEBAIFBhc3NSZWZQdHI8UmFuZ2U+IFdlYlBhZ2U6OnJhbmdlRm9yV2ViU2UKICAgICBOb2Rl KiBiZXN0Q2hvaWNlID0gY3VycmVudE5vZGU7CiAgICAgd2hpbGUgKGN1cnJlbnROb2RlKSB7CiAg ICAgICAgIGJvdW5kaW5nUmVjdCA9IGN1cnJlbnROb2RlLT5yZW5kZXJlcigpLT5hYnNvbHV0ZUJv dW5kaW5nQm94UmVjdCh0cnVlKTsKKyAgICAgICAgYm91bmRpbmdSZWN0LnNjYWxlKG1fcGFnZS0+ cGFnZVNjYWxlRmFjdG9yKCkpOwogICAgICAgICBpZiAoYm91bmRpbmdSZWN0LndpZHRoKCkgPiBt X2Jsb2NrU2VsZWN0aW9uRGVzaXJlZFNpemUud2lkdGgoKSAmJiBib3VuZGluZ1JlY3QuaGVpZ2h0 KCkgPiBtX2Jsb2NrU2VsZWN0aW9uRGVzaXJlZFNpemUuaGVpZ2h0KCkpCiAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgYmVzdENob2ljZSA9IGN1cnJlbnROb2RlOwo=