134256 2014-06-24 11:18:51 -0700 [ftlopt] StructureAbstractValue::onlyStructure() should return nullptr if isClobbered() 2014-06-24 12:07:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1018015 0 fpizlo 2014-06-24 11:18:51 -0700 This is a bug, but it's kind of benign right now since none of the optimizations that use onlyStructure() would trigger in regions of code where structures are clobbered. 1018017 1 233721 fpizlo 2014-06-24 11:20:55 -0700 Created attachment 233721 the patch 1018021 2 233721 msaboff 2014-06-24 11:27:55 -0700 Comment on attachment 233721 the patch r=me 1018042 3 fpizlo 2014-06-24 12:07:13 -0700 Landed in http://trac.webkit.org/changeset/170376 233721 2014-06-24 11:20:55 -0700 2014-06-24 11:27:54 -0700 the patch blah.patch text/plain 2184 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcwMzczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTA2LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg W2Z0bG9wdF0gU3RydWN0dXJlQWJzdHJhY3RWYWx1ZTo6b25seVN0cnVjdHVyZSgpIHNob3VsZCBy ZXR1cm4gbnVsbHB0ciBpZiBpc0Nsb2JiZXJlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQyNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgaXNuJ3QgdGVzdGFibGUgcmlnaHQg bm93IChpLmUuIGl0J3MgYmVuaWduKSBidXQgd2Ugc2hvdWxkIGdldCBpdCBhbnl3YXkuIFRoZSBw b2ludCBpcworICAgICAgICB0byBiZSBhYmxlIHRvIHByZWNpc2VseSBtb2RlbCB3aGF0IGdvZXMg b24gaW4gdGhlIHNuaXBwZXRzIG9mIGNvZGUgYmV0d2VlbiBhIHNpZGUtZWZmZWN0CisgICAgICAg IGFuZCBhbiBJbnZhbGlkYXRpb25Qb2ludC4KKyAgICAgICAgCisgICAgICAgIFRoaXMgcGF0Y2gg YWxzbyBtYWtlcyBvbmx5U3RydWN0dXJlKCkgYSBmYWlyIGJpdCBuaWNlci4KKworICAgICAgICAq IGRmZy9ERkdTdHJ1Y3R1cmVBYnN0cmFjdFZhbHVlLmg6CisgICAgICAgIChKU0M6OkRGRzo6U3Ry dWN0dXJlQWJzdHJhY3RWYWx1ZTo6b25seVN0cnVjdHVyZSk6CisKIDIwMTQtMDYtMjEgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBbZnRsb3B0XSBGb2xkIEdldEJ5 SWQvUHV0QnlJZCB0byBNdWx0aUdldEJ5T2Zmc2V0L0dldEJ5T2Zmc2V0IG9yIE11bHRpUHV0QnlP ZmZzZXQvUHV0QnlPZmZzZXQsIHdoaWNoIGltcGxpZXMgaGFuZGxpbmcgbm9uLXNpbmdsZXRvbiBz ZXRzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cnVjdHVyZUFic3RyYWN0 VmFsdWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cnVj dHVyZUFic3RyYWN0VmFsdWUuaAkocmV2aXNpb24gMTcwMzIyKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTdHJ1Y3R1cmVBYnN0cmFjdFZhbHVlLmgJKHdvcmtpbmcgY29weSkKQEAg LTE4MSwxNCArMTgxLDE0IEBAIHB1YmxpYzoKICAgICAKICAgICBTdHJ1Y3R1cmUqIG9wZXJhdG9y W10oc2l6ZV90IGkpIGNvbnN0IHsgcmV0dXJuIGF0KGkpOyB9CiAgICAgCi0gICAgLy8gRklYTUU6 IEVsaW1pbmF0ZSBhbGwgdXNlcyBvZiB0aGlzIG1ldGhvZC4gVGhlcmUgc2hvdWxkbid0IGJlIGFu eQotICAgIC8vIHNwZWNpYWwtY2FzaW5nIGZvciB0aGUgb25lLXN0cnVjdHVyZSBjYXNlLgotICAg IC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMyMjkKKyAgICAv LyBJbiBtb3N0IGNhc2VzLCB3aGF0IHlvdSByZWFsbHkgd2FudCB0byBkbyBpcyB2ZXJpZnkgd2hl dGhlciB0aGUgc2V0IGlzIHRvcCBvciBjbG9iYmVyZWQsIGFuZAorICAgIC8vIGlmIG5vdCwgZW51 bWVyYXRlIHRoZSBzZXQgb2Ygc3RydWN0dXJlcy4gVXNlIHRoaXMgb25seSBpbiBjYXNlcyB3aGVy ZSB0aGUgc2luZ2xldG9uIGNhc2UgaXMKKyAgICAvLyBtZWFuaW5nZnVsbHkgc3BlY2lhbCwgbGlr ZSBmb3IgdHJhbnNpdGlvbnMuCiAgICAgU3RydWN0dXJlKiBvbmx5U3RydWN0dXJlKCkgY29uc3QK ICAgICB7Ci0gICAgICAgIGlmIChpc1RvcCgpIHx8IHNpemUoKSAhPSAxKQorICAgICAgICBpZiAo aXNUb3AoKSB8fCBpc0Nsb2JiZXJlZCgpKQogICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0g ICAgICAgIHJldHVybiBhdCgwKTsKKyAgICAgICAgcmV0dXJuIG1fc2V0Lm9ubHlTdHJ1Y3R1cmUo KTsKICAgICB9CiAgICAgCiAgICAgdm9pZCBkdW1wSW5Db250ZXh0KFByaW50U3RyZWFtJiwgRHVt cENvbnRleHQqKSBjb25zdDsK