134248 2014-06-24 06:46:07 -0700 Only flush layers when the exposed rect actually changes 2022-10-10 15:14:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned ahmad.saleem792 simon.fraser webkit-bug-importer oldest_to_newest 1017927 0 koivisto 2014-06-24 06:46:07 -0700 Currently we flush unconditionally. 1017930 1 233698 koivisto 2014-06-24 06:56:47 -0700 Created attachment 233698 patch 1017956 2 233698 simon.fraser 2014-06-24 08:56:57 -0700 Comment on attachment 233698 patch View in context: https://bugs.webkit.org/attachment.cgi?id=233698&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:206 > + auto rect = enclosingIntRect(exposedContentRect); > + if (frameView->exposedContentRect() == rect) > + return; This makes assumptions about how FrameView does rounding. Maybe setExposedContentRect() should instead return a bool? 1018044 3 koivisto 2014-06-24 12:10:48 -0700 http://trac.webkit.org/changeset/170377 1018046 4 koivisto 2014-06-24 12:16:12 -0700 > This makes assumptions about how FrameView does rounding. Maybe setExposedContentRect() should instead return a bool? There is currently no rounding (these were just switched to FloatRect) and it is generally reasonable to expect getters and setters to pair. The setter should probably be renamed if it starts rounding. 1904639 5 ahmad.saleem792 2022-10-10 15:13:28 -0700 Landed and didn't backed out: https://github.com/WebKit/WebKit/commit/80d3862733cf0b06bde7cde3af207aa5f5e4518b Marking this as "RESOLVED FIXED". 1904641 6 webkit-bug-importer 2022-10-10 15:14:18 -0700 <rdar://problem/100999725> 233698 2014-06-24 06:56:47 -0700 2014-06-24 08:56:57 -0700 patch exposed-rect-flush.patch text/plain 2635 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDM1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA2LTI0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBPbmx5IGZsdXNoIGxheWVycyB3 aGVuIHRoZSBleHBvc2VkIHJlY3QgYWN0dWFsbHkgY2hhbmdlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MjQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKwogMjAxNC0w Ni0yNCAgSmFyZWsgQ3pla2Fsc2tpICA8amFyZWtjemVrQHBvY3p0YS5vbmV0LnBsPgogCiAgICAg ICAgIFtBVEtdIERvbid0IGlnbm9yZSBsaW5rcyByZW5kZXJlZCBhcyBibG9ja3MuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmV4cC5pbgkocmV2aXNpb24gMTcwMjYwKQorKysgU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTE1NDQsNiArMTU0NCw3IEBAIF9fWk5LN1dl YkNvcmUxMFNjcm9sbFZpZXcxNndpbmRvd1RvQ29udGUKIF9fWk5LN1dlYkNvcmUxMFNjcm9sbFZp ZXcxNndpbmRvd1RvQ29udGVudHNFUktOU184SW50UG9pbnRFCiBfX1pOSzdXZWJDb3JlMTBTY3Jv bGxWaWV3MThjb250ZW50c1RvUm9vdFZpZXdFUktOU183SW50UmVjdEUKIF9fWk5LN1dlYkNvcmUx MFNjcm9sbFZpZXcxOGNvbnRlbnRzVG9Sb290Vmlld0VSS05TXzhJbnRQb2ludEUKK19fWk5LN1dl YkNvcmUxMFNjcm9sbFZpZXcxOGV4cG9zZWRDb250ZW50UmVjdEV2CiBfX1pOSzdXZWJDb3JlMTBT Y3JvbGxWaWV3MThyb290Vmlld1RvQ29udGVudHNFUktOU184SW50UG9pbnRFCiBfX1pOSzdXZWJD b3JlMTBTY3JvbGxWaWV3MjNyb290Vmlld1RvVG90YWxDb250ZW50c0VSS05TXzhJbnRQb2ludEUK IF9fWk5LN1dlYkNvcmUxMFNjcm9sbFZpZXc0MGRvY3VtZW50U2Nyb2xsT2Zmc2V0UmVsYXRpdmVU b1ZpZXdPcmlnaW5FdgpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTcwMzU5KQorKysgU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQt MDYtMjQgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIE9ubHkg Zmx1c2ggbGF5ZXJzIHdoZW4gdGhlIGV4cG9zZWQgcmVjdCBhY3R1YWxseSBjaGFuZ2VzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQyNDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW06CisgICAgICAgIChXZWJL aXQ6OlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhOjpzZXRFeHBvc2VkQ29udGVudFJlY3QpOgor CiAyMDE0LTA2LTIzICBKYWVodW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgZml4IGJ1aWxkIHdhcm5pbmcuCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3Rl TGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0JKHJldmlzaW9uIDE3MDI2MCkKKysrIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0J KHdvcmtpbmcgY29weSkKQEAgLTIwMSw3ICsyMDEsMTEgQEAgdm9pZCBSZW1vdGVMYXllclRyZWVE cmF3aW5nQXJlYTo6c2V0RXhwbwogICAgIGlmICghZnJhbWVWaWV3KQogICAgICAgICByZXR1cm47 CiAKLSAgICBmcmFtZVZpZXctPnNldEV4cG9zZWRDb250ZW50UmVjdChlbmNsb3NpbmdJbnRSZWN0 KGV4cG9zZWRDb250ZW50UmVjdCkpOworICAgIGF1dG8gcmVjdCA9IGVuY2xvc2luZ0ludFJlY3Qo ZXhwb3NlZENvbnRlbnRSZWN0KTsKKyAgICBpZiAoZnJhbWVWaWV3LT5leHBvc2VkQ29udGVudFJl Y3QoKSA9PSByZWN0KQorICAgICAgICByZXR1cm47CisKKyAgICBmcmFtZVZpZXctPnNldEV4cG9z ZWRDb250ZW50UmVjdChyZWN0KTsKICAgICBzY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJGbHVzaCgp OwogfQogI2VuZGlmCg==